From nobody Thu Dec 18 06:06:01 2025 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 86D64253350; Fri, 21 Feb 2025 19:56:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740167806; cv=none; b=MeANPiTnE0eL8L46TMEbDzP4gtgDRY8f1K2P4KTmoLp9OUkrN9IdDjDUhAoy/fjrvwB3OstvKlUd8VxYDaYFb7ytLNsxIjpQ9E2jjKzxP/CH9w6skex9s8IrYht9T0EVR2eVe3mgD9R/vmQ4Kh5kMSNmORXVB+jh0e8XC7CWqRY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740167806; c=relaxed/simple; bh=wWKHwzQiqoRogydSZWFXtt6QHJDP2XaIpTA5O8in9ac=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=DedWCa2dXh/b6m+rMj+o0QqHqULIi3zPCV4qyF3rqMYE0zn1bc9rc/JjHdAxQ4gXtPCJUhsfLsj9p8HaVUm1ijiUkq/DWoQd6/sSgJlFyPeO+fXB/cjCNrT1BniQ1Bvefz2yeQMan1THau/UFcrJ+AHePXIz39ahYQZhfB3hhoc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=EoFXGQgY; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="EoFXGQgY" Received: from linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net (linux.microsoft.com [13.77.154.182]) by linux.microsoft.com (Postfix) with ESMTPSA id D47A6204E5BF; Fri, 21 Feb 2025 11:56:42 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D47A6204E5BF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1740167802; bh=zPLYD2dRfopSrN03kgPi4Tmd+omXF28zRCncg1mhesI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EoFXGQgYbxRJpv9vDOiDKvPXyEMr653hI1a07XSa+dDu6nOu4SgjC1Eo0NnpKgcKp 513mZc5/seGYCpJSW4vYnHLKhGwyAW1KKH8HywHzxhs3aUNOiPxtKkjUNAjmsLipbO +4OsnbWNnfLwNqNcyBgPdnuNqqow7tzGkIxmGJf4= From: Nuno Das Neves To: linux-hyperv@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, iommu@lists.linux.dev, mhklinux@outlook.com, eahariha@linux.microsoft.com, mukeshrathor@microsoft.com Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, daniel.lezcano@linaro.org, joro@8bytes.org, robin.murphy@arm.com, arnd@arndb.de, jinankjain@linux.microsoft.com, muminulrussell@gmail.com, skinsburskii@linux.microsoft.com Subject: [PATCH v3 1/3] hyperv: Convert hypercall statuses to linux error codes Date: Fri, 21 Feb 2025 11:56:33 -0800 Message-Id: <1740167795-13296-2-git-send-email-nunodasneves@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1740167795-13296-1-git-send-email-nunodasneves@linux.microsoft.com> References: <1740167795-13296-1-git-send-email-nunodasneves@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Return linux-friendly error codes from hypercall helper functions, which allows them to be used more flexibly. Introduce hv_result_to_errno() for this purpose, which also handles the special value U64_MAX returned from hv_do_hypercall(). Signed-off-by: Nuno Das Neves Reviewed-by: Easwar Hariharan Reviewed-by: Michael Kelley --- drivers/hv/hv_common.c | 34 ++++++++++++++++++++++++++++++++++ drivers/hv/hv_proc.c | 10 +++++----- include/asm-generic/mshyperv.h | 1 + 3 files changed, 40 insertions(+), 5 deletions(-) diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c index ee3083937b4f..5cf9894b9e79 100644 --- a/drivers/hv/hv_common.c +++ b/drivers/hv/hv_common.c @@ -683,3 +683,37 @@ u64 __weak hv_tdx_hypercall(u64 control, u64 param1, u= 64 param2) return HV_STATUS_INVALID_PARAMETER; } EXPORT_SYMBOL_GPL(hv_tdx_hypercall); + +/* Convert a hypercall result into a linux-friendly error code. */ +int hv_result_to_errno(u64 status) +{ + /* hv_do_hypercall() may return U64_MAX, hypercalls aren't possible */ + if (unlikely(status =3D=3D U64_MAX)) + return -EOPNOTSUPP; + /* + * A failed hypercall is usually only recoverable (or loggable) near + * the call site where the HV_STATUS_* code is known. So the errno + * it gets converted to is not too useful further up the stack. + * Provide a few mappings that could be useful, and revert to -EIO + * as a fallback. + */ + switch (hv_result(status)) { + case HV_STATUS_SUCCESS: + return 0; + case HV_STATUS_INVALID_HYPERCALL_CODE: + case HV_STATUS_INVALID_HYPERCALL_INPUT: + case HV_STATUS_INVALID_PARAMETER: + case HV_STATUS_INVALID_PARTITION_ID: + case HV_STATUS_INVALID_VP_INDEX: + case HV_STATUS_INVALID_PORT_ID: + case HV_STATUS_INVALID_CONNECTION_ID: + case HV_STATUS_INVALID_LP_INDEX: + case HV_STATUS_INVALID_REGISTER_VALUE: + return -EINVAL; + case HV_STATUS_INSUFFICIENT_MEMORY: + return -ENOMEM; + default: + break; + } + return -EIO; +} diff --git a/drivers/hv/hv_proc.c b/drivers/hv/hv_proc.c index 3e410489f480..2fae18e4f7d2 100644 --- a/drivers/hv/hv_proc.c +++ b/drivers/hv/hv_proc.c @@ -88,7 +88,7 @@ int hv_call_deposit_pages(int node, u64 partition_id, u32= num_pages) local_irq_restore(flags); if (!hv_result_success(status)) { pr_err("Failed to deposit pages: %lld\n", status); - ret =3D hv_result(status); + ret =3D hv_result_to_errno(status); goto err_free_allocations; } =20 @@ -114,7 +114,7 @@ int hv_call_add_logical_proc(int node, u32 lp_index, u3= 2 apic_id) struct hv_output_add_logical_processor *output; u64 status; unsigned long flags; - int ret =3D HV_STATUS_SUCCESS; + int ret =3D 0; =20 /* * When adding a logical processor, the hypervisor may return @@ -139,7 +139,7 @@ int hv_call_add_logical_proc(int node, u32 lp_index, u3= 2 apic_id) if (!hv_result_success(status)) { pr_err("%s: cpu %u apic ID %u, %lld\n", __func__, lp_index, apic_id, status); - ret =3D hv_result(status); + ret =3D hv_result_to_errno(status); } break; } @@ -154,7 +154,7 @@ int hv_call_create_vp(int node, u64 partition_id, u32 v= p_index, u32 flags) struct hv_create_vp *input; u64 status; unsigned long irq_flags; - int ret =3D HV_STATUS_SUCCESS; + int ret =3D 0; =20 /* Root VPs don't seem to need pages deposited */ if (partition_id !=3D hv_current_partition_id) { @@ -181,7 +181,7 @@ int hv_call_create_vp(int node, u64 partition_id, u32 v= p_index, u32 flags) if (!hv_result_success(status)) { pr_err("%s: vcpu %u, lp %u, %lld\n", __func__, vp_index, flags, status); - ret =3D hv_result(status); + ret =3D hv_result_to_errno(status); } break; } diff --git a/include/asm-generic/mshyperv.h b/include/asm-generic/mshyperv.h index 7adc10a4fa3e..3f115e2bcdaa 100644 --- a/include/asm-generic/mshyperv.h +++ b/include/asm-generic/mshyperv.h @@ -297,6 +297,7 @@ static inline int cpumask_to_vpset_skip(struct hv_vpset= *vpset, return __cpumask_to_vpset(vpset, cpus, func); } =20 +int hv_result_to_errno(u64 status); void hyperv_report_panic(struct pt_regs *regs, long err, bool in_die); bool hv_is_hyperv_initialized(void); bool hv_is_hibernation_supported(void); --=20 2.34.1