From nobody Sun Feb 8 20:35:54 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A125A18E05B; Fri, 23 Aug 2024 18:19:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724437193; cv=none; b=nZi8yGFWAht+/iR6r+rDjbLyYa8hsEi9vMWYCF9BWYW42VYBqp7s3ygRx87YQqAcXK9PRjGtZJSUmfhChqvVBi4jzKvyuapGmSLzbDTQzwvmPXfdea73t1APCePIhSIak/mKokhxqxo6QbfhYNFC3/hpVisjb/KJQy1u/Dt9WC0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724437193; c=relaxed/simple; bh=x5HHU0SBHuL9gbv/yKoeZWm4P0pIi2l2QWUYahKWuI8=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=HVIfTscSbugsvcWJgwiHvWpe/Z9YqX34uG2pQIu5tAnUDyCG2yUbkOjTIEuEtab9aDaAFQKF2GupCXAbFSV1f7V8iWl6qX1J7TqurC2DVE6qnIp/8pw4Y9gqOsYBQIZFKL8X9wCFTGeCwDk8mvNHn2/Dw5X3nnuILQ98Gl2U5ao= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=e0MFSEyY; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=WJve/7V9; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="e0MFSEyY"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="WJve/7V9" Date: Fri, 23 Aug 2024 18:19:49 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1724437189; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P7RqTooVElktesgJGQex7X/0e4odWmiKq6l4/sOY4/s=; b=e0MFSEyYColFaHIjLaCXtpRdIgJkwaz4kj/mM1q+k58w1QsNvetlcWFzi6thU2pExpmKHy MEy/yH0e3ngu4zdYfQtKQFSUracJEOaml4UEA8zCp/ET5D9AdWqht0FDdmY+imRoFh2xCk WnoJ40MLmNQoZYN5tklY1ydWM6EVAyKg/OD5UVSHRNovLx77n1DGtHRVBXQZVSyg23QdlS mZLI/MNOKhWEDXHO49shIW7Te/BeiRz+Txf7hk6KalJobIWFAJQTfvUhgeIvfUEl9ZZV+8 zPibDhaNLMccKullEj/gtaYSpo9AvKtkuW/zeSjTGW/NLaGBUvB+xTZCMLPviA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1724437189; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P7RqTooVElktesgJGQex7X/0e4odWmiKq6l4/sOY4/s=; b=WJve/7V9DEKEVmgfqdCUupFK0Aefc0FI+xUEKrn76PYLKper0CzIppNscqoaKkCh6DhiiD 24P1WA5OD9vHxnBw== From: "tip-bot2 for Chen Yufan" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/core] timekeeping: Use time_after() in timekeeping_check_update() Cc: Chen Yufan , Thomas Gleixner , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20240822070717.12773-1-chenyufan@vivo.com> References: <20240822070717.12773-1-chenyufan@vivo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <172443718918.2215.9073356657150571388.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The following commit has been merged into the timers/core branch of tip: Commit-ID: 42db2c2cb5ac3572380a9489b8f8bbe0e534dfc7 Gitweb: https://git.kernel.org/tip/42db2c2cb5ac3572380a9489b8f8bbe0e= 534dfc7 Author: Chen Yufan AuthorDate: Thu, 22 Aug 2024 15:07:17 +08:00 Committer: Thomas Gleixner CommitterDate: Fri, 23 Aug 2024 20:15:11 +02:00 timekeeping: Use time_after() in timekeeping_check_update() The open coded comparison does not handle wrap arounds correctly. Signed-off-by: Chen Yufan Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/all/20240822070717.12773-1-chenyufan@vivo.com --- kernel/time/timekeeping.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index 2fa87dc..4fa42a1 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -217,7 +217,7 @@ static void timekeeping_check_update(struct timekeeper = *tk, u64 offset) } =20 if (tk->underflow_seen) { - if (jiffies - tk->last_warning > WARNING_FREQ) { + if (time_after(jiffies, tk->last_warning + WARNING_FREQ)) { printk_deferred("WARNING: Underflow in clocksource '%s' observed, time = update ignored.\n", name); printk_deferred(" Please report this, consider using a differen= t clocksource, if possible.\n"); printk_deferred(" Your kernel is probably still fine.\n"); @@ -227,7 +227,7 @@ static void timekeeping_check_update(struct timekeeper = *tk, u64 offset) } =20 if (tk->overflow_seen) { - if (jiffies - tk->last_warning > WARNING_FREQ) { + if (time_after(jiffies, tk->last_warning + WARNING_FREQ)) { printk_deferred("WARNING: Overflow in clocksource '%s' observed, time u= pdate capped.\n", name); printk_deferred(" Please report this, consider using a differen= t clocksource, if possible.\n"); printk_deferred(" Your kernel is probably still fine.\n");