From nobody Wed Dec 17 01:10:38 2025 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B16F171655; Mon, 22 Jul 2024 19:35:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721676924; cv=none; b=bWlMNzLqfJ1q8o5HMK9oGzkhh37KCflf8KS30S7RmJiQyNpYzeIvb0MVvaZitKjcVd1ENZyy6Z+27211Ja6ie/A/N9f358ZusNcm0l2RLz2svw1OMPl1LRi1uhjsk+eZfFWBhNGsjDZXXRUdB0Np27qog4NkQCBWKsROsNx1LEI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721676924; c=relaxed/simple; bh=DyXpRc21lA5PNoYxSGUg8tpUAJAbGxpVptVHK/nXu5I=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=aPTRWgKAFlaHHS8Zl0YbdWwA/Yj1UZnzKo1okri0vgKyVyoXNE2BgkcenmSnvY8h7qyVN7u1l17Xp0/A7Q01Ar8Q/Y090RyvbJMZZOPzST2kLGwEuvGRqlZf9eQaFG5tC9PAKCb0d+ZvuI+dnjYoGhSXwiyAD3koCsyGNNkI0Hg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=z/uZ8/bz; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=yNJExm0x; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="z/uZ8/bz"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="yNJExm0x" Date: Mon, 22 Jul 2024 19:35:20 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1721676920; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HLOCwij10VLL1BYys/xjrFmDzoCWkMm0Tqz9jBFesy4=; b=z/uZ8/bz2Z9nmOdpp6pgfpzw2Q/XEZ0+Hfy02v/LYpbNAz2eWiArCOmOwXSOZ/7NA30+QJ ejOhWvn4fmO9tw9S9SkewzNC1WCkjDYUqtlBujFJql6cVcP6iSoMJgVb9jQN8pDBJit3tB Lwxx/t33CBQW1LdIyOq5t07K1ZFxJRbxAMcKNqeXvm6bZRIB05nCXFvQ8XNQC1CvrQIP5G F68fDsD33jrIO9P//EBAvUgfoO8hi1WVQBYHBFicyvHpN95jD0hiMFxTYGeS3kfbD1eIZs uA6YTpP5KMRyc2Cw4QrEBImodiHo2fkcgvrw3WCjvY31BxIH50OV0yLMxY0mKg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1721676920; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HLOCwij10VLL1BYys/xjrFmDzoCWkMm0Tqz9jBFesy4=; b=yNJExm0xR+dxMFRCMywpUhBEQf3ZeuawaNKqRlxtRw1cO4D5WN5g0bpX+/CNlXGKT9MzH6 +vMkVHXPQ5SyuwCQ== From: "tip-bot2 for Anna-Maria Behnsen" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/urgent] timers/migration: Improve tracing Cc: "Anna-Maria Behnsen" , Thomas Gleixner , Frederic Weisbecker , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20240716-tmigr-fixes-v4-3-757baa7803fe@linutronix.de> References: <20240716-tmigr-fixes-v4-3-757baa7803fe@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <172167692009.2215.9790596749360519014.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The following commit has been merged into the timers/urgent branch of tip: Commit-ID: 92506741521fd09dfaa9d6ef3c3620a9dd6bbafd Gitweb: https://git.kernel.org/tip/92506741521fd09dfaa9d6ef3c3620a9d= d6bbafd Author: Anna-Maria Behnsen AuthorDate: Tue, 16 Jul 2024 16:19:21 +02:00 Committer: Thomas Gleixner CommitterDate: Mon, 22 Jul 2024 18:03:34 +02:00 timers/migration: Improve tracing Trace points of inactive and active propagation are located at the end of the related functions. The interesting information of those trace points is the updated group state. When trace points are not located directly at the place where group state changed, order of trace points in traces could be confusing. Move inactive and active propagation trace points directly after update of group state values. Signed-off-by: Anna-Maria Behnsen Signed-off-by: Thomas Gleixner Reviewed-by: Frederic Weisbecker Link: https://lore.kernel.org/r/20240716-tmigr-fixes-v4-3-757baa7803fe@linu= tronix.de --- kernel/time/timer_migration.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.c index 867f0ec..4fbd930 100644 --- a/kernel/time/timer_migration.c +++ b/kernel/time/timer_migration.c @@ -656,6 +656,8 @@ static bool tmigr_active_up(struct tmigr_group *group, =20 } while (!atomic_try_cmpxchg(&group->migr_state, &curstate.state, newstat= e.state)); =20 + trace_tmigr_group_set_cpu_active(group, newstate, childmask); + if (walk_done =3D=3D false) data->childmask =3D group->childmask; =20 @@ -673,8 +675,6 @@ static bool tmigr_active_up(struct tmigr_group *group, */ group->groupevt.ignore =3D true; =20 - trace_tmigr_group_set_cpu_active(group, newstate, childmask); - return walk_done; } =20 @@ -1306,9 +1306,10 @@ static bool tmigr_inactive_up(struct tmigr_group *gr= oup, =20 WARN_ON_ONCE((newstate.migrator !=3D TMIGR_NONE) && !(newstate.active)); =20 - if (atomic_try_cmpxchg(&group->migr_state, &curstate.state, - newstate.state)) + if (atomic_try_cmpxchg(&group->migr_state, &curstate.state, newstate.sta= te)) { + trace_tmigr_group_set_cpu_inactive(group, newstate, childmask); break; + } =20 /* * The memory barrier is paired with the cmpxchg() in @@ -1327,8 +1328,6 @@ static bool tmigr_inactive_up(struct tmigr_group *gro= up, if (walk_done =3D=3D false) data->childmask =3D group->childmask; =20 - trace_tmigr_group_set_cpu_inactive(group, newstate, childmask); - return walk_done; }