From nobody Wed Feb 11 03:02:37 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89EE61755B; Fri, 17 May 2024 07:32:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715931128; cv=none; b=RT5M9nghFm9JYtyPt+BkI6cM7cTCrJc1Mwj6xFhDRVP13p8fKbWZ5axf6MG3xCuC4Qg3Q1B4DDqjopMy87IQWxy6Lj6skEWKG61pOcRlbuKTDroDSaB6vpcKMMSrMYwpUzxhb+XW/AvCcC+6GaYXDv7S31Gll36G5pVsVi9qv/8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715931128; c=relaxed/simple; bh=S2PZLFddPVrB1+FlcKAYCzt3l6bHD5eTHhU3XuYpYMU=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=XhKN7gz65qf+iwAg5hn0G6KG2Hq3GcfIWf/R6USgRlH8jBDpi2RYv/nGUAH8aiawvEHsZxq1/PXD5nVINAacnW8kk4X90yu3VDegyzcMGAInxO4pRCQbRIfruvqq82wPgGRx0KC2sM/DjGvBKxscwpdYdihlC+IX7Xbn4PC9+YQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=JYlw8zc+; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=5dKDK6QN; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="JYlw8zc+"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="5dKDK6QN" Date: Fri, 17 May 2024 07:32:03 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1715931123; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2t3iRQxrW2/GtqbP4uHv4QN2NOW1BFn6P6L7kFpcAi0=; b=JYlw8zc+WqjwMx214LBQumYVbQZWnRb3Zv7qIg0gQyxsOq1j2zFPTa+ycXH8EySJio/0Ks vRUx9SNOm31tqHD5czt2FoDLQjBRjfJYY+1tHXGduN5SModyKk2rCoYI9CCeIB48RuSSBF 4zsPlv0cmQW+sSYEgEh8gHwq+oY2YNBlnx5ouKSQxzXoGRosvptf4ZO9+qeeIM2khdM6hO QL2A50pOfLcAEEXXRx2zdiiJAAmfv1iIvxD24awoYBrvic2eQeZynlTwORyblosi5xFM3G 7FdSm91+YPEf8fgIRwbaKZ8di5Etkmf3fgMQLNvPRCjK7egDfDbNQawtIpCABg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1715931123; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2t3iRQxrW2/GtqbP4uHv4QN2NOW1BFn6P6L7kFpcAi0=; b=5dKDK6QNnGbGuYHaQ6Q0YrqEZjFXX4r99dF/dWIoUhzmZmbpqOC0XYXueaS9CXEKgIud6z 9ZlxhEgs8P8g4VDA== From: "tip-bot2 for Nathan Chancellor" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/urgent] x86/boot: Address clang -Wimplicit-fallthrough in vsprintf() Cc: kernel test robot , Nathan Chancellor , Ingo Molnar , Justin Stitt , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: =?utf-8?q?=3C20240516-x86-boot-fix-clang-implicit-fallthrough-v?= =?utf-8?q?1-1-04dc320ca07c=40kernel=2Eorg=3E?= References: =?utf-8?q?=3C20240516-x86-boot-fix-clang-implicit-fallthrough-v1?= =?utf-8?q?-1-04dc320ca07c=40kernel=2Eorg=3E?= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <171593112323.10875.12795745055609386229.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The following commit has been merged into the x86/urgent branch of tip: Commit-ID: 82110ae235e0560d1f952f74f9fd991587b0e3a7 Gitweb: https://git.kernel.org/tip/82110ae235e0560d1f952f74f9fd99158= 7b0e3a7 Author: Nathan Chancellor AuthorDate: Thu, 16 May 2024 07:03:41 -07:00 Committer: Ingo Molnar CommitterDate: Fri, 17 May 2024 09:22:56 +02:00 x86/boot: Address clang -Wimplicit-fallthrough in vsprintf() After enabling -Wimplicit-fallthrough for the x86 boot code, clang warns: arch/x86/boot/printf.c:257:3: warning: unannotated fall-through between s= witch labels [-Wimplicit-fallthrough] 257 | case 'u': | ^ Clang is a little more pedantic than GCC, which does not warn when falling through to a case that is just break or return. Clang's version is more in line with the kernel's own stance in deprecated.rst, which states that all switch/case blocks must end in either break, fallthrough, continue, goto, or return. Add the missing break to silence the warning. Fixes: dd0716c2b877 ("x86/boot: Add a fallthrough annotation") Reported-by: kernel test robot Signed-off-by: Nathan Chancellor Signed-off-by: Ingo Molnar Acked-by: Justin Stitt Link: https://lore.kernel.org/r/20240516-x86-boot-fix-clang-implicit-fallth= rough-v1-1-04dc320ca07c@kernel.org Closes: https://lore.kernel.org/oe-kbuild-all/202405162054.ryP73vy1-lkp@int= el.com/ --- arch/x86/boot/printf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/boot/printf.c b/arch/x86/boot/printf.c index c0ec1dc..51dc14b 100644 --- a/arch/x86/boot/printf.c +++ b/arch/x86/boot/printf.c @@ -254,6 +254,8 @@ int vsprintf(char *buf, const char *fmt, va_list args) case 'd': case 'i': flags |=3D SIGN; + break; + case 'u': break;