From nobody Sat May 18 19:47:46 2024 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3D164CB55; Tue, 23 Apr 2024 10:33:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713868437; cv=none; b=KMcny5m+npf2PCD2uzAHoHVYWg8dayDsLLeJ27Xu5RyZHrK01Ma53BakxM6tnblFZCXeRAyqjsAdGnkDSpELkfoGIjWuTzzGE47eGehr8PH3Aq95O5GhFJKR1RqF+lrM25LSRpEX43JVEXpSCbsSDKV/UXFcuwY+Hmx9XA0KQd8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713868437; c=relaxed/simple; bh=UtpNEe7RCVCyvjmiQbOopIWJt3NeINXQPxdStX6uzGQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=dL4a8Km+6idLT678ZedonevDnP9tIt55OHOKTLEXsf2+g0DAUZQ+vMw1jzdbOlRCcEl3hRevOt3HdsWVvB+gx/u/6wEsuTyykjKze4RLyPI/Gvs42grKgT/idHTt+3qHhNbPy5G1d0b7TSUcfxRcG7MpEj2MdA4w8jTYByiyDoM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=qualcomm.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=E2tMDePN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="E2tMDePN" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 43N7uX8A019524; Tue, 23 Apr 2024 10:33:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:to:cc:subject:date:message-id:in-reply-to:references; s= qcppdkim1; bh=ngidwSR8rhrotn4Wwssi/8HJt6GkxJpIhIcymAffNfk=; b=E2 tMDePNdHhWwWORDe8P78B9ICMuZ4tWro5OPNQ28EZ0GNcnbtBRe3WILVURWK/Ckq av/vjxnGz4biIIzsE0w9TcmgR6aE7HzkBtVxANJhW4kHTEcINQ9SevGy6eKcrvHP wigmOhh+VB9wsCd6c4b7UXonw/ppy53fpoVP9XO4nGs8stPQSqJE3pbnYCXsZkG5 dcfvHGlJiPb6sz+t4Kcz1pDuGcUTrLAT5B+dzntpX2GXdlEvpsT7amkYiRHAC/UV gg3yfkmq1HfVNYIp6YByd4w47V+rAdk26cWYjLVOxkgZQXglk5aDuvroAQFreO8j fcZjhO4AFSmIb7O0OYGw== Received: from aptaippmta02.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com [103.229.16.4]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xp91rrcek-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Apr 2024 10:33:43 +0000 (GMT) Received: from pps.filterd (APTAIPPMTA02.qualcomm.com [127.0.0.1]) by APTAIPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 43NAXetW030325; Tue, 23 Apr 2024 10:33:40 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APTAIPPMTA02.qualcomm.com (PPS) with ESMTP id 3xm6skdt6a-1; Tue, 23 Apr 2024 10:33:40 +0000 Received: from APTAIPPMTA02.qualcomm.com (APTAIPPMTA02.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43NAXeTE030320; Tue, 23 Apr 2024 10:33:40 GMT Received: from cbsp-sh-gv.qualcomm.com (CBSP-SH-gv.ap.qualcomm.com [10.231.249.68]) by APTAIPPMTA02.qualcomm.com (PPS) with ESMTP id 43NAXef6030319; Tue, 23 Apr 2024 10:33:40 +0000 Received: by cbsp-sh-gv.qualcomm.com (Postfix, from userid 4098150) id 8E6645B13; Tue, 23 Apr 2024 18:33:39 +0800 (CST) From: Qiang Yu To: mani@kernel.org, quic_jhugo@quicinc.com Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, quic_mrana@quicinc.com, Qiang Yu Subject: [PATCH v4 1/3] bus: mhi: host: Add sysfs entry to force device to enter EDL Date: Tue, 23 Apr 2024 18:33:35 +0800 Message-Id: <1713868417-37856-2-git-send-email-quic_qianyu@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1713868417-37856-1-git-send-email-quic_qianyu@quicinc.com> References: <1713868417-37856-1-git-send-email-quic_qianyu@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: u91YeVTGBqAdZW4xFWRkqUKiU8mTMC8C X-Proofpoint-ORIG-GUID: u91YeVTGBqAdZW4xFWRkqUKiU8mTMC8C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-23_09,2024-04-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 clxscore=1015 phishscore=0 bulkscore=0 suspectscore=0 impostorscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2404230028 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Add sysfs entry to allow users of MHI bus force device to enter EDL. Considering that the way to enter EDL mode varies from device to device and some devices even do not support EDL. Hence, add a callback edl_trigger in mhi controller as part of the sysfs entry to be invoked and MHI core will only create EDL sysfs entry for mhi controller that provides edl_trigger callback. All of the process a specific device required to enter EDL mode can be placed in this callback. Signed-off-by: Qiang Yu Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam --- Documentation/ABI/stable/sysfs-bus-mhi | 13 +++++++++++++ drivers/bus/mhi/host/init.c | 33 ++++++++++++++++++++++++++++++= +++ include/linux/mhi.h | 2 ++ 3 files changed, 48 insertions(+) diff --git a/Documentation/ABI/stable/sysfs-bus-mhi b/Documentation/ABI/sta= ble/sysfs-bus-mhi index 1a47f9e..b44f467 100644 --- a/Documentation/ABI/stable/sysfs-bus-mhi +++ b/Documentation/ABI/stable/sysfs-bus-mhi @@ -29,3 +29,16 @@ Description: Initiates a SoC reset on the MHI controller= . A SoC reset is This can be useful as a method of recovery if the device is non-responsive, or as a means of loading new firmware as a system administration task. + +What: /sys/bus/mhi/devices/.../trigger_edl +Date: April 2024 +KernelVersion: 6.9 +Contact: mhi@lists.linux.dev +Description: Writing a non-zero value to this file will force devices to + enter EDL (Emergency Download) mode. This entry only exist= s for + devices capable of entering the EDL mode using the standar= d EDL + triggering mechanism defined in the MHI spec v1.2. Once in= EDL + mode, the flash programmer image can be downloaded to the + device to enter the flash programmer execution environment. + This can be useful if user wants to use QDL (Qualcomm Down= load, + which is used to download firmware over EDL) to update fir= mware. diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c index 44f9349..7104c18 100644 --- a/drivers/bus/mhi/host/init.c +++ b/drivers/bus/mhi/host/init.c @@ -127,6 +127,30 @@ static ssize_t soc_reset_store(struct device *dev, } static DEVICE_ATTR_WO(soc_reset); =20 +static ssize_t trigger_edl_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct mhi_device *mhi_dev =3D to_mhi_device(dev); + struct mhi_controller *mhi_cntrl =3D mhi_dev->mhi_cntrl; + unsigned long val; + int ret; + + ret =3D kstrtoul(buf, 10, &val); + if (ret < 0) + return ret; + + if (!val) + return -EINVAL; + + ret =3D mhi_cntrl->edl_trigger(mhi_cntrl); + if (ret) + return ret; + + return count; +} +static DEVICE_ATTR_WO(trigger_edl); + static struct attribute *mhi_dev_attrs[] =3D { &dev_attr_serial_number.attr, &dev_attr_oem_pk_hash.attr, @@ -1018,6 +1042,12 @@ int mhi_register_controller(struct mhi_controller *m= hi_cntrl, if (ret) goto err_release_dev; =20 + if (mhi_cntrl->edl_trigger) { + ret =3D sysfs_create_file(&mhi_dev->dev.kobj, &dev_attr_trigger_edl.attr= ); + if (ret) + goto err_release_dev; + } + mhi_cntrl->mhi_dev =3D mhi_dev; =20 mhi_create_debugfs(mhi_cntrl); @@ -1051,6 +1081,9 @@ void mhi_unregister_controller(struct mhi_controller = *mhi_cntrl) mhi_deinit_free_irq(mhi_cntrl); mhi_destroy_debugfs(mhi_cntrl); =20 + if (mhi_cntrl->edl_trigger) + sysfs_remove_file(&mhi_dev->dev.kobj, &dev_attr_trigger_edl.attr); + destroy_workqueue(mhi_cntrl->hiprio_wq); kfree(mhi_cntrl->mhi_cmd); kfree(mhi_cntrl->mhi_event); diff --git a/include/linux/mhi.h b/include/linux/mhi.h index cde01e1..d968e1a 100644 --- a/include/linux/mhi.h +++ b/include/linux/mhi.h @@ -353,6 +353,7 @@ struct mhi_controller_config { * @read_reg: Read a MHI register via the physical link (required) * @write_reg: Write a MHI register via the physical link (required) * @reset: Controller specific reset function (optional) + * @edl_trigger: CB function to trigger EDL mode (optional) * @buffer_len: Bounce buffer length * @index: Index of the MHI controller instance * @bounce_buf: Use of bounce buffer @@ -435,6 +436,7 @@ struct mhi_controller { void (*write_reg)(struct mhi_controller *mhi_cntrl, void __iomem *addr, u32 val); void (*reset)(struct mhi_controller *mhi_cntrl); + int (*edl_trigger)(struct mhi_controller *mhi_cntrl); =20 size_t buffer_len; int index; --=20 2.7.4 From nobody Sat May 18 19:47:46 2024 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3CC74501F; Tue, 23 Apr 2024 10:33:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713868437; cv=none; b=Xqxak7uSweIwC41C5FEpVkRqcnbBGZI0ZGb5xLlqchd/XrsfTXKB3nQqeWUc69PFN+CJi5D/Mbo9buptbrfO7hMRlzEFvrMFCDlVwFE3LCP99LA6X3v2KjYLQ1voMe9f3MbZTsz7RjdRXHNIPwVzn22+mQyLRPky2tUpdiqaQYQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713868437; c=relaxed/simple; bh=XIPYcrQ3GunBqF7O2yX/Nrd0N+vABpiohMutuXWlHLk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=WhUgwgFZtgUYlOc7tR+AayNnrCB89ZDrLPyR6XRKpb6Qc9r04QArcFFChqO6Wlzo/PxZb6BfWaYNaKN4umCzn+X/ujmuwNXb61KmdWr0PYYEYwqHYWxxAWZ624YQwQdi7ScwZ4Wcc4A0FRr9te9TFUCbc8ElgAvzDYO5XtfUCXE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=qualcomm.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=MfDgEw2J; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="MfDgEw2J" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 43N5Tj4Z012462; Tue, 23 Apr 2024 10:33:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:to:cc:subject:date:message-id:in-reply-to:references; s= qcppdkim1; bh=MiYKtVjiYGayHJ4uhB0s6D821r2mrG8hS7wgv8FbeJE=; b=Mf DgEw2JukuSF2ZlcjBATtdQWwUtmQLG7phAvAuxvSF+UgR5IGzoY6YGBLOQ555a2x IfOTalO9VDEXmdD1IErFxmoi3fdBHL+TIJc3UzuiMj1CRQlFcow0wd7lCoKen512 1qzs5iDR5ZL/7x5OddxyIhcSpv7ucPks89DWkXTtebyu8liDq6y6guXfS7X7iMfX UBvj7EDa0JI4JCTFzZcg404taKPy+qIXk4ybiuONv/xEkd8B674tF2Dq8pwvJmih 2/vJ0ejEKYJEAaevGN75ttY6WxSsdOIwLjVgcpTYnCRemdf9eaT9+pocHRZDwBe8 5GJdlPK4Z7Pw0a91/sNw== Received: from aptaippmta02.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com [103.229.16.4]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xnvtn9qxc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Apr 2024 10:33:43 +0000 (GMT) Received: from pps.filterd (APTAIPPMTA02.qualcomm.com [127.0.0.1]) by APTAIPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 43NAXf3F030334; Tue, 23 Apr 2024 10:33:41 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APTAIPPMTA02.qualcomm.com (PPS) with ESMTP id 3xm6skdt6e-1; Tue, 23 Apr 2024 10:33:41 +0000 Received: from APTAIPPMTA02.qualcomm.com (APTAIPPMTA02.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43NAXfuX030329; Tue, 23 Apr 2024 10:33:41 GMT Received: from cbsp-sh-gv.qualcomm.com (CBSP-SH-gv.ap.qualcomm.com [10.231.249.68]) by APTAIPPMTA02.qualcomm.com (PPS) with ESMTP id 43NAXeX4030328; Tue, 23 Apr 2024 10:33:41 +0000 Received: by cbsp-sh-gv.qualcomm.com (Postfix, from userid 4098150) id EE2955B14; Tue, 23 Apr 2024 18:33:39 +0800 (CST) From: Qiang Yu To: mani@kernel.org, quic_jhugo@quicinc.com Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, quic_mrana@quicinc.com, Qiang Yu Subject: [PATCH v4 2/3] bus: mhi: host: Add a new API for getting channel doorbell address Date: Tue, 23 Apr 2024 18:33:36 +0800 Message-Id: <1713868417-37856-3-git-send-email-quic_qianyu@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1713868417-37856-1-git-send-email-quic_qianyu@quicinc.com> References: <1713868417-37856-1-git-send-email-quic_qianyu@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: O8X6Ht0mrDFJqmpmjiWc153Lxw9F5fBe X-Proofpoint-ORIG-GUID: O8X6Ht0mrDFJqmpmjiWc153Lxw9F5fBe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-23_09,2024-04-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 mlxlogscore=999 phishscore=0 priorityscore=1501 mlxscore=0 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2404230028 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Some controllers may want to know the address of a certain doorbell. Hence add a new API where we read CHDBOFF register to get the base address of doorbell, so that the controller can calculate the address of the doorbell it wants by adding additional offset. Signed-off-by: Qiang Yu Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam --- drivers/bus/mhi/host/init.c | 6 ++---- drivers/bus/mhi/host/main.c | 16 ++++++++++++++++ include/linux/mhi.h | 6 ++++++ 3 files changed, 24 insertions(+), 4 deletions(-) diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c index 7104c18..6e0fa79 100644 --- a/drivers/bus/mhi/host/init.c +++ b/drivers/bus/mhi/host/init.c @@ -541,11 +541,9 @@ int mhi_init_mmio(struct mhi_controller *mhi_cntrl) dev_dbg(dev, "Initializing MHI registers\n"); =20 /* Read channel db offset */ - ret =3D mhi_read_reg(mhi_cntrl, base, CHDBOFF, &val); - if (ret) { - dev_err(dev, "Unable to read CHDBOFF register\n"); + ret =3D mhi_get_channel_doorbell_offset(mhi_cntrl, &val); + if (ret) return -EIO; - } =20 if (val >=3D mhi_cntrl->reg_len - (8 * MHI_DEV_WAKE_DB)) { dev_err(dev, "CHDB offset: 0x%x is out of range: 0x%zx\n", diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c index 15d657a..4de7567 100644 --- a/drivers/bus/mhi/host/main.c +++ b/drivers/bus/mhi/host/main.c @@ -1691,3 +1691,19 @@ void mhi_unprepare_from_transfer(struct mhi_device *= mhi_dev) } } EXPORT_SYMBOL_GPL(mhi_unprepare_from_transfer); + +int mhi_get_channel_doorbell_offset(struct mhi_controller *mhi_cntrl, u32 = *chdb_offset) +{ + struct device *dev =3D &mhi_cntrl->mhi_dev->dev; + void __iomem *base =3D mhi_cntrl->regs; + int ret; + + ret =3D mhi_read_reg(mhi_cntrl, base, CHDBOFF, chdb_offset); + if (ret) { + dev_err(dev, "Unable to read CHDBOFF register\n"); + return -EIO; + } + + return 0; +} +EXPORT_SYMBOL_GPL(mhi_get_channel_doorbell_offset); diff --git a/include/linux/mhi.h b/include/linux/mhi.h index d968e1a..cb3b676 100644 --- a/include/linux/mhi.h +++ b/include/linux/mhi.h @@ -816,4 +816,10 @@ int mhi_queue_skb(struct mhi_device *mhi_dev, enum dma= _data_direction dir, */ bool mhi_queue_is_full(struct mhi_device *mhi_dev, enum dma_data_direction= dir); =20 +/** + * mhi_get_channel_doorbell_offset - Get the channel doorbell offset + * @mhi_cntrl: MHI controller + * @chdb_offset: Channel doorbell offset + */ +int mhi_get_channel_doorbell_offset(struct mhi_controller *mhi_cntrl, u32 = *chdb_offset); #endif /* _MHI_H_ */ --=20 2.7.4 From nobody Sat May 18 19:47:46 2024 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65E15322A; Tue, 23 Apr 2024 10:33:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713868435; cv=none; b=A9Pr/R/HcVuFr3MyBbfO/5vMdLmez2Cw7DCaDEv+puJOSJCvyVZa7by8xQvDNbguHWZSN1dho9VihhqKaNNclD6YAvC57qNI1MOZ4TDZDp0ebF3dYKtOqTrf5dPtUtSlLV5UW4hArkh7QE7BnuEdlKJrC7IGTONAMN6beLFETQ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713868435; c=relaxed/simple; bh=bXqo+Zh46zqPZrck6jl1uquMHLCwuBpnagCno6z+964=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=pFtA6dTQHQcmodOIyyBF+5Xh2ImUgK+nesn9FQEiCWGdH4qdU9xx46ioQPaxa3kPYVUQ+DD57OHuwvVRFcBVk/Y4PUj4voKEEpEoXEpsr3Jd2HMH3u15OVd1bKq9ji9jCHQmAOk/To/VwrLeGnRXMs3IfkM4FvmZdZ3IXpQYO1A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=qualcomm.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=mshBm6sk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="mshBm6sk" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 43N9nm6q005293; Tue, 23 Apr 2024 10:33:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:to:cc:subject:date:message-id:in-reply-to:references; s= qcppdkim1; bh=fPY8VNbNEa664HwPePTbFwyJ0YDyG1kZh2fUqeuBZws=; b=ms hBm6sk/UDgqCXfrFUL04S/z2seloa5H2Hb1DRV8RjsCg30Tsq2jiOPf/euxp0sQl lx7jrq3zHCZaWj8PCNB0kT9UEIX8AtkdEPTLSEe4JqkAlLjMsr/c4l+QaHfrWsVI cjiFdcngioR7FZLg36xch2bsOv7lClAV7FCXWjuF0huDF0sHtwU5RsXMef/qYcvB 6RsLFkkCs++OzCOwpRm3d1y9hh6XlsAFsNva4kdkhMQ5j8N6TIct+cjN8EMocvlj 4gGNqrzIWjtw8OHfmQs7CypIKRCInH5QzufEJ1r7psNYCaB6jKAZ0lecv0uC9Y2m WKEmBN6KVYejSQ2j8IIw== Received: from aptaippmta01.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com [103.229.16.4]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xpapmg3jc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Apr 2024 10:33:43 +0000 (GMT) Received: from pps.filterd (APTAIPPMTA01.qualcomm.com [127.0.0.1]) by APTAIPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 43NAXfYD003612; Tue, 23 Apr 2024 10:33:41 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APTAIPPMTA01.qualcomm.com (PPS) with ESMTP id 3xm6ske0ba-1; Tue, 23 Apr 2024 10:33:41 +0000 Received: from APTAIPPMTA01.qualcomm.com (APTAIPPMTA01.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43NAXfth003605; Tue, 23 Apr 2024 10:33:41 GMT Received: from cbsp-sh-gv.qualcomm.com (CBSP-SH-gv.ap.qualcomm.com [10.231.249.68]) by APTAIPPMTA01.qualcomm.com (PPS) with ESMTP id 43NAXf8t003604; Tue, 23 Apr 2024 10:33:41 +0000 Received: by cbsp-sh-gv.qualcomm.com (Postfix, from userid 4098150) id 61DC85B10; Tue, 23 Apr 2024 18:33:40 +0800 (CST) From: Qiang Yu To: mani@kernel.org, quic_jhugo@quicinc.com Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, quic_mrana@quicinc.com, Qiang Yu Subject: [PATCH v4 3/3] bus: mhi: host: pci_generic: Add edl callback to enter EDL Date: Tue, 23 Apr 2024 18:33:37 +0800 Message-Id: <1713868417-37856-4-git-send-email-quic_qianyu@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1713868417-37856-1-git-send-email-quic_qianyu@quicinc.com> References: <1713868417-37856-1-git-send-email-quic_qianyu@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: PI4mMDUrlgJ2iEevvVBpKQW_xG_UpIwg X-Proofpoint-GUID: PI4mMDUrlgJ2iEevvVBpKQW_xG_UpIwg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-23_09,2024-04-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 mlxlogscore=999 clxscore=1015 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2404230028 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Some of the MHI modems like SDX65 based ones are capable of entering the EDL mode as per the standard triggering mechanism defined in the MHI spec v1.2.= So let's add a common mhi_pci_generic_edl_trigger() function that triggers the= EDL mode in the device when user writes to the /sys/bus/mhi/devices/.../trigger= _edl file. Signed-off-by: Qiang Yu Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam --- drivers/bus/mhi/host/pci_generic.c | 45 ++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 45 insertions(+) diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_= generic.c index 51639bf..c65eaa8 100644 --- a/drivers/bus/mhi/host/pci_generic.c +++ b/drivers/bus/mhi/host/pci_generic.c @@ -27,12 +27,16 @@ #define PCI_VENDOR_ID_THALES 0x1269 #define PCI_VENDOR_ID_QUECTEL 0x1eac =20 +#define MHI_EDL_DB 91 +#define MHI_EDL_COOKIE 0xEDEDEDED + /** * struct mhi_pci_dev_info - MHI PCI device specific information * @config: MHI controller configuration * @name: name of the PCI module * @fw: firmware path (if any) * @edl: emergency download mode firmware path (if any) + * @edl_trigger: capable of triggering EDL mode in the device (if supporte= d) * @bar_num: PCI base address register to use for MHI MMIO register space * @dma_data_width: DMA transfer word size (32 or 64 bits) * @mru_default: default MRU size for MBIM network packets @@ -44,6 +48,7 @@ struct mhi_pci_dev_info { const char *name; const char *fw; const char *edl; + bool edl_trigger; unsigned int bar_num; unsigned int dma_data_width; unsigned int mru_default; @@ -292,6 +297,7 @@ static const struct mhi_pci_dev_info mhi_qcom_sdx75_inf= o =3D { .name =3D "qcom-sdx75m", .fw =3D "qcom/sdx75m/xbl.elf", .edl =3D "qcom/sdx75m/edl.mbn", + .edl_trigger =3D true, .config =3D &modem_qcom_v2_mhiv_config, .bar_num =3D MHI_PCI_DEFAULT_BAR_NUM, .dma_data_width =3D 32, @@ -302,6 +308,7 @@ static const struct mhi_pci_dev_info mhi_qcom_sdx65_inf= o =3D { .name =3D "qcom-sdx65m", .fw =3D "qcom/sdx65m/xbl.elf", .edl =3D "qcom/sdx65m/edl.mbn", + .edl_trigger =3D true, .config =3D &modem_qcom_v1_mhiv_config, .bar_num =3D MHI_PCI_DEFAULT_BAR_NUM, .dma_data_width =3D 32, @@ -312,6 +319,7 @@ static const struct mhi_pci_dev_info mhi_qcom_sdx55_inf= o =3D { .name =3D "qcom-sdx55m", .fw =3D "qcom/sdx55m/sbl1.mbn", .edl =3D "qcom/sdx55m/edl.mbn", + .edl_trigger =3D true, .config =3D &modem_qcom_v1_mhiv_config, .bar_num =3D MHI_PCI_DEFAULT_BAR_NUM, .dma_data_width =3D 32, @@ -928,6 +936,40 @@ static void health_check(struct timer_list *t) mod_timer(&mhi_pdev->health_check_timer, jiffies + HEALTH_CHECK_PERIOD); } =20 +static int mhi_pci_generic_edl_trigger(struct mhi_controller *mhi_cntrl) +{ + void __iomem *base =3D mhi_cntrl->regs; + void __iomem *edl_db; + int ret =3D 0; + u32 val; + + ret =3D mhi_device_get_sync(mhi_cntrl->mhi_dev); + if (ret) { + dev_err(mhi_cntrl->cntrl_dev, "Failed to wakeup the device\n"); + return ret; + } + + pm_wakeup_event(&mhi_cntrl->mhi_dev->dev, 0); + mhi_cntrl->runtime_get(mhi_cntrl); + + ret =3D mhi_get_channel_doorbell_offset(mhi_cntrl, &val); + if (ret) + goto err_get_chdb; + + edl_db =3D base + val + (8 * MHI_EDL_DB); + + mhi_cntrl->write_reg(mhi_cntrl, edl_db + 4, upper_32_bits(MHI_EDL_COOKIE)= ); + mhi_cntrl->write_reg(mhi_cntrl, edl_db, lower_32_bits(MHI_EDL_COOKIE)); + + mhi_soc_reset(mhi_cntrl); + +err_get_chdb: + mhi_cntrl->runtime_put(mhi_cntrl); + mhi_device_put(mhi_cntrl->mhi_dev); + + return ret; +} + static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id = *id) { const struct mhi_pci_dev_info *info =3D (struct mhi_pci_dev_info *) id->d= river_data; @@ -962,6 +1004,9 @@ static int mhi_pci_probe(struct pci_dev *pdev, const s= truct pci_device_id *id) mhi_cntrl->runtime_put =3D mhi_pci_runtime_put; mhi_cntrl->mru =3D info->mru_default; =20 + if (info->edl_trigger) + mhi_cntrl->edl_trigger =3D mhi_pci_generic_edl_trigger; + if (info->sideband_wake) { mhi_cntrl->wake_get =3D mhi_pci_wake_get_nop; mhi_cntrl->wake_put =3D mhi_pci_wake_put_nop; --=20 2.7.4