From nobody Fri Dec 19 15:47:55 2025 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AADA26EB6E; Wed, 31 Jan 2024 10:55:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706698562; cv=none; b=rqiMAmIWyl1rbYzFsiC5qw69D0kNVdLFegsSsr6hKblcGL3Ome+Slfoe25qR9QKQpkedXFsjUto45t195K8C/A3uXqJPxB5MKP7Of3lMbKd2LfeTGojgP9HKijSPh1cmUTodm9zDP/b+8HSI7XObST4HdiwEi9vs9r8b3OExf3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706698562; c=relaxed/simple; bh=LHBIj/8uoDBRrS1dlZPeCz2qf0GZ0mc5vqMb8Dcyy6U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=sSfJqTRaFhIlREW0cMpPSoS3WWTve1HRpfs/X/LuJhQgILvlJcGvq5E+W20HYvaLNJ4+iO2SktQrlmAnxWQozpv+tEGgHCqG9pmncRgiYPB9j12SsC+fa6uDcN8jAnrqt1fmXUQcVFFQbkAwHplkZwhvQtoW6wsNLOlVgRhKM9s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=L7xBFSUO; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="L7xBFSUO" Received: from linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net (linux.microsoft.com [13.77.154.182]) by linux.microsoft.com (Postfix) with ESMTPSA id 1859020B2005; Wed, 31 Jan 2024 02:55:58 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1859020B2005 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1706698558; bh=MsUo2v+//cFlf6nJMuZ1DMVlU3JLOjmKGXGXkSEimVc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L7xBFSUON0y+jHp0RHicnx4GOcP3xCMFb6wyib2qcVkrCV4YXENV/EBgdnPq/AW1T t6fjax+zreYGHyrT/FTObwgcTI2XXzPsHWPiSMa5jFGT72oV3Ng9dnZiazoqVyWkX1 Rd8KPyE++IipAvl46yMwOVL88ODVAnYR0pVsveXY= From: Konstantin Taranov To: kotaranov@microsoft.com, sharmaajay@microsoft.com, longli@microsoft.com, jgg@ziepe.ca, leon@kernel.org Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH rdma-next v1 5/5] RDMA/mana_ib: Adding and deleting GIDs Date: Wed, 31 Jan 2024 02:55:52 -0800 Message-Id: <1706698552-25383-6-git-send-email-kotaranov@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1706698552-25383-1-git-send-email-kotaranov@linux.microsoft.com> References: <1706698552-25383-1-git-send-email-kotaranov@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Implement add_gid and del_gid for RNIC. We support ipv4 and ipv6 addresses. Signed-off-by: Konstantin Taranov --- drivers/infiniband/hw/mana/device.c | 2 ++ drivers/infiniband/hw/mana/main.c | 66 ++++++++++++++++++++++++++++++++= ++++ drivers/infiniband/hw/mana/mana_ib.h | 37 ++++++++++++++++++++ 3 files changed, 105 insertions(+) diff --git a/drivers/infiniband/hw/mana/device.c b/drivers/infiniband/hw/ma= na/device.c index b9ff3fd..9655307 100644 --- a/drivers/infiniband/hw/mana/device.c +++ b/drivers/infiniband/hw/mana/device.c @@ -15,6 +15,7 @@ .driver_id =3D RDMA_DRIVER_MANA, .uverbs_abi_ver =3D MANA_IB_UVERBS_ABI_VERSION, =20 + .add_gid =3D mana_ib_gd_add_gid, .alloc_pd =3D mana_ib_alloc_pd, .alloc_ucontext =3D mana_ib_alloc_ucontext, .create_cq =3D mana_ib_create_cq, @@ -23,6 +24,7 @@ .create_wq =3D mana_ib_create_wq, .dealloc_pd =3D mana_ib_dealloc_pd, .dealloc_ucontext =3D mana_ib_dealloc_ucontext, + .del_gid =3D mana_ib_gd_del_gid, .dereg_mr =3D mana_ib_dereg_mr, .destroy_cq =3D mana_ib_destroy_cq, .destroy_qp =3D mana_ib_destroy_qp, diff --git a/drivers/infiniband/hw/mana/main.c b/drivers/infiniband/hw/mana= /main.c index 645abf3..282c024 100644 --- a/drivers/infiniband/hw/mana/main.c +++ b/drivers/infiniband/hw/mana/main.c @@ -675,3 +675,69 @@ void mana_ib_gd_destroy_rnic_adapter(struct mana_ib_de= v *mdev) mdev->adapter_handle =3D INVALID_MANA_HANDLE; mana_ib_destroy_eqs(mdev); } + +int mana_ib_gd_add_gid(const struct ib_gid_attr *attr, void **context) +{ + struct mana_ib_dev *mdev =3D container_of(attr->device, struct mana_ib_de= v, ib_dev); + enum rdma_network_type ntype =3D rdma_gid_attr_network_type(attr); + struct mana_rnic_config_addr_resp resp =3D {}; + struct gdma_context *gc =3D mdev_to_gc(mdev); + struct mana_rnic_config_addr_req req =3D {}; + int err; + + if (!rnic_is_enabled(mdev)) + return -EINVAL; + + if (ntype !=3D RDMA_NETWORK_IPV4 && ntype !=3D RDMA_NETWORK_IPV6) { + ibdev_dbg(&mdev->ib_dev, "Unsupported rdma network type %d", ntype); + return -EINVAL; + } + + mana_gd_init_req_hdr(&req.hdr, MANA_IB_CONFIG_IP_ADDR, sizeof(req), sizeo= f(resp)); + req.hdr.dev_id =3D gc->mana_ib.dev_id; + req.adapter =3D mdev->adapter_handle; + req.op =3D ADDR_OP_ADD; + req.sgid_type =3D (ntype =3D=3D RDMA_NETWORK_IPV6) ? SGID_TYPE_IPV6 : SGI= D_TYPE_IPV4; + copy_in_reverse(req.ip_addr, attr->gid.raw, sizeof(union ib_gid)); + + err =3D mana_gd_send_request(gc, sizeof(req), &req, sizeof(resp), &resp); + if (err) { + ibdev_err(&mdev->ib_dev, "Failed to config IP addr err %d\n", err); + return err; + } + + return 0; +} + +int mana_ib_gd_del_gid(const struct ib_gid_attr *attr, void **context) +{ + struct mana_ib_dev *mdev =3D container_of(attr->device, struct mana_ib_de= v, ib_dev); + enum rdma_network_type ntype =3D rdma_gid_attr_network_type(attr); + struct mana_rnic_config_addr_resp resp =3D {}; + struct gdma_context *gc =3D mdev_to_gc(mdev); + struct mana_rnic_config_addr_req req =3D {}; + int err; + + if (!rnic_is_enabled(mdev)) + return -EINVAL; + + if (ntype !=3D RDMA_NETWORK_IPV4 && ntype !=3D RDMA_NETWORK_IPV6) { + ibdev_dbg(&mdev->ib_dev, "Unsupported rdma network type %d", ntype); + return -EINVAL; + } + + mana_gd_init_req_hdr(&req.hdr, MANA_IB_CONFIG_IP_ADDR, sizeof(req), sizeo= f(resp)); + req.hdr.dev_id =3D gc->mana_ib.dev_id; + req.adapter =3D mdev->adapter_handle; + req.op =3D ADDR_OP_REMOVE; + req.sgid_type =3D (ntype =3D=3D RDMA_NETWORK_IPV6) ? SGID_TYPE_IPV6 : SGI= D_TYPE_IPV4; + copy_in_reverse(req.ip_addr, attr->gid.raw, sizeof(union ib_gid)); + + err =3D mana_gd_send_request(gc, sizeof(req), &req, sizeof(resp), &resp); + if (err) { + ibdev_err(&mdev->ib_dev, "Failed to config IP addr err %d\n", err); + return err; + } + + return 0; +} diff --git a/drivers/infiniband/hw/mana/mana_ib.h b/drivers/infiniband/hw/m= ana/mana_ib.h index 196f3c8..2a3e3b0 100644 --- a/drivers/infiniband/hw/mana/mana_ib.h +++ b/drivers/infiniband/hw/mana/mana_ib.h @@ -118,6 +118,7 @@ enum mana_ib_command_code { MANA_IB_GET_ADAPTER_CAP =3D 0x30001, MANA_IB_CREATE_ADAPTER =3D 0x30002, MANA_IB_DESTROY_ADAPTER =3D 0x30003, + MANA_IB_CONFIG_IP_ADDR =3D 0x30004, }; =20 struct mana_ib_query_adapter_caps_req { @@ -167,6 +168,30 @@ struct mana_rnic_destroy_adapter_resp { struct gdma_resp_hdr hdr; }; /* HW Data */ =20 +enum mana_ib_addr_op { + ADDR_OP_ADD =3D 1, + ADDR_OP_REMOVE, +}; + +enum sgid_entry_type { + SGID_TYPE_INVALID =3D 0, + SGID_TYPE_IPV4 =3D 1, + SGID_TYPE_IPV6 =3D 2, + SGID_TYPE_HYBRID =3D 3 +}; + +struct mana_rnic_config_addr_req { + struct gdma_req_hdr hdr; + mana_handle_t adapter; + enum mana_ib_addr_op op; + enum sgid_entry_type sgid_type; + u8 ip_addr[16]; +}; /* HW Data */ + +struct mana_rnic_config_addr_resp { + struct gdma_resp_hdr hdr; +}; /* HW Data */ + static inline bool rnic_is_enabled(struct mana_ib_dev *mdev) { return mdev->adapter_handle !=3D INVALID_MANA_HANDLE; @@ -188,6 +213,14 @@ static inline struct net_device *mana_ib_get_netdev(st= ruct ib_device *ibdev, u32 return mc->ports[port - 1]; } =20 +static inline void copy_in_reverse(u8 *dst, const u8 *src, u32 size) +{ + u32 i; + + for (i =3D 0; i < size; i++) + dst[size - 1 - i] =3D src[i]; +} + int mana_ib_install_cq_cb(struct mana_ib_dev *mdev, struct mana_ib_cq *cq); =20 int mana_ib_gd_create_dma_region(struct mana_ib_dev *dev, struct ib_umem *= umem, @@ -266,4 +299,8 @@ int mana_ib_query_gid(struct ib_device *ibdev, u32 port= , int index, int mana_ib_query_pkey(struct ib_device *ibdev, u32 port, u16 index, u16 *= pkey); =20 enum rdma_link_layer mana_ib_get_link_layer(struct ib_device *device, u32 = port_num); + +int mana_ib_gd_add_gid(const struct ib_gid_attr *attr, void **context); + +int mana_ib_gd_del_gid(const struct ib_gid_attr *attr, void **context); #endif --=20 1.8.3.1