From nobody Tue Dec 16 16:35:59 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C661C4332F for ; Wed, 13 Dec 2023 10:01:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235201AbjLMKBu (ORCPT ); Wed, 13 Dec 2023 05:01:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232663AbjLMKBs (ORCPT ); Wed, 13 Dec 2023 05:01:48 -0500 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B1B3E83; Wed, 13 Dec 2023 02:01:54 -0800 (PST) Received: from linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net (linux.microsoft.com [13.77.154.182]) by linux.microsoft.com (Postfix) with ESMTPSA id D9FAC20B74C0; Wed, 13 Dec 2023 02:01:53 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D9FAC20B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1702461713; bh=W76rnqlsU93altV/2qDWt6+X+GwQAHiWQz5/saK9YpA=; h=From:To:Cc:Subject:Date:From; b=BEIll5Vo3uXoX3e04Vuj3HajXdbhmOkMB/PmrDnLfOK5t3VQbVawsSsp0xoJ//UvQ qtSxCc3FMfwaXE3qOD6NiJhmwsxq+E+kOIvulaCUV2qY509ZEGGQKsDMlUFdFcMW/V IPwH7SI3iR3BqrIJQuN4cexjtEGvKFGVbiyykiQE= From: Konstantin Taranov To: kotaranov@microsoft.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, kuba@kernel.org, leon@kernel.org, decui@microsoft.com, edumazet@google.com, cai.huoqing@linux.dev, pabeni@redhat.com, davem@davemloft.net, longli@microsoft.com Cc: linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: [PATCH for-next v2] net: mana: add msix index sharing between EQs Date: Wed, 13 Dec 2023 02:01:47 -0800 Message-Id: <1702461707-2692-1-git-send-email-kotaranov@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Konstantin Taranov This patch allows to assign and poll more than one EQ on the same msix index. It is achieved by introducing a list of attached EQs in each IRQ context. It also removes the existing msix_index map that tried to ensure that there is only one EQ at each msix_index. This patch exports symbols for creating EQs from other MANA kernel modules. Signed-off-by: Konstantin Taranov --- V1 -> V2: removed msix_index map and improved thread-safety of rcu lists --- .../net/ethernet/microsoft/mana/gdma_main.c | 76 +++++++++---------- .../net/ethernet/microsoft/mana/hw_channel.c | 1 + drivers/net/ethernet/microsoft/mana/mana_en.c | 1 + include/net/mana/gdma.h | 7 +- 4 files changed, 43 insertions(+), 42 deletions(-) diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c b/drivers/net/= ethernet/microsoft/mana/gdma_main.c index 6367de0..a686301 100644 --- a/drivers/net/ethernet/microsoft/mana/gdma_main.c +++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c @@ -414,8 +414,12 @@ static void mana_gd_process_eq_events(void *arg) =20 old_bits =3D (eq->head / num_eqe - 1) & GDMA_EQE_OWNER_MASK; /* No more entries */ - if (owner_bits =3D=3D old_bits) + if (owner_bits =3D=3D old_bits) { + /* return here without ringing the doorbell */ + if (i =3D=3D 0) + return; break; + } =20 new_bits =3D (eq->head / num_eqe) & GDMA_EQE_OWNER_MASK; if (owner_bits !=3D new_bits) { @@ -445,42 +449,29 @@ static int mana_gd_register_irq(struct gdma_queue *qu= eue, struct gdma_dev *gd =3D queue->gdma_dev; struct gdma_irq_context *gic; struct gdma_context *gc; - struct gdma_resource *r; unsigned int msi_index; unsigned long flags; struct device *dev; int err =3D 0; =20 gc =3D gd->gdma_context; - r =3D &gc->msix_resource; dev =3D gc->dev; + msi_index =3D spec->eq.msix_index; =20 - spin_lock_irqsave(&r->lock, flags); - - msi_index =3D find_first_zero_bit(r->map, r->size); - if (msi_index >=3D r->size || msi_index >=3D gc->num_msix_usable) { + if (msi_index >=3D gc->num_msix_usable) { err =3D -ENOSPC; - } else { - bitmap_set(r->map, msi_index, 1); - queue->eq.msix_index =3D msi_index; - } - - spin_unlock_irqrestore(&r->lock, flags); - - if (err) { - dev_err(dev, "Register IRQ err:%d, msi:%u rsize:%u, nMSI:%u", - err, msi_index, r->size, gc->num_msix_usable); + dev_err(dev, "Register IRQ err:%d, msi:%u nMSI:%u", + err, msi_index, gc->num_msix_usable); =20 return err; } =20 + queue->eq.msix_index =3D msi_index; gic =3D &gc->irq_contexts[msi_index]; =20 - WARN_ON(gic->handler || gic->arg); - - gic->arg =3D queue; - - gic->handler =3D mana_gd_process_eq_events; + spin_lock_irqsave(&gic->lock, flags); + list_add_rcu(&queue->entry, &gic->eq_list); + spin_unlock_irqrestore(&gic->lock, flags); =20 return 0; } @@ -490,12 +481,11 @@ static void mana_gd_deregiser_irq(struct gdma_queue *= queue) struct gdma_dev *gd =3D queue->gdma_dev; struct gdma_irq_context *gic; struct gdma_context *gc; - struct gdma_resource *r; unsigned int msix_index; unsigned long flags; + struct gdma_queue *eq; =20 gc =3D gd->gdma_context; - r =3D &gc->msix_resource; =20 /* At most num_online_cpus() + 1 interrupts are used. */ msix_index =3D queue->eq.msix_index; @@ -503,14 +493,17 @@ static void mana_gd_deregiser_irq(struct gdma_queue *= queue) return; =20 gic =3D &gc->irq_contexts[msix_index]; - gic->handler =3D NULL; - gic->arg =3D NULL; - - spin_lock_irqsave(&r->lock, flags); - bitmap_clear(r->map, msix_index, 1); - spin_unlock_irqrestore(&r->lock, flags); + spin_lock_irqsave(&gic->lock, flags); + list_for_each_entry_rcu(eq, &gic->eq_list, entry) { + if (queue =3D=3D eq) { + list_del_rcu(&eq->entry); + break; + } + } + spin_unlock_irqrestore(&gic->lock, flags); =20 queue->eq.msix_index =3D INVALID_PCI_MSIX_INDEX; + synchronize_rcu(); } =20 int mana_gd_test_eq(struct gdma_context *gc, struct gdma_queue *eq) @@ -588,6 +581,7 @@ static int mana_gd_create_eq(struct gdma_dev *gd, int err; =20 queue->eq.msix_index =3D INVALID_PCI_MSIX_INDEX; + queue->id =3D INVALID_QUEUE_ID; =20 log2_num_entries =3D ilog2(queue->queue_size / GDMA_EQE_SIZE); =20 @@ -819,6 +813,7 @@ free_q: kfree(queue); return err; } +EXPORT_SYMBOL_NS(mana_gd_create_mana_eq, NET_MANA); =20 int mana_gd_create_mana_wq_cq(struct gdma_dev *gd, const struct gdma_queue_spec *spec, @@ -895,6 +890,7 @@ void mana_gd_destroy_queue(struct gdma_context *gc, str= uct gdma_queue *queue) mana_gd_free_memory(gmi); kfree(queue); } +EXPORT_SYMBOL_NS(mana_gd_destroy_queue, NET_MANA); =20 int mana_gd_verify_vf_version(struct pci_dev *pdev) { @@ -1217,9 +1213,14 @@ int mana_gd_poll_cq(struct gdma_queue *cq, struct gd= ma_comp *comp, int num_cqe) static irqreturn_t mana_gd_intr(int irq, void *arg) { struct gdma_irq_context *gic =3D arg; + struct list_head *eq_list =3D &gic->eq_list; + struct gdma_queue *eq; =20 - if (gic->handler) - gic->handler(gic->arg); + rcu_read_lock(); + list_for_each_entry_rcu(eq, eq_list, entry) { + gic->handler(eq); + } + rcu_read_unlock(); =20 return IRQ_HANDLED; } @@ -1271,8 +1272,9 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev) =20 for (i =3D 0; i < nvec; i++) { gic =3D &gc->irq_contexts[i]; - gic->handler =3D NULL; - gic->arg =3D NULL; + gic->handler =3D mana_gd_process_eq_events; + INIT_LIST_HEAD(&gic->eq_list); + spin_lock_init(&gic->lock); =20 if (!i) snprintf(gic->name, MANA_IRQ_NAME_SZ, "mana_hwc@pci:%s", @@ -1295,10 +1297,6 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev) irq_set_affinity_and_hint(irq, cpumask_of(cpu)); } =20 - err =3D mana_gd_alloc_res_map(nvec, &gc->msix_resource); - if (err) - goto free_irq; - gc->max_num_msix =3D nvec; gc->num_msix_usable =3D nvec; =20 @@ -1329,8 +1327,6 @@ static void mana_gd_remove_irqs(struct pci_dev *pdev) if (gc->max_num_msix < 1) return; =20 - mana_gd_free_res_map(&gc->msix_resource); - for (i =3D 0; i < gc->max_num_msix; i++) { irq =3D pci_irq_vector(pdev, i); if (irq < 0) diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net= /ethernet/microsoft/mana/hw_channel.c index 9d1cd3b..2729a2c 100644 --- a/drivers/net/ethernet/microsoft/mana/hw_channel.c +++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c @@ -300,6 +300,7 @@ static int mana_hwc_create_gdma_eq(struct hw_channel_co= ntext *hwc, spec.eq.context =3D ctx; spec.eq.callback =3D cb; spec.eq.log2_throttle_limit =3D DEFAULT_LOG2_THROTTLING_FOR_ERROR_EQ; + spec.eq.msix_index =3D 0; =20 return mana_gd_create_hwc_queue(hwc->gdma_dev, &spec, queue); } diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/et= hernet/microsoft/mana/mana_en.c index fc3d290..2c04bdb 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -1244,6 +1244,7 @@ static int mana_create_eq(struct mana_context *ac) spec.eq.log2_throttle_limit =3D LOG2_EQ_THROTTLE; =20 for (i =3D 0; i < gc->max_num_queues; i++) { + spec.eq.msix_index =3D (i + 1) % gc->num_msix_usable; err =3D mana_gd_create_mana_eq(gd, &spec, &ac->eqs[i].eq); if (err) goto out; diff --git a/include/net/mana/gdma.h b/include/net/mana/gdma.h index 88b6ef7..76f2fd2 100644 --- a/include/net/mana/gdma.h +++ b/include/net/mana/gdma.h @@ -293,6 +293,7 @@ struct gdma_queue { =20 u32 head; u32 tail; + struct list_head entry; =20 /* Extra fields specific to EQ/CQ. */ union { @@ -328,6 +329,7 @@ struct gdma_queue_spec { void *context; =20 unsigned long log2_throttle_limit; + unsigned int msix_index; } eq; =20 struct { @@ -344,7 +346,9 @@ struct gdma_queue_spec { =20 struct gdma_irq_context { void (*handler)(void *arg); - void *arg; + /* Protect the eq_list */ + spinlock_t lock; + struct list_head eq_list; char name[MANA_IRQ_NAME_SZ]; }; =20 @@ -355,7 +359,6 @@ struct gdma_context { unsigned int max_num_queues; unsigned int max_num_msix; unsigned int num_msix_usable; - struct gdma_resource msix_resource; struct gdma_irq_context *irq_contexts; =20 /* L2 MTU */ --=20 2.43.0