From nobody Tue Dec 16 19:56:59 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60CB3C00A8F for ; Tue, 24 Oct 2023 13:22:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234570AbjJXNW3 (ORCPT ); Tue, 24 Oct 2023 09:22:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234617AbjJXNVV (ORCPT ); Tue, 24 Oct 2023 09:21:21 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E6D91712; Tue, 24 Oct 2023 06:21:00 -0700 (PDT) Date: Tue, 24 Oct 2023 13:20:58 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1698153658; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8ZW+x5+R2o7rfC0WHEPGCf9ASLJX1ELsdyA6Y8UQPp4=; b=NT7nCNSb2e42nHRxlw0MB2fqjH1ef8As0BvAtweFTSLeoOo2ZaMLO7wkyS30lqIWvtMm93 JtbDhrfMM1N3DpMyYywRLi9gkSUUMI9ch/9vvzzGa/BecuX1oMjYwP9ziKI696NR8SpqJd Zo3WdJI+m0OVvm41Yh6KkaicN+3A/1l69TDKI1AteHX7QDOma8Zz9D5lp4kiqy5zHKZXmJ CxabS7/LhAiGxqBA7xE6kGnKtoruUAyjJ+fbSd7ZfG3Tcn9tk78uu82NEm38w8EmA6fyHM j3InhnXDkl6ekqyfEw18eFBJX2ppjtAiiM73QTuNlmtjneUmNeC/+JgZL3Yj7A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1698153658; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8ZW+x5+R2o7rfC0WHEPGCf9ASLJX1ELsdyA6Y8UQPp4=; b=fqbwbdQCb8PFGZ99yx/8tMLb0tqneOaJ6LuszNz+2IhQhpiRxRGD0HKYj0NGa4t4l8BfJ2 kRsvMY3/EkGaVZDQ== From: "tip-bot2 for Thomas Gleixner" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/microcode] x86/microcode: Clean up mc_cpu_down_prep() Cc: Thomas Gleixner , "Borislav Petkov (AMD)" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20231002115903.028651784@linutronix.de> References: <20231002115903.028651784@linutronix.de> MIME-Version: 1.0 Message-ID: <169815365810.3135.10571621932502453882.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the x86/microcode branch of tip: Commit-ID: ba48aa32388ac652256baa8d0a6092d350160da0 Gitweb: https://git.kernel.org/tip/ba48aa32388ac652256baa8d0a6092d35= 0160da0 Author: Thomas Gleixner AuthorDate: Mon, 02 Oct 2023 13:59:55 +02:00 Committer: Borislav Petkov (AMD) CommitterDate: Tue, 24 Oct 2023 15:05:54 +02:00 x86/microcode: Clean up mc_cpu_down_prep() This function has nothing to do with suspend. It's a hotplug callback. Remove the bogus comment. Drop the pointless debug printk. The hotplug core provides tracepoints which track the invocation of those callbacks. Signed-off-by: Thomas Gleixner Signed-off-by: Borislav Petkov (AMD) Link: https://lore.kernel.org/r/20231002115903.028651784@linutronix.de --- arch/x86/kernel/cpu/microcode/core.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/mic= rocode/core.c index 0ed96d2..e306fee 100644 --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -498,16 +498,10 @@ static int mc_cpu_online(unsigned int cpu) =20 static int mc_cpu_down_prep(unsigned int cpu) { - struct device *dev; - - dev =3D get_cpu_device(cpu); + struct device *dev =3D get_cpu_device(cpu); =20 microcode_fini_cpu(cpu); - - /* Suspend is in progress, only remove the interface */ sysfs_remove_group(&dev->kobj, &mc_attr_group); - pr_debug("%s: CPU%d\n", __func__, cpu); - return 0; }