From nobody Thu Dec 18 04:29:44 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2647CDB47E for ; Fri, 20 Oct 2023 11:39:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377467AbjJTLjw (ORCPT ); Fri, 20 Oct 2023 07:39:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377456AbjJTLjA (ORCPT ); Fri, 20 Oct 2023 07:39:00 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EFC92108; Fri, 20 Oct 2023 04:38:10 -0700 (PDT) Date: Fri, 20 Oct 2023 11:37:52 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1697801873; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oWLNPxAL6RB4jWe7j4BW9JKrK+K+JTutnur4CH8rKmM=; b=Gvj2cJ/1KNv8N6SZFVfv1jZQLYcrITN+MS5g9AxvrQfEc+hNd9cjFZs6lmZQYmtZ5iGp8W Vu88PQBMhw1LBGt/0458z/FuYTL2+hvvEksp3I1VikmK56Q11o9sQJSWsaMLASOzCzpaOu 2i4+8TLPpzQk/UeGS9RXtePA6uys880YbPu+iVe+EENyX7geGtHlY/r+Axc55/jshXsHf4 5vdmx6BU8zNvl2UY54AnHE1NSGLIS72BRiMVBsyg8q1jME6WXAES68253xC2TDR093qYny U92GxBwYgD0XX/VT5squ5vOUwsoNyKCDKD3NMiZBdnuHmP2fMAbKwapp5taZKg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1697801873; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oWLNPxAL6RB4jWe7j4BW9JKrK+K+JTutnur4CH8rKmM=; b=puXd1RnAYzg/PpcdGJbfHWwIQMMeCz/9sj3LfC7sW6mWBjuwJayiQejKFnmfW+IjRem3Xm KAnUhWfpaHFfvmDg== From: "tip-bot2 for Thomas Gleixner" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/microcode] x86/microcode: Clean up mc_cpu_down_prep() Cc: Thomas Gleixner , "Borislav Petkov (AMD)" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20231002115903.028651784@linutronix.de> References: <20231002115903.028651784@linutronix.de> MIME-Version: 1.0 Message-ID: <169780187253.3135.16969663955261216142.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the x86/microcode branch of tip: Commit-ID: d91172afa89d1bb7ada97625d761bcdefdd4f9f6 Gitweb: https://git.kernel.org/tip/d91172afa89d1bb7ada97625d761bcdef= dd4f9f6 Author: Thomas Gleixner AuthorDate: Mon, 02 Oct 2023 13:59:55 +02:00 Committer: Borislav Petkov (AMD) CommitterDate: Thu, 19 Oct 2023 15:53:58 +02:00 x86/microcode: Clean up mc_cpu_down_prep() This function has nothing to do with suspend. It's a hotplug callback. Remove the bogus comment. Drop the pointless debug printk. The hotplug core provides tracepoints which track the invocation of those callbacks. Signed-off-by: Thomas Gleixner Signed-off-by: Borislav Petkov (AMD) Link: https://lore.kernel.org/r/20231002115903.028651784@linutronix.de --- arch/x86/kernel/cpu/microcode/core.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/mic= rocode/core.c index 0ed96d2..e306fee 100644 --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -498,16 +498,10 @@ static int mc_cpu_online(unsigned int cpu) =20 static int mc_cpu_down_prep(unsigned int cpu) { - struct device *dev; - - dev =3D get_cpu_device(cpu); + struct device *dev =3D get_cpu_device(cpu); =20 microcode_fini_cpu(cpu); - - /* Suspend is in progress, only remove the interface */ sysfs_remove_group(&dev->kobj, &mc_attr_group); - pr_debug("%s: CPU%d\n", __func__, cpu); - return 0; }