From nobody Fri Jan 2 18:51:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB6DBE95A8E for ; Mon, 9 Oct 2023 12:30:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376398AbjJIMaV (ORCPT ); Mon, 9 Oct 2023 08:30:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346551AbjJIM3y (ORCPT ); Mon, 9 Oct 2023 08:29:54 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63CBFD6; Mon, 9 Oct 2023 05:29:51 -0700 (PDT) Date: Mon, 09 Oct 2023 12:29:49 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1696854590; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BIFOTLwgFf0FxaK/QbeXOF0TQu5Vo6hgzhc06FG0EXE=; b=dRAm4q2jAhIh2eJ1YJ5K3w8NyKY/CwZeZPup/FYR80gEnDTZn6T2jgxvpsYQMc7Tq4R3TY YRajbahj7W7pgbITocwBfm9DHRsKmgMueViQJxVKwqKdI+ZdKYAZ0PUF7bFMLfhUEmezEr efu/S9YqPddd8dU9/gjoEPYTo9u5FLJFFJORP6zLQrkCDJfND65weaC5LWrgQ8PWqkOJ/W aernaYbBgvadSMPi1Yzs8pwEE5mZH4LqO2nsDm8ueGscXI7jPofIZocT2sbTM1pWyqqn3C PpEie0VJIAtSg5ltJc9Oano0cpEws00NUSwgWarl5PGe2hoMK3TqUwoXHzoh4g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1696854590; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BIFOTLwgFf0FxaK/QbeXOF0TQu5Vo6hgzhc06FG0EXE=; b=PGBmfs4Bv0Q74K6SCeZCXPIMe01KzoXWpWAd0hTBiMDKMB+6vnAQAxhBS2G5L4elHSmCZF natTIiW2JT8KiHCQ== From: "tip-bot2 for Thomas Gleixner" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/microcode] x86/microcode: Clean up mc_cpu_down_prep() Cc: Thomas Gleixner , "Borislav Petkov (AMD)" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20231002115903.028651784@linutronix.de> References: <20231002115903.028651784@linutronix.de> MIME-Version: 1.0 Message-ID: <169685458938.3135.206662791860103089.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the x86/microcode branch of tip: Commit-ID: 75d0be07daa201cd283e00d09eb27b30c0b0261e Gitweb: https://git.kernel.org/tip/75d0be07daa201cd283e00d09eb27b30c= 0b0261e Author: Thomas Gleixner AuthorDate: Mon, 02 Oct 2023 13:59:55 +02:00 Committer: Borislav Petkov (AMD) CommitterDate: Fri, 06 Oct 2023 15:12:23 +02:00 x86/microcode: Clean up mc_cpu_down_prep() This function has nothing to do with suspend. It's a hotplug callback. Remove the bogus comment. Drop the pointless debug printk. The hotplug core provides tracepoints which track the invocation of those callbacks. Signed-off-by: Thomas Gleixner Signed-off-by: Borislav Petkov (AMD) Link: https://lore.kernel.org/r/20231002115903.028651784@linutronix.de --- arch/x86/kernel/cpu/microcode/core.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/mic= rocode/core.c index 17b7578..0038126 100644 --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -536,16 +536,10 @@ static int mc_cpu_online(unsigned int cpu) =20 static int mc_cpu_down_prep(unsigned int cpu) { - struct device *dev; - - dev =3D get_cpu_device(cpu); + struct device *dev =3D get_cpu_device(cpu); =20 microcode_fini_cpu(cpu); - - /* Suspend is in progress, only remove the interface */ sysfs_remove_group(&dev->kobj, &mc_attr_group); - pr_debug("%s: CPU%d\n", __func__, cpu); - return 0; }