From nobody Thu Feb 12 06:28:52 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86440EE6457 for ; Fri, 15 Sep 2023 12:06:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234625AbjIOMGJ (ORCPT ); Fri, 15 Sep 2023 08:06:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234613AbjIOMGF (ORCPT ); Fri, 15 Sep 2023 08:06:05 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17F143584; Fri, 15 Sep 2023 05:03:30 -0700 (PDT) Date: Fri, 15 Sep 2023 12:03:29 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1694779409; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tBk01TZqJa0xUvb64FfLoh9y4GLN054lkdXjN7A7La8=; b=EsaiYeOw9T+ygEcGJlO8QQ8dsaBQfcqHNHFB3Cn+etpQ/UJ5l/e48LNvGwv+BQHC4F71SL iy7Yoo1PNrjEhYVjvERHW1/GHJIxwPntFtdHdPvZkKQrU7TQ+80w7POl+3DYg/jszoiLSc vEWVcnNKuj0s2bUWdc25YrcGKy6c2ORTiJ2bPbAAiYyby8w4i5noLrvvsmKHRpsgBy+foc WpOmoHFxsIVJ0n2baVyKvDozJIBaN5e1EqA49++wIxrFX0o+da2OVMgDvXE98G58p7l3nb qF3wSUjDtby0OlJsmgA6887byiKNnC1TafGXUvzCs0AsxB9Tr/frJ1woVK9f2A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1694779409; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tBk01TZqJa0xUvb64FfLoh9y4GLN054lkdXjN7A7La8=; b=FmXegposMGlqeGZhwhfMgaDBYdRN9Mx1sWsk5hc86W+OZcE1q9kE0usBLy/FmOnGNK9ulz T7nJTK1oZkeUIzDA== From: "tip-bot2 for Yury Norov" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: sched/core] sched/fair: Fix open-coded numa_nearest_node() Cc: Yury Norov , Ingo Molnar , Mel Gorman , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230819141239.287290-3-yury.norov@gmail.com> References: <20230819141239.287290-3-yury.norov@gmail.com> MIME-Version: 1.0 Message-ID: <169477940902.27769.3566376802843412168.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the sched/core branch of tip: Commit-ID: d1db9fb432d50b0eecdfdd85d17cc15a59cc093b Gitweb: https://git.kernel.org/tip/d1db9fb432d50b0eecdfdd85d17cc15a5= 9cc093b Author: Yury Norov AuthorDate: Sat, 19 Aug 2023 07:12:34 -07:00 Committer: Ingo Molnar CommitterDate: Fri, 15 Sep 2023 13:48:10 +02:00 sched/fair: Fix open-coded numa_nearest_node() task_numa_placement() searches for a nearest node to migrate by calling for_each_node_state(). Now that we have numa_nearest_node(), switch to using it. Signed-off-by: Yury Norov Signed-off-by: Ingo Molnar Cc: Mel Gorman Link: https://lore.kernel.org/r/20230819141239.287290-3-yury.norov@gmail.com --- kernel/sched/fair.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 8dbff6e..41cfd61 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2847,19 +2847,7 @@ static void task_numa_placement(struct task_struct *= p) } =20 /* Cannot migrate task to CPU-less node */ - if (max_nid !=3D NUMA_NO_NODE && !node_state(max_nid, N_CPU)) { - int near_nid =3D max_nid; - int distance, near_distance =3D INT_MAX; - - for_each_node_state(nid, N_CPU) { - distance =3D node_distance(max_nid, nid); - if (distance < near_distance) { - near_nid =3D nid; - near_distance =3D distance; - } - } - max_nid =3D near_nid; - } + max_nid =3D numa_nearest_node(max_nid, N_CPU); =20 if (ng) { numa_group_count_active_nodes(ng);