From nobody Fri Sep 12 03:14:24 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92EA7C04A94 for ; Wed, 9 Aug 2023 16:49:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231439AbjHIQt4 (ORCPT ); Wed, 9 Aug 2023 12:49:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231304AbjHIQtf (ORCPT ); Wed, 9 Aug 2023 12:49:35 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D31841BFE; Wed, 9 Aug 2023 09:49:34 -0700 (PDT) Date: Wed, 09 Aug 2023 16:49:33 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1691599773; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zH38xtHL9HqIzLBGvvTBhROYV0QZSJpOfbkOR0Lj/7w=; b=Tz9QrgDEHDorugHj8mio5yFNF9GQdvZliXTTnRo1SEMgoKYzgwdu2tD0sGXa7WidPdLUwg eRkM/3S8dzj/er8JEDZIsDU9JZX/69RoJayc01OHJsRBtSFpFzXdmwJQkEWVuvBguWCZaf a1d8ioCQvXjBrxKEhCvkqdT7Qiqs2eaivmS7zln3ULnVtj2Q1QV9fYOaxsmC4eIwpj1Jya jToh75r9JZtHbZI/+WoovIZSqmg9JoUYhFy/1vXwnxLP4XiLYWHCaECOMvSqNJ04VxCwHc gN7E0rfXp+eMfSaBxUgkBv4bI0lJQgbrtudwfVmnc+XsHruFzF40gWY5K/6f3A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1691599773; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zH38xtHL9HqIzLBGvvTBhROYV0QZSJpOfbkOR0Lj/7w=; b=L2+qmcdwXZ6165XeHZ52prG4+lvCnk05vLLBHWuBp1VhSPz1HH2ZRX4BtceDZaFGdB4i1k T414Fi9n+ZiprICQ== From: "tip-bot2 for Thomas Gleixner" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/apic] x86/ioapic/32: Decrapify phys_id_present_map operation Cc: Thomas Gleixner , Dave Hansen , "Peter Zijlstra (Intel)" , x86@kernel.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Message-ID: <169159977304.27769.12345903887373451399.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the x86/apic branch of tip: Commit-ID: 6026bdba949934b45b7e3ae2babbb7c58d4daeca Gitweb: https://git.kernel.org/tip/6026bdba949934b45b7e3ae2babbb7c58= d4daeca Author: Thomas Gleixner AuthorDate: Tue, 08 Aug 2023 15:03:59 -07:00 Committer: Dave Hansen CommitterDate: Wed, 09 Aug 2023 08:10:12 -07:00 x86/ioapic/32: Decrapify phys_id_present_map operation The operation to set the IOAPIC ID in phys_id_present_map is as convoluted as it can be. 1) Allocate a bitmap of 32byte size on the stack 2) Zero the bitmap and set the IOAPIC ID bit 3) Or the temporary bitmap over phys_id_present_map The same functionality can be achieved by setting the IOAPIC ID bit directly in the phys_id_present_map. Signed-off-by: Thomas Gleixner Signed-off-by: Dave Hansen Acked-by: Peter Zijlstra (Intel) --- arch/x86/kernel/apic/io_apic.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index 8c47099..ff2d27e 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -1511,12 +1511,9 @@ void __init setup_ioapic_ids_from_mpc_nocheck(void) physid_set(i, phys_id_present_map); ioapics[ioapic_idx].mp_config.apicid =3D i; } else { - physid_mask_t tmp; - - physid_set_mask_of_physid(mpc_ioapic_id(ioapic_idx), &tmp); apic_printk(APIC_VERBOSE, "Setting %d in the phys_id_present_map\n", mpc_ioapic_id(ioapic_idx)); - physids_or(phys_id_present_map, phys_id_present_map, tmp); + physid_set(mpc_ioapic_id(ioapic_idx), phys_id_present_map); } =20 /*