From nobody Sun Feb 8 13:39:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82289C001DE for ; Fri, 28 Jul 2023 08:24:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234878AbjG1IXg (ORCPT ); Fri, 28 Jul 2023 04:23:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234938AbjG1IW3 (ORCPT ); Fri, 28 Jul 2023 04:22:29 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3C2030E0; Fri, 28 Jul 2023 01:21:23 -0700 (PDT) Date: Fri, 28 Jul 2023 08:21:21 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690532482; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vbdquQpgk4n9HAlhi8cxuSh9d1y+3JXXGaBXsoEW6M8=; b=Trr2qBEvMeNW9Z5IQJBYeFH15nBJOfRtkqFYsdxe2VAXvo1rjO34EbQjEen8wtL99T/S/4 2R34RAoEu64Y3zvaSumjoXEnb42qaGsKCvWcUwfg8YuH3r2t8FVRChY2XB3bIfUwPe5wZC 6dt2+ZsgfSuSV3lOJB46vQOX1iPBh0Sf2B0d006q3lai25ciG93GuLNgVYBLdCgJgBA3GI TieCzbWe/uuc23h9sNOJ4eNJIE7MgpZO4vbM71kr3x3owv0rHzGjQRNttGiPOXlQBWFpZe N/EbtLiWFaetLMuNNGwojQI5eM6t4hlEg+GM7V37XGUjakzFbXRvKeqmEmQeUQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690532482; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vbdquQpgk4n9HAlhi8cxuSh9d1y+3JXXGaBXsoEW6M8=; b=Y3iS/tHZFLUGSj6hh4K5M0cD6iIhULH3haEVQ5j/p9oN8agKAh2cOX/8arOHVXU+JMUM0P nvOG3hWE+f6nN3Bw== From: "tip-bot2 for Sohil Mehta" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/core] x86/smpboot: Remove a stray comment about CPU hotplug Cc: Sohil Mehta , Thomas Gleixner , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230727180533.3119660-2-sohil.mehta@intel.com> References: <20230727180533.3119660-2-sohil.mehta@intel.com> MIME-Version: 1.0 Message-ID: <169053248168.28540.18322875262543490504.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the x86/core branch of tip: Commit-ID: 52defa4a5e719a57992aed52c8d3e214e75ac276 Gitweb: https://git.kernel.org/tip/52defa4a5e719a57992aed52c8d3e214e= 75ac276 Author: Sohil Mehta AuthorDate: Thu, 27 Jul 2023 18:05:31=20 Committer: Thomas Gleixner CommitterDate: Fri, 28 Jul 2023 10:17:53 +02:00 x86/smpboot: Remove a stray comment about CPU hotplug This old comment is irrelavant to the logic of disabling interrupts and could be misleading. Remove it. Now, hlt_play_dead() resembles the code that the comment was initially added for, but, it doesn't make sense anymore because an offlined cpu could also be put into other states such as mwait. Signed-off-by: Sohil Mehta Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/r/20230727180533.3119660-2-sohil.mehta@intel.= com --- arch/x86/kernel/smpboot.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index e1aa2cd..6a09a02 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1614,9 +1614,7 @@ void play_dead_common(void) idle_task_exit(); =20 cpuhp_ap_report_dead(); - /* - * With physical CPU hotplug, we should halt the cpu - */ + local_irq_disable(); }