From nobody Tue Sep 9 17:49:10 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AB8EC001DC for ; Wed, 26 Jul 2023 20:08:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231679AbjGZUIj (ORCPT ); Wed, 26 Jul 2023 16:08:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231247AbjGZUIb (ORCPT ); Wed, 26 Jul 2023 16:08:31 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BFED12707; Wed, 26 Jul 2023 13:08:29 -0700 (PDT) Received: by linux.microsoft.com (Postfix, from userid 1174) id 560F82383126; Wed, 26 Jul 2023 13:08:29 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 560F82383126 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxonhyperv.com; s=default; t=1690402109; bh=JEIhw/jaTya18OX189IFQdQJH+n9QTgW7FoEIyakSrw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IzPINmxZxbi4LqskiAoPawlZDRF9ZVIjChONAgLDBIGQHeyqZ08CtR3YUjvDQUdyx sNyRjQhsn4ZrPic4n73xyIAa2hL30RMqot81bQ4RbUMz9pAXV3a9ab6sW6lsjorUW0 wzAdHLS9h1Jr95qoOKLSP98+xrJJaWi+OYepc4ws= From: sharmaajay@linuxonhyperv.com To: Jason Gunthorpe , Leon Romanovsky , Dexuan Cui , Wei Liu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-rdma@vger.kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ajay Sharma Subject: [Patch v3 4/4] RDMA/mana_ib : Query adapter capabilities Date: Wed, 26 Jul 2023 13:08:24 -0700 Message-Id: <1690402104-29518-5-git-send-email-sharmaajay@linuxonhyperv.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1690402104-29518-1-git-send-email-sharmaajay@linuxonhyperv.com> References: <1690402104-29518-1-git-send-email-sharmaajay@linuxonhyperv.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Ajay Sharma Query the adapter capabilities to expose to other clients and VF. This checks against the user supplied values and protects against overflows. Signed-off-by: Ajay Sharma --- drivers/infiniband/hw/mana/device.c | 4 ++ drivers/infiniband/hw/mana/main.c | 66 +++++++++++++++++++++++++--- drivers/infiniband/hw/mana/mana_ib.h | 53 +++++++++++++++++++++- 3 files changed, 115 insertions(+), 8 deletions(-) diff --git a/drivers/infiniband/hw/mana/device.c b/drivers/infiniband/hw/ma= na/device.c index 4077e440657a..e15da43c73a0 100644 --- a/drivers/infiniband/hw/mana/device.c +++ b/drivers/infiniband/hw/mana/device.c @@ -97,6 +97,10 @@ static int mana_ib_probe(struct auxiliary_device *adev, goto free_error_eq; } =20 + ret =3D mana_ib_query_adapter_caps(mib_dev); + if (ret) + ibdev_dbg(&mib_dev->ib_dev, "Failed to get caps, use defaults"); + ret =3D ib_register_device(&mib_dev->ib_dev, "mana_%d", mdev->gdma_context->dev); if (ret) diff --git a/drivers/infiniband/hw/mana/main.c b/drivers/infiniband/hw/mana= /main.c index 1b1a8670d0fa..512815e1e64d 100644 --- a/drivers/infiniband/hw/mana/main.c +++ b/drivers/infiniband/hw/mana/main.c @@ -469,21 +469,27 @@ int mana_ib_get_port_immutable(struct ib_device *ibde= v, u32 port_num, int mana_ib_query_device(struct ib_device *ibdev, struct ib_device_attr *p= rops, struct ib_udata *uhw) { + struct mana_ib_dev *mib_dev =3D container_of(ibdev, + struct mana_ib_dev, ib_dev); + props->max_qp =3D MANA_MAX_NUM_QUEUES; props->max_qp_wr =3D MAX_SEND_BUFFERS_PER_QUEUE; - - /* - * max_cqe could be potentially much bigger. - * As this version of driver only support RAW QP, set it to the same - * value as max_qp_wr - */ props->max_cqe =3D MAX_SEND_BUFFERS_PER_QUEUE; - props->max_mr_size =3D MANA_IB_MAX_MR_SIZE; props->max_mr =3D MANA_IB_MAX_MR; props->max_send_sge =3D MAX_TX_WQE_SGL_ENTRIES; props->max_recv_sge =3D MAX_RX_WQE_SGL_ENTRIES; =20 + /* If the Management SW is updated and supports adapter creation */ + if (mib_dev->adapter_handle) { + props->max_qp =3D mib_dev->adapter_caps.max_qp_count; + props->max_qp_wr =3D mib_dev->adapter_caps.max_requester_sq_size; + props->max_cqe =3D mib_dev->adapter_caps.max_requester_sq_size; + props->max_mr =3D mib_dev->adapter_caps.max_mr_count; + props->max_send_sge =3D mib_dev->adapter_caps.max_send_wqe_size; + props->max_recv_sge =3D mib_dev->adapter_caps.max_recv_wqe_size; + } + return 0; } =20 @@ -599,3 +605,49 @@ int mana_ib_create_error_eq(struct mana_ib_dev *mib_de= v) =20 return 0; } + +static void assign_caps(struct mana_ib_adapter_caps *caps, + struct mana_ib_query_adapter_caps_resp *resp) +{ + caps->max_sq_id =3D resp->max_sq_id; + caps->max_rq_id =3D resp->max_rq_id; + caps->max_cq_id =3D resp->max_cq_id; + caps->max_qp_count =3D resp->max_qp_count; + caps->max_cq_count =3D resp->max_cq_count; + caps->max_mr_count =3D resp->max_mr_count; + caps->max_pd_count =3D resp->max_pd_count; + caps->max_inbound_read_limit =3D resp->max_inbound_read_limit; + caps->max_outbound_read_limit =3D resp->max_outbound_read_limit; + caps->mw_count =3D resp->mw_count; + caps->max_srq_count =3D resp->max_srq_count; + caps->max_requester_sq_size =3D resp->max_requester_sq_size; + caps->max_responder_sq_size =3D resp->max_responder_sq_size; + caps->max_requester_rq_size =3D resp->max_requester_rq_size; + caps->max_responder_rq_size =3D resp->max_responder_rq_size; + caps->max_send_wqe_size =3D resp->max_send_wqe_size; + caps->max_recv_wqe_size =3D resp->max_recv_wqe_size; + caps->max_inline_data_size =3D resp->max_inline_data_size; +} + +int mana_ib_query_adapter_caps(struct mana_ib_dev *mib_dev) +{ + struct mana_ib_query_adapter_caps_resp resp =3D {}; + struct mana_ib_query_adapter_caps_req req =3D {}; + int err; + + mana_gd_init_req_hdr(&req.hdr, MANA_IB_GET_ADAPTER_CAP, sizeof(req), + sizeof(resp)); + req.hdr.resp.msg_version =3D MANA_IB__GET_ADAPTER_CAP_RESPONSE_V3; + req.hdr.dev_id =3D mib_dev->gc->mana_ib.dev_id; + + err =3D mana_gd_send_request(mib_dev->gc, sizeof(req), &req, + sizeof(resp), &resp); + + if (err) { + ibdev_err(&mib_dev->ib_dev, "Failed to query adapter caps err %d", err); + return err; + } + + assign_caps(&mib_dev->adapter_caps, &resp); + return 0; +} diff --git a/drivers/infiniband/hw/mana/mana_ib.h b/drivers/infiniband/hw/m= ana/mana_ib.h index 8a652bccd978..1044358230d3 100644 --- a/drivers/infiniband/hw/mana/mana_ib.h +++ b/drivers/infiniband/hw/mana/mana_ib.h @@ -20,19 +20,41 @@ =20 /* MANA doesn't have any limit for MR size */ #define MANA_IB_MAX_MR_SIZE U64_MAX - +#define MANA_IB__GET_ADAPTER_CAP_RESPONSE_V3 3 /* * The hardware limit of number of MRs is greater than maximum number of M= Rs * that can possibly represent in 24 bits */ #define MANA_IB_MAX_MR 0xFFFFFFu =20 +struct mana_ib_adapter_caps { + u32 max_sq_id; + u32 max_rq_id; + u32 max_cq_id; + u32 max_qp_count; + u32 max_cq_count; + u32 max_mr_count; + u32 max_pd_count; + u32 max_inbound_read_limit; + u32 max_outbound_read_limit; + u32 mw_count; + u32 max_srq_count; + u32 max_requester_sq_size; + u32 max_responder_sq_size; + u32 max_requester_rq_size; + u32 max_responder_rq_size; + u32 max_send_wqe_size; + u32 max_recv_wqe_size; + u32 max_inline_data_size; +}; + struct mana_ib_dev { struct ib_device ib_dev; struct gdma_dev *gdma_dev; struct gdma_context *gc; struct gdma_queue *fatal_err_eq; mana_handle_t adapter_handle; + struct mana_ib_adapter_caps adapter_caps; }; =20 struct mana_ib_wq { @@ -96,6 +118,7 @@ struct mana_ib_rwq_ind_table { }; =20 enum mana_ib_command_code { + MANA_IB_GET_ADAPTER_CAP =3D 0x30001, MANA_IB_CREATE_ADAPTER =3D 0x30002, MANA_IB_DESTROY_ADAPTER =3D 0x30003, }; @@ -120,6 +143,32 @@ struct mana_ib_destroy_adapter_resp { struct gdma_resp_hdr hdr; }; /* HW Data */ =20 +struct mana_ib_query_adapter_caps_req { + struct gdma_req_hdr hdr; +}; /*HW Data */ + +struct mana_ib_query_adapter_caps_resp { + struct gdma_resp_hdr hdr; + u32 max_sq_id; + u32 max_rq_id; + u32 max_cq_id; + u32 max_qp_count; + u32 max_cq_count; + u32 max_mr_count; + u32 max_pd_count; + u32 max_inbound_read_limit; + u32 max_outbound_read_limit; + u32 mw_count; + u32 max_srq_count; + u32 max_requester_sq_size; + u32 max_responder_sq_size; + u32 max_requester_rq_size; + u32 max_responder_rq_size; + u32 max_send_wqe_size; + u32 max_recv_wqe_size; + u32 max_inline_data_size; +}; /* HW Data */ + int mana_ib_gd_create_dma_region(struct mana_ib_dev *mib_dev, struct ib_umem *umem, mana_handle_t *gdma_region); @@ -194,4 +243,6 @@ int mana_ib_create_adapter(struct mana_ib_dev *mib_dev); =20 int mana_ib_destroy_adapter(struct mana_ib_dev *mib_dev); =20 +int mana_ib_query_adapter_caps(struct mana_ib_dev *mib_dev); + #endif --=20 2.25.1