From nobody Sun Feb 8 04:23:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BCEBC77B7A for ; Sat, 10 Jun 2023 12:45:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234557AbjFJMpf (ORCPT ); Sat, 10 Jun 2023 08:45:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229746AbjFJMpc (ORCPT ); Sat, 10 Jun 2023 08:45:32 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5586A35A9; Sat, 10 Jun 2023 05:45:31 -0700 (PDT) Date: Sat, 10 Jun 2023 12:45:29 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1686401130; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XboSUGbdr0u3XL6PVEwK6uua1P2wr0tGpGmjuZRtSzw=; b=APOAJCIxP8No2Xm40yAMANDmIkGb+N0E6CwzRD/CwFOIoSwCIiER0WmQEmz/VprFjX/RuC lWygmV+LVQFev1sq/iVZ9y8naG/+VCG2Q0zBiHvjO7KS97RZ2ssgFYUVF2Q7ymXwiDOwvN AFAnWlsVFqfLBmdDDTg5cTkpwlXr2Z5dEeae6jN5tG6UsfbyMQdjlyKMvXs0p23s9amt6b BO8uwWoABvDoHFIcpdxb28a9GCkjFYD5RSTk+YbU9FF0kb8LKJmxPF+UdnHhl7sEyFB8wI VoCvaUVAGyL5t8Su/h8jIwpUIws48H2vhaIUBsSPH2FlvWuI0VS/UFIXiiKVJQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1686401130; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XboSUGbdr0u3XL6PVEwK6uua1P2wr0tGpGmjuZRtSzw=; b=D7ax3R2ue6vSHytfgqvV66ngUofx/6Z2TXV5wJqdXIdZRidkN/z2RHtCrWSUFu6LSMUgio ydh8gC89sru3RrAg== From: "tip-bot2 for Wen Yang" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/core] tick/rcu: Fix bogus ratelimit condition Cc: Wen Yang , Thomas Gleixner , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: References: MIME-Version: 1.0 Message-ID: <168640112909.404.8400459838695123810.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the timers/core branch of tip: Commit-ID: 5579a8a8f15bd08b731a015630daca6ccd0f8a14 Gitweb: https://git.kernel.org/tip/5579a8a8f15bd08b731a015630daca6cc= d0f8a14 Author: Wen Yang AuthorDate: Fri, 05 May 2023 00:12:53 +08:00 Committer: Thomas Gleixner CommitterDate: Sat, 10 Jun 2023 14:36:17 +02:00 tick/rcu: Fix bogus ratelimit condition The ratelimit logic in report_idle_softirq() is broken because the exit condition is always true: static int ratelimit; if (ratelimit < 10) return false; ---> always returns here ratelimit++; ---> no chance to run Make it check for >=3D 10 instead. Fixes: 0345691b24c0 ("tick/rcu: Stop allowing RCU_SOFTIRQ in idle") Signed-off-by: Wen Yang Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/r/tencent_5AAA3EEAB42095C9B7740BE62FBF9A67E00= 7@qq.com --- kernel/time/tick-sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 5225467..8905505 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -1030,7 +1030,7 @@ static bool report_idle_softirq(void) return false; } =20 - if (ratelimit < 10) + if (ratelimit >=3D 10) return false; =20 /* On RT, softirqs handling may be waiting on some lock */