From nobody Sun Feb 8 19:43:23 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D1BAC7EE45 for ; Mon, 5 Jun 2023 15:09:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234547AbjFEPJf (ORCPT ); Mon, 5 Jun 2023 11:09:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234182AbjFEPId (ORCPT ); Mon, 5 Jun 2023 11:08:33 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9646FA; Mon, 5 Jun 2023 08:08:32 -0700 (PDT) Date: Mon, 05 Jun 2023 15:08:31 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1685977711; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K0YG/CJ7lHpIjVq0+B9QQOsHY9cQnAyJfuD1hfeyad0=; b=PXMguflJkqxiUP7acUPugZdTeNjojB0Z6Mx+DdhK1n/5A0HQVI4NIQHavvqf34gs3A/jtC PTDr2KBowRdMwuHpNcl9L+HxM0aX8XeccN7A6RxIp9SjEDAr00e4L5S+QuDDMA5f1EmOhA i7V9D4VScawcuc6z8thNaUjJBBcUAdba4NOnebh4SE1pGd0CygyS3/UFribXw76t4Ip2/I VhMkh8TZ8gFs/TsYGK+fJGJamB5fAv27N7FnBtypjHWrAFxzFyAQT9mv0a82H1XXjkxLIk GUQrenwiqn622r56yOEFeYeE/oHhgFsKPcD76feCUtHEasAGB6gXPUOHgZFJAw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1685977711; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K0YG/CJ7lHpIjVq0+B9QQOsHY9cQnAyJfuD1hfeyad0=; b=OQKklJtSD+JMHQo72c9R1WZ8IxajGB2IF4yrqzd2oF7n+A///NynFR/LRM0z3/pFqkt6Uy 14bCxhe6VH8BmYCw== From: "tip-bot2 for Thomas Gleixner" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/core] posix-timers: Cleanup comments about timer ID tracking Cc: Thomas Gleixner , Frederic Weisbecker , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230425183313.038444551@linutronix.de> References: <20230425183313.038444551@linutronix.de> MIME-Version: 1.0 Message-ID: <168597771124.404.9140622043621148080.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the timers/core branch of tip: Commit-ID: 10338fd15894827fefc2bf28ed75c81ba1dbfceb Gitweb: https://git.kernel.org/tip/10338fd15894827fefc2bf28ed75c81ba= 1dbfceb Author: Thomas Gleixner AuthorDate: Tue, 25 Apr 2023 20:49:01 +02:00 Committer: Thomas Gleixner CommitterDate: Mon, 05 Jun 2023 17:03:37 +02:00 posix-timers: Cleanup comments about timer ID tracking Describe the hash table properly and remove the IDR leftover comments. Signed-off-by: Thomas Gleixner Reviewed-by: Frederic Weisbecker Link: https://lore.kernel.org/r/20230425183313.038444551@linutronix.de --- kernel/time/posix-timers.c | 28 ++++++++-------------------- 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c index 4017533..355c6f4 100644 --- a/kernel/time/posix-timers.c +++ b/kernel/time/posix-timers.c @@ -35,20 +35,17 @@ #include "timekeeping.h" #include "posix-timers.h" =20 -/* - * Management arrays for POSIX timers. Timers are now kept in static hash = table - * with 512 entries. - * Timer ids are allocated by local routine, which selects proper hash hea= d by - * key, constructed from current->signal address and per signal struct cou= nter. - * This keeps timer ids unique per process, but now they can intersect bet= ween - * processes. - */ +static struct kmem_cache *posix_timers_cache; =20 /* - * Lets keep our timers in a slab cache :-) + * Timers are managed in a hash table for lockless lookup. The hash key is + * constructed from current::signal and the timer ID and the timer is + * matched against current::signal and the timer ID when walking the hash + * bucket list. + * + * This allows checkpoint/restore to reconstruct the exact timer IDs for + * a process. */ -static struct kmem_cache *posix_timers_cache; - static DEFINE_HASHTABLE(posix_timers_hashtable, 9); static DEFINE_SPINLOCK(hash_lock); =20 @@ -66,15 +63,6 @@ static const struct k_clock clock_realtime, clock_monoto= nic; #endif =20 /* - * The timer ID is turned into a timer address by idr_find(). - * Verifying a valid ID consists of: - * - * a) checking that idr_find() returns other than -1. - * b) checking that the timer id matches the one in the timer itself. - * c) that the timer owner is in the callers thread group. - */ - -/* * CLOCKs: The POSIX standard calls for a couple of clocks and allows us * to implement others. This structure defines the various * clocks.