From nobody Sun Feb 8 14:56:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCAEBC77B7F for ; Tue, 16 May 2023 09:11:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231601AbjEPJLN (ORCPT ); Tue, 16 May 2023 05:11:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231816AbjEPJKH (ORCPT ); Tue, 16 May 2023 05:10:07 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 580722D55; Tue, 16 May 2023 02:10:04 -0700 (PDT) Date: Tue, 16 May 2023 09:09:59 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1684228199; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Te3ghZBp6wpNyW2Ta4F0OhsvLt52lAei2YT8fMwsGOE=; b=oMRzZwaE8MG0/fI/DWq80Ngrg6GhItOzLl+yL1oFIPi9aBIU0fF9Rmct1J9SJ7MhZCJloj zSkQ7Kmv1IxL35tO90h5R1MdE+21aBclONqV3UnExHUGGjj9iPxs/ZCA6S5rqZYR7PlGp8 3wTmdybKZycE7H3WKax+dSETsPRGNVoYVGefmw9mjK0VWp3YDzJ7XnEXxxXuoos+IEfNBL n8lDC74hLoyh0sHlo+xLPM1qkpCTwmEWZI+20YTkpk8DaPjjVFVtAL4lVkj9K27w3sneXZ HXUwCwDjZlClm1u2ZSToR8Hra7G+EbWmZcbNwr2b4sSEj3EvAjTDdsoAPeytkQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1684228199; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Te3ghZBp6wpNyW2Ta4F0OhsvLt52lAei2YT8fMwsGOE=; b=AaeadbfmMZ92AWeTi8Ym6VDoIj1PVMCNUZKk2X00wlvBsmEe2yExSxXvmzn7UshgA9n+yY UX1IuTmi76uMQ9DA== From: "tip-bot2 for Thomas Gleixner" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: smp/core] x86/xen/smp_pv: Remove wait for CPU online Cc: Thomas Gleixner , "Peter Zijlstra (Intel)" , Michael Kelley , Oleksandr Natalenko , Helge Deller , "Guilherme G. Piccoli" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230512205256.369512093@linutronix.de> References: <20230512205256.369512093@linutronix.de> MIME-Version: 1.0 Message-ID: <168422819921.404.10642421522981044037.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the smp/core branch of tip: Commit-ID: 2de7fd26d90729c4e3430f9924b199dea810a9bc Gitweb: https://git.kernel.org/tip/2de7fd26d90729c4e3430f9924b199dea= 810a9bc Author: Thomas Gleixner AuthorDate: Fri, 12 May 2023 23:07:24 +02:00 Committer: Peter Zijlstra CommitterDate: Mon, 15 May 2023 13:44:54 +02:00 x86/xen/smp_pv: Remove wait for CPU online Now that the core code drops sparse_irq_lock after the idle thread synchronized, it's pointless to wait for the AP to mark itself online. Whether the control CPU runs in a wait loop or sleeps in the core code waiting for the online operation to complete makes no difference. Signed-off-by: Thomas Gleixner Signed-off-by: Peter Zijlstra (Intel) Tested-by: Michael Kelley Tested-by: Oleksandr Natalenko Tested-by: Helge Deller # parisc Tested-by: Guilherme G. Piccoli # Steam Deck Link: https://lore.kernel.org/r/20230512205256.369512093@linutronix.de --- arch/x86/xen/smp_pv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c index a6f9128..be40927 100644 --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -340,11 +340,11 @@ static int xen_pv_cpu_up(unsigned int cpu, struct tas= k_struct *idle) =20 xen_pmu_init(cpu); =20 - rc =3D HYPERVISOR_vcpu_op(VCPUOP_up, xen_vcpu_nr(cpu), NULL); - BUG_ON(rc); - - while (cpu_report_state(cpu) !=3D CPU_ONLINE) - HYPERVISOR_sched_op(SCHEDOP_yield, NULL); + /* + * Why is this a BUG? If the hypercall fails then everything can be + * rolled back, no? + */ + BUG_ON(HYPERVISOR_vcpu_op(VCPUOP_up, xen_vcpu_nr(cpu), NULL)); =20 return 0; }