From nobody Thu Feb 12 07:42:08 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95398C77B60 for ; Wed, 26 Apr 2023 09:13:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240199AbjDZJNY (ORCPT ); Wed, 26 Apr 2023 05:13:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240042AbjDZJMi (ORCPT ); Wed, 26 Apr 2023 05:12:38 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C4094225; Wed, 26 Apr 2023 02:12:35 -0700 (PDT) Date: Wed, 26 Apr 2023 09:12:32 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1682500352; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+9+tbxi1xwAofZsvJzB71/MMe9Mf2Q8L9QuiXGZM8XI=; b=zHx6OnnatuhtH/w3NKyANPISLrIhZ7RLuQ5CjD8JXj4ZDgGKlpau5/RqoTuAjoKcPGu1BV K5HEFoRP5eFFpeHdzRjxy3dodJwpMIDYmOMQVteiKGRC3qCbRZC9VyxpMAKyun5LdxX630 Vyl4KFmoYilRTSU1JhTHWUvBlfdg4oe+djz2tQ0uA4EIb4e3Ah6HDkc13KdsiT8RmqeAvB 7stJRXCTTnsYIEFEUP9jLyOjmpg6RIKgt4PD2shj5EU/a9Q+hfmYq7w16xZXUOmFTylkVj ygkyk23iI2lyaLeIHD39VLhKPGtllLZATt7euYEYe8OYGf2PyEZMNg0DyH7BhA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1682500352; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+9+tbxi1xwAofZsvJzB71/MMe9Mf2Q8L9QuiXGZM8XI=; b=ByiKSqEWbdTQ76iZL11DYGcBTeUzgxariJZvhZSmi1xFy4AoNQRfZOFN1e4/WFqLsYu52S dkFZbYcVUcNemeDw== From: tip-bot2 for Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/core] clocksource/drivers/timer-ti-dm: Improve error message in .remove Cc: u.kleine-koenig@pengutronix.de, Daniel Lezcano , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230313075430.2730803-4-u.kleine-koenig@pengutronix.de> References: <20230313075430.2730803-4-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Message-ID: <168250035216.404.14983446522756531530.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the timers/core branch of tip: Commit-ID: 8efcbe927c5129d5b2528bbb40034c7dde87a6b6 Gitweb: https://git.kernel.org/tip/8efcbe927c5129d5b2528bbb40034c7dd= e87a6b6 Author: Uwe Kleine-K=C3=B6nig AuthorDate: Mon, 13 Mar 2023 08:54:28 +01:00 Committer: Daniel Lezcano CommitterDate: Mon, 24 Apr 2023 16:56:13 +02:00 clocksource/drivers/timer-ti-dm: Improve error message in .remove If a platform driver's remove callback returns an error code, the driver core emits a generic (and thus little helpful) error message. Instead emit a more specifc error message about the actual error and return zero to suppress the core's message. Note that returning zero has no side effects apart from not emitting said error message. This prepares converting platform driver's remove message to return void. Signed-off-by: Uwe Kleine-K=C3=B6nig Signed-off-by: Daniel Lezcano Link: https://lore.kernel.org/r/20230313075430.2730803-4-u.kleine-koenig@pe= ngutronix.de --- drivers/clocksource/timer-ti-dm.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-= ti-dm.c index b24b903..098562b 100644 --- a/drivers/clocksource/timer-ti-dm.c +++ b/drivers/clocksource/timer-ti-dm.c @@ -1197,7 +1197,10 @@ static int omap_dm_timer_remove(struct platform_devi= ce *pdev) =20 pm_runtime_disable(&pdev->dev); =20 - return ret; + if (ret) + dev_err(&pdev->dev, "Unable to determine timer entry in list of drivers = on remove\n"); + + return 0; } =20 static const struct omap_dm_timer_ops dmtimer_ops =3D {