From nobody Fri Apr 10 12:57:23 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80741C61DA4 for ; Sat, 18 Feb 2023 14:28:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229694AbjBRO2i (ORCPT ); Sat, 18 Feb 2023 09:28:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjBRO2h (ORCPT ); Sat, 18 Feb 2023 09:28:37 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16C1315CBA for ; Sat, 18 Feb 2023 06:28:36 -0800 (PST) Date: Sat, 18 Feb 2023 14:28:33 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1676730513; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YYf8cdQX1+qWLhAT0OWbBu0XyR2VvktlZhwh5Ldum5I=; b=cZcwsny+fQZgJoMJ4M3Ps4x1/u/Fki14JvAiARAyJ7vB7fkasRfqhtEVol3mO9W6xPnePn 3Gpl2XYGZPCpztbTrUHI/4WSq8mUpsHINFDiQdcC+edmKOzuvrNOSQ4n642nu85vkHAPtp VpEWt4Na+dpxDtcFkrFvsQxZAoVGo6PbEKJ/sGLnmTG//bAilL1EFyT6KyhV5p+yOUzcng QYMUh+HE6sQPqY9Zeq125XQ2dDpo9Mf7ZYKfjiLdxVamG/kCgKwrbmQSJqezeEwNkX2tbP PX9ySlMZWE3Srx9GJnZ4XiftBDKa6mOpLOBpet6kKS25xeIFLRkMZDAGk1IonQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1676730513; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YYf8cdQX1+qWLhAT0OWbBu0XyR2VvktlZhwh5Ldum5I=; b=LQK6ToFdPcEwQ/Hje+PZDkWeSuPReN23GQkeHcvIsFAjk/sBc9JW3g973uBKbLMDr7Bjqi vHxAtuekm5kgWHDg== From: "irqchip-bot for Florian Fainelli" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-kernel@vger.kernel.org Subject: [irqchip: irq/irqchip-next] irqchip/irq-brcmstb-l2: Set IRQ_LEVEL for level triggered interrupts Cc: Florian Fainelli , philmd@linaro.org, Marc Zyngier , tglx@linutronix.de In-Reply-To: <20221216230934.2478345-2-f.fainelli@gmail.com> References: <20221216230934.2478345-2-f.fainelli@gmail.com> MIME-Version: 1.0 Message-ID: <167673051321.4906.7043097380956478723.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the irq/irqchip-next branch of ir= qchip: Commit-ID: 94debe03e8afa1267f95a9001786a6aa506b9ff3 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-plat= forms/94debe03e8afa1267f95a9001786a6aa506b9ff3 Author: Florian Fainelli AuthorDate: Fri, 16 Dec 2022 15:09:33 -08:00 Committer: Marc Zyngier CommitterDate: Sat, 18 Feb 2023 14:23:41=20 irqchip/irq-brcmstb-l2: Set IRQ_LEVEL for level triggered interrupts When support for the level triggered interrupt controller flavor was added with c0ca7262088e, we forgot to update the flags to be set to contain IRQ_LEVEL. While the flow handler is correct, the output from /proc/interrupts does not show such interrupts as being level triggered when they are, correct that. Fixes: c0ca7262088e ("irqchip/brcmstb-l2: Add support for the BCM7271 L2 co= ntroller") Signed-off-by: Florian Fainelli Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20221216230934.2478345-2-f.fainelli@gmail.c= om --- drivers/irqchip/irq-brcmstb-l2.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb= -l2.c index e4efc08..091b0fe 100644 --- a/drivers/irqchip/irq-brcmstb-l2.c +++ b/drivers/irqchip/irq-brcmstb-l2.c @@ -161,6 +161,7 @@ static int __init brcmstb_l2_intc_of_init(struct device= _node *np, *init_params) { unsigned int clr =3D IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN; + unsigned int set =3D 0; struct brcmstb_l2_intc_data *data; struct irq_chip_type *ct; int ret; @@ -208,9 +209,12 @@ static int __init brcmstb_l2_intc_of_init(struct devic= e_node *np, if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(CONFIG_CPU_BIG_ENDIAN)) flags |=3D IRQ_GC_BE_IO; =20 + if (init_params->handler =3D=3D handle_level_irq) + set |=3D IRQ_LEVEL; + /* Allocate a single Generic IRQ chip for this node */ ret =3D irq_alloc_domain_generic_chips(data->domain, 32, 1, - np->full_name, init_params->handler, clr, 0, flags); + np->full_name, init_params->handler, clr, set, flags); if (ret) { pr_err("failed to allocate generic irq chip\n"); goto out_free_domain;