From nobody Fri Sep 12 04:47:55 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04355C636D4 for ; Mon, 13 Feb 2023 18:49:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230032AbjBMStB (ORCPT ); Mon, 13 Feb 2023 13:49:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229841AbjBMSsg (ORCPT ); Mon, 13 Feb 2023 13:48:36 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C32A0E07E; Mon, 13 Feb 2023 10:48:35 -0800 (PST) Date: Mon, 13 Feb 2023 18:48:33 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1676314113; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9b+Byo62pKbQj/k6bgSFis9WZ9wu30fro/AnJgLkOXw=; b=RZ1OMgRrfq6Xxy23hHrVzeAH9ufILm00sTvAObQHPSguQn06LA1DGhnpOWmVTLAmadoJO3 aWQa4DmktpVcxcZVxGck9MMxS7npRb8sUJMcg/rrSBJ1Woyo66OclF+p442uX6knDu8kdz QFQ8na4WbWBkcmxtq2uRpSpWl8lleobLjFVR+UDofW+EjLwE1XINrBiWr8U0etcTe9jpo+ rzv6QKNlCSK2aosLaYpOibjjx2AA+cZBJBU2gXXMFJAgctbE5D4/bycY32nihsVLMVY8Vm hxUiNMh4lKq2Hb7wa526wFXWra8SCGMtPfySCvSwolMcMDZPUUrufoW7aqOWCw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1676314113; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9b+Byo62pKbQj/k6bgSFis9WZ9wu30fro/AnJgLkOXw=; b=8NkPDS8GsY8hURi+83+QpKzDSg4mc/hPy51SOikFWc0rAsd5ogflJwR6IL9RBMhqRQztxQ Xz8KbVeVaDvMrtBg== From: "tip-bot2 for Paul E. McKenney" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/core] clocksource: Improve read-back-delay message Cc: "Paul E. McKenney" , John Stultz , Thomas Gleixner , Stephen Boyd , Feng Tang , x86@kernel.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Message-ID: <167631411351.4906.13640037074294664636.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the timers/core branch of tip: Commit-ID: f092eb34b33043152bfb8a4ca01db9a06728261d Gitweb: https://git.kernel.org/tip/f092eb34b33043152bfb8a4ca01db9a06= 728261d Author: Paul E. McKenney AuthorDate: Tue, 13 Dec 2022 13:57:28 -08:00 Committer: Paul E. McKenney CommitterDate: Tue, 03 Jan 2023 20:43:45 -08:00 clocksource: Improve read-back-delay message When cs_watchdog_read() is unable to get a qualifying clocksource read within the limit set by max_cswd_read_retries, it prints a message and marks the clocksource under test as unstable. But that message is unclear to anyone unfamiliar with the code: clocksource: timekeeping watchdog on CPU13: wd-tsc-wd read-back delay 10006= 14ns, attempt 3, marking unstable Therefore, add some context so that the message appears as follows: clocksource: timekeeping watchdog on CPU13: wd-tsc-wd excessive read-back d= elay of 1000614ns vs. limit of 125000ns, wd-wd read-back delay only 27ns, a= ttempt 3, marking tsc unstable Signed-off-by: Paul E. McKenney Cc: John Stultz Cc: Thomas Gleixner Cc: Stephen Boyd Cc: Feng Tang --- kernel/time/clocksource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c index a3d19f6..b599149 100644 --- a/kernel/time/clocksource.c +++ b/kernel/time/clocksource.c @@ -260,8 +260,8 @@ static enum wd_read_status cs_watchdog_read(struct cloc= ksource *cs, u64 *csnow,=20 goto skip_test; } =20 - pr_warn("timekeeping watchdog on CPU%d: wd-%s-wd read-back delay of %lldn= s, attempt %d, marking unstable\n", - smp_processor_id(), cs->name, wd_delay, nretries); + pr_warn("timekeeping watchdog on CPU%d: wd-%s-wd excessive read-back dela= y of %lldns vs. limit of %ldns, wd-wd read-back delay only %lldns, attempt = %d, marking %s unstable\n", + smp_processor_id(), cs->name, wd_delay, WATCHDOG_MAX_SKEW, wd_seq_delay,= nretries, cs->name); return WD_READ_UNSTABLE; =20 skip_test: