From nobody Sun Apr 5 20:05:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA773C54EBE for ; Fri, 13 Jan 2023 12:36:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241728AbjAMMgw (ORCPT ); Fri, 13 Jan 2023 07:36:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241306AbjAMMcT (ORCPT ); Fri, 13 Jan 2023 07:32:19 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C4941CB17; Fri, 13 Jan 2023 04:31:16 -0800 (PST) Date: Fri, 13 Jan 2023 12:31:14 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1673613074; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IdHvpPSQSZAkV9++SX1Wbo6VK6lNx4oK1LX4BODVDuM=; b=Rxo3nIFYac09XXf1iHPYN0cJtsDJXsUPGperJrvzh8J+Eia5lph4QlZ2kqQoY0TiblV2YZ tHOy/1IeK8l21qXiwtxa57p/D8aLGqUuNRfjHt1W2DV5OqDRgl3wN/Jol8MRX6fqXMMT7z TCmG9LrR9TJezy/8BgIfLLCNZ8r5UkTY+JH2mYMFjO7z8IcimkbxFkLv3F++aqrGYCCXyv Z95TJw9Z4L87Avq0yyZPd2EDQ+CEdhYJpsGGD7G21lVBuuyrdJ+khWbEzXph60GrX1OnKv e9TgX93WHJ27QSpIaRm8TSEsD+cXsZfiqcOyMeRk+AG4bq2Fj3ZQ87iWyfdL4A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1673613074; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IdHvpPSQSZAkV9++SX1Wbo6VK6lNx4oK1LX4BODVDuM=; b=m6DjOo2gOAfG1//egqVuiphILBH//iBHWkSNndZhRtD3SZaxq1fasvbWpKtTtNlIKKryBJ C/bGxNl+UFCFbKAg== From: "tip-bot2 for Peter Zijlstra" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: sched/core] cpuidle, armada: Push RCU-idle into driver Cc: "Peter Zijlstra (Intel)" , Ingo Molnar , Tony Lindgren , Ulf Hansson , Frederic Weisbecker , "Rafael J. Wysocki" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230112195539.946630819@infradead.org> References: <20230112195539.946630819@infradead.org> MIME-Version: 1.0 Message-ID: <167361307427.4906.15441555774819619097.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the sched/core branch of tip: Commit-ID: 4ce40e9dbe83153f60d7e4ccd24a1eb4f8264f6a Gitweb: https://git.kernel.org/tip/4ce40e9dbe83153f60d7e4ccd24a1eb4f= 8264f6a Author: Peter Zijlstra AuthorDate: Thu, 12 Jan 2023 20:43:24 +01:00 Committer: Ingo Molnar CommitterDate: Fri, 13 Jan 2023 11:47:27 +01:00 cpuidle, armada: Push RCU-idle into driver Doing RCU-idle outside the driver, only to then temporarily enable it again before going idle is suboptimal. Notably the cpu_pm_*() calls implicitly re-enable RCU for a bit. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Ingo Molnar Tested-by: Tony Lindgren Tested-by: Ulf Hansson Reviewed-by: Frederic Weisbecker Acked-by: Rafael J. Wysocki Link: https://lore.kernel.org/r/20230112195539.946630819@infradead.org --- drivers/cpuidle/cpuidle-mvebu-v7.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/cpuidle/cpuidle-mvebu-v7.c b/drivers/cpuidle/cpuidle-m= vebu-v7.c index 01a8569..c9568aa 100644 --- a/drivers/cpuidle/cpuidle-mvebu-v7.c +++ b/drivers/cpuidle/cpuidle-mvebu-v7.c @@ -36,7 +36,10 @@ static int mvebu_v7_enter_idle(struct cpuidle_device *de= v, if (drv->states[index].flags & MVEBU_V7_FLAG_DEEP_IDLE) deepidle =3D true; =20 + ct_idle_enter(); ret =3D mvebu_v7_cpu_suspend(deepidle); + ct_idle_exit(); + cpu_pm_exit(); =20 if (ret) @@ -49,6 +52,7 @@ static struct cpuidle_driver armadaxp_idle_driver =3D { .name =3D "armada_xp_idle", .states[0] =3D ARM_CPUIDLE_WFI_STATE, .states[1] =3D { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D mvebu_v7_enter_idle, .exit_latency =3D 100, .power_usage =3D 50, @@ -57,6 +61,7 @@ static struct cpuidle_driver armadaxp_idle_driver =3D { .desc =3D "CPU power down", }, .states[2] =3D { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D mvebu_v7_enter_idle, .exit_latency =3D 1000, .power_usage =3D 5, @@ -72,6 +77,7 @@ static struct cpuidle_driver armada370_idle_driver =3D { .name =3D "armada_370_idle", .states[0] =3D ARM_CPUIDLE_WFI_STATE, .states[1] =3D { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D mvebu_v7_enter_idle, .exit_latency =3D 100, .power_usage =3D 5, @@ -87,6 +93,7 @@ static struct cpuidle_driver armada38x_idle_driver =3D { .name =3D "armada_38x_idle", .states[0] =3D ARM_CPUIDLE_WFI_STATE, .states[1] =3D { + .flags =3D CPUIDLE_FLAG_RCU_IDLE, .enter =3D mvebu_v7_enter_idle, .exit_latency =3D 10, .power_usage =3D 5,