From nobody Tue Sep 16 06:41:25 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B999C54EBF for ; Fri, 6 Jan 2023 15:06:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235166AbjAFPF7 (ORCPT ); Fri, 6 Jan 2023 10:05:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234623AbjAFPFr (ORCPT ); Fri, 6 Jan 2023 10:05:47 -0500 Received: from out30-8.freemail.mail.aliyun.com (out30-8.freemail.mail.aliyun.com [115.124.30.8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE2B260844; Fri, 6 Jan 2023 07:05:45 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0VZ-UXmi_1673017539; Received: from srmbuffer011165236051.sqa.eu95(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VZ-UXmi_1673017539) by smtp.aliyun-inc.com; Fri, 06 Jan 2023 23:05:40 +0800 From: Jing Zhang To: John Garry , Ian Rogers Cc: Xing Zhengjun , Will Deacon , James Clark , Mike Leach , Leo Yan , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andrew Kilroy , Shuai Xue , Zhuo Song , Jing Zhang Subject: [PATCH v6 1/7] perf vendor events arm64: Add common topdown L1 metrics Date: Fri, 6 Jan 2023 23:05:23 +0800 Message-Id: <1673017529-1429208-2-git-send-email-renyu.zj@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1673017529-1429208-1-git-send-email-renyu.zj@linux.alibaba.com> References: <1673017529-1429208-1-git-send-email-renyu.zj@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The metrics of topdown L1 are from ARM sbsa7.0 platform design doc[0], D37-38, which are standard. So put them in the common file sbsa.json of arm64, so that other cores besides n2/v2 can also be reused. Slots may be different in each architecture, so added "#slots" literal to get different constant for each architecture. The value of slots comes from the register PMMIR_EL1, which I can read in /sys/bus/event_source/device/armv8_pmuv3_*/caps/slots. PMMIR_EL1.SLOT might read as zero if the STALL_SLOT event is not implemented or the PMU version is lower than ID_AA64DFR0_EL1_PMUVer_V3P4. [0] https://documentation-service.arm.com/static/60250c7395978b529036da86?t= oken=3D Signed-off-by: Jing Zhang Acked-by: Ian Rogers --- tools/perf/arch/arm64/util/pmu.c | 22 ++++++++++++++++++++++ tools/perf/pmu-events/arch/arm64/sbsa.json | 30 ++++++++++++++++++++++++++= ++++ tools/perf/pmu-events/jevents.py | 2 ++ tools/perf/util/expr.c | 5 +++++ tools/perf/util/pmu.c | 5 +++++ tools/perf/util/pmu.h | 1 + 6 files changed, 65 insertions(+) create mode 100644 tools/perf/pmu-events/arch/arm64/sbsa.json diff --git a/tools/perf/arch/arm64/util/pmu.c b/tools/perf/arch/arm64/util/= pmu.c index 477e513..227dadb 100644 --- a/tools/perf/arch/arm64/util/pmu.c +++ b/tools/perf/arch/arm64/util/pmu.c @@ -3,6 +3,7 @@ #include #include "../../../util/cpumap.h" #include "../../../util/pmu.h" +#include =20 const struct pmu_events_table *pmu_events_table__find(void) { @@ -24,3 +25,24 @@ const struct pmu_events_table *pmu_events_table__find(vo= id) =20 return NULL; } + +int perf_pmu__get_slots(void) +{ + char path[PATH_MAX]; + unsigned long long slots =3D 0; + struct perf_pmu *pmu =3D NULL; + + while ((pmu =3D perf_pmu__scan(pmu)) !=3D NULL) { + if (is_pmu_core(pmu->name)) + break; + } + if (pmu) { + scnprintf(path, PATH_MAX, + EVENT_SOURCE_DEVICE_PATH "%s/caps/slots", pmu->name); + /* The value of slots is not greater than INT_MAX, but sysfs__read_int + * can't read value with 0x prefix, so use sysfs__read_ull instead. + */ + sysfs__read_ull(path, &slots); + } + return (int)slots; +} diff --git a/tools/perf/pmu-events/arch/arm64/sbsa.json b/tools/perf/pmu-ev= ents/arch/arm64/sbsa.json new file mode 100644 index 0000000..f678c37e --- /dev/null +++ b/tools/perf/pmu-events/arch/arm64/sbsa.json @@ -0,0 +1,30 @@ +[ + { + "MetricExpr": "stall_slot_frontend / (#slots * cpu_cycles)", + "BriefDescription": "Frontend bound L1 topdown metric", + "MetricGroup": "TopdownL1", + "MetricName": "frontend_bound", + "ScaleUnit": "100%" + }, + { + "MetricExpr": "(1 - op_retired / op_spec) * (1 - stall_slot / (#sl= ots * cpu_cycles))", + "BriefDescription": "Bad speculation L1 topdown metric", + "MetricGroup": "TopdownL1", + "MetricName": "bad_speculation", + "ScaleUnit": "100%" + }, + { + "MetricExpr": "(op_retired / op_spec) * (1 - stall_slot / (#slots = * cpu_cycles))", + "BriefDescription": "Retiring L1 topdown metric", + "MetricGroup": "TopdownL1", + "MetricName": "retiring", + "ScaleUnit": "100%" + }, + { + "MetricExpr": "stall_slot_backend / (#slots * cpu_cycles)", + "BriefDescription": "Backend Bound L1 topdown metric", + "MetricGroup": "TopdownL1", + "MetricName": "backend_bound", + "ScaleUnit": "100%" + } +] diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jeven= ts.py index 4c398e0..0416b74 100755 --- a/tools/perf/pmu-events/jevents.py +++ b/tools/perf/pmu-events/jevents.py @@ -358,6 +358,8 @@ def preprocess_arch_std_files(archpath: str) -> None: for event in read_json_events(item.path, topic=3D''): if event.name: _arch_std_events[event.name.lower()] =3D event + if event.metric_name: + _arch_std_events[event.metric_name.lower()] =3D event =20 =20 def print_events_table_prefix(tblname: str) -> None: diff --git a/tools/perf/util/expr.c b/tools/perf/util/expr.c index 00dcde3..3d67707 100644 --- a/tools/perf/util/expr.c +++ b/tools/perf/util/expr.c @@ -19,6 +19,7 @@ #include #include #include +#include "pmu.h" =20 #ifdef PARSER_DEBUG extern int expr_debug; @@ -448,6 +449,10 @@ double expr__get_literal(const char *literal, const st= ruct expr_scanner_ctx *ctx result =3D topology->core_cpus_lists; goto out; } + if (!strcmp("#slots", literal)) { + result =3D perf_pmu__get_slots(); + goto out; + } =20 pr_err("Unrecognized literal '%s'", literal); out: diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index 2bdeb89..d4cace2 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -1993,3 +1993,8 @@ int perf_pmu__cpus_match(struct perf_pmu *pmu, struct= perf_cpu_map *cpus, *ucpus_ptr =3D unmatched_cpus; return 0; } + +int __weak perf_pmu__get_slots(void) +{ + return 0; +} diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h index 69ca000..a2f7df8 100644 --- a/tools/perf/util/pmu.h +++ b/tools/perf/util/pmu.h @@ -259,4 +259,5 @@ int perf_pmu__cpus_match(struct perf_pmu *pmu, struct p= erf_cpu_map *cpus, =20 char *pmu_find_real_name(const char *name); char *pmu_find_alias_name(const char *name); +int perf_pmu__get_slots(void); #endif /* __PMU_H */ --=20 1.8.3.1