From nobody Wed Sep 17 01:25:27 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E8DC4332F for ; Tue, 27 Dec 2022 12:17:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231334AbiL0MQp (ORCPT ); Tue, 27 Dec 2022 07:16:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231718AbiL0MOn (ORCPT ); Tue, 27 Dec 2022 07:14:43 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 365F563FF; Tue, 27 Dec 2022 04:13:56 -0800 (PST) Date: Tue, 27 Dec 2022 12:13:52 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1672143233; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hulIJpjMgo6pOe8FjgQRymuJwZUMCCYKSFHvu1/1r9s=; b=WJyri35SpY+6VrrUTSEbHH0xkbOZuOfXy8Kjw8BHu+XBiKcR1QePxGMRvBLeshfLkrvDVF s6Jn3lKXF6s/Bnus2PBXylzlI7Oot8S2GDFN8eRjP69q/yKMtbMQmPIQAKlq4sGk6wkGfI uonIOND3YW/UAiXPmgMFY7qCcKwUmw5C0CfY/1XogBK8F7BwJ5992tYQYRaMGK19vM8W1T My4HogM6o+ViKvDgjBE6bH1DBiDOGOoFADWDnAODBxS6F0kB4l8sWIM9ofFACGd8bIJVSy Flvsk9sVMoaUBmbmcOL9eeC2rc4ZfuEu7630DEfdpREEfVbFlONv1dTOy56eqA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1672143233; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hulIJpjMgo6pOe8FjgQRymuJwZUMCCYKSFHvu1/1r9s=; b=xoRZfHCSJyKy5ctgOrpsNzDVqqCbIVMkX5AsRuGZS6avlsyFda3HkJI6K6voa2x3kkxYc3 PZRrcDye5Tf5aWBA== From: "tip-bot2 for Mathieu Desnoyers" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: sched/core] selftests/rseq: Fix: Fail thread registration when CONFIG_RSEQ=n Cc: Mathieu Desnoyers , "Peter Zijlstra (Intel)" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20221122203932.231377-2-mathieu.desnoyers@efficios.com> References: <20221122203932.231377-2-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 Message-ID: <167214323279.4906.12457162726827402464.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the sched/core branch of tip: Commit-ID: 4842dadfc66f627083ec46c4e9a426e805c765f3 Gitweb: https://git.kernel.org/tip/4842dadfc66f627083ec46c4e9a426e80= 5c765f3 Author: Mathieu Desnoyers AuthorDate: Tue, 22 Nov 2022 15:39:03 -05:00 Committer: Peter Zijlstra CommitterDate: Tue, 27 Dec 2022 12:52:10 +01:00 selftests/rseq: Fix: Fail thread registration when CONFIG_RSEQ=3Dn When linking the selftests against a libc which does not handle rseq registration (before 2.35), rseq thread registration silently succeed even with CONFIG_RSEQ=3Dn because it erroneously thinks that libc is handling rseq registration. This is caused by setting the rseq ownership flag only after the rseq_available() check. It should rather be set before the rseq_available() check. Set the rseq_size to 0 (error value) immediately after the rseq_available() check fails rather than in the thread registration functions. Signed-off-by: Mathieu Desnoyers Signed-off-by: Peter Zijlstra (Intel) Link: https://lore.kernel.org/r/20221122203932.231377-2-mathieu.desnoyers@e= fficios.com --- tools/testing/selftests/rseq/rseq.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/rseq/rseq.c b/tools/testing/selftests/= rseq/rseq.c index 4177f95..376a73f 100644 --- a/tools/testing/selftests/rseq/rseq.c +++ b/tools/testing/selftests/rseq/rseq.c @@ -119,9 +119,11 @@ void rseq_init(void) rseq_flags =3D *libc_rseq_flags_p; return; } - if (!rseq_available()) - return; rseq_ownership =3D 1; + if (!rseq_available()) { + rseq_size =3D 0; + return; + } rseq_offset =3D (void *)&__rseq_abi - rseq_thread_pointer(); rseq_size =3D sizeof(struct rseq_abi); rseq_flags =3D 0;