From nobody Sun Apr 12 16:36:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8D78C4332F for ; Fri, 23 Dec 2022 12:02:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236269AbiLWMCr (ORCPT ); Fri, 23 Dec 2022 07:02:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236159AbiLWMBu (ORCPT ); Fri, 23 Dec 2022 07:01:50 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C85A646652 for ; Fri, 23 Dec 2022 04:00:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671796838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UMR68Vqzj+brVScHEIGdxjOKpH6UtvV7/GGHsJVFg+A=; b=MEPlVmIADOxrmb+JAdBYoli1WUGNsvE/oLYH7nahSYVRNLlhlcFkLpBsis5aixCQ/zinw+ cdXuztpnHuE1wGO6v6ZThhBKeruzQyCIos9cl575dDONdky7q3GLl/OEzgZZHk1QqhYJiq zLIwcgOUHCjn6QwAyuXlMwSyotaF++4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-637-P98DP3HZOJmxy9oNObBLtA-1; Fri, 23 Dec 2022 07:00:33 -0500 X-MC-Unique: P98DP3HZOJmxy9oNObBLtA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5E3C2101A55E; Fri, 23 Dec 2022 12:00:33 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id A465440C2064; Fri, 23 Dec 2022 12:00:32 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [PATCH net-next 05/19] rxrpc: Only set/transmit aborts in the I/O thread From: David Howells To: netdev@vger.kernel.org Cc: Marc Dionne , linux-afs@lists.infradead.org, dhowells@redhat.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 23 Dec 2022 12:00:32 +0000 Message-ID: <167179683208.2516210.18131962625222355183.stgit@warthog.procyon.org.uk> In-Reply-To: <167179679960.2516210.10739247907156079872.stgit@warthog.procyon.org.uk> References: <167179679960.2516210.10739247907156079872.stgit@warthog.procyon.org.uk> User-Agent: StGit/1.5 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Only set the abort call completion state in the I/O thread and only transmit ABORT packets from there. rxrpc_abort_call() can then be made to actually send the packet. Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.org --- include/trace/events/rxrpc.h | 1 + net/rxrpc/ar-internal.h | 6 +++++- net/rxrpc/call_event.c | 7 ++++++- net/rxrpc/call_object.c | 5 ++--- net/rxrpc/input.c | 6 ++---- net/rxrpc/recvmsg.c | 2 ++ net/rxrpc/sendmsg.c | 28 +++++++++++++++++++++------- 7 files changed, 39 insertions(+), 16 deletions(-) diff --git a/include/trace/events/rxrpc.h b/include/trace/events/rxrpc.h index b526d982da7e..c44cc01de750 100644 --- a/include/trace/events/rxrpc.h +++ b/include/trace/events/rxrpc.h @@ -17,6 +17,7 @@ * Declare tracing information enums and their string mappings for display. */ #define rxrpc_call_poke_traces \ + EM(rxrpc_call_poke_abort, "Abort") \ EM(rxrpc_call_poke_error, "Error") \ EM(rxrpc_call_poke_idle, "Idle") \ EM(rxrpc_call_poke_start, "Start") \ diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-internal.h index b2e3c0f84647..b7023ae360e7 100644 --- a/net/rxrpc/ar-internal.h +++ b/net/rxrpc/ar-internal.h @@ -625,7 +625,10 @@ struct rxrpc_call { unsigned long events; spinlock_t notify_lock; /* Kernel notification lock */ rwlock_t state_lock; /* lock for state transition */ - u32 abort_code; /* Local/remote abort code */ + const char *send_abort_why; /* String indicating why the abort was sent = */ + s32 send_abort; /* Abort code to be sent */ + short send_abort_err; /* Error to be associated with the abort */ + s32 abort_code; /* Local/remote abort code */ int error; /* Local error incurred */ enum rxrpc_call_state state; /* current state of call */ enum rxrpc_call_completion completion; /* Call completion condition */ @@ -1146,6 +1149,7 @@ struct key *rxrpc_look_up_server_security(struct rxrp= c_connection *, /* * sendmsg.c */ +bool rxrpc_propose_abort(struct rxrpc_call *, u32, int, const char *); int rxrpc_do_sendmsg(struct rxrpc_sock *, struct msghdr *, size_t); =20 /* diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event.c index b2cf448fb02c..a8b5dff09999 100644 --- a/net/rxrpc/call_event.c +++ b/net/rxrpc/call_event.c @@ -336,6 +336,7 @@ void rxrpc_input_call_event(struct rxrpc_call *call, st= ruct sk_buff *skb) unsigned long now, next, t; rxrpc_serial_t ackr_serial; bool resend =3D false, expired =3D false; + s32 abort_code; =20 rxrpc_see_call(call, rxrpc_call_see_input); =20 @@ -346,6 +347,11 @@ void rxrpc_input_call_event(struct rxrpc_call *call, s= truct sk_buff *skb) if (call->state =3D=3D RXRPC_CALL_COMPLETE) goto out; =20 + abort_code =3D smp_load_acquire(&call->send_abort); + if (abort_code) + rxrpc_abort_call(call->send_abort_why, call, 0, call->send_abort, + call->send_abort_err); + if (skb && skb->mark =3D=3D RXRPC_SKB_MARK_ERROR) goto out; =20 @@ -433,7 +439,6 @@ void rxrpc_input_call_event(struct rxrpc_call *call, st= ruct sk_buff *skb) } else { rxrpc_abort_call("EXP", call, 0, RX_CALL_TIMEOUT, -ETIME); } - rxrpc_send_abort_packet(call); goto out; } =20 diff --git a/net/rxrpc/call_object.c b/net/rxrpc/call_object.c index 239fc3c75079..8d3d2e058827 100644 --- a/net/rxrpc/call_object.c +++ b/net/rxrpc/call_object.c @@ -590,7 +590,7 @@ void rxrpc_release_calls_on_socket(struct rxrpc_sock *r= x) call =3D list_entry(rx->to_be_accepted.next, struct rxrpc_call, accept_link); list_del(&call->accept_link); - rxrpc_abort_call("SKR", call, 0, RX_CALL_DEAD, -ECONNRESET); + rxrpc_propose_abort(call, RX_CALL_DEAD, -ECONNRESET, "SKR"); rxrpc_put_call(call, rxrpc_call_put_release_sock_tba); } =20 @@ -598,8 +598,7 @@ void rxrpc_release_calls_on_socket(struct rxrpc_sock *r= x) call =3D list_entry(rx->sock_calls.next, struct rxrpc_call, sock_link); rxrpc_get_call(call, rxrpc_call_get_release_sock); - rxrpc_abort_call("SKT", call, 0, RX_CALL_DEAD, -ECONNRESET); - rxrpc_send_abort_packet(call); + rxrpc_propose_abort(call, RX_CALL_DEAD, -ECONNRESET, "SKT"); rxrpc_release_call(rx, call); rxrpc_put_call(call, rxrpc_call_put_release_sock); } diff --git a/net/rxrpc/input.c b/net/rxrpc/input.c index d0e20e946e48..1f03a286620d 100644 --- a/net/rxrpc/input.c +++ b/net/rxrpc/input.c @@ -12,8 +12,7 @@ static void rxrpc_proto_abort(const char *why, struct rxrpc_call *call, rxrpc_seq_t seq) { - if (rxrpc_abort_call(why, call, seq, RX_PROTOCOL_ERROR, -EBADMSG)) - rxrpc_send_abort_packet(call); + rxrpc_abort_call(why, call, seq, RX_PROTOCOL_ERROR, -EBADMSG); } =20 /* @@ -1007,8 +1006,7 @@ void rxrpc_implicit_end_call(struct rxrpc_call *call,= struct sk_buff *skb) case RXRPC_CALL_COMPLETE: break; default: - if (rxrpc_abort_call("IMP", call, 0, RX_CALL_DEAD, -ESHUTDOWN)) - rxrpc_send_abort_packet(call); + rxrpc_abort_call("IMP", call, 0, RX_CALL_DEAD, -ESHUTDOWN); trace_rxrpc_improper_term(call); break; } diff --git a/net/rxrpc/recvmsg.c b/net/rxrpc/recvmsg.c index 6ebd6440a2b7..3d6ba7e464b4 100644 --- a/net/rxrpc/recvmsg.c +++ b/net/rxrpc/recvmsg.c @@ -134,6 +134,8 @@ bool rxrpc_abort_call(const char *why, struct rxrpc_cal= l *call, write_lock(&call->state_lock); ret =3D __rxrpc_abort_call(why, call, seq, abort_code, error); write_unlock(&call->state_lock); + if (ret) + rxrpc_send_abort_packet(call); return ret; } =20 diff --git a/net/rxrpc/sendmsg.c b/net/rxrpc/sendmsg.c index cde1e65f16b4..eb162695c946 100644 --- a/net/rxrpc/sendmsg.c +++ b/net/rxrpc/sendmsg.c @@ -17,6 +17,25 @@ #include #include "ar-internal.h" =20 +/* + * Propose an abort to be made in the I/O thread. + */ +bool rxrpc_propose_abort(struct rxrpc_call *call, + u32 abort_code, int error, const char *why) +{ + _enter("{%d},%d,%d,%s", call->debug_id, abort_code, error, why); + + if (!call->send_abort && call->state < RXRPC_CALL_COMPLETE) { + call->send_abort_why =3D why; + call->send_abort_err =3D error; + smp_store_release(&call->send_abort, abort_code); + rxrpc_poke_call(call, rxrpc_call_poke_abort); + return true; + } + + return false; +} + /* * Return true if there's sufficient Tx queue space. */ @@ -663,9 +682,8 @@ int rxrpc_do_sendmsg(struct rxrpc_sock *rx, struct msgh= dr *msg, size_t len) /* it's too late for this call */ ret =3D -ESHUTDOWN; } else if (p.command =3D=3D RXRPC_CMD_SEND_ABORT) { + rxrpc_propose_abort(call, p.abort_code, -ECONNABORTED, "CMD"); ret =3D 0; - if (rxrpc_abort_call("CMD", call, 0, p.abort_code, -ECONNABORTED)) - ret =3D rxrpc_send_abort_packet(call); } else if (p.command !=3D RXRPC_CMD_SEND_DATA) { ret =3D -EINVAL; } else { @@ -760,11 +778,7 @@ bool rxrpc_kernel_abort_call(struct socket *sock, stru= ct rxrpc_call *call, _enter("{%d},%d,%d,%s", call->debug_id, abort_code, error, why); =20 mutex_lock(&call->user_mutex); - - aborted =3D rxrpc_abort_call(why, call, 0, abort_code, error); - if (aborted) - rxrpc_send_abort_packet(call); - + aborted =3D rxrpc_propose_abort(call, abort_code, error, why); mutex_unlock(&call->user_mutex); return aborted; }