From nobody Fri Sep 19 07:15:44 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93C1BC4167B for ; Sat, 26 Nov 2022 13:35:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229747AbiKZNfh (ORCPT ); Sat, 26 Nov 2022 08:35:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229735AbiKZNfL (ORCPT ); Sat, 26 Nov 2022 08:35:11 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74F5721255 for ; Sat, 26 Nov 2022 05:34:46 -0800 (PST) Date: Sat, 26 Nov 2022 13:34:43 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1669469685; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wRSgG0kiOlTr5n2RtTAcIHAn15ie11sILlgqGJCYQMY=; b=s8ybBptCPDwrmWAyjdt+d3/aJN3WrtpSTR9ECJC5wJXHWuAOhknw9+GXtJicI2R96Zx343 gCPj97A7OZF8fhyinT1IpFtv+Td+NL14yIYB+C2vYYm5+isIXIRWirpKbRRfgvgyBrlpU1 3GjanMe20RMDILUBsYnideMcE3c4uSSdSOhuOJX4sDZDr3HYFWqFa5mKGf3Uae69GU5jTk sYEk1GlrBF6bEYWORddgy78esAanCJGHg8Hw+BQWWEP5yXLUT1n0gMa2cFbUIDWgr8y+gc AayBpWSdG6JcHF6GVrTptf52Qs68zTwwfs8afDO/mKzdCVHXS+OwEqoyvTWWMA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1669469685; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wRSgG0kiOlTr5n2RtTAcIHAn15ie11sILlgqGJCYQMY=; b=QMhyVVnvcrl0tcjdtrlwjdZrnyAaPUXNuhsGu8efofEvZz7evCzEeK41DMzXuJpkckr7h3 fMpQht1qwOgW8rBw== From: "irqchip-bot for Jianmin Lv" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-kernel@vger.kernel.org Subject: [irqchip: irq/irqchip-next] irqchip/loongson-pch-pic: Fix translate callback for DT path Cc: Jianmin Lv , Huacai Chen , Marc Zyngier , tglx@linutronix.de In-Reply-To: <20221022075955.11726-3-lvjianmin@loongson.cn> References: <20221022075955.11726-3-lvjianmin@loongson.cn> MIME-Version: 1.0 Message-ID: <166946968386.4906.165635954561473495.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the irq/irqchip-next branch of ir= qchip: Commit-ID: c7c00138015975c8f0e268564249cc47d8de632c Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-plat= forms/c7c00138015975c8f0e268564249cc47d8de632c Author: Jianmin Lv AuthorDate: Sat, 22 Oct 2022 15:59:53 +08:00 Committer: Marc Zyngier CommitterDate: Sat, 26 Nov 2022 13:05:38=20 irqchip/loongson-pch-pic: Fix translate callback for DT path In DT path of translate callback, if fwspec->param_count=3D=3D1 and of_node is non-null, fwspec->param[1] will be accessed, which is introduced from previous commit bcdd75c596c8 (irqchip/loongson-pch-pic: Add ACPI init support). Before the patch, for non-null of_node, translate callback (use irq_domain_translate_twocell()) will return -EINVAL if fwspec->param_count < 2, so the check in the patch is added. Fixes: bcdd75c596c8 ("irqchip/loongson-pch-pic: Add ACPI init support") Signed-off-by: Jianmin Lv Reviewed-by: Huacai Chen Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20221022075955.11726-3-lvjianmin@loongson.cn --- drivers/irqchip/irq-loongson-pch-pic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/irqchip/irq-loongson-pch-pic.c b/drivers/irqchip/irq-l= oongson-pch-pic.c index c01b9c2..03493cd 100644 --- a/drivers/irqchip/irq-loongson-pch-pic.c +++ b/drivers/irqchip/irq-loongson-pch-pic.c @@ -159,6 +159,9 @@ static int pch_pic_domain_translate(struct irq_domain *= d, return -EINVAL; =20 if (of_node) { + if (fwspec->param_count < 2) + return -EINVAL; + *hwirq =3D fwspec->param[0] + priv->ht_vec_base; *type =3D fwspec->param[1] & IRQ_TYPE_SENSE_MASK; } else {