From nobody Mon Apr 6 11:51:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F41C04A95 for ; Wed, 28 Sep 2022 06:58:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231292AbiI1G6A (ORCPT ); Wed, 28 Sep 2022 02:58:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233302AbiI1G53 (ORCPT ); Wed, 28 Sep 2022 02:57:29 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01BF8861DA; Tue, 27 Sep 2022 23:57:24 -0700 (PDT) Date: Wed, 28 Sep 2022 06:57:21 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1664348242; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YFu7nnk8kMBWwPl8IqyP7zFs+hVguPmywV5EeUtNqpw=; b=4K2MfT1u5yqhpnlmZGdVIKOfHvpX0dVlS5F56tzzK4sOjgLqV8WZ8nXRUUbMLc9H5Sarv2 0CgMtD6SJJ9/EV8J8GpNto7MCE3QuPiIylp7vCXTcSOIPuugsEEsK+9FPuct40kBHcCqai ESItFhhd5KmmzIPhTxSE3/p6WlxR6w0GryG+uc4O3SsTtgUvox2SfalxNMT/dl83PW5HOo 3EPfcpmSlhBt2hlwxKrVhj0Og31wF2UoxtgN5iJQyYR3Ygyhl9ylN7ln07BP4G3HQBhA63 i/dONP5USHwZ7qWoSlUiOKpSjlqq1lDzTWXkTsvHIOgoOWnvnAeyLe6rmdraWA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1664348242; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YFu7nnk8kMBWwPl8IqyP7zFs+hVguPmywV5EeUtNqpw=; b=/f6kngUCsOvIdxGMSVM//dmP1l1Dfc+L6jRu4mBGIHb9IM5gvv3Mkz/svwhFtoCchv3LTs xmkwruj7Br2XrvAQ== From: "tip-bot2 for Namhyung Kim" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: perf/core] perf: Use sample_flags for raw_data Cc: Namhyung Kim , "Peter Zijlstra (Intel)" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20220921220032.2858517-2-namhyung@kernel.org> References: <20220921220032.2858517-2-namhyung@kernel.org> MIME-Version: 1.0 Message-ID: <166434824149.401.4361243714612738808.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the perf/core branch of tip: Commit-ID: 838d9bb62d132ec3baf1b5aba2e95ef9a7a9a3cd Gitweb: https://git.kernel.org/tip/838d9bb62d132ec3baf1b5aba2e95ef9a= 7a9a3cd Author: Namhyung Kim AuthorDate: Wed, 21 Sep 2022 15:00:32 -07:00 Committer: Peter Zijlstra CommitterDate: Tue, 27 Sep 2022 22:50:24 +02:00 perf: Use sample_flags for raw_data Use the new sample_flags to indicate whether the raw data field is filled by the PMU driver. Although it could check with the NULL, follow the same rule with other fields. Remove the raw field from the perf_sample_data_init() to minimize the number of cache lines touched. Signed-off-by: Namhyung Kim Signed-off-by: Peter Zijlstra (Intel) Link: https://lkml.kernel.org/r/20220921220032.2858517-2-namhyung@kernel.org --- arch/s390/kernel/perf_cpum_cf.c | 1 + arch/s390/kernel/perf_pai_crypto.c | 1 + arch/x86/events/amd/ibs.c | 1 + include/linux/perf_event.h | 5 ++--- kernel/events/core.c | 3 ++- 5 files changed, 7 insertions(+), 4 deletions(-) diff --git a/arch/s390/kernel/perf_cpum_cf.c b/arch/s390/kernel/perf_cpum_c= f.c index f7dd3c8..f043a7f 100644 --- a/arch/s390/kernel/perf_cpum_cf.c +++ b/arch/s390/kernel/perf_cpum_cf.c @@ -664,6 +664,7 @@ static int cfdiag_push_sample(struct perf_event *event, raw.frag.data =3D cpuhw->stop; raw.size =3D raw.frag.size; data.raw =3D &raw; + data.sample_flags |=3D PERF_SAMPLE_RAW; } =20 overflow =3D perf_event_overflow(event, &data, ®s); diff --git a/arch/s390/kernel/perf_pai_crypto.c b/arch/s390/kernel/perf_pai= _crypto.c index b38b4ae..6826e2a 100644 --- a/arch/s390/kernel/perf_pai_crypto.c +++ b/arch/s390/kernel/perf_pai_crypto.c @@ -366,6 +366,7 @@ static int paicrypt_push_sample(void) raw.frag.data =3D cpump->save; raw.size =3D raw.frag.size; data.raw =3D &raw; + data.sample_flags |=3D PERF_SAMPLE_RAW; } =20 overflow =3D perf_event_overflow(event, &data, ®s); diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c index ce5720b..c29a006 100644 --- a/arch/x86/events/amd/ibs.c +++ b/arch/x86/events/amd/ibs.c @@ -781,6 +781,7 @@ fail: }, }; data.raw =3D &raw; + data.sample_flags |=3D PERF_SAMPLE_RAW; } =20 /* diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index f4a1357..e9b151c 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -1028,7 +1028,6 @@ struct perf_sample_data { * minimize the cachelines touched. */ u64 sample_flags; - struct perf_raw_record *raw; u64 period; =20 /* @@ -1040,6 +1039,7 @@ struct perf_sample_data { union perf_mem_data_src data_src; u64 txn; u64 addr; + struct perf_raw_record *raw; =20 u64 type; u64 ip; @@ -1078,8 +1078,7 @@ static inline void perf_sample_data_init(struct perf_= sample_data *data, u64 addr, u64 period) { /* remaining struct members initialized in perf_prepare_sample() */ - data->sample_flags =3D 0; - data->raw =3D NULL; + data->sample_flags =3D PERF_SAMPLE_PERIOD; data->period =3D period; =20 if (addr) { diff --git a/kernel/events/core.c b/kernel/events/core.c index a91f74d..04e19a8 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -7332,7 +7332,7 @@ void perf_prepare_sample(struct perf_event_header *he= ader, struct perf_raw_record *raw =3D data->raw; int size; =20 - if (raw) { + if (raw && (data->sample_flags & PERF_SAMPLE_RAW)) { struct perf_raw_frag *frag =3D &raw->frag; u32 sum =3D 0; =20 @@ -7348,6 +7348,7 @@ void perf_prepare_sample(struct perf_event_header *he= ader, frag->pad =3D raw->size - sum; } else { size =3D sizeof(u64); + data->raw =3D NULL; } =20 header->size +=3D size;