From nobody Mon Apr 6 00:29:49 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10327C07E9D for ; Wed, 28 Sep 2022 01:54:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231985AbiI1By3 (ORCPT ); Tue, 27 Sep 2022 21:54:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229692AbiI1By1 (ORCPT ); Tue, 27 Sep 2022 21:54:27 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1D931F01B6 for ; Tue, 27 Sep 2022 18:54:25 -0700 (PDT) Received: from canpemm500010.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4McfYr74rlzHtcy for ; Wed, 28 Sep 2022 09:49:36 +0800 (CST) Received: from localhost.localdomain (10.175.112.70) by canpemm500010.china.huawei.com (7.192.105.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 28 Sep 2022 09:54:24 +0800 From: Wang Yufen To: CC: , Subject: [-next RESEND] fault-injection: using debugfs_create_xul() instead of debugfs_create_xl() Date: Wed, 28 Sep 2022 10:14:59 +0800 Message-ID: <1664331299-4976-1-git-send-email-wangyufen@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.112.70] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500010.china.huawei.com (7.192.105.118) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using debugfs_create_xul() instead of debugfs_create_xl(), and del the local define debugfs_create_xl(). Suggested-by: Akinobu Mita Signed-off-by: Wang Yufen Signed-off-by: Wei Yongjun Reviewed-by: Akinobu Mita --- lib/fault-inject.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/lib/fault-inject.c b/lib/fault-inject.c index 9dd1dd1..dbb5409 100644 --- a/lib/fault-inject.c +++ b/lib/fault-inject.c @@ -185,14 +185,6 @@ static void debugfs_create_ul(const char *name, umode_= t mode, =20 #ifdef CONFIG_FAULT_INJECTION_STACKTRACE_FILTER =20 -DEFINE_SIMPLE_ATTRIBUTE(fops_xl, debugfs_ul_get, debugfs_ul_set, "0x%llx\n= "); - -static void debugfs_create_xl(const char *name, umode_t mode, - struct dentry *parent, unsigned long *value) -{ - debugfs_create_file(name, mode, parent, value, &fops_xl); -} - static int debugfs_stacktrace_depth_set(void *data, u64 val) { *(unsigned long *)data =3D @@ -237,10 +229,10 @@ struct dentry *fault_create_debugfs_attr(const char *= name, #ifdef CONFIG_FAULT_INJECTION_STACKTRACE_FILTER debugfs_create_stacktrace_depth("stacktrace-depth", mode, dir, &attr->stacktrace_depth); - debugfs_create_xl("require-start", mode, dir, &attr->require_start); - debugfs_create_xl("require-end", mode, dir, &attr->require_end); - debugfs_create_xl("reject-start", mode, dir, &attr->reject_start); - debugfs_create_xl("reject-end", mode, dir, &attr->reject_end); + debugfs_create_xul("require-start", mode, dir, &attr->require_start); + debugfs_create_xul("require-end", mode, dir, &attr->require_end); + debugfs_create_xul("reject-start", mode, dir, &attr->reject_start); + debugfs_create_xul("reject-end", mode, dir, &attr->reject_end); #endif /* CONFIG_FAULT_INJECTION_STACKTRACE_FILTER */ =20 attr->dname =3D dget(dir); --=20 1.8.3.1