From nobody Mon Apr 6 00:29:49 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F08C6FA82 for ; Tue, 13 Sep 2022 09:12:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231604AbiIMJMe (ORCPT ); Tue, 13 Sep 2022 05:12:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231247AbiIMJMb (ORCPT ); Tue, 13 Sep 2022 05:12:31 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DBCA57247 for ; Tue, 13 Sep 2022 02:12:30 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id f24so11184173plr.1 for ; Tue, 13 Sep 2022 02:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date; bh=EMAhRQenL2hUdqt4UEMSUYn6VhBs6usk5YM+b/UiubY=; b=QR4h9rBbXfMXwSfowuM29Txd3PECeQyRU2zLkwirxu6Xu2abQFq5FtiBLdiUVEddii +8A5gWBwuLdtY9/rQSRIdnxCGqq1RncDjqrwQFgQaM4jQp5e+M+amJh53VGIK2l2wmbG WOD3z7A+y5uJMimOycIJqQ+zbL03kHZSc8BkgNyjh/PPa0RcIneNj0IMPEfoY0/cHbBL nz0vVzqbxGqoO41lcKrh7cZYZWJRPU535kszr+rvh+Q15W4gTBRCS9bgyi+zeHnNlyfH 4dG1O1MXN/VO2WYWptHTfHKe+EpupAHhZJl/0MnGquj1wi+eJ8nds4FKPXGNcUtR0EtO s45Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=EMAhRQenL2hUdqt4UEMSUYn6VhBs6usk5YM+b/UiubY=; b=JcVqeS8WSekDZdlGezNLCA7m36CPcUwQubmmYtoqFVFvSd6Nxzp/dEjkarvwuQj9Z8 rUbvDqbKKIqvFW02nHqFHqUF8gglNeoyriNzqT+uXlb9PnZLfCEx9+8SS5Fbtjz1Vbph IocDGLpCfZvEG1hV9/BJBU/Hi+cx3/joZMZfFFSH7nXJbmE5be1ZnCkr8c0VFC2GBxtd avBLJa5DZz+qTRYA+Vnr4A7dGXJuJR2i5IV0rBcXnM8nSw7hIoihXBB/I6A/YUOtRWhN Fs4LcojLBWiDNiERz9nmYJVE8J9Vppi1An+Gp6yu51T7ImH9GDmon9iRCTLCK7zDoE9O XX9A== X-Gm-Message-State: ACgBeo13i42P4Bh4EuH6KVamG3/hCImYANUiNZiJW9tIOzy7V+dhwvXH nngjEtbdW0P364V4i8gfiQ== X-Google-Smtp-Source: AA6agR5DxXSkOSzxyXwhhv9jgg+SwSheGvcNYeAQI3G+qRh9y7ZtRQmO490kndDSfsv/LAIvKJD3Fw== X-Received: by 2002:a17:90b:3ec2:b0:202:b123:29cc with SMTP id rm2-20020a17090b3ec200b00202b12329ccmr2974074pjb.167.1663060349560; Tue, 13 Sep 2022 02:12:29 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.3]) by smtp.gmail.com with ESMTPSA id h10-20020a170902680a00b0015e8d4eb1d5sm7804661plk.31.2022.09.13.02.12.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Sep 2022 02:12:28 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH 1/4] mm/damon: simplify the parameter passing for 'prepare_access_checks' Date: Tue, 13 Sep 2022 17:11:24 +0800 Message-Id: <1663060287-30201-2-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1663060287-30201-1-git-send-email-kaixuxia@tencent.com> References: <1663060287-30201-1-git-send-email-kaixuxia@tencent.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Kaixu Xia The parameter 'struct damon_ctx *ctx' isn't used in the functions __damon_{p,v}a_prepare_access_check(), so we can remove it and simplify the parameter passing. Signed-off-by: Kaixu Xia Reviewed-by: SeongJae Park --- mm/damon/paddr.c | 5 ++--- mm/damon/vaddr.c | 6 +++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index 6b0d9e6aa677..f00cbe74a00e 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -63,8 +63,7 @@ static void damon_pa_mkold(unsigned long paddr) folio_put(folio); } =20 -static void __damon_pa_prepare_access_check(struct damon_ctx *ctx, - struct damon_region *r) +static void __damon_pa_prepare_access_check(struct damon_region *r) { r->sampling_addr =3D damon_rand(r->ar.start, r->ar.end); =20 @@ -78,7 +77,7 @@ static void damon_pa_prepare_access_checks(struct damon_c= tx *ctx) =20 damon_for_each_target(t, ctx) { damon_for_each_region(r, t) - __damon_pa_prepare_access_check(ctx, r); + __damon_pa_prepare_access_check(r); } } =20 diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index c2c08c1b316b..39ea48d9cc15 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -397,8 +397,8 @@ static void damon_va_mkold(struct mm_struct *mm, unsign= ed long addr) * Functions for the access checking of the regions */ =20 -static void __damon_va_prepare_access_check(struct damon_ctx *ctx, - struct mm_struct *mm, struct damon_region *r) +static void __damon_va_prepare_access_check(struct mm_struct *mm, + struct damon_region *r) { r->sampling_addr =3D damon_rand(r->ar.start, r->ar.end); =20 @@ -416,7 +416,7 @@ static void damon_va_prepare_access_checks(struct damon= _ctx *ctx) if (!mm) continue; damon_for_each_region(r, t) - __damon_va_prepare_access_check(ctx, mm, r); + __damon_va_prepare_access_check(mm, r); mmput(mm); } } --=20 2.27.0 From nobody Mon Apr 6 00:29:49 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0C60C6FA82 for ; Tue, 13 Sep 2022 09:12:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231622AbiIMJMk (ORCPT ); Tue, 13 Sep 2022 05:12:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231603AbiIMJMe (ORCPT ); Tue, 13 Sep 2022 05:12:34 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AC855A800 for ; Tue, 13 Sep 2022 02:12:32 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id w2so868055pfb.0 for ; Tue, 13 Sep 2022 02:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date; bh=d7BK1Sg/tQCQogt0rSecDlpjX+Yo/gtbxqyxdutICMQ=; b=F5EDu9R9IR0UvjFC7OdCUSJ/Po9JehilOSlp9+qm7VVdD2J1hV+psz6iqpAEFlT+Di iD30oZ7chQAvufHgLDNkrlCALvHSS9mx8LGhOPJwLjL+zVPwGaU1UvVtnavr5pfALoP1 KdU3CPHKbbNmehmOHD9iHUFmJtmk902qR164d3RXk2cqJlMnKHvXpdstz7uai0FfWTMO POou7hnMoIaF2tAgIzD17jkVHYzmBIfo0FyysmCPdcS1T98HqV/EkRJItxexF/L0hrp+ S9o+RtrEmojFyEQZtNlKIcgFLW4FRAgn6BILbJfplteXGBe9u7aSsdDAVfJcJYQc5pD1 JX2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=d7BK1Sg/tQCQogt0rSecDlpjX+Yo/gtbxqyxdutICMQ=; b=WyuoOwwnXG3ek6YMOZVzwdc+ty8Jh3QPoYLLTL0Cnx/vTj1BWAESM4+pUN4wqslIlg ReaHx7Uy5n6uhX7gfhFIUxWoBFzX9p1oKr2PM2GyRN8lK1CYIiDtAcitwhXiCezDiO34 jk86yz9pvoHBSND4uJG3aa0NJEhLjMgSF+swJ34yXeuTq9lLteJ6LDrH+Mldy4qyPcLy gmMVjKQ5FIYsxF8CucRD5zwRokccb0mnBLt9lcRv2LDTazYvKyFZf6xoBML+ZUDkrjP/ 3LQEvHuG74BNIEU8roapZsxkxGpKKBJm0uAeHpxZPQdmCFATd/Og84ucUPW2kCuXQBVs oO7Q== X-Gm-Message-State: ACgBeo33LZSFBhaK0a9dzQqCfBVO8mUPV/HcI9/pLVcXcwzbAjLKcdTZ Pq0uOZxfF1AuWbh2buljZQ== X-Google-Smtp-Source: AA6agR7lkGJ1RnSR3/Tv86EzHnFrYiMd6dvnhbaaQpCNJSHgcCYv8ERsl4HSdAP0dChPa9EOLQ9v2A== X-Received: by 2002:a05:6a00:1704:b0:53b:b450:a51d with SMTP id h4-20020a056a00170400b0053bb450a51dmr31817498pfc.79.1663060351722; Tue, 13 Sep 2022 02:12:31 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.3]) by smtp.gmail.com with ESMTPSA id h10-20020a170902680a00b0015e8d4eb1d5sm7804661plk.31.2022.09.13.02.12.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Sep 2022 02:12:31 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH 2/4] mm/damon/sysfs: simplify the variable 'pid' assignment operation Date: Tue, 13 Sep 2022 17:11:25 +0800 Message-Id: <1663060287-30201-3-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1663060287-30201-1-git-send-email-kaixuxia@tencent.com> References: <1663060287-30201-1-git-send-email-kaixuxia@tencent.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Kaixu Xia We can initialize the variable 'pid' with '-1' in pid_show() to simplify the variable assignment operation and make the code more readable. Signed-off-by: Kaixu Xia Reviewed-by: SeongJae Park --- mm/damon/sysfs.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index da01befae8bd..3606eec9b65d 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -2588,19 +2588,16 @@ static ssize_t pid_show(struct kobject *kobj, struct damon_sysfs_kdamond *kdamond =3D container_of(kobj, struct damon_sysfs_kdamond, kobj); struct damon_ctx *ctx; - int pid; + int pid =3D -1; =20 if (!mutex_trylock(&damon_sysfs_lock)) return -EBUSY; ctx =3D kdamond->damon_ctx; - if (!ctx) { - pid =3D -1; + if (!ctx) goto out; - } + mutex_lock(&ctx->kdamond_lock); - if (!ctx->kdamond) - pid =3D -1; - else + if (ctx->kdamond) pid =3D ctx->kdamond->pid; mutex_unlock(&ctx->kdamond_lock); out: --=20 2.27.0 From nobody Mon Apr 6 00:29:49 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6D1DC6FA82 for ; Tue, 13 Sep 2022 09:12:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231627AbiIMJMo (ORCPT ); Tue, 13 Sep 2022 05:12:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231609AbiIMJMf (ORCPT ); Tue, 13 Sep 2022 05:12:35 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 442245C355 for ; Tue, 13 Sep 2022 02:12:34 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id s206so10760950pgs.3 for ; Tue, 13 Sep 2022 02:12:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date; bh=hx151K56M/3bv6oAI9HhJMBBMiJc3yf10YF7//PgZEk=; b=FPiNmlQPMV6NfeIj+gceFZdllChsvPQx/1lJNqCJqvVP1c58jZuGu813kkSzCyz2hx Tper+kYL1VSI/1saYTXNGGszfUXJw/+hQ49l5F35wUbzN6l3P2fCHgkoHwjUrA/dOrYe KM8zByWZ7tnHjBJt+4FJFDoqMGJ2rOU791TH/tWsF8g2wu/F0qgHUr4YwofAw6sCagNs /zYA5OGN1J2rN2Kvg9qlxnXoC3BXR8vo82K8BZzG10yRyZkz7wyfSMvaDwgGJfWDBNai wR56e95dlv9L9cWF/2Q70PbCH68161V+YbnP/71/BhGm96EC0lGcuqA/94jAnWX5YspB Br0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=hx151K56M/3bv6oAI9HhJMBBMiJc3yf10YF7//PgZEk=; b=NtHMg6xYVO+MyrW/b3BX4TrHYpk8VjUcXle66vQqGeYUzsWf05Tsi7Rpy4SAg4vWnb 2KNos02WGECRMMXA5O1tDXm0aTy0c8VWh+CDLJma4QrNtxrLU8YZvu1o3VZWkIGZeqVT kI44PSfjSV+3HTIyO7CLzhufz4q9RSEwqqvkf+fpFIYYfcjK55uiQCHCsVtiv1xsWj1q AQT4zAeeaf1qxKIyOqjN5yUmFPMtYAwF9hWwIV/hIhi6XFs3CqNZPO1p+1r7BKkbxRAv +LKJs/tLEWiXWiKlfm8ZpjKDwJtQlgvkd3QkXTKN3Ltd1qAX6wQmMO9ofDe6c+P61qPl X29w== X-Gm-Message-State: ACgBeo1BSBhwCk+jHNxvDXU9YyQIh1a85eDBiLDIT0fUI2HCFHXtjgBq gy8zXpItxNyzemAAioCh9w== X-Google-Smtp-Source: AA6agR5+BtVH+Z9KVlL41Vvl5mVJIMp8QHiYV3uVzGpz9IGkyui/fsI188gxmT54nqYnyGte46kSbg== X-Received: by 2002:a62:2503:0:b0:538:426a:af11 with SMTP id l3-20020a622503000000b00538426aaf11mr32167439pfl.22.1663060353757; Tue, 13 Sep 2022 02:12:33 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.3]) by smtp.gmail.com with ESMTPSA id h10-20020a170902680a00b0015e8d4eb1d5sm7804661plk.31.2022.09.13.02.12.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Sep 2022 02:12:33 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH 3/4] mm/damon/core: simplify the kdamond stop mechanism by removing 'done' Date: Tue, 13 Sep 2022 17:11:26 +0800 Message-Id: <1663060287-30201-4-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1663060287-30201-1-git-send-email-kaixuxia@tencent.com> References: <1663060287-30201-1-git-send-email-kaixuxia@tencent.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Kaixu Xia When the 'kdamond_wait_activation()' function or 'after_sampling()' or 'after_aggregation()' DAMON callbacks return an error, it is unnecessary to use bool 'done' to check if kdamond should be finished. This commit simplifies the kdamond stop mechanism by removing 'done' and break the while loop directly in the cases. Signed-off-by: Kaixu Xia Reviewed-by: SeongJae Park --- mm/damon/core.c | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index 0b1eb945c68a..4ce860af70ec 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -1165,30 +1165,25 @@ static int kdamond_fn(void *data) struct damon_region *r, *next; unsigned int max_nr_accesses =3D 0; unsigned long sz_limit =3D 0; - bool done =3D false; =20 pr_debug("kdamond (%d) starts\n", current->pid); =20 if (ctx->ops.init) ctx->ops.init(ctx); if (ctx->callback.before_start && ctx->callback.before_start(ctx)) - done =3D true; + goto done; =20 sz_limit =3D damon_region_sz_limit(ctx); =20 - while (!kdamond_need_stop(ctx) && !done) { - if (kdamond_wait_activation(ctx)) { - done =3D true; - continue; - } + while (!kdamond_need_stop(ctx)) { + if (kdamond_wait_activation(ctx)) + break; =20 if (ctx->ops.prepare_access_checks) ctx->ops.prepare_access_checks(ctx); if (ctx->callback.after_sampling && - ctx->callback.after_sampling(ctx)) { - done =3D true; - continue; - } + ctx->callback.after_sampling(ctx)) + break; =20 kdamond_usleep(ctx->sample_interval); =20 @@ -1200,10 +1195,8 @@ static int kdamond_fn(void *data) max_nr_accesses / 10, sz_limit); if (ctx->callback.after_aggregation && - ctx->callback.after_aggregation(ctx)) { - done =3D true; - continue; - } + ctx->callback.after_aggregation(ctx)) + break; kdamond_apply_schemes(ctx); kdamond_reset_aggregated(ctx); kdamond_split_regions(ctx); @@ -1217,6 +1210,7 @@ static int kdamond_fn(void *data) sz_limit =3D damon_region_sz_limit(ctx); } } +done: damon_for_each_target(t, ctx) { damon_for_each_region_safe(r, next, t) damon_destroy_region(r, t); --=20 2.27.0 From nobody Mon Apr 6 00:29:49 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8877AC54EE9 for ; Tue, 13 Sep 2022 09:12:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231638AbiIMJMw (ORCPT ); Tue, 13 Sep 2022 05:12:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231611AbiIMJMh (ORCPT ); Tue, 13 Sep 2022 05:12:37 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60BF55A800 for ; Tue, 13 Sep 2022 02:12:36 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id q62-20020a17090a17c400b00202a3497516so8387119pja.1 for ; Tue, 13 Sep 2022 02:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date; bh=RludiuXI04g98bb6hCOo/Y+uQHagYxl6mhzM1wptlJE=; b=ZziSErcgXFTobtgN4y5qbgv8tURNEb5sxc0isyqeQJfLoU0RVzXarfIlNoeDn5ElEx l8gU5Xg2lvH0gIdizMMxc0mXyNlZJnn92OaJNh6aJdoe8Qf+EtKJz1nFD+Kdy96RVfSl EtJBEV9RCQrEydMLHeBhCUKUVSvkGeGfWU1cQXw0ghtjLKRiuxq00frbiw6pAKvomMBT FDg/8PJotaxvkLOYrix15q3LSA9jyJN/Ot++L4/Tx8+9GhOqtlTM/3myg+YkyOZ7+OTp 6kZwlU3F5WjuWtZYCvGk3HfP8dOw2inqKcgsVGJqnd5GoDycJbIzD8ZhsTH0mfqxULTC 2//Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date; bh=RludiuXI04g98bb6hCOo/Y+uQHagYxl6mhzM1wptlJE=; b=3ed6c0W4nuxPQRaidEc67ruao7g9sy8Kh0inePl6VKyVooeNSanDORNv4q2lkutJ94 j5ns9sJFHJXIxkbn9lvoTrnIwY49fKqO4MOcm7rzrbSJuvdZZe8ensJqvZK0zRm4aV18 WY7TnxFh9YE/wejHZpxvvjyPze0hgDxedq+QHsn7h8jsb5QECKxbGDGzIx1w5yhnQtPN jnweNX+nqinK0/LlUg88/Mcpw8pWKfVv4e1Gixr7dKJfXRDu+lkdqoLUiUqt8ZyRXSyK iLeW4fh7CiF0uIt+fsK8/Tiv8SmzKE1CYgCj8r3yn/kOHgMNhbEVKFOy2wXsJ0fYG0xg iTsg== X-Gm-Message-State: ACgBeo3IzVpNky5VWlsQSSBCNwGje1JeV6c1HR1UYKWWxuR9VAsra+Bk FWneSwfJeX4uxH1MvxbHmw== X-Google-Smtp-Source: AA6agR5fkOMWeikIf2G4s+cnzgehLhSEMVAMumnMknm+iaDNywQoKQy3BUN6M0oQGYLVlkC5XlHvHg== X-Received: by 2002:a17:903:22c9:b0:178:18a1:d170 with SMTP id y9-20020a17090322c900b0017818a1d170mr17125135plg.2.1663060355904; Tue, 13 Sep 2022 02:12:35 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.3]) by smtp.gmail.com with ESMTPSA id h10-20020a170902680a00b0015e8d4eb1d5sm7804661plk.31.2022.09.13.02.12.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Sep 2022 02:12:35 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH 4/4] mm/damon/vaddr: indicate the target is invalid when 'nr_regions' is zero Date: Tue, 13 Sep 2022 17:11:27 +0800 Message-Id: <1663060287-30201-5-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1663060287-30201-1-git-send-email-kaixuxia@tencent.com> References: <1663060287-30201-1-git-send-email-kaixuxia@tencent.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Kaixu Xia When 'init()' and 'update()' DAMON operations failed and the number of the damon_target regions is zero, the kdamond would do nothing to this monitoring target in this case. It makes no sense to run kdamond when all of monitoring targets have no regions. So add the judgement in 'target_valid()' operation to indicate the target is invalid when 'nr_regions' is zero. Signed-off-by: Kaixu Xia Reviewed-by: SeongJae Park --- mm/damon/vaddr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index 39ea48d9cc15..65ff98d49ec0 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -598,6 +598,9 @@ static bool damon_va_target_valid(void *target) struct damon_target *t =3D target; struct task_struct *task; =20 + if (!damon_nr_regions(t)) + return false; + task =3D damon_get_task_struct(t); if (task) { put_task_struct(task); --=20 2.27.0