From nobody Sat Sep 21 17:43:19 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1130DECAAD5 for ; Mon, 5 Sep 2022 13:54:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237097AbiIENyJ (ORCPT ); Mon, 5 Sep 2022 09:54:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236740AbiIENyH (ORCPT ); Mon, 5 Sep 2022 09:54:07 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 796E058B4D for ; Mon, 5 Sep 2022 06:54:04 -0700 (PDT) X-UUID: f13ff5aed6fd4b07b2ef54aa705b65bc-20220905 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=lGdHgBDZ1zzn0pii7JJeVx/yeyEN3AsCvLFo305J2p8=; b=sHkyjHZE4TIF9KKX4NMkJOHanodcfvAzU1J0chujkGiBv8CvhJZvhddjyajk1OsONn3ZU1f9fvTJJvcC//gYFYb9nB9J7xljTnJvcURodIk+UNjmbfLr3pWR9U+zRtE2yZzN0QVaL/Hnx9FQU+4vU5tO0Zsv7MSIkhDztIJ8+EY=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.10,REQID:a9827fc7-1c6b-4ecb-80b8-d072ba745e41,OB:0,L OB:0,IP:0,URL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release _Ham,ACTION:release,TS:-5 X-CID-META: VersionHash:84eae18,CLOUDID:853a3c21-1c20-48a5-82a0-25f9c331906d,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: f13ff5aed6fd4b07b2ef54aa705b65bc-20220905 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1818427845; Mon, 05 Sep 2022 21:53:58 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Mon, 5 Sep 2022 21:53:57 +0800 Received: from mszsdaap41.gcn.mediatek.inc (10.16.6.141) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 5 Sep 2022 21:53:56 +0800 From: To: , , , , , CC: , , , , , Xinlei Lee Subject: [PATCH] drm: mediatek: Modify dpi power on/off sequence. Date: Mon, 5 Sep 2022 21:53:53 +0800 Message-ID: <1662386033-4463-1-git-send-email-xinlei.lee@mediatek.com> X-Mailer: git-send-email 2.6.4 MIME-Version: 1.0 X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Xinlei Lee Modify dpi power on/off sequence so that the first gpio operation will take= effect. Fixes: 6bd4763fd532 ("drm/mediatek: set dpi pin mode to gpio low to avoid l= eakage current") Signed-off-by: Xinlei Lee --- Base on the branch of Linux-next/master. Because dpi power_on/off is protected by dpi->refcount, the first time it cannot be powered on and off successfully, it will cause leakage. --- --- drivers/gpu/drm/mediatek/mtk_dpi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/= mtk_dpi.c index 630a4e301ef6..2ce1a39ce3bf 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -462,9 +462,6 @@ static void mtk_dpi_power_off(struct mtk_dpi *dpi) if (--dpi->refcount !=3D 0) return; =20 - if (dpi->pinctrl && dpi->pins_gpio) - pinctrl_select_state(dpi->pinctrl, dpi->pins_gpio); - mtk_dpi_disable(dpi); clk_disable_unprepare(dpi->pixel_clk); clk_disable_unprepare(dpi->engine_clk); @@ -489,9 +486,6 @@ static int mtk_dpi_power_on(struct mtk_dpi *dpi) goto err_pixel; } =20 - if (dpi->pinctrl && dpi->pins_dpi) - pinctrl_select_state(dpi->pinctrl, dpi->pins_dpi); - return 0; =20 err_pixel: @@ -721,6 +715,9 @@ static void mtk_dpi_bridge_disable(struct drm_bridge *b= ridge) { struct mtk_dpi *dpi =3D bridge_to_dpi(bridge); =20 + if (dpi->pinctrl && dpi->pins_gpio) + pinctrl_select_state(dpi->pinctrl, dpi->pins_gpio); + mtk_dpi_power_off(dpi); } =20 @@ -728,6 +725,9 @@ static void mtk_dpi_bridge_enable(struct drm_bridge *br= idge) { struct mtk_dpi *dpi =3D bridge_to_dpi(bridge); =20 + if (dpi->pinctrl && dpi->pins_dpi) + pinctrl_select_state(dpi->pinctrl, dpi->pins_dpi); + mtk_dpi_power_on(dpi); mtk_dpi_set_display_mode(dpi, &dpi->mode); mtk_dpi_enable(dpi); --=20 2.18.0