From nobody Tue Apr 7 10:39:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04E93ECAAD2 for ; Mon, 29 Aug 2022 09:47:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229484AbiH2JrL (ORCPT ); Mon, 29 Aug 2022 05:47:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbiH2JrJ (ORCPT ); Mon, 29 Aug 2022 05:47:09 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E898C2CCB8 for ; Mon, 29 Aug 2022 02:47:08 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id q3so4217524pjg.3 for ; Mon, 29 Aug 2022 02:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:subject:cc:to:from:from:to:cc; bh=WCWvh4lo94fZ8ZBFtAu0Nlm75Eg+DNVgcN8RUJinllU=; b=J+GEvp1aNPQ/lMGxZ0Ih9OYwR550sY4wPsU1jBeRdYWP/H+pKXR/pLdWbS8IR8qw0o VCr18L8cQyRIk2fNPQIfw+rthUV7UGn6+hmid/1BKMJvt4Dc77I3BFdZOD0rEM6fFUJH mSpVhr+pdZbJoz7tibho8YlpMgWcZvWGRK+SGjJeiImU6oDEBmlFpXjpvw3OLJAG5XLj 79pgQLdLl1+yXALQKgMjdFoGrooq8BLs+WfNC5B7zUr/ZNrQhXFLwybTjyEZxxckcLqw 1PtHM2JIgoGjqXomZ1JLEFd+Bp4VPrC3hWPFXGJ7lGAWiuQKyFLuUq6x4Y5MSR4FG5pU LY8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=WCWvh4lo94fZ8ZBFtAu0Nlm75Eg+DNVgcN8RUJinllU=; b=uN947XvddQibg0YFgj3SKwtzIWR7uitqTlJiSjW+WSI08/RYZh2b+LQKIX9qH+2y8N SR8D9TAY/nfPK1B+UFqIdRZU1v+F4d7VGtEbwCrwK5X5347NkHw0ON8zVxDv0olMRtbe TUEQuE0rvia+lQkcRZ//wJYbj3a87azh3pilYoepQ/F8IMOC1/kuaYROia/IcuciA9ZY vdM5OFjZsiHuCYBC9KDnld+gAppSc9UPnsOAajCb8Wr8hqiiNsepeeVGcymyRCUmfkJY CPgFHWmVJtZk2QvXJNql7xHZlok84U9nySGCiN2KTF5epUyUUotzFszgbcWDzM2FbKgG FH6A== X-Gm-Message-State: ACgBeo0zUMoRur6SZTiqFle5MbRPO8/c4dKYc0jcfoqkGZtriQWdzY5+ ZGdWtDimvqWr25hXMSS7xkgp6pxUfOYO X-Google-Smtp-Source: AA6agR4UHapZ8kLe3GaRmB8rX3Cc88S3xMaDmHkYryxb9UGyCfBRhCVfinlNXxAKKiBApXkhoNieUg== X-Received: by 2002:a17:903:18a:b0:16f:e43:efdf with SMTP id z10-20020a170903018a00b0016f0e43efdfmr15514244plg.157.1661766428407; Mon, 29 Aug 2022 02:47:08 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.4]) by smtp.gmail.com with ESMTPSA id p3-20020a1709028a8300b00162529828aesm6967306plo.109.2022.08.29.02.47.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Aug 2022 02:47:07 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH] mm/damon: get the hotness from damon_hot_score() in damon_pageout_score() Date: Mon, 29 Aug 2022 17:46:06 +0800 Message-Id: <1661766366-20998-1-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Kaixu Xia We can get the hotness value from damon_hot_score() directly in damon_pageout_score() function and improve the code readability. Signed-off-by: Kaixu Xia Reviewed-by: SeongJae Park --- mm/damon/ops-common.c | 46 ++++++------------------------------------- 1 file changed, 6 insertions(+), 40 deletions(-) diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c index b1335de200e7..f599838b5f64 100644 --- a/mm/damon/ops-common.c +++ b/mm/damon/ops-common.c @@ -88,7 +88,7 @@ void damon_pmdp_mkold(pmd_t *pmd, struct mm_struct *mm, u= nsigned long addr) #define DAMON_MAX_SUBSCORE (100) #define DAMON_MAX_AGE_IN_LOG (32) =20 -int damon_pageout_score(struct damon_ctx *c, struct damon_region *r, +int damon_hot_score(struct damon_ctx *c, struct damon_region *r, struct damos *s) { unsigned int max_nr_accesses; @@ -127,48 +127,14 @@ int damon_pageout_score(struct damon_ctx *c, struct d= amon_region *r, */ hotness =3D hotness * DAMOS_MAX_SCORE / DAMON_MAX_SUBSCORE; =20 - /* Return coldness of the region */ - return DAMOS_MAX_SCORE - hotness; + return hotness; } =20 -int damon_hot_score(struct damon_ctx *c, struct damon_region *r, +int damon_pageout_score(struct damon_ctx *c, struct damon_region *r, struct damos *s) { - unsigned int max_nr_accesses; - int freq_subscore; - unsigned int age_in_sec; - int age_in_log, age_subscore; - unsigned int freq_weight =3D s->quota.weight_nr_accesses; - unsigned int age_weight =3D s->quota.weight_age; - int hotness; - - max_nr_accesses =3D c->aggr_interval / c->sample_interval; - freq_subscore =3D r->nr_accesses * DAMON_MAX_SUBSCORE / max_nr_accesses; + int hotness =3D damon_hot_score(c, r, s); =20 - age_in_sec =3D (unsigned long)r->age * c->aggr_interval / 1000000; - for (age_in_log =3D 0; age_in_log < DAMON_MAX_AGE_IN_LOG && age_in_sec; - age_in_log++, age_in_sec >>=3D 1) - ; - - /* If frequency is 0, higher age means it's colder */ - if (freq_subscore =3D=3D 0) - age_in_log *=3D -1; - - /* - * Now age_in_log is in [-DAMON_MAX_AGE_IN_LOG, DAMON_MAX_AGE_IN_LOG]. - * Scale it to be in [0, 100] and set it as age subscore. - */ - age_in_log +=3D DAMON_MAX_AGE_IN_LOG; - age_subscore =3D age_in_log * DAMON_MAX_SUBSCORE / - DAMON_MAX_AGE_IN_LOG / 2; - - hotness =3D (freq_weight * freq_subscore + age_weight * age_subscore); - if (freq_weight + age_weight) - hotness /=3D freq_weight + age_weight; - /* - * Transform it to fit in [0, DAMOS_MAX_SCORE] - */ - hotness =3D hotness * DAMOS_MAX_SCORE / DAMON_MAX_SUBSCORE; - - return hotness; + /* Return coldness of the region */ + return DAMOS_MAX_SCORE - hotness; } --=20 2.27.0