From nobody Wed Apr 8 06:08:43 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFFFCC32772 for ; Tue, 23 Aug 2022 17:01:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343759AbiHWRAU (ORCPT ); Tue, 23 Aug 2022 13:00:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343658AbiHWQ7m (ORCPT ); Tue, 23 Aug 2022 12:59:42 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7557D9E88B for ; Tue, 23 Aug 2022 07:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661263981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hvJBDnayJvUqadukdvJ+aiDopuGVk3vgU1r1hwgbino=; b=CiHda9nDDfnvrKucWCwRW2VKpx2sHIcUJj29viixzydJpYJSsCK4nepgvkpZTRVRLngV3v wJ86pz5hjk1cyLc14VC83JdLIL9SrIaS8Mfv63B+Eo3M962MWzoM3AW+VJ6Grn2fNhRF7P HLLwAldkoI97SRsEH9oTlwamX1zwK4Q= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-500-yYU6UjgkMmaDtPw6gXNbxw-1; Tue, 23 Aug 2022 10:12:58 -0400 X-MC-Unique: yYU6UjgkMmaDtPw6gXNbxw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EC50D38005CA; Tue, 23 Aug 2022 14:12:57 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB5BF2026D4C; Tue, 23 Aug 2022 14:12:56 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [PATCH 7/7] cifs: Add some RDMA send tracepoints From: David Howells To: Steve French , Al Viro Cc: dhowells@redhat.com, Shyam Prasad N , Rohith Surabattula , Jeff Layton , linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 23 Aug 2022 15:12:56 +0100 Message-ID: <166126397621.708021.17666049570505935252.stgit@warthog.procyon.org.uk> In-Reply-To: <166126392703.708021.14465850073772688008.stgit@warthog.procyon.org.uk> References: <166126392703.708021.14465850073772688008.stgit@warthog.procyon.org.uk> User-Agent: StGit/1.5 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add some tracepoints to help trace RDMA in cifs. Signed-off-by: David Howells --- fs/cifs/smbdirect.c | 15 +++++++- fs/cifs/trace.h | 95 +++++++++++++++++++++++++++++++++++++++++++++++= ++++ 2 files changed, 108 insertions(+), 2 deletions(-) diff --git a/fs/cifs/smbdirect.c b/fs/cifs/smbdirect.c index 578c24d5a941..711beb3722e3 100644 --- a/fs/cifs/smbdirect.c +++ b/fs/cifs/smbdirect.c @@ -1945,6 +1945,8 @@ static ssize_t smbd_post_send_iter_scanner(struct iov= _iter *iter, const void *p, ctx->len +=3D len; log_write(INFO, "sending page i=3D%d offset=3D%zu size=3D%zu remaining_da= ta_length=3D%d\n", ix, offset, len, *ctx->_remaining_data_length); + trace_smb3_rdma_page(ctx->num_rqst, ctx->rqst_idx, ix, offset, len, + iov_iter_count(iter), *ctx->_remaining_data_length); *ctx->_remaining_data_length -=3D len; ctx->nsg++; return len; @@ -2043,19 +2045,27 @@ int smbd_send(struct TCP_Server_Info *server, klen +=3D rqst->rq_iov[i].iov_len; iov_iter_kvec(&iter, WRITE, rqst->rq_iov, rqst->rq_nvec, klen); =20 + trace_smb3_rdma_send(num_rqst, rqst_idx, rqst->rq_nvec, klen, + iov_iter_count(&rqst->rq_iter), remaining_data_length); + rc =3D smbd_post_send_iter(info, &iter, num_rqst, rqst_idx, &remaining_data_length); - if (rc < 0) + if (rc < 0) { + trace_smb3_rdma_fail(num_rqst, rqst_idx, 1, rc); goto done; + } =20 if (iov_iter_count(&rqst->rq_iter) > 0) { /* And then the data pages if there are any */ rc =3D smbd_post_send_iter(info, &rqst->rq_iter, num_rqst, rqst_idx, &remaining_data_length); - if (rc < 0) + if (rc < 0) { + trace_smb3_rdma_fail(num_rqst, rqst_idx, 2, rc); goto done; + } } =20 + trace_smb3_rdma_done(num_rqst, rqst_idx, 3); rqst_idx++; if (rqst_idx < num_rqst) goto next_rqst; @@ -2282,6 +2292,7 @@ static ssize_t smbd_iter_to_mr_scanner(struct iov_ite= r *iter, const void *p, sg_set_buf(&ctx->sgl[ix], p, len); log_write(INFO, "sending page i=3D%d offset=3D%zu size=3D%zu\n", ix, offset, len); + trace_smb3_rdma_page(0, 0, ix, offset, len, iov_iter_count(iter), 0); ctx->nsg++; return len; } diff --git a/fs/cifs/trace.h b/fs/cifs/trace.h index 6b88dc2e364f..70640232b572 100644 --- a/fs/cifs/trace.h +++ b/fs/cifs/trace.h @@ -1055,6 +1055,101 @@ DEFINE_SMB3_CREDIT_EVENT(waitff_credits); DEFINE_SMB3_CREDIT_EVENT(overflow_credits); DEFINE_SMB3_CREDIT_EVENT(set_credits); =20 +TRACE_EVENT(smb3_rdma_send, + TP_PROTO(unsigned int nr_rqst, unsigned int sub_rqst, + unsigned int nr_kvec, unsigned int kvec_len, + unsigned int iter_len, unsigned int remaining_len), + TP_ARGS(nr_rqst, sub_rqst, nr_kvec, kvec_len, iter_len, remaining_len= ), + TP_STRUCT__entry( + __field(u8, nr_rqst) + __field(u8, sub_rqst) + __field(u8, nr_kvec) + __field(unsigned int, kvec_len) + __field(unsigned int, iter_len) + __field(unsigned int, remaining_len) + ), + TP_fast_assign( + __entry->nr_rqst =3D nr_rqst; + __entry->sub_rqst =3D sub_rqst; + __entry->nr_kvec =3D nr_kvec; + __entry->kvec_len =3D kvec_len; + __entry->iter_len =3D iter_len; + __entry->remaining_len =3D remaining_len; + ), + TP_printk("nrq=3D%u/%u nkv=3D%u kvl=3D%u iter=3D%u rem=3D%u", + __entry->sub_rqst + 1, __entry->nr_rqst, + __entry->nr_kvec, __entry->kvec_len, + __entry->iter_len, __entry->remaining_len) + ) + +TRACE_EVENT(smb3_rdma_page, + TP_PROTO(unsigned int nr_rqst, unsigned int sub_rqst, + unsigned int i, size_t offset, ssize_t len, + unsigned int iter_len, unsigned int remaining_len), + TP_ARGS(nr_rqst, sub_rqst, i, offset, len, iter_len, remaining_len), + TP_STRUCT__entry( + __field(u8, nr_rqst) + __field(u8, sub_rqst) + __field(unsigned int, iter_len) + __field(unsigned int, remaining_len) + __field(unsigned int, i) + __field(size_t, offset) + __field(ssize_t, len) + ), + TP_fast_assign( + __entry->nr_rqst =3D nr_rqst; + __entry->sub_rqst =3D sub_rqst; + __entry->i =3D i; + __entry->offset =3D offset; + __entry->len =3D len; + __entry->iter_len =3D iter_len; + __entry->remaining_len =3D remaining_len; + ), + TP_printk("nrq=3D%u/%u pg=3D%u o=3D%zx l=3D%zx iter=3D%u rem=3D%u", + __entry->sub_rqst + 1, __entry->nr_rqst, + __entry->i, __entry->offset, __entry->len, + __entry->iter_len, __entry->remaining_len) + ) + +TRACE_EVENT(smb3_rdma_done, + TP_PROTO(unsigned int nr_rqst, unsigned int sub_rqst, + unsigned int where), + TP_ARGS(nr_rqst, sub_rqst, where), + TP_STRUCT__entry( + __field(u8, nr_rqst) + __field(u8, sub_rqst) + __field(u8, where) + ), + TP_fast_assign( + __entry->nr_rqst =3D nr_rqst; + __entry->sub_rqst =3D sub_rqst; + __entry->where =3D where; + ), + TP_printk("nrq=3D%u/%u where=3D%u", + __entry->sub_rqst + 1, __entry->nr_rqst, __entry->where) + ) + +TRACE_EVENT(smb3_rdma_fail, + TP_PROTO(unsigned int nr_rqst, unsigned int sub_rqst, + unsigned int where, int rc), + TP_ARGS(nr_rqst, sub_rqst, where, rc), + TP_STRUCT__entry( + __field(u8, nr_rqst) + __field(u8, sub_rqst) + __field(u8, where) + __field(short, rc) + ), + TP_fast_assign( + __entry->nr_rqst =3D nr_rqst; + __entry->sub_rqst =3D sub_rqst; + __entry->where =3D where; + __entry->rc =3D rc; + ), + TP_printk("nrq=3D%u/%u where=3D%u rc=3D%d", + __entry->sub_rqst + 1, __entry->nr_rqst, + __entry->where, __entry->rc) + ) + #endif /* _CIFS_TRACE_H */ =20 #undef TRACE_INCLUDE_PATH