From nobody Mon Apr 13 11:57:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6565BC2BB41 for ; Tue, 16 Aug 2022 06:51:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231183AbiHPGvo (ORCPT ); Tue, 16 Aug 2022 02:51:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230521AbiHPGvG (ORCPT ); Tue, 16 Aug 2022 02:51:06 -0400 Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 78023107AF5 for ; Mon, 15 Aug 2022 19:01:40 -0700 (PDT) Received: from localhost.localdomain.localdomain (unknown [10.2.5.46]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxReJ7+vpiKy8CAA--.12277S3; Tue, 16 Aug 2022 10:01:32 +0800 (CST) From: Jianmin Lv To: Thomas Gleixner , Marc Zyngier Cc: linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, Jiaxun Yang , Huacai Chen Subject: [PATCH V1 1/2] irqchip/loongson-pch-pic: Support to set irq type for ACPI path Date: Tue, 16 Aug 2022 10:01:30 +0800 Message-Id: <1660615291-35409-2-git-send-email-lvjianmin@loongson.cn> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1660615291-35409-1-git-send-email-lvjianmin@loongson.cn> References: <1660615291-35409-1-git-send-email-lvjianmin@loongson.cn> X-CM-TRANSID: AQAAf8DxReJ7+vpiKy8CAA--.12277S3 X-Coremail-Antispam: 1UD129KBjvJXoW7Ar47XF1xCF4UuF1xWrWDtwb_yoW8CrWxpF WYv3y3Aw4xJF17Cr95Cw48WFy3AwnxtFW7KF4Fy3W2grsrGrZYk3W7uFyrXrnrZF43AF42 9rnYvFWUG3W7ZF7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkKb7Iv0xC_Kw4lb4IE77IF4wAFc2x0x2IEx4CE42xK8VAvwI8I cIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2 AK021l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v2 6r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267 AKxVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lc2xSY4AK6svPMxAIw28IcxkI7VAKI48JMxAI w28IcVCjz48v1sIEY20_XrWUJr1UMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrV AFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCI c40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267 AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_ Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU56c_D UUUUU== X-CM-SenderInfo: 5oymxthqpl0qxorr0wxvrqhubq/ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" For ACPI path, the translate callback used IRQ_TYPE_NONE and ignored the irq type in fwspec->param[1]. For supporting to set type for irqs of the irqdomain, fwspec->param[1] should be used to get irq type. On Loongson platform, the irq trigger type of PCI devices is high level, so high level triggered type is inputed to acpi_register_gsi when create irq mapping for PCI devices. Signed-off-by: Jianmin Lv --- drivers/acpi/pci_irq.c | 3 ++- drivers/irqchip/irq-loongson-pch-pic.c | 10 ++++++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c index 08e1577..34483b3 100644 --- a/drivers/acpi/pci_irq.c +++ b/drivers/acpi/pci_irq.c @@ -393,7 +393,8 @@ int acpi_pci_irq_enable(struct pci_dev *dev) * controller and must therefore be considered active high * as default. */ - int polarity =3D acpi_irq_model =3D=3D ACPI_IRQ_MODEL_GIC ? + int polarity =3D acpi_irq_model =3D=3D ACPI_IRQ_MODEL_GIC || + acpi_irq_model =3D=3D ACPI_IRQ_MODEL_LPIC ? ACPI_ACTIVE_HIGH : ACPI_ACTIVE_LOW; char *link =3D NULL; char link_desc[16]; diff --git a/drivers/irqchip/irq-loongson-pch-pic.c b/drivers/irqchip/irq-l= oongson-pch-pic.c index b6f1392..5067010 100644 --- a/drivers/irqchip/irq-loongson-pch-pic.c +++ b/drivers/irqchip/irq-loongson-pch-pic.c @@ -177,13 +177,15 @@ static int pch_pic_domain_translate(struct irq_domain= *d, if (fwspec->param_count < 1) return -EINVAL; =20 - if (of_node) { + if (of_node) *hwirq =3D fwspec->param[0] + priv->ht_vec_base; - *type =3D fwspec->param[1] & IRQ_TYPE_SENSE_MASK; - } else { + else *hwirq =3D fwspec->param[0] - priv->gsi_base; + + if (fwspec->param_count > 1) + *type =3D fwspec->param[1] & IRQ_TYPE_SENSE_MASK; + else *type =3D IRQ_TYPE_NONE; - } =20 return 0; } --=20 1.8.3.1 From nobody Mon Apr 13 11:57:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE9DFC2BB41 for ; Tue, 16 Aug 2022 06:51:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229962AbiHPGvu (ORCPT ); Tue, 16 Aug 2022 02:51:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231128AbiHPGvH (ORCPT ); Tue, 16 Aug 2022 02:51:07 -0400 Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D89CA107AFA for ; Mon, 15 Aug 2022 19:01:40 -0700 (PDT) Received: from localhost.localdomain.localdomain (unknown [10.2.5.46]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxReJ7+vpiKy8CAA--.12277S4; Tue, 16 Aug 2022 10:01:32 +0800 (CST) From: Jianmin Lv To: Thomas Gleixner , Marc Zyngier Cc: linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, Jiaxun Yang , Huacai Chen Subject: [PATCH V1 2/2] irqchip/loongson-liointc: Support to set irq type for ACPI path Date: Tue, 16 Aug 2022 10:01:31 +0800 Message-Id: <1660615291-35409-3-git-send-email-lvjianmin@loongson.cn> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1660615291-35409-1-git-send-email-lvjianmin@loongson.cn> References: <1660615291-35409-1-git-send-email-lvjianmin@loongson.cn> X-CM-TRANSID: AQAAf8DxReJ7+vpiKy8CAA--.12277S4 X-Coremail-Antispam: 1UD129KBjvdXoW7JrWUCF17WFW5CFy5Zw4UCFg_yoWfKrX_Cr WI93Z3Ga4rZF1xJr97uw1jvryI9FWkW3WkuF45uasIv3y8X347urW7Zw13Ja97Kr10vF93 AF4F9rySka42yjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb4kYjsxI4VWkCwAYFVCjjxCrM7CY07I20VC2zVCF04k26cxKx2IY s7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4 kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_ Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14 v26r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2 j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7x kEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCY02Avz4vE-syl42xK82IYc2Ij64vIr41l42xK 82IY6x8ErcxFaVAv8VW5Wr1UJr1l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67 AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIY rxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14 v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8 JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxU2xR6UU UUU X-CM-SenderInfo: 5oymxthqpl0qxorr0wxvrqhubq/ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" For ACPI path, the xlate callback used IRQ_TYPE_NONE and ignored the irq type in intspec[1]. For supporting to set type for irqs of the irqdomain, intspec[1] should be used to get irq type. Signed-off-by: Jianmin Lv --- drivers/irqchip/irq-loongson-liointc.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-loongson-liointc.c b/drivers/irqchip/irq-l= oongson-liointc.c index c4f3c886a..24755537 100644 --- a/drivers/irqchip/irq-loongson-liointc.c +++ b/drivers/irqchip/irq-loongson-liointc.c @@ -167,7 +167,12 @@ static int liointc_domain_xlate(struct irq_domain *d, = struct device_node *ctrlr, if (WARN_ON(intsize < 1)) return -EINVAL; *out_hwirq =3D intspec[0] - GSI_MIN_CPU_IRQ; - *out_type =3D IRQ_TYPE_NONE; + + if (intsize > 1) + *out_type =3D intspec[1] & IRQ_TYPE_SENSE_MASK; + else + *out_type =3D IRQ_TYPE_NONE; + return 0; } =20 --=20 1.8.3.1