From nobody Sun Dec 14 20:15:58 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 791A4C19F28 for ; Wed, 3 Aug 2022 17:03:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237236AbiHCRD1 (ORCPT ); Wed, 3 Aug 2022 13:03:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236733AbiHCRDV (ORCPT ); Wed, 3 Aug 2022 13:03:21 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8B2A4E862; Wed, 3 Aug 2022 10:03:20 -0700 (PDT) Date: Wed, 03 Aug 2022 17:03:17 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1659546198; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dXSabjNJjRfwC9JFIBmyear8cE5dLFtL3ysvEWzyh9Q=; b=nob9bSrJp280n42Pa4q1E0LgcMknzroqzp9bmlED1L+iUbDeuRhVy6UQ/B0j3HYDBnxtxK Pm6D1Hkj31rMuvZDxNYKYpL9zQB5Mw3IJOUp471H94LHCBtuz9chJtEO2r0gfC/tGyqsJ6 hLq53NBUs4nhLn4Xsf1pvdiyZ4omyOvx91RWlMTHWTnCiI5fh56swa6fluE7mlbsoOkMiX qh1xtBF8iD5vJGpiu0jCotlKuJIqi0UYJudRN5TV/amFFxVvzIZxxej15zwmKwpaLlGmc6 jrwzRjFkZqRnN+1WQpU8WFsWert2Q2O79Er/YUDdbBLJUZ5lXxgVhRkil2zulA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1659546198; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dXSabjNJjRfwC9JFIBmyear8cE5dLFtL3ysvEWzyh9Q=; b=N4ZbaufxcQl9SRixIVhsnSYeyD8Tntjjo6gDIEwCxbWwkByzQ8JMj4dyY4iFOqXHpuH0FV SVkmho5ziaBbBIAQ== From: "tip-bot2 for Hao Jia" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: sched/core] sched/fair: Remove unused parameter idle of _nohz_idle_balance() Cc: Hao Jia , Ingo Molnar , Vincent Guittot , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20220803130223.70419-1-jiahao.os@bytedance.com> References: <20220803130223.70419-1-jiahao.os@bytedance.com> MIME-Version: 1.0 Message-ID: <165954619718.15455.1084400841351133182.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the sched/core branch of tip: Commit-ID: d985ee9f449aafe45397ae1cf8887e9ac91d2f95 Gitweb: https://git.kernel.org/tip/d985ee9f449aafe45397ae1cf8887e9ac= 91d2f95 Author: Hao Jia AuthorDate: Wed, 03 Aug 2022 21:02:23 +08:00 Committer: Ingo Molnar CommitterDate: Wed, 03 Aug 2022 18:54:26 +02:00 sched/fair: Remove unused parameter idle of _nohz_idle_balance() After commit 7a82e5f52a35 ("sched/fair: Merge for each idle cpu loop of ILB= "), _nohz_idle_balance()'s 'idle' parameter is not used anymore, so we can remo= ve it. Signed-off-by: Hao Jia Signed-off-by: Ingo Molnar Reviewed-by: Vincent Guittot Link: https://lore.kernel.org/r/20220803130223.70419-1-jiahao.os@bytedance.= com --- kernel/sched/fair.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 41486d9..d22c5e8 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10916,8 +10916,7 @@ static bool update_nohz_stats(struct rq *rq) * can be a simple update of blocked load or a complete load balance with * tasks movement depending of flags. */ -static void _nohz_idle_balance(struct rq *this_rq, unsigned int flags, - enum cpu_idle_type idle) +static void _nohz_idle_balance(struct rq *this_rq, unsigned int flags) { /* Earliest time when we have to do rebalance again */ unsigned long now =3D jiffies; @@ -11032,7 +11031,7 @@ static bool nohz_idle_balance(struct rq *this_rq, e= num cpu_idle_type idle) if (idle !=3D CPU_IDLE) return false; =20 - _nohz_idle_balance(this_rq, flags, idle); + _nohz_idle_balance(this_rq, flags); =20 return true; } @@ -11052,7 +11051,7 @@ void nohz_run_idle_balance(int cpu) * (ie NOHZ_STATS_KICK set) and will do the same. */ if ((flags =3D=3D NOHZ_NEWILB_KICK) && !need_resched()) - _nohz_idle_balance(cpu_rq(cpu), NOHZ_STATS_KICK, CPU_IDLE); + _nohz_idle_balance(cpu_rq(cpu), NOHZ_STATS_KICK); } =20 static void nohz_newidle_balance(struct rq *this_rq)