From nobody Sat Apr 18 14:13:12 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0B41C433EF for ; Wed, 13 Jul 2022 10:30:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235204AbiGMKaz (ORCPT ); Wed, 13 Jul 2022 06:30:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236018AbiGMKau (ORCPT ); Wed, 13 Jul 2022 06:30:50 -0400 X-Greylist: delayed 410 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 13 Jul 2022 03:30:49 PDT Received: from chinatelecom.cn (prt-mail.chinatelecom.cn [42.123.76.223]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 37390FC9A4 for ; Wed, 13 Jul 2022 03:30:49 -0700 (PDT) HMM_SOURCE_IP: 172.18.0.188:55882.729471011 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-10.133.8.199 (unknown [172.18.0.188]) by chinatelecom.cn (HERMES) with SMTP id 479A82800C5; Wed, 13 Jul 2022 18:23:55 +0800 (CST) X-189-SAVE-TO-SEND: +liuxp11@chinatelecom.cn Received: from ([172.18.0.188]) by app0023 with ESMTP id 8281e15f9b554ce79754ed296a5cd601 for viro@zeniv.linux.org.uk; Wed, 13 Jul 2022 18:23:57 CST X-Transaction-ID: 8281e15f9b554ce79754ed296a5cd601 X-Real-From: liuxp11@chinatelecom.cn X-Receive-IP: 172.18.0.188 X-MEDUSA-Status: 0 Sender: liuxp11@chinatelecom.cn From: Liu Xinpeng To: viro@zeniv.linux.org.uk Cc: linux-kernel@vger.kernel.org, Liu Xinpeng Subject: [PATCH] iov_iter: Fix repeated minus operation Date: Wed, 13 Jul 2022 18:23:40 +0800 Message-Id: <1657707820-124858-1-git-send-email-liuxp11@chinatelecom.cn> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" After executing command 'cat /proc/cpuinfo', got a message: [ 6.909745] ------------[ cut here ]------------ [ 6.910267] WARNING: CPU: 0 PID: 76 at lib/iov_iter.c:1026 iov_iter_pipe+0x34/0x40 [ 6.910951] Modules linked in: [ 6.911584] CPU: 0 PID: 76 Comm: cat Not tainted 5.19.0-rc6-next-2022071= 1 #9 [ 6.911916] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.0-59-gc9ba5276e321-prebuilt.qemu.org 04/01/2014 [ 6.912668] RIP: 0010:iov_iter_pipe+0x34/0x40 [ 6.913062] Code: 72 54 39 72 5c 76 23 48 c7 07 00 00 00 00 48 c7 47 08 = 00 00 00 00 c6 07 03 48 89 4f 10 48 89 57 18 89 47 20 89 47 24 c3 0f 0b <0f> 7 [ 6.914341] RSP: 0018:ffffc900001c7d48 EFLAGS: 00000246 [ 6.914647] RAX: 0000000000000010 RBX: ffff888004988700 RCX: 00000000000= 00000 [ 6.914893] RDX: ffff88800490bc00 RSI: 0000000000000010 RDI: ffffc900001= c7d58 [ 6.915302] RBP: ffffc900001c7e00 R08: 0000000000000000 R09: ffff888004c= afad8 [ 6.915609] R10: 0000000000020000 R11: 0000000000001000 R12: ffff8880049= 0bc00 [ 6.915856] R13: ffffc900001c7e48 R14: 00000000000002d5 R15: ffff8880049= 0bc00 [ 6.916352] FS: 00000000016df8c0(0000) GS:ffff88800f600000(0000) Checking the code, need to delete the duplicate minus in a loop. Signed-off-by: Liu Xinpeng Tested-by: Michael Walle --- lib/iov_iter.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/iov_iter.c b/lib/iov_iter.c index 4a3451e..642841ce 100644 --- a/lib/iov_iter.c +++ b/lib/iov_iter.c @@ -472,7 +472,6 @@ static size_t copy_pipe_to_iter(const void *addr, size_= t bytes, break; memcpy_to_page(page, off, addr, chunk); addr +=3D chunk; - n -=3D chunk; } return bytes; } --=20 1.8.3.1