From nobody Sun Apr 19 15:19:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D64F6C433EF for ; Wed, 29 Jun 2022 09:24:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232736AbiF2JYw (ORCPT ); Wed, 29 Jun 2022 05:24:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232345AbiF2JYv (ORCPT ); Wed, 29 Jun 2022 05:24:51 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1355F369FB; Wed, 29 Jun 2022 02:24:49 -0700 (PDT) Received: from fraeml745-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LXwwM4l7mz686b6; Wed, 29 Jun 2022 17:22:27 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml745-chm.china.huawei.com (10.206.15.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 29 Jun 2022 11:24:47 +0200 Received: from localhost.localdomain (10.69.192.58) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 29 Jun 2022 10:24:45 +0100 From: John Garry To: , CC: , , John Garry Subject: [PATCH v2] ata: pata_cs5535: Fix W=1 warnings Date: Wed, 29 Jun 2022 17:18:44 +0800 Message-ID: <1656494324-101603-1-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 2.8.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.69.192.58] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org x86_64 allmodconfig build with W=3D1 gives these warnings: drivers/ata/pata_cs5535.c: In function =E2=80=98cs5535_set_piomode=E2=80=99: drivers/ata/pata_cs5535.c:93:11: error: variable =E2=80=98dummy=E2=80=99 se= t but not used [-Werror=3Dunused-but-set-variable] u32 reg, dummy; ^~~~~ drivers/ata/pata_cs5535.c: In function =E2=80=98cs5535_set_dmamode=E2=80=99: drivers/ata/pata_cs5535.c:132:11: error: variable =E2=80=98dummy=E2=80=99 s= et but not used [-Werror=3Dunused-but-set-variable] u32 reg, dummy; ^~~~~ cc1: all warnings being treated as errors Mark variables 'dummy' as "maybe unused" as they are only ever written in rdmsr() calls. Signed-off-by: John Garry Reviewed-by: Sergey Shtylyov --- Differences to v1: - Add RB tag (thanks!) - Fix commit message diff --git a/drivers/ata/pata_cs5535.c b/drivers/ata/pata_cs5535.c index 6725931f3c35..c2c3238ff84b 100644 --- a/drivers/ata/pata_cs5535.c +++ b/drivers/ata/pata_cs5535.c @@ -90,7 +90,7 @@ static void cs5535_set_piomode(struct ata_port *ap, struc= t ata_device *adev) static const u16 pio_cmd_timings[5] =3D { 0xF7F4, 0x53F3, 0x13F1, 0x5131, 0x1131 }; - u32 reg, dummy; + u32 reg, __maybe_unused dummy; struct ata_device *pair =3D ata_dev_pair(adev); =20 int mode =3D adev->pio_mode - XFER_PIO_0; @@ -129,7 +129,7 @@ static void cs5535_set_dmamode(struct ata_port *ap, str= uct ata_device *adev) static const u32 mwdma_timings[3] =3D { 0x7F0FFFF3, 0x7F035352, 0x7F024241 }; - u32 reg, dummy; + u32 reg, __maybe_unused dummy; int mode =3D adev->dma_mode; =20 rdmsr(ATAC_CH0D0_DMA + 2 * adev->devno, reg, dummy); --=20 2.35.3