From nobody Sun Apr 19 23:31:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D309CCA473 for ; Fri, 24 Jun 2022 12:05:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230391AbiFXMFv (ORCPT ); Fri, 24 Jun 2022 08:05:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229615AbiFXMFu (ORCPT ); Fri, 24 Jun 2022 08:05:50 -0400 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 298347E020; Fri, 24 Jun 2022 05:05:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QO3+hKMXD/Y6PRKvjNg/gexhuJhWj5LtQ9FwZHZ20KApNSBhgdw6MElISu+1lNqVUPSuDjIccg6JKF/xsVwmBptmzrH0ybXMWkqrY6enqlox3UoQ4DrPkQfKwLgm4g+ZuBIVRHA32hQe5yE28TyF2rbJEVYFgBKgBHWElF19d4sc/HHzRZQ73kV75ecIWQQJnqiPE0+9EYSyy77211WvTu1LpLX8rAH2gfISyhMJejuylEpWp/Yv9Ea85htmpbLUPb8JUYCblondnrWdml6blj8eLTV6WaKTV9XV9X8z/N+vqb2Fv6iydqSMyrKxytk1cMj3tYGT9lk6Oosr8++Tvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U/5lUZm/kw9/+tuWTrViqTho9jF1ruXzIM3SMV1abU8=; b=Rpj22lsegs+5t5ipVPLzxE8w3Wsi5PvvTAIZVQ9PlS5472WEch0xqqg/q9DxGLgIltIx2RUbwd2eOF8Yke24fjGlJaXCK0ND79fq/RiDZzyJpO2g9uUh0YRU+hjROeTzVOufxUmaMUFrp1JRPmL36HXgUrNfM6eTboUEl/LIfs7UdKeRT/UvQgQi2Y3ea0bBgxaviVr20oLMmYj+HUnmWUqoLq7vbL90EmZbrM1YDZ1HDmK3DkjyptnhRDHCOoAUxRrySgROSa18AM8Ty+9Q5wldnLPuIPajcyNvph6hd7WjSCfb+h0weUAJJ86OY2PUETNRrLYr6zttwSor2TwAhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=amd.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U/5lUZm/kw9/+tuWTrViqTho9jF1ruXzIM3SMV1abU8=; b=YL8R2G7dR7gZlKslYGf+/c+aaKolWgKQR4G7eeJYM2hC1EKtHMpD961rpYsz312dZV+jwcUSytIciXZL/9r+tqbHxlZEu3JqLGUDj162woZb67tpYVbep7cJt6lkGfNBACvpTxW9jjJthPoAV1qCqkgq2tgKyXUA8vxa0Fljh3k= Received: from SA1PR02CA0018.namprd02.prod.outlook.com (2603:10b6:806:2cf::26) by DM5PR02MB3292.namprd02.prod.outlook.com (2603:10b6:4:64::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Fri, 24 Jun 2022 12:05:46 +0000 Received: from SN1NAM02FT0056.eop-nam02.prod.protection.outlook.com (2603:10b6:806:2cf:cafe::4) by SA1PR02CA0018.outlook.office365.com (2603:10b6:806:2cf::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:05:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0056.mail.protection.outlook.com (10.97.4.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:05:46 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 24 Jun 2022 05:05:46 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 24 Jun 2022 05:05:46 -0700 Envelope-to: git@amd.com, michal.simek@amd.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Received: from [172.23.64.2] (port=47730 helo=xhdvnc102.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o4i4H-00056G-EJ; Fri, 24 Jun 2022 05:05:46 -0700 Received: by xhdvnc102.xilinx.com (Postfix, from userid 90444) id 62D65104545; Fri, 24 Jun 2022 17:35:33 +0530 (IST) From: Manikanta Guntupalli To: , , , , , CC: Raviteja Narayanam , Manikanta Guntupalli Subject: [PATCH 01/12] i2c: xiic: Add standard mode support for > 255 byte read transfers Date: Fri, 24 Jun 2022 17:35:16 +0530 Message-ID: <1656072327-13628-2-git-send-email-manikanta.guntupalli@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> References: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 243351e8-3dd0-43a9-c5ec-08da55d9df23 X-MS-TrafficTypeDiagnostic: DM5PR02MB3292:EE_ X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5JzoU8KWLuGhftzqz0AO+COyQQCr1ulFGPccyOrVhxV8uYVJuyIbW8pC+02Q1y8Ohr6qE7i+g4FL6qg4G7gx8sOuP6mKmS+zYsLLsAC91cNBm8/ssvKik2T+dbmQvHFzwtIseanB4j7bG4UcATBNAA4N7w/mSy88QQ1UjCUQAmUBco3CDKpgbnvobTn7NXP05oIKZwAlMJrjme3omTX5Za+e/h9+zi9cicbq6RZhQ1hWBsVMJosGCr98+QcjrPW3gdtZdSD3x8BruMVHzyNh25lvFnOIvQOYU/8ClSpVijdO0u6sv6pUIbzy0Ch+Vh6+F8XVVhS8AVucOY52JlVfEPiVt/MBIDERhYLh0mq4/wL3eV9zeq8OhXm8owagPeieOUgUSgKJgMqNubK1up4CSGtVq54D4MbQcuBm2LCRV5BCD3ab70H6K3uBfmC/uM6U9bc9WKfQenB/GBO1KOzqHN5evnC5Y837BGSS8jNrdYN9F8m8s75H7xsjGI2UIIT9HS3cKL9N5znTNkf/DrjBkexWckKHGVgaxuQ4vp1l3n+7shgMwU8HwKKPzIWeeR53FZ6BMJggM/CuQIKwaABNsDtNk1K3bqsei9VqXrPLlXpyUbp6TcccxteFg7rboV6HGImqrw4+pzZU/wDpt5whHR5JPV8BmF1ft30DJILEDRYxQmH5l5WciA+oyPOPDXQ1JjHLW+cifed2n0TuCDUZgCbwlXlvuwVNU7bcwzCujfQrgXTiW9WIrO5820AM7opRDEcC1wMzGxeFbTJR4Y6duLZvyeT583GHNnjdWTmBpJBX8CDhnjgDUIFZshWyX/kqRqNAiNsu6DdYDcMTihjAb3T6p4pb5vAht3Xr3O4Ynh4= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(136003)(39860400002)(376002)(40470700004)(36840700001)(46966006)(110136005)(316002)(42186006)(54906003)(47076005)(70206006)(6266002)(70586007)(8676002)(41300700001)(336012)(2616005)(107886003)(6666004)(426003)(186003)(4326008)(478600001)(26005)(83380400001)(40460700003)(8936002)(7636003)(82740400003)(356005)(40480700001)(5660300002)(82310400005)(2906002)(30864003)(36756003)(44832011)(36860700001)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 12:05:46.5335 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 243351e8-3dd0-43a9-c5ec-08da55d9df23 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0056.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB3292 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Raviteja Narayanam Added standard mode for AXI I2C controller to enable read transfers of size more than 255 bytes. The driver selects standard mode in the following scenarios. 1. If a single message request comes from user space, requesting a read of more than 255 bytes 2. If a message set request comes from user space consisting of many messages and if any one of them is a read operation, irrespective of the size of transfer. (This is done because it is observed that repeated start operation is not happening in dynamic mode read as expected in a message set request from user space.) Signed-off-by: Raviteja Narayanam Signed-off-by: Manikanta Guntupalli --- drivers/i2c/busses/i2c-xiic.c | 326 +++++++++++++++++++++++++++++----- 1 file changed, 280 insertions(+), 46 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 9a1c3f8b7048..fb2443623844 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -60,6 +60,8 @@ enum xiic_endian { * @clk: Pointer to AXI4-lite input clock * @state: See STATE_ * @singlemaster: Indicates bus is single master + * @dynamic: Mode of controller + * @repeated_start: Repeated start operation */ struct xiic_i2c { struct device *dev; @@ -76,6 +78,8 @@ struct xiic_i2c { struct clk *clk; enum xilinx_i2c_state state; bool singlemaster; + bool dynamic; + bool repeated_start; }; =20 #define XIIC_MSB_OFFSET 0 @@ -143,6 +147,9 @@ struct xiic_i2c { #define XIIC_TX_DYN_START_MASK 0x0100 /* 1 =3D Set dynamic star= t */ #define XIIC_TX_DYN_STOP_MASK 0x0200 /* 1 =3D Set dynamic stop= */ =20 +/* Dynamic mode constants */ +#define MAX_READ_LENGTH_DYNAMIC 255 /* Max length for dynam= ic read */ + /* * The following constants define the register offsets for the Interrupt * registers. There are some holes in the memory map for reserved addresses @@ -316,13 +323,14 @@ static void xiic_deinit(struct xiic_i2c *i2c) =20 static void xiic_read_rx(struct xiic_i2c *i2c) { - u8 bytes_in_fifo; + u8 bytes_in_fifo, cr =3D 0, bytes_to_read =3D 0; + u32 bytes_rem =3D 0; int i; =20 bytes_in_fifo =3D xiic_getreg8(i2c, XIIC_RFO_REG_OFFSET) + 1; =20 dev_dbg(i2c->adap.dev.parent, - "%s entry, bytes in fifo: %d, msg: %d, SR: 0x%x, CR: 0x%x\n", + "%s entry, bytes in fifo: %d, rem: %d, SR: 0x%x, CR: 0x%x\n", __func__, bytes_in_fifo, xiic_rx_space(i2c), xiic_getreg8(i2c, XIIC_SR_REG_OFFSET), xiic_getreg8(i2c, XIIC_CR_REG_OFFSET)); @@ -330,13 +338,52 @@ static void xiic_read_rx(struct xiic_i2c *i2c) if (bytes_in_fifo > xiic_rx_space(i2c)) bytes_in_fifo =3D xiic_rx_space(i2c); =20 - for (i =3D 0; i < bytes_in_fifo; i++) + bytes_to_read =3D bytes_in_fifo; + + if (!i2c->dynamic) { + bytes_rem =3D xiic_rx_space(i2c) - bytes_in_fifo; + + if (bytes_rem > IIC_RX_FIFO_DEPTH) { + bytes_to_read =3D bytes_in_fifo; + } else if (bytes_rem > 1) { + bytes_to_read =3D bytes_rem - 1; + } else if (bytes_rem =3D=3D 1) { + bytes_to_read =3D 1; + /* Set NACK in CR to indicate slave transmitter */ + cr =3D xiic_getreg8(i2c, XIIC_CR_REG_OFFSET); + xiic_setreg8(i2c, XIIC_CR_REG_OFFSET, cr | + XIIC_CR_NO_ACK_MASK); + } else if (bytes_rem =3D=3D 0) { + bytes_to_read =3D bytes_in_fifo; + + /* Generate stop on the bus if it is last message */ + if (i2c->nmsgs =3D=3D 1) { + cr =3D xiic_getreg8(i2c, XIIC_CR_REG_OFFSET); + xiic_setreg8(i2c, XIIC_CR_REG_OFFSET, cr & + ~XIIC_CR_MSMS_MASK); + } + + /* Make TXACK=3D0, clean up for next transaction */ + cr =3D xiic_getreg8(i2c, XIIC_CR_REG_OFFSET); + xiic_setreg8(i2c, XIIC_CR_REG_OFFSET, cr & + ~XIIC_CR_NO_ACK_MASK); + } + } + + /* Read the fifo */ + for (i =3D 0; i < bytes_to_read; i++) { i2c->rx_msg->buf[i2c->rx_pos++] =3D xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET); + } + + if (i2c->dynamic) { + u8 bytes; =20 - xiic_setreg8(i2c, XIIC_RFD_REG_OFFSET, - (xiic_rx_space(i2c) > IIC_RX_FIFO_DEPTH) ? - IIC_RX_FIFO_DEPTH - 1 : xiic_rx_space(i2c) - 1); + /* Receive remaining bytes if less than fifo depth */ + bytes =3D min_t(u8, xiic_rx_space(i2c), IIC_RX_FIFO_DEPTH); + bytes--; + xiic_setreg8(i2c, XIIC_RFD_REG_OFFSET, bytes); + } } =20 static int xiic_tx_fifo_space(struct xiic_i2c *i2c) @@ -367,6 +414,56 @@ static void xiic_fill_tx_fifo(struct xiic_i2c *i2c) } } =20 +static void xiic_std_fill_tx_fifo(struct xiic_i2c *i2c) +{ + u8 fifo_space =3D xiic_tx_fifo_space(i2c); + u16 data =3D 0; + int len =3D xiic_tx_space(i2c); + + dev_dbg(i2c->adap.dev.parent, "%s entry, len: %d, fifo space: %d\n", + __func__, len, fifo_space); + + if (len > fifo_space) + len =3D fifo_space; + else if (len && !(i2c->repeated_start)) + len--; + + while (len--) { + data =3D i2c->tx_msg->buf[i2c->tx_pos++]; + xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, data); + } +} + +static void xiic_send_tx(struct xiic_i2c *i2c) +{ + dev_dbg(i2c->adap.dev.parent, + "%s entry, rem: %d, SR: 0x%x, CR: 0x%x\n", + __func__, xiic_tx_space(i2c), + xiic_getreg8(i2c, XIIC_SR_REG_OFFSET), + xiic_getreg8(i2c, XIIC_CR_REG_OFFSET)); + + if (xiic_tx_space(i2c) > 1) { + xiic_std_fill_tx_fifo(i2c); + return; + } + + if ((xiic_tx_space(i2c) =3D=3D 1)) { + u16 data; + + if (i2c->nmsgs =3D=3D 1) { + u8 cr; + + /* Write to CR to stop */ + cr =3D xiic_getreg8(i2c, XIIC_CR_REG_OFFSET); + xiic_setreg8(i2c, XIIC_CR_REG_OFFSET, cr & + ~XIIC_CR_MSMS_MASK); + } + /* Send last byte */ + data =3D i2c->tx_msg->buf[i2c->tx_pos++]; + xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, data); + } +} + static void xiic_wakeup(struct xiic_i2c *i2c, int code) { i2c->tx_msg =3D NULL; @@ -401,7 +498,9 @@ static irqreturn_t xiic_process(int irq, void *dev_id) dev_dbg(i2c->adap.dev.parent, "%s: SR: 0x%x, msg: %p, nmsgs: %d\n", __func__, xiic_getreg8(i2c, XIIC_SR_REG_OFFSET), i2c->tx_msg, i2c->nmsgs); - + dev_dbg(i2c->adap.dev.parent, "%s, ISR: 0x%x, CR: 0x%x\n", + __func__, xiic_getreg32(i2c, XIIC_IISR_OFFSET), + xiic_getreg8(i2c, XIIC_CR_REG_OFFSET)); =20 /* Service requesting interrupt */ if ((pend & XIIC_INTR_ARB_LOST_MASK) || @@ -480,7 +579,10 @@ static irqreturn_t xiic_process(int irq, void *dev_id) goto out; } =20 - xiic_fill_tx_fifo(i2c); + if (i2c->dynamic) + xiic_fill_tx_fifo(i2c); + else + xiic_send_tx(i2c); =20 /* current message sent and there is space in the fifo */ if (!xiic_tx_space(i2c) && xiic_tx_fifo_space(i2c) >=3D 2) { @@ -579,31 +681,99 @@ static int xiic_busy(struct xiic_i2c *i2c) static void xiic_start_recv(struct xiic_i2c *i2c) { u16 rx_watermark; + u8 cr =3D 0, rfd_set =3D 0; struct i2c_msg *msg =3D i2c->rx_msg =3D i2c->tx_msg; + unsigned long flags; =20 - /* Clear and enable Rx full interrupt. */ - xiic_irq_clr_en(i2c, XIIC_INTR_RX_FULL_MASK | XIIC_INTR_TX_ERROR_MASK); + dev_dbg(i2c->adap.dev.parent, "%s entry, ISR: 0x%x, CR: 0x%x\n", + __func__, xiic_getreg32(i2c, XIIC_IISR_OFFSET), + xiic_getreg8(i2c, XIIC_CR_REG_OFFSET)); =20 - /* we want to get all but last byte, because the TX_ERROR IRQ is used - * to inidicate error ACK on the address, and negative ack on the last - * received byte, so to not mix them receive all but last. - * In the case where there is only one byte to receive - * we can check if ERROR and RX full is set at the same time - */ - rx_watermark =3D msg->len; - if (rx_watermark > IIC_RX_FIFO_DEPTH) - rx_watermark =3D IIC_RX_FIFO_DEPTH; - xiic_setreg8(i2c, XIIC_RFD_REG_OFFSET, (u8)(rx_watermark - 1)); + /* Disable Tx interrupts */ + xiic_irq_dis(i2c, XIIC_INTR_TX_HALF_MASK | XIIC_INTR_TX_EMPTY_MASK); =20 - if (!(msg->flags & I2C_M_NOSTART)) - /* write the address */ - xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, - i2c_8bit_addr_from_msg(msg) | XIIC_TX_DYN_START_MASK); =20 - xiic_irq_clr_en(i2c, XIIC_INTR_BNB_MASK); + if (i2c->dynamic) { + u8 bytes; + u16 val; =20 - xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, - msg->len | ((i2c->nmsgs =3D=3D 1) ? XIIC_TX_DYN_STOP_MASK : 0)); + /* Clear and enable Rx full interrupt. */ + xiic_irq_clr_en(i2c, XIIC_INTR_RX_FULL_MASK | + XIIC_INTR_TX_ERROR_MASK); + + /* + * We want to get all but last byte, because the TX_ERROR IRQ + * is used to indicate error ACK on the address, and + * negative ack on the last received byte, so to not mix + * them receive all but last. + * In the case where there is only one byte to receive + * we can check if ERROR and RX full is set at the same time + */ + rx_watermark =3D msg->len; + bytes =3D min_t(u8, rx_watermark, IIC_RX_FIFO_DEPTH); + bytes--; + + xiic_setreg8(i2c, XIIC_RFD_REG_OFFSET, bytes); + + local_irq_save(flags); + if (!(msg->flags & I2C_M_NOSTART)) + /* write the address */ + xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, + i2c_8bit_addr_from_msg(msg) | + XIIC_TX_DYN_START_MASK); + + xiic_irq_clr_en(i2c, XIIC_INTR_BNB_MASK); + + /* If last message, include dynamic stop bit with length */ + val =3D (i2c->nmsgs =3D=3D 1) ? XIIC_TX_DYN_STOP_MASK : 0; + val |=3D msg->len; + + xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, val); + local_irq_restore(flags); + } else { + cr =3D xiic_getreg8(i2c, XIIC_CR_REG_OFFSET); + + /* Set Receive fifo depth */ + rx_watermark =3D msg->len; + if (rx_watermark > IIC_RX_FIFO_DEPTH) { + rfd_set =3D IIC_RX_FIFO_DEPTH - 1; + } else if ((rx_watermark =3D=3D 1) || (rx_watermark =3D=3D 0)) { + rfd_set =3D rx_watermark - 1; + /* Handle single byte transfer separately */ + cr |=3D XIIC_CR_NO_ACK_MASK; + } else { + rfd_set =3D rx_watermark - 2; + } + /* Check if RSTA should be set */ + if (cr & XIIC_CR_MSMS_MASK) { + i2c->repeated_start =3D true; + /* Already a master, RSTA should be set */ + xiic_setreg8(i2c, XIIC_CR_REG_OFFSET, (cr | + XIIC_CR_REPEATED_START_MASK) & + ~(XIIC_CR_DIR_IS_TX_MASK)); + } + + xiic_setreg8(i2c, XIIC_RFD_REG_OFFSET, rfd_set); + + /* Clear and enable Rx full and transmit complete interrupts */ + xiic_irq_clr_en(i2c, XIIC_INTR_RX_FULL_MASK | + XIIC_INTR_TX_ERROR_MASK); + + /* Write the address */ + xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, + i2c_8bit_addr_from_msg(msg)); + + /* Write to Control Register,to start transaction in Rx mode */ + if ((cr & XIIC_CR_MSMS_MASK) =3D=3D 0) { + i2c->repeated_start =3D false; + xiic_setreg8(i2c, XIIC_CR_REG_OFFSET, (cr | + XIIC_CR_MSMS_MASK) + & ~(XIIC_CR_DIR_IS_TX_MASK)); + } + dev_dbg(i2c->adap.dev.parent, "%s end, ISR: 0x%x, CR: 0x%x\n", + __func__, xiic_getreg32(i2c, XIIC_IISR_OFFSET), + xiic_getreg8(i2c, XIIC_CR_REG_OFFSET)); + } =20 if (i2c->nmsgs =3D=3D 1) /* very last, enable bus not busy as well */ @@ -611,10 +781,15 @@ static void xiic_start_recv(struct xiic_i2c *i2c) =20 /* the message is tx:ed */ i2c->tx_pos =3D msg->len; + + /* Enable interrupts */ + xiic_setreg32(i2c, XIIC_DGIER_OFFSET, XIIC_GINTR_ENABLE_MASK); } =20 static void xiic_start_send(struct xiic_i2c *i2c) { + u8 cr =3D 0; + u16 data; struct i2c_msg *msg =3D i2c->tx_msg; =20 dev_dbg(i2c->adap.dev.parent, "%s entry, msg: %p, len: %d", @@ -623,24 +798,61 @@ static void xiic_start_send(struct xiic_i2c *i2c) __func__, xiic_getreg32(i2c, XIIC_IISR_OFFSET), xiic_getreg8(i2c, XIIC_CR_REG_OFFSET)); =20 - if (!(msg->flags & I2C_M_NOSTART)) { - /* write the address */ - u16 data =3D i2c_8bit_addr_from_msg(msg) | - XIIC_TX_DYN_START_MASK; - if ((i2c->nmsgs =3D=3D 1) && msg->len =3D=3D 0) - /* no data and last message -> add STOP */ - data |=3D XIIC_TX_DYN_STOP_MASK; + if (i2c->dynamic) { + if (!(msg->flags & I2C_M_NOSTART)) { + /* write the address */ + data =3D i2c_8bit_addr_from_msg(msg) | + XIIC_TX_DYN_START_MASK; + + if (i2c->nmsgs =3D=3D 1 && msg->len =3D=3D 0) + /* no data and last message -> add STOP */ + data |=3D XIIC_TX_DYN_STOP_MASK; + + xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, data); + } + + /* Clear any pending Tx empty, Tx Error and then enable them */ + xiic_irq_clr_en(i2c, XIIC_INTR_TX_EMPTY_MASK | + XIIC_INTR_TX_ERROR_MASK | + XIIC_INTR_BNB_MASK | + ((i2c->nmsgs > 1 || xiic_tx_space(i2c)) ? + XIIC_INTR_TX_HALF_MASK : 0)); + + xiic_fill_tx_fifo(i2c); + } else { + /* Check if RSTA should be set */ + cr =3D xiic_getreg8(i2c, XIIC_CR_REG_OFFSET); + if (cr & XIIC_CR_MSMS_MASK) { + i2c->repeated_start =3D true; + /* Already a master, RSTA should be set */ + xiic_setreg8(i2c, XIIC_CR_REG_OFFSET, (cr | + XIIC_CR_REPEATED_START_MASK | + XIIC_CR_DIR_IS_TX_MASK) & + ~(XIIC_CR_NO_ACK_MASK)); + } =20 + /* Write address to FIFO */ + data =3D i2c_8bit_addr_from_msg(msg); xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, data); - } =20 - /* Clear any pending Tx empty, Tx Error and then enable them. */ - xiic_irq_clr_en(i2c, XIIC_INTR_TX_EMPTY_MASK | XIIC_INTR_TX_ERROR_MASK | - XIIC_INTR_BNB_MASK | - ((i2c->nmsgs > 1 || xiic_tx_space(i2c)) ? - XIIC_INTR_TX_HALF_MASK : 0)); + /* Fill fifo */ + xiic_std_fill_tx_fifo(i2c); + + if ((cr & XIIC_CR_MSMS_MASK) =3D=3D 0) { + i2c->repeated_start =3D false; + + /* Start Tx by writing to CR */ + cr =3D xiic_getreg8(i2c, XIIC_CR_REG_OFFSET); + xiic_setreg8(i2c, XIIC_CR_REG_OFFSET, cr | + XIIC_CR_MSMS_MASK | + XIIC_CR_DIR_IS_TX_MASK); + } =20 - xiic_fill_tx_fifo(i2c); + /* Clear any pending Tx empty, Tx Error and then enable them */ + xiic_irq_clr_en(i2c, XIIC_INTR_TX_EMPTY_MASK | + XIIC_INTR_TX_ERROR_MASK | + XIIC_INTR_BNB_MASK); + } } =20 static void __xiic_start_xfer(struct xiic_i2c *i2c) @@ -701,6 +913,33 @@ static int xiic_xfer(struct i2c_adapter *adap, struct = i2c_msg *msgs, int num) if (err < 0) return err; =20 + /* Decide standard mode or Dynamic mode */ + i2c->dynamic =3D true; + + /* + * If number of messages is 1 and read length is > 255 bytes, + * enter standard mode + */ + + if (i2c->nmsgs =3D=3D 1 && (i2c->tx_msg->flags & I2C_M_RD) && + i2c->tx_msg->len > MAX_READ_LENGTH_DYNAMIC) { + i2c->dynamic =3D false; + } else if (i2c->nmsgs > 1) { + int count; + + /* + * If number of messages is more than 1 and one of them is + * a read message, enter standard mode. Since repeated start + * operation in dynamic mode read is not happenning + */ + for (count =3D 0; count < i2c->nmsgs; count++) { + if (i2c->tx_msg[count].flags & I2C_M_RD) { + i2c->dynamic =3D false; + break; + } + } + } + err =3D xiic_start_xfer(i2c, msgs, num); if (err < 0) { dev_err(adap->dev.parent, "Error xiic_start_xfer\n"); @@ -737,15 +976,10 @@ static const struct i2c_algorithm xiic_algorithm =3D { .functionality =3D xiic_func, }; =20 -static const struct i2c_adapter_quirks xiic_quirks =3D { - .max_read_len =3D 255, -}; - static const struct i2c_adapter xiic_adapter =3D { .owner =3D THIS_MODULE, .class =3D I2C_CLASS_DEPRECATED, .algo =3D &xiic_algorithm, - .quirks =3D &xiic_quirks, }; =20 static int xiic_i2c_probe(struct platform_device *pdev) --=20 2.25.1 From nobody Sun Apr 19 23:31:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2705EC433EF for ; Fri, 24 Jun 2022 12:06:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231378AbiFXMGE (ORCPT ); Fri, 24 Jun 2022 08:06:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229615AbiFXMGC (ORCPT ); Fri, 24 Jun 2022 08:06:02 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2064.outbound.protection.outlook.com [40.107.223.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDF167E039; Fri, 24 Jun 2022 05:06:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ngi27QUmsFRw2Nayoi+d3yRImqqnNKufGyk8LUAJGCuMbkalXokTxqPuR5TQ45vt3NarOrs5ggGcV/gwhcEUYPR7quWglgbTTqnQCRmeXGOsLCql+irxDRsCSfd8OyC5m5i9/hDcwdgTqx3P+7JL/U7+Sdb9WL7y/0Xm7yXzyZP4lvuUPwgaE25wP1HSWLau+tYbTFHsBAmTbFlgH+mBD9mdsmOlOLNJD6c8MzRkcZ+uMdx5FNSNEOehiQZAXDoQPLrIr9nIradmj0qEp3TUqB9sCWfX7cHud6tpILC2B0Rk167zlHr4gR4B0PAL8daGeAkciWC3Msh+GTc6XFtL4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pX7xlpPLhJjmvOzb4otaCQbfDCGBmHnvzCz/nEkdhxc=; b=mHdDPMBGnTzYw9QLkvJ8mNysz9KZMJFxRLz6G2QLWAU7tUijpBphZOtTfACxsb1LeJAZBl1m17L58VKD99Bq3Rk5u1qgu2vcp8cBueqV5pYJ7meFpBx11SL1uE2TGmFhL4ypVdzovQo2hq8+s+v57LBiknP9jtNUHygeyla5Dx5CGc2G8mUdGQmfKohivG9JWPfGlw52TEm9XRTLbuefbUPNVMdlYXmrZuOkM6JUDooYtfTWUHm5ytGIdU/CQMSUKRS7Sn5AypTwPOlNHdQDtRLxXahDMgjZ1hucwiDA2xT6jM3tqWaQTB5BeiACOxpwaFu5oKM3DH7b3eKG5c5UFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=amd.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pX7xlpPLhJjmvOzb4otaCQbfDCGBmHnvzCz/nEkdhxc=; b=j3YzBlktxdNb+OejcUaP60zdAjxpsT5FzVA5501ASMHvV67NCVbmliygt7efzw0cD9VseCX0+8aZQBFp4VxCK7rkmRjB9kYaSwVTMlAQ/tfGxdiipXjB8WEVJSCaN6ccOAIBHMPmBo/sz7RRnNOUq8a4fDD/B4nM5yslKHLCZy0= Received: from BN6PR16CA0009.namprd16.prod.outlook.com (2603:10b6:404:f5::19) by SN6PR02MB5278.namprd02.prod.outlook.com (2603:10b6:805:67::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Fri, 24 Jun 2022 12:06:00 +0000 Received: from BN1NAM02FT053.eop-nam02.prod.protection.outlook.com (2603:10b6:404:f5:cafe::f) by BN6PR16CA0009.outlook.office365.com (2603:10b6:404:f5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17 via Frontend Transport; Fri, 24 Jun 2022 12:06:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT053.mail.protection.outlook.com (10.13.2.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:05:59 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 24 Jun 2022 05:05:59 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 24 Jun 2022 05:05:59 -0700 Envelope-to: git@amd.com, michal.simek@amd.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Received: from [172.23.64.2] (port=47731 helo=xhdvnc102.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o4i4V-00056d-5J; Fri, 24 Jun 2022 05:05:59 -0700 Received: by xhdvnc102.xilinx.com (Postfix, from userid 90444) id 5FB34104546; Fri, 24 Jun 2022 17:35:35 +0530 (IST) From: Manikanta Guntupalli To: , , , , , CC: Raviteja Narayanam , Manikanta Guntupalli Subject: [PATCH 02/12] i2c: xiic: Enter standard mode only for > 255 byte read transfers Date: Fri, 24 Jun 2022 17:35:17 +0530 Message-ID: <1656072327-13628-3-git-send-email-manikanta.guntupalli@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> References: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8a84927d-940c-4e5f-e574-08da55d9e726 X-MS-TrafficTypeDiagnostic: SN6PR02MB5278:EE_ X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V5JBDczcE3qhX9ZFiw4+//N+EE/3kN+ECnqhdCjzJNQZe8YHf026aNd6YJ5VVdghVy/cCUTqCj6EjgIKdVBCdBKZuLVjnpxW0T/G1KvufL2xCP3poTJRAAjU4KK6M//kdAED5gDT/WuibwDjwu0eYAsV9cyMJwiH6sBVrBT/Ho3Bz6S0gaKZIlxn5IUnu1UL2vJq7TG8c2LY1i5p66xCoOGSdcDg3R31pQ8xnkPfNhhAdGHkWn1J3v6VqC5f0cpbCdmJslPZSZbw14xZwWF8AOFQYl6Q8VszLmkpmnYmbqvsJKwgKfnH68jdrEUsav3CelYW8xieIVCxzcOOQo84DKM1thuizwHKW6pP6x4BvOGqGQoiM3wRhpkvsgO8Onia9dHaFc44HWET38gfKxmSmiGTa8Xm0IB2V7IThPpBYeuznKR35V5FM9JZAvcTaqvGdiTbL83tsLgVnK1WABZbJfPo2aeY8FDHR7NlcIIFarJzoEbnV6QyNayH31qNGD5NRWtphIngUb959x4s1f3LMwyqDdzm1r13RD7Yuv4D+DG+HqPW+AeWoZt/jVgRqvEfOKinyHMAw3yVzguuWMRlNDEfj1tZamoF3ES9Cd8K77EQw/2wXim/WoMD9rgAkNckhahuSfG0tFigR/r+/g4g5GVnCQprb1WxOTKGmsCoMtKMvnEbH2unYrg2CUNXgNlvEKlYcrHJnHIEt2EkZ3Y2GEpabrHVVy87s3XmNSZS6T81tderkw+DceM34K0H3ZFC39DEka6dOIFa5xh5jsmwDWr1eG0n9StfDH4HAvEyS+P22jmA0v9E4JmhRB81QzcnGnXjraVQw1lRqlOUOlmUwHnMYVXMVvLe312SmhxgwI8= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(346002)(136003)(376002)(40470700004)(36840700001)(46966006)(47076005)(54906003)(36860700001)(186003)(336012)(110136005)(8676002)(107886003)(40460700003)(70586007)(82740400003)(36756003)(316002)(426003)(2616005)(4326008)(42186006)(6666004)(40480700001)(6266002)(44832011)(41300700001)(26005)(83380400001)(8936002)(7636003)(478600001)(82310400005)(356005)(70206006)(2906002)(5660300002)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 12:05:59.9290 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8a84927d-940c-4e5f-e574-08da55d9e726 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT053.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB5278 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Raviteja Narayanam To maintain backward compatibility the default transfer mode is dynamic mode. Enter standard mode only when the size of read transfer is > 255 bytes. Signed-off-by: Raviteja Narayanam Signed-off-by: Manikanta Guntupalli --- drivers/i2c/busses/i2c-xiic.c | 29 +++++++---------------------- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index fb2443623844..c8b68176427c 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -904,7 +904,7 @@ static int xiic_start_xfer(struct xiic_i2c *i2c, struct= i2c_msg *msgs, int num) static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int n= um) { struct xiic_i2c *i2c =3D i2c_get_adapdata(adap); - int err; + int err, count; =20 dev_dbg(adap->dev.parent, "%s entry SR: 0x%x\n", __func__, xiic_getreg8(i2c, XIIC_SR_REG_OFFSET)); @@ -916,27 +916,12 @@ static int xiic_xfer(struct i2c_adapter *adap, struct= i2c_msg *msgs, int num) /* Decide standard mode or Dynamic mode */ i2c->dynamic =3D true; =20 - /* - * If number of messages is 1 and read length is > 255 bytes, - * enter standard mode - */ - - if (i2c->nmsgs =3D=3D 1 && (i2c->tx_msg->flags & I2C_M_RD) && - i2c->tx_msg->len > MAX_READ_LENGTH_DYNAMIC) { - i2c->dynamic =3D false; - } else if (i2c->nmsgs > 1) { - int count; - - /* - * If number of messages is more than 1 and one of them is - * a read message, enter standard mode. Since repeated start - * operation in dynamic mode read is not happenning - */ - for (count =3D 0; count < i2c->nmsgs; count++) { - if (i2c->tx_msg[count].flags & I2C_M_RD) { - i2c->dynamic =3D false; - break; - } + /* Enter standard mode only when read length is > 255 bytes */ + for (count =3D 0; count < i2c->nmsgs; count++) { + if ((i2c->tx_msg[count].flags & I2C_M_RD) && + i2c->tx_msg[count].len > MAX_READ_LENGTH_DYNAMIC) { + i2c->dynamic =3D false; + break; } } =20 --=20 2.25.1 From nobody Sun Apr 19 23:31:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45660C433EF for ; Fri, 24 Jun 2022 12:06:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231616AbiFXMGS (ORCPT ); Fri, 24 Jun 2022 08:06:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231405AbiFXMGR (ORCPT ); Fri, 24 Jun 2022 08:06:17 -0400 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2071.outbound.protection.outlook.com [40.107.94.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CFC17E039; Fri, 24 Jun 2022 05:06:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Co6TJtLMagPhM+e8rngYE+/hi4OdwRT/B2hY0P6rlDCK4rVq98s9PrnHUzd+7jBBlmgoYB4ipycYEDJugLZohsYvKkUY7BwNL/b6Ny13Y+0OvmQ91HNtJAzp0u8a1U38C0cHAd6BI853MooVuwAGzkS4kqm7CiBUe4kBFHLyICceaDK+p/nqZ4QsLuMdOa41qISiINvIksxnp0NvBkbiSNkXHWk/sk9Aon51j6CVXQBpSsPQdwAsLvRhCsH20s5pzS71JhUzTMdcdpQIErlvVKXEJlTvhdba8oJHG+ZCaQLR5NepkrM3SDm0O3kLWJRIMQ8bkpcbxv5bdnIEJG1y0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lmAirJbQixEAzRHhtueUD2aTAo2hECopPY8LPrRKv9U=; b=Z7qS39wQkCeRJHWpuwfwQCvbB0t35WcHalhN3j2A4kTj1Ei+0tjtDM5QBpfBp35wWTCRvd4fexe5rfsUEHx507qmks5KXLM+ACSue9RyThRBmaQzNapd5f/MlICJkkoRZ65fgm3zqGoJB09kWUAPWSM8ABlP99MAJpr7kUWd1qYnMhdWsO4vd1Lc31se7NPH6P87kA6S+7T0NC+sYaybG1VgqQW2ZbXxLnJET5P5gResIkwqqJiQDjZKwtwSfBhrVxJyr4S9LALiejFExUZgojUl9VAU5MWOZS7wALxk+2FvNXZ3WUtUyNGwWe4qpaNQztFxum9CzY7Mc06zr/evug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=amd.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lmAirJbQixEAzRHhtueUD2aTAo2hECopPY8LPrRKv9U=; b=c8ksJjWhYsR7uhCvrHlcR7173l5iWSqIP7mLJDexMXLqu2Mbubk3c4PEgq8LfivHU7TiiS7Qk0yWlbS8R45R4vdHrTZ9uo4ZKrTBhM52RCQJFIOdkSJbTIe1Xr9Ls8MM8BmcQ9twCZpytoO9KtvTHN40NDUmiQAtuBD2FFMu0oU= Received: from BN6PR16CA0019.namprd16.prod.outlook.com (2603:10b6:404:f5::29) by IA1PR02MB8876.namprd02.prod.outlook.com (2603:10b6:208:388::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.22; Fri, 24 Jun 2022 12:06:13 +0000 Received: from BN1NAM02FT053.eop-nam02.prod.protection.outlook.com (2603:10b6:404:f5:cafe::2d) by BN6PR16CA0019.outlook.office365.com (2603:10b6:404:f5::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.22 via Frontend Transport; Fri, 24 Jun 2022 12:06:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT053.mail.protection.outlook.com (10.13.2.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:06:13 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 24 Jun 2022 05:06:12 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 24 Jun 2022 05:06:12 -0700 Envelope-to: git@amd.com, michal.simek@amd.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Received: from [172.23.64.2] (port=47732 helo=xhdvnc102.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o4i4i-000BOG-8b; Fri, 24 Jun 2022 05:06:12 -0700 Received: by xhdvnc102.xilinx.com (Postfix, from userid 90444) id D6615104547; Fri, 24 Jun 2022 17:35:36 +0530 (IST) From: Manikanta Guntupalli To: , , , , , CC: Raviteja Narayanam , Manikanta Guntupalli Subject: [PATCH 03/12] i2c: xiic: Fix Rx and Tx paths in standard mode repeated start Date: Fri, 24 Jun 2022 17:35:18 +0530 Message-ID: <1656072327-13628-4-git-send-email-manikanta.guntupalli@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> References: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fef2375c-ccc5-4728-bcbe-08da55d9ef45 X-MS-TrafficTypeDiagnostic: IA1PR02MB8876:EE_ X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: roj8qB86Brcc/PXeiuIWtlbaAmCsW82iuciGxr/SikXNw/E5pkxnxb3BXewkf1Kjwr6PS6kz02EivprSUmTz+JRXTt+PywGl6HLnBs36MbZaHIFsrp5ux5ZceDc0s1iTLZ81rmwKrlJADu9aDNNh9TY9bE6Aqq/GDhBXhbJL/51HR3lDLnQDEIyF9Drtf8hbru/Kh4+nNDJaSpx1wCr6JRPHmsH6zqEvCcdxIk4MFCu1MG+BE3L/i/HZFZRSxEY8fDMNCRZhz9gwROsXj/nyzBZPOa/E4Zf4Dt+AB/UyUb+5iZJATXF+bHcRvOuh6hVUIAesi5ssPQAvHvffNTuAJE3yB4RH/Jr8wKPi9hLg6xf1tSG2p1IXrJBxj4jXZ9x62ok/voIBVNB9WcQOJXLt6rKG67+zWcAJDzki9paSdar1hm/1u2jNeEc43rHkWQOhJeRXKZHseC3l3GcYcSL9kpGlBv+SMdOq+SHiKDeCSP1xQGGqBsq2Wg7TWkZ5bxy/8LDnL4Ytc4R2AkD9+CjdJKog0ubtn5MEX14eIueE9ukFpQG9qvo9HVzz3fJlo7tLpzePlOPr9ATW90kg2OlkRbMgTBOxouRgqhWJPTNJz0oFv9eDx8JiOfGKf9jhkN6WhLCQbm1yZ2G2UHCFFMtJUZj7ryUf1Ggd9t5WzqJ5Lrtk67ijo/zLi1jQ9+9HJQCeSbAMl+9BBjo5eQ5qB9AHGe35QfosTaRdsiD8X0S0udRF5ToyOQNTUQ6HcdTtzRm8gUCxj5RFYQc94+LGqiApXcm08AR8LNZMczVgFcV00TcdQmJbNilzmA0yW2RXnj//3BGqQzN9TrnJxqdloXghRiWEtAmH2Ve2NNz0jNaFL9Q= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(39860400002)(396003)(346002)(46966006)(36840700001)(40470700004)(82310400005)(40480700001)(7636003)(110136005)(83380400001)(8676002)(107886003)(82740400003)(36860700001)(2616005)(42186006)(336012)(6666004)(186003)(478600001)(356005)(47076005)(70206006)(2906002)(6266002)(8936002)(54906003)(5660300002)(44832011)(316002)(426003)(70586007)(36756003)(41300700001)(40460700003)(4326008)(26005)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 12:06:13.4592 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fef2375c-ccc5-4728-bcbe-08da55d9ef45 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT053.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR02MB8876 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Raviteja Narayanam When a combined message request comes from user space, the controller has to initiate repeated start sequence. In standard mode, this repeated start sequence is corrupted if there is still data in the Tx FIFO. So, always make sure that all the bytes are completely transmitted out of the FIFO by waiting for TXEMPTY, if the previous message is of Tx type. Signed-off-by: Raviteja Narayanam Signed-off-by: Manikanta Guntupalli --- drivers/i2c/busses/i2c-xiic.c | 54 +++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index c8b68176427c..2d5214f1ba03 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -62,6 +62,7 @@ enum xiic_endian { * @singlemaster: Indicates bus is single master * @dynamic: Mode of controller * @repeated_start: Repeated start operation + * @prev_msg_tx: Previous message is Tx */ struct xiic_i2c { struct device *dev; @@ -80,6 +81,7 @@ struct xiic_i2c { bool singlemaster; bool dynamic; bool repeated_start; + bool prev_msg_tx; }; =20 #define XIIC_MSB_OFFSET 0 @@ -282,6 +284,24 @@ static int xiic_clear_rx_fifo(struct xiic_i2c *i2c) return 0; } =20 +static int xiic_wait_tx_empty(struct xiic_i2c *i2c) +{ + u8 isr; + unsigned long timeout; + + timeout =3D jiffies + XIIC_I2C_TIMEOUT; + for (isr =3D xiic_getreg32(i2c, XIIC_IISR_OFFSET); + !(isr & XIIC_INTR_TX_EMPTY_MASK); + isr =3D xiic_getreg32(i2c, XIIC_IISR_OFFSET)) { + if (time_after(jiffies, timeout)) { + dev_err(i2c->dev, "Timeout waiting at Tx empty\n"); + return -ETIMEDOUT; + } + } + + return 0; +} + static int xiic_reinit(struct xiic_i2c *i2c) { int ret; @@ -731,6 +751,20 @@ static void xiic_start_recv(struct xiic_i2c *i2c) xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, val); local_irq_restore(flags); } else { + /* + * If previous message is Tx, make sure that Tx FIFO is empty + * before starting a new transfer as the repeated start in + * standard mode can corrupt the transaction if there are + * still bytes to be transmitted in FIFO + */ + if (i2c->prev_msg_tx) { + int status; + + status =3D xiic_wait_tx_empty(i2c); + if (status) + return; + } + cr =3D xiic_getreg8(i2c, XIIC_CR_REG_OFFSET); =20 /* Set Receive fifo depth */ @@ -784,6 +818,8 @@ static void xiic_start_recv(struct xiic_i2c *i2c) =20 /* Enable interrupts */ xiic_setreg32(i2c, XIIC_DGIER_OFFSET, XIIC_GINTR_ENABLE_MASK); + + i2c->prev_msg_tx =3D false; } =20 static void xiic_start_send(struct xiic_i2c *i2c) @@ -820,6 +856,20 @@ static void xiic_start_send(struct xiic_i2c *i2c) =20 xiic_fill_tx_fifo(i2c); } else { + /* + * If previous message is Tx, make sure that Tx FIFO is empty + * before starting a new transfer as the repeated start in + * standard mode can corrupt the transaction if there are + * still bytes to be transmitted in FIFO + */ + if (i2c->prev_msg_tx) { + int status; + + status =3D xiic_wait_tx_empty(i2c); + if (status) + return; + } + /* Check if RSTA should be set */ cr =3D xiic_getreg8(i2c, XIIC_CR_REG_OFFSET); if (cr & XIIC_CR_MSMS_MASK) { @@ -853,6 +903,7 @@ static void xiic_start_send(struct xiic_i2c *i2c) XIIC_INTR_TX_ERROR_MASK | XIIC_INTR_BNB_MASK); } + i2c->prev_msg_tx =3D true; } =20 static void __xiic_start_xfer(struct xiic_i2c *i2c) @@ -916,6 +967,9 @@ static int xiic_xfer(struct i2c_adapter *adap, struct i= 2c_msg *msgs, int num) /* Decide standard mode or Dynamic mode */ i2c->dynamic =3D true; =20 + /* Initialize prev message type */ + i2c->prev_msg_tx =3D false; + /* Enter standard mode only when read length is > 255 bytes */ for (count =3D 0; count < i2c->nmsgs; count++) { if ((i2c->tx_msg[count].flags & I2C_M_RD) && --=20 2.25.1 From nobody Sun Apr 19 23:31:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 335AFC43334 for ; Fri, 24 Jun 2022 12:06:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231826AbiFXMGz (ORCPT ); Fri, 24 Jun 2022 08:06:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231847AbiFXMGx (ORCPT ); Fri, 24 Jun 2022 08:06:53 -0400 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2048.outbound.protection.outlook.com [40.107.93.48]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCBC87FD1F; Fri, 24 Jun 2022 05:06:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BxAXKjFypJksmVyUXmdkP/g4kyhOVk5jVf+EPAyY/tm8HIPfizFV46b4S8ubSmZ9EEYQt2nZ/xs1omrxzAYoEpL1EWbQLcdzYTQoSKP5d8cUt6AJ+6yHfOOWuDq7Bs1u7QjEEnkV2wjiLGt9xoRyHe0XqMbQHOXTHAaOD/aWtn8C39CK8D8EYwWzDiXhsXsmQpQBxA0R2+V1HKURgt7ijitoEm6hFlq2XK5KbXlO495VW8AEaNwO0yXMAe9HmI0hcOnRjReEoLJs2dL7lea3zgGtnnKEazb1Znton92ULdm0GcDidiZ4dk5eNfatiwt3K3Vp73E8FEwKbTGUeGCBjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JLoIQatsTzciqaKcDsrIkk3NhUIFHoZHUaZhb4sVahg=; b=bVwRO254cJ6OQRuZPoEGaj8TVxlQ3J8sHTx9PfXp/JM8q+qaBoartGPvMNIshPEU9kX2hYvvRyr7m+wVtk8/NDzUf8KffiFJ4V7hCleimasvRpClHfr6OAxogNHzQoxCf9yna56Swf6D2QPlJ99p8ZS/GqpyoGk7tsezQgQgnv6++ZhSn+5GmfSJ6FIFSrj+P8P/HrCAz+VbaR0fKeTo7O2ZbNhcSUSNs5WdGaIokyLoRPyMz5iyZhwWwu1Y3hIE5//IxWhar5iygd67V4sjibJy+W0ImMcC8ADQGbG/2I+iH6G3oceeoA4dvZvkQnaHMnwUddfFmXBmy9vyvrFbYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=amd.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JLoIQatsTzciqaKcDsrIkk3NhUIFHoZHUaZhb4sVahg=; b=A7q3ipsnIGIMxpKylMB5uOnIx+jjFDvpkZg+m6z3FhqWhcyyzllNhmyrLdK4JBDW673pXrzMQlak7zDpVmuFOKjYFj944hIaPL4ANYmEJ7m8yjg9byf+557fHkJESSRz5p77NKG852IpiqM31bs1NX7D6hOZk3TWLTa9A6+MVZ8= Received: from BN0PR02CA0041.namprd02.prod.outlook.com (2603:10b6:408:e5::16) by SN1PR02MB3853.namprd02.prod.outlook.com (2603:10b6:802:24::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.18; Fri, 24 Jun 2022 12:06:47 +0000 Received: from BN1NAM02FT023.eop-nam02.prod.protection.outlook.com (2603:10b6:408:e5:cafe::f1) by BN0PR02CA0041.outlook.office365.com (2603:10b6:408:e5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:06:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT023.mail.protection.outlook.com (10.13.2.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:06:47 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 24 Jun 2022 05:06:25 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 24 Jun 2022 05:06:25 -0700 Envelope-to: git@amd.com, michal.simek@amd.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Received: from [172.23.64.2] (port=47733 helo=xhdvnc102.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o4i4v-0005Lb-Hv; Fri, 24 Jun 2022 05:06:25 -0700 Received: by xhdvnc102.xilinx.com (Postfix, from userid 90444) id A7C16104548; Fri, 24 Jun 2022 17:35:38 +0530 (IST) From: Manikanta Guntupalli To: , , , , , CC: Raviteja Narayanam , Manikanta Guntupalli Subject: [PATCH 04/12] i2c: xiic: Add wait for FIFO empty in send_tx Date: Fri, 24 Jun 2022 17:35:19 +0530 Message-ID: <1656072327-13628-5-git-send-email-manikanta.guntupalli@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> References: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fba88ecf-ba2c-4f8b-2f85-08da55da036b X-MS-TrafficTypeDiagnostic: SN1PR02MB3853:EE_ X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UrOTDu6XRP3dQ2gePL5yzb/fP0F7tyiVR5kpSMwL/F5nskQPr5sR0IUuc8U80yyCmE64SBdSHOhhVBPOX0qK51lCM3JV6z/Fke3pwO5Z0roKHQibW//9RQ3x7kCxJvXq0QRa+VNw2DyYmk8ktMvMvXToIbBacVWFUY3r2Mo/Rx/YsBgiBvteMB+00ZySc+1hGwx98vmZFe1fInUO8CeZ27HyG9mvZsLEZzZLusbgc12j0m7qiUPWtkYtEpgGalSMo/gYSZZc7gefz6+0HiaBvi30JUtwhz+xD36rN7IzcH0ZuMFbKNNHHq3TNCqfsM+eNJG1myri8AugKrhbvIMVBIDGMPTLuzxKbrJxLDeIxjfmRG1I8LnsLMpq/2+gPaoZ4c29ZCrI71siDCJSZfUirVdfiw1JmcrO9G8zyUIndaEM9Tjh3byS2cW5tuX3TgX0/3XiHR/+b9meYoqF/Fr2rnhUaiWAiEF44HD95bg9adGBmX+Tlo7QPpAsDO6+n56gX4kj2RJl9qISDllDwr2wvPlKJZfXU5xiO8APVaCtovwA3DLOnfzoHj6WvONbWjxFgTZ+YnkerNJXoB9PPTti5WcwmlHf1HnxqhFduUcWrNtp1eQjiOjPnqsq/+aP4f+wUBLu2rpeLYTlS6Qgt6YPRaSI1N1In2t2nUNJ7yNnhZJfXUdT9P0h2jnxoDiAPblkhFmW3iXJNvwpBYaWnFRa1sp8M1KrOzZgOhTUGxuk/MMe/aL8RuH+R09SGOB1Re2+e5ERQX6I8gfxMK91Zwd6EbigddFcyDMWzKBnL8UUDsAT5ntKTXDv0QrFkfY0MDWm0Ge3rXGKuBTyhrXNgsxy2xpr3Ubq8NPpUfREIlqR+YA= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(376002)(346002)(136003)(40470700004)(46966006)(36840700001)(8936002)(36860700001)(41300700001)(2906002)(40480700001)(110136005)(42186006)(70206006)(5660300002)(8676002)(70586007)(316002)(107886003)(478600001)(186003)(4326008)(2616005)(356005)(6266002)(7636003)(26005)(426003)(54906003)(336012)(6666004)(82740400003)(82310400005)(40460700003)(44832011)(36756003)(47076005)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 12:06:47.3527 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fba88ecf-ba2c-4f8b-2f85-08da55da036b X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT023.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB3853 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Raviteja Narayanam If the tx_half_empty interrupt comes first instead of tx_empty, STOP bit is generated even before all the bytes are transmitted out on the bus. STOP bit should be sent only after all the bytes in the FIFO are transmitted out of the FIFO. So wait until FIFO is empty before sending the STOP bit. Signed-off-by: Raviteja Narayanam Signed-off-by: Manikanta Guntupalli --- drivers/i2c/busses/i2c-xiic.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 2d5214f1ba03..9c3266ac209e 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -472,6 +472,12 @@ static void xiic_send_tx(struct xiic_i2c *i2c) =20 if (i2c->nmsgs =3D=3D 1) { u8 cr; + int status; + + /* Wait till FIFO is empty so STOP is sent last */ + status =3D xiic_wait_tx_empty(i2c); + if (status) + return; =20 /* Write to CR to stop */ cr =3D xiic_getreg8(i2c, XIIC_CR_REG_OFFSET); --=20 2.25.1 From nobody Sun Apr 19 23:31:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15806C433EF for ; Fri, 24 Jun 2022 12:06:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231786AbiFXMGs (ORCPT ); Fri, 24 Jun 2022 08:06:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231696AbiFXMGn (ORCPT ); Fri, 24 Jun 2022 08:06:43 -0400 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2063.outbound.protection.outlook.com [40.107.243.63]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BCDD7E03A; Fri, 24 Jun 2022 05:06:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DQmY+wIEnoUEZKS+bH3ONCVJmkOh5u0v9FPEC311MGtCisyWUNIGEJ/PqTdy5Bjo8FdK1iH4zMmwot38FfCvoSKG2xqxP84LonaMvVxGAzeQfnmst0CDTLe27UNYdU+ssK773HRork72ZItl0hDC3Q0zItHrzIT19eVfety5dCix1e987JY4icoe/ddrDB/imlH72/gm5Ca7i3F53WuTqTPpw6wTFv6M9co6VvreTlxR4y40KiDSlPC5ogrM9QGlZIteJPWUFIXgVZdN0hn3B+e77eDvJF4Pp8THd2DiCrvRynS7ea9VMH7KNjAtnvDM8Z12RDdaPU0Gis7k5NuXyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xeQwoQ0RRLoXHdY9/bwrGuA2PNBPb0svqiany5xuwuY=; b=ggVbqRdxjCAH6t/KgkXje5roRbo4hylg7xgDTuqPP3OAhL61xLQ44qgwaPaN+56ZiU2DxdqSYtwPA4msYoZ6RD1i3YegAsUioVGtxOkI7QjPzkYOAXysXPAADdFM8GgCbScDqMJv02+Z4RUEVj482YQvvHZPJg7tWSvJhKRqW0iICd1ZfR3wUm8SSVrxomLlxS356IOOaJgaEsPr4mJwM25KPNT3Z/Bv8roCDaADEf4gjkO8mpZ8XV6J0pCtVMz30WY3CdEYkbguzj0hevpwuSdd5dHCLhL042iUBxoyiQJFBsN0uvkkNJXGore+2bjXb/5Sk6UgTulO0Q/QRuE80g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=amd.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xeQwoQ0RRLoXHdY9/bwrGuA2PNBPb0svqiany5xuwuY=; b=gkXBADh4f9GF57iA4IHKX7CDgJWkqK5Eac3KTOTR6PSl5pdp/WNeZwmaOrWE9do1DSniCEzM0ZMESbKgo6b1n4+hAYKtlyzl4riILX5WKWvsMwF4HMt0LQFwZXZJxG0jGFtnEdI660+i+pRxlhhYvcAIeIhXH7FWbDsfa4MNfB4= Received: from SN7PR04CA0099.namprd04.prod.outlook.com (2603:10b6:806:122::14) by DM5PR02MB2810.namprd02.prod.outlook.com (2603:10b6:3:10c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Fri, 24 Jun 2022 12:06:40 +0000 Received: from SN1NAM02FT0025.eop-nam02.prod.protection.outlook.com (2603:10b6:806:122:cafe::9e) by SN7PR04CA0099.outlook.office365.com (2603:10b6:806:122::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:06:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0025.mail.protection.outlook.com (10.97.5.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:06:39 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 24 Jun 2022 05:06:38 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 24 Jun 2022 05:06:38 -0700 Envelope-to: git@amd.com, michal.simek@amd.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Received: from [172.23.64.2] (port=47734 helo=xhdvnc102.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o4i58-0005MC-LE; Fri, 24 Jun 2022 05:06:38 -0700 Received: by xhdvnc102.xilinx.com (Postfix, from userid 90444) id D8FEB104549; Fri, 24 Jun 2022 17:35:45 +0530 (IST) From: Manikanta Guntupalli To: , , , , , CC: Raviteja Narayanam , Manikanta Guntupalli Subject: [PATCH 05/12] i2c: xiic: Use 'nmsgs' variable instead of repeated_start Date: Fri, 24 Jun 2022 17:35:20 +0530 Message-ID: <1656072327-13628-6-git-send-email-manikanta.guntupalli@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> References: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bdbe2081-03e0-405d-61ae-08da55d9fec9 X-MS-TrafficTypeDiagnostic: DM5PR02MB2810:EE_ X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2vL1Cisg6WEONRv/6FZZTKZgmKvy6MS/XjA/PEOd/vidacEy7c/HrNR8AV6ne9wmiAbSKJKh14uo/hHRZ4rmPWb7J0/pj8ZUt3RllC92vVE3kA2uxOPOCkE99l7zXj7eHXZVhtxdQibR4O48UGwTj/TJnZfOCNdIdeA8NV2b7FVcrbo5+f9qYl6Q65xZ0vyUIvydSh+2zm+15rWd8HLi2qIKz7nXNhoS5acvLfz1by+pgPmUo+i8yDfx9+r8P/m75W/rWRS3Q9HnSriQezTR4iGYCB/sr+S4Xl7nzeL1AdriBz8oTlNk1hiVvj5oaDcZYtUdhk1xuutylFf2FTs3IZcl3WiH8xwsI8dRIDBmYjLZMGbigFtx0t/blUQ3aFESEaQ+PA3sfSmeyeJlwOmifXEDFmZY0Bw4EQrgVtwN6acT/s61Ku+6UXqVHWERGe4VfljemCunCfpEIUgQ/kNu3QMsR1YsS7JPqwmgHrKwGDeapKqMrCOG578wFrvd9X5h6hAgwTLypkCZgo+j13HwNR4qLp77KjH6iKZ1haOQHXnPnb7yo69ckALoOCASBmf5b/pogE+Ro7l4msHlwkH3a2F/AFh18qn98Y4xCeUib0C01zv7CxWYLDrjHSRRvhD3Kn40ODFmUqJRSb2G663M+I+kA1r4v2BOCjViWpGk8aiDYPjyhr1w8oXkiD5gM5+WAP+6e0UoN2maCk1e1lAA0w95hYBMo1OxZeUeU9uqHQ04uv9AQK8ZzegaWgHQ6IoGOmKgAkceEnJBH5wqVTv5bnOgjOIBJYseTUD+oWQ0mkBhn1dgwzqI1oOFvvccjk3D9Z2Eb/JQxzjwLqSYNkdb1md45Nnl/9Ez3FIi3sEpuWM= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(396003)(346002)(136003)(46966006)(40470700004)(36840700001)(44832011)(7636003)(316002)(2906002)(54906003)(70586007)(8936002)(110136005)(8676002)(356005)(5660300002)(70206006)(40460700003)(82740400003)(4326008)(478600001)(83380400001)(41300700001)(26005)(6266002)(42186006)(40480700001)(47076005)(2616005)(107886003)(6666004)(186003)(82310400005)(36860700001)(426003)(336012)(36756003)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 12:06:39.5971 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bdbe2081-03e0-405d-61ae-08da55d9fec9 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0025.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB2810 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Raviteja Narayanam Remove the redundant repeated_start variable as it is setup at different places, and read at only one place which can be decided by 'nmsgs' variable alone. Signed-off-by: Raviteja Narayanam Signed-off-by: Manikanta Guntupalli --- drivers/i2c/busses/i2c-xiic.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 9c3266ac209e..3debb44608cf 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -61,7 +61,6 @@ enum xiic_endian { * @state: See STATE_ * @singlemaster: Indicates bus is single master * @dynamic: Mode of controller - * @repeated_start: Repeated start operation * @prev_msg_tx: Previous message is Tx */ struct xiic_i2c { @@ -80,7 +79,6 @@ struct xiic_i2c { enum xilinx_i2c_state state; bool singlemaster; bool dynamic; - bool repeated_start; bool prev_msg_tx; }; =20 @@ -445,7 +443,7 @@ static void xiic_std_fill_tx_fifo(struct xiic_i2c *i2c) =20 if (len > fifo_space) len =3D fifo_space; - else if (len && !(i2c->repeated_start)) + else if (len && !(i2c->nmsgs > 1)) len--; =20 while (len--) { @@ -786,7 +784,6 @@ static void xiic_start_recv(struct xiic_i2c *i2c) } /* Check if RSTA should be set */ if (cr & XIIC_CR_MSMS_MASK) { - i2c->repeated_start =3D true; /* Already a master, RSTA should be set */ xiic_setreg8(i2c, XIIC_CR_REG_OFFSET, (cr | XIIC_CR_REPEATED_START_MASK) & @@ -805,7 +802,6 @@ static void xiic_start_recv(struct xiic_i2c *i2c) =20 /* Write to Control Register,to start transaction in Rx mode */ if ((cr & XIIC_CR_MSMS_MASK) =3D=3D 0) { - i2c->repeated_start =3D false; xiic_setreg8(i2c, XIIC_CR_REG_OFFSET, (cr | XIIC_CR_MSMS_MASK) & ~(XIIC_CR_DIR_IS_TX_MASK)); @@ -879,7 +875,6 @@ static void xiic_start_send(struct xiic_i2c *i2c) /* Check if RSTA should be set */ cr =3D xiic_getreg8(i2c, XIIC_CR_REG_OFFSET); if (cr & XIIC_CR_MSMS_MASK) { - i2c->repeated_start =3D true; /* Already a master, RSTA should be set */ xiic_setreg8(i2c, XIIC_CR_REG_OFFSET, (cr | XIIC_CR_REPEATED_START_MASK | @@ -895,7 +890,6 @@ static void xiic_start_send(struct xiic_i2c *i2c) xiic_std_fill_tx_fifo(i2c); =20 if ((cr & XIIC_CR_MSMS_MASK) =3D=3D 0) { - i2c->repeated_start =3D false; =20 /* Start Tx by writing to CR */ cr =3D xiic_getreg8(i2c, XIIC_CR_REG_OFFSET); --=20 2.25.1 From nobody Sun Apr 19 23:31:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56165C433EF for ; Fri, 24 Jun 2022 12:07:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231862AbiFXMG7 (ORCPT ); Fri, 24 Jun 2022 08:06:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231834AbiFXMG4 (ORCPT ); Fri, 24 Jun 2022 08:06:56 -0400 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2054.outbound.protection.outlook.com [40.107.244.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9F117FD0B; Fri, 24 Jun 2022 05:06:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T0ibyOyrXbPFSUh6mYyKzU2HhMvY5RCFxKS39b5W1+WB0ZKaJC00xuoXJUBVWWhchp4E6XQKBfDHZdXwI8yJSqkCkBQYOJ6lUMrti854BMJZ8+wKEJ4Mr14mfhgpZOcshgzxYj8t9XcHYTxq1wpBmz+EbW1ixxpLqd11vrSnxZkKsxjEIu/oqFcfGe2LoYppWt/F+SMtTR0DoF7HJBYJNiF3NxRLroEPFg2bys7Ql1OkWvMfcbhbjOIHNt3AAvqacNs8uzM16ZXmYyETZqzxg1XZ6xU+Pt51RvortPTxuXSFwbWcDhv04zlnHCG3ILS7MYTbGkrHxRbKOD70w+pYog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/2AKS8s6dnWrCDGJXZ6uq+SKqvilRAa8SP3IfLFzYZ8=; b=QmiiJ0A9sl7H0neb49mEmm/88bUGTPtPB4ZltDcvxLnuMuZlH5wN7I/a8Qfg2GpZ6YQ5+s+//ZUhWGXI7tFPgJYSvEGtaLwUqP4G+aHm3Y9J3Uc0Ko8c+nK3DWxIKJjQ5Jr+a7SIQZjv65JENuHu8SrcU1x/B57Dbr0pKA3YAj6DwHkichcZ9npu4rBDWMCAEq351hhzLrr/ZBZtDCovyAeOjPw4PCd7U/HWxRNDYWxZd7Hvhprh4Z3CYbYv8n866neK5xJY7UzAMJYZo/kUmL07SjhXto0HSs2yEdZqSfynAbL8+XPe9cZ7/nNeDREqYJ587kdMsytGQNt0Arjf7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=amd.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/2AKS8s6dnWrCDGJXZ6uq+SKqvilRAa8SP3IfLFzYZ8=; b=Oe6RO5tS0ez2fmdTv+PpH92Nt0xqJKfQjc2cwWHDzCEXB2uUCoCtVjDhAjHLw/82sCVVOwLFC/IzFiyFZ+4FSmfG4i8K36CDV+f1ekb/H+IuU41IZEe+WxFxEODa3LBETJ2/d3iMuzPp+2V7EOLpM9hh74iZ5dJUMKcttBxP2jY= Received: from SN7PR04CA0236.namprd04.prod.outlook.com (2603:10b6:806:127::31) by BL0PR02MB4963.namprd02.prod.outlook.com (2603:10b6:208:54::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Fri, 24 Jun 2022 12:06:53 +0000 Received: from SN1NAM02FT0049.eop-nam02.prod.protection.outlook.com (2603:10b6:806:127:cafe::99) by SN7PR04CA0236.outlook.office365.com (2603:10b6:806:127::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:06:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0049.mail.protection.outlook.com (10.97.5.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:06:52 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 24 Jun 2022 05:06:52 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 24 Jun 2022 05:06:52 -0700 Envelope-to: git@amd.com, michal.simek@amd.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Received: from [172.23.64.2] (port=47735 helo=xhdvnc102.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o4i5L-0005Mt-OS; Fri, 24 Jun 2022 05:06:52 -0700 Received: by xhdvnc102.xilinx.com (Postfix, from userid 90444) id 53B9E104545; Fri, 24 Jun 2022 17:35:48 +0530 (IST) From: Manikanta Guntupalli To: , , , , , CC: Raviteja Narayanam , Manikanta Guntupalli Subject: [PATCH 06/12] i2c: xiic: Add smbus_block_read functionality Date: Fri, 24 Jun 2022 17:35:21 +0530 Message-ID: <1656072327-13628-7-git-send-email-manikanta.guntupalli@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> References: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3e0ad034-d185-405d-1831-08da55da0696 X-MS-TrafficTypeDiagnostic: BL0PR02MB4963:EE_ X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qQ6r0vxNkZQbdKrasBfTQ33FT+aqIY4mNyyZxDa5wkmKQ+UaWuc4Oq7laPKPpaIoaq/0p4tJ7UN2M0J6sPO9qCREyfwNBqgjey+vvShiVR0d2NlB3ZLjLtuKnUdjzxlapCcNWaGxisfGkF+1Ub5GBL9ltJ7r+kikLVyBbyWHxpbjgQKw2v6HOxTX2Qk3B1ZdLXeAPnaMINwyv7qJ1rhnFryFcCNxyC7+7b4llq7wUIv0p7gQO1t+KHsBD5O7idqRC5i+rNimascH4rMaiVRc3t6zP3xYCbq6Fa9Zg5iwFmT51qEDKwicoXRsxv6Ojwx6ZsL9gG+iH24mx+4Y5iSntmyS1MKUEI/G/Oqzk4kzJ+H9RIyZI1PC94xhFf8Eay8nnCDCCNDooVqrLuOT3Y9ZNT7EywctD65vtBsfM4pC1I+gm0g4oVrRoKUBJ7SSMu8r2laheMZSdKk2n3h4kOvap2C6CWMsSLe751NYsHmAP2R1g64wIiplG+0fN8cNtbN4H8aGM2eaQ/CyP4ZzbyGu2Hk6uRtTixUN5bzlzA44m3XzT6Ge6WCe/RN4yH8JGuwZ06pwdlxO8mIip4MBGKZ3XwNcGDBd+iboWkwniskECq/8ZwvwYXT/GSjhrBLZIaJ8Snrt1aq+vmQN9So3SYePsamT5/E3NIZBsbpstq4+9bJkxwyCRPp3SeUsOwTQOxG3khSbUagVwU+62L0IsUJKlBynIoIt9XoO7AUC1+2D5k8qPnBGmy2oBCoCVWfS2brFkntZoxtIt+j2rPKHPUy6C008fo/jhPKhRGPSX0znp7Phq/avQds4xsPhwhnu5wTKq+5KBJM67hPODnvUN663FSSXQa6hXE4adIxdayKfL2BKtdcFZfj8aPvzrnvVnDuf X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(136003)(396003)(376002)(36840700001)(46966006)(40470700004)(40480700001)(36756003)(2906002)(41300700001)(70206006)(83380400001)(40460700003)(44832011)(8936002)(316002)(70586007)(54906003)(42186006)(110136005)(5660300002)(478600001)(2616005)(47076005)(4326008)(336012)(26005)(107886003)(8676002)(82310400005)(6666004)(82740400003)(7636003)(36860700001)(356005)(43170500006)(6266002)(186003)(426003)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 12:06:52.7296 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3e0ad034-d185-405d-1831-08da55da0696 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0049.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB4963 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Raviteja Narayanam smbus_block_read is added to xiic driver to read from few sensors which support this command. Since the number of bytes to read is not known prior to transfer, we are using xiic standard mode for low level control of IP. Signed-off-by: Raviteja Narayanam Signed-off-by: Manikanta Guntupalli Tested-by: Krzysztof Adamski --- drivers/i2c/busses/i2c-xiic.c | 82 ++++++++++++++++++++++++++++++++--- 1 file changed, 76 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 3debb44608cf..57ede62de67d 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -62,6 +62,7 @@ enum xiic_endian { * @singlemaster: Indicates bus is single master * @dynamic: Mode of controller * @prev_msg_tx: Previous message is Tx + * @smbus_block_read: Flag to handle block read */ struct xiic_i2c { struct device *dev; @@ -80,6 +81,7 @@ struct xiic_i2c { bool singlemaster; bool dynamic; bool prev_msg_tx; + bool smbus_block_read; }; =20 #define XIIC_MSB_OFFSET 0 @@ -339,6 +341,54 @@ static void xiic_deinit(struct xiic_i2c *i2c) xiic_setreg8(i2c, XIIC_CR_REG_OFFSET, cr & ~XIIC_CR_ENABLE_DEVICE_MASK); } =20 +static void xiic_smbus_block_read_setup(struct xiic_i2c *i2c) +{ + u8 rxmsg_len; + u8 rfd_set =3D 0; + + /* + * Clear the I2C_M_RECV_LEN flag to avoid setting + * message length again + */ + i2c->rx_msg->flags &=3D ~I2C_M_RECV_LEN; + + /* Set smbus_block_read flag to identify in isr */ + i2c->smbus_block_read =3D true; + + /* Read byte from rx fifo and set message length */ + rxmsg_len =3D xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET); + + i2c->rx_msg->buf[i2c->rx_pos++] =3D rxmsg_len; + + /* Check if received length is valid */ + if (rxmsg_len <=3D I2C_SMBUS_BLOCK_MAX) { + /* Set Receive fifo depth */ + if (rxmsg_len > IIC_RX_FIFO_DEPTH) { + rfd_set =3D IIC_RX_FIFO_DEPTH - 1; + i2c->rx_msg->len =3D rxmsg_len + 1; + } else if ((rxmsg_len =3D=3D 1) || + (rxmsg_len =3D=3D 0)) { + /* + * Minimum of 3 bytes required to exit cleanly. 1 byte + * already received, Second byte is being received. Have + * to set NACK in read_rx before receiving the last byte + */ + i2c->rx_msg->len =3D 3; + } else { + rfd_set =3D rxmsg_len - 2; + i2c->rx_msg->len =3D rxmsg_len + 1; + } + xiic_setreg8(i2c, XIIC_RFD_REG_OFFSET, rfd_set); + + return; + } + + /* Invalid message length, trigger STATE_ERROR with tx_msg_len in ISR */ + i2c->tx_msg->len =3D 3; + i2c->smbus_block_read =3D false; + dev_err(i2c->adap.dev.parent, "smbus_block_read Invalid msg length\n"); +} + static void xiic_read_rx(struct xiic_i2c *i2c) { u8 bytes_in_fifo, cr =3D 0, bytes_to_read =3D 0; @@ -361,6 +411,12 @@ static void xiic_read_rx(struct xiic_i2c *i2c) if (!i2c->dynamic) { bytes_rem =3D xiic_rx_space(i2c) - bytes_in_fifo; =20 + /* Set msg length if smbus_block_read */ + if (i2c->rx_msg->flags & I2C_M_RECV_LEN) { + xiic_smbus_block_read_setup(i2c); + return; + } + if (bytes_rem > IIC_RX_FIFO_DEPTH) { bytes_to_read =3D bytes_in_fifo; } else if (bytes_rem > 1) { @@ -638,6 +694,12 @@ static irqreturn_t xiic_process(int irq, void *dev_id) /* The bus is not busy, disable BusNotBusy interrupt */ xiic_irq_dis(i2c, XIIC_INTR_BNB_MASK); =20 + if (i2c->tx_msg && i2c->smbus_block_read) { + i2c->smbus_block_read =3D false; + /* Set requested message len=3D1 to indicate STATE_DONE */ + i2c->tx_msg->len =3D 1; + } + if (!i2c->tx_msg) goto out; =20 @@ -777,8 +839,12 @@ static void xiic_start_recv(struct xiic_i2c *i2c) rfd_set =3D IIC_RX_FIFO_DEPTH - 1; } else if ((rx_watermark =3D=3D 1) || (rx_watermark =3D=3D 0)) { rfd_set =3D rx_watermark - 1; - /* Handle single byte transfer separately */ - cr |=3D XIIC_CR_NO_ACK_MASK; + + /* Set No_ACK, except for smbus_block_read */ + if (!(i2c->rx_msg->flags & I2C_M_RECV_LEN)) { + /* Handle single byte transfer separately */ + cr |=3D XIIC_CR_NO_ACK_MASK; + } } else { rfd_set =3D rx_watermark - 2; } @@ -970,10 +1036,14 @@ static int xiic_xfer(struct i2c_adapter *adap, struc= t i2c_msg *msgs, int num) /* Initialize prev message type */ i2c->prev_msg_tx =3D false; =20 - /* Enter standard mode only when read length is > 255 bytes */ + /* + * Enter standard mode only when read length is > 255 bytes or + * for smbus_block_read transaction + */ for (count =3D 0; count < i2c->nmsgs; count++) { - if ((i2c->tx_msg[count].flags & I2C_M_RD) && - i2c->tx_msg[count].len > MAX_READ_LENGTH_DYNAMIC) { + if (((i2c->tx_msg[count].flags & I2C_M_RD) && + i2c->tx_msg[count].len > MAX_READ_LENGTH_DYNAMIC) || + (i2c->tx_msg[count].flags & I2C_M_RECV_LEN)) { i2c->dynamic =3D false; break; } @@ -1007,7 +1077,7 @@ static int xiic_xfer(struct i2c_adapter *adap, struct= i2c_msg *msgs, int num) =20 static u32 xiic_func(struct i2c_adapter *adap) { - return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL | I2C_FUNC_SMBUS_BLOCK_DATA; } =20 static const struct i2c_algorithm xiic_algorithm =3D { --=20 2.25.1 From nobody Sun Apr 19 23:31:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B633DCCA473 for ; Fri, 24 Jun 2022 12:07:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231890AbiFXMH1 (ORCPT ); Fri, 24 Jun 2022 08:07:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231912AbiFXMHX (ORCPT ); Fri, 24 Jun 2022 08:07:23 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2076.outbound.protection.outlook.com [40.107.237.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC3EE7FD1D; Fri, 24 Jun 2022 05:07:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nfah1Na+KULQFj1kFmXC0+zoXwTkgVEfN4ebs8hJcBcAcTf+uxhFxJ/X7NyiY1cEwJEuGludvt65bxIHM1/jQZwEZAhv24G2EpJUmuhhBoqEdsmgqZCJc8p/kGve+X49VKFIdlzopWnxJYctarfpRX2XVPoYsyBMzaN60LOay2DICMqfGyuGm5wwV3OLkePWkgMFahktZG1W8nHRsvRf4NVJAqm9HOISYdhhd17htQdL3E8TEBH00nBZdUBgkKG2gK7nNgpwkv13I5Ail+ge9GOgTofPRovqaXSCVHalKaPEPxX2t3Zyc6AeXavhGqUHy9VnaeLf2P6MsBxtCFnRoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dHMFMQ9G+R2QUl1qoYxbcynk0N7f3QD1ec1BupioQmQ=; b=fuUGlA0KvIeZfgnj2d4orp4yDLO29wIzYoEckejqFy3WJdHnpvx+inGhwOf1D0J+Z54bpJTq5XxxFScObpbS52HWPv4oCu5zBiKiCfwn6Z73Xw0+YSqJ6BuVHc4ivs9jpEP1IXmV5m5+G0t9fvX3Lix132b3FOFeXts3tY3G86rrk0AhIIC3N9JCb/vd6LKiljtCCWPVbdmpEWxulMbW5Yui6fPQ8h3zPiut3eigry8HcVSTsfRSW6B1fFD+v7bTx3j5u2+6Kt5zI+KUMJhd3dth7Cvhj4OiU3LINX+qm1kk1FkpcEOcxZ0+IDGtTMzshTXGG31/gErFy3E0508jxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=amd.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dHMFMQ9G+R2QUl1qoYxbcynk0N7f3QD1ec1BupioQmQ=; b=NuhnzxL8FELcXU1DQHYxkrrsmEa9+787hNAy8TV3usCG5sS1h/rQmnMDUW+NBHsS0uDN55K2tslakHen2rNhRwJOxjRUSmeT477/KVIiGHXtSVq7DGztpal9Rl1XJCcDZxkD37EeCWUoUapfUXw5n9gIjdAuRRhbVrk2YB4zrFI= Received: from BN6PR22CA0051.namprd22.prod.outlook.com (2603:10b6:404:ca::13) by PH0PR02MB8389.namprd02.prod.outlook.com (2603:10b6:510:107::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.16; Fri, 24 Jun 2022 12:07:20 +0000 Received: from BN1NAM02FT062.eop-nam02.prod.protection.outlook.com (2603:10b6:404:ca:cafe::52) by BN6PR22CA0051.outlook.office365.com (2603:10b6:404:ca::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18 via Frontend Transport; Fri, 24 Jun 2022 12:07:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT062.mail.protection.outlook.com (10.13.2.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:07:19 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 24 Jun 2022 05:07:05 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 24 Jun 2022 05:07:05 -0700 Envelope-to: git@amd.com, michal.simek@amd.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Received: from [172.23.64.2] (port=47736 helo=xhdvnc102.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o4i5Z-000BXd-17; Fri, 24 Jun 2022 05:07:05 -0700 Received: by xhdvnc102.xilinx.com (Postfix, from userid 90444) id 60FA110454A; Fri, 24 Jun 2022 17:35:50 +0530 (IST) From: Manikanta Guntupalli To: , , , , , CC: Raviteja Narayanam , Manikanta Guntupalli Subject: [PATCH 07/12] i2c: xiic: Switch to Xiic standard mode for i2c-read Date: Fri, 24 Jun 2022 17:35:22 +0530 Message-ID: <1656072327-13628-8-git-send-email-manikanta.guntupalli@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> References: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7402fd42-74e0-4585-15a1-08da55da16d9 X-MS-TrafficTypeDiagnostic: PH0PR02MB8389:EE_ X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3D6WwgkBXogBrFTEeTAojVCV2pmwOY4M2d96wmD0cYxsnDKETFGKsceRKmXUTp1/uBmWonuitPLsDUhJhL6+7NtNuVILX3D+EK/WgdJTeDIM+JPHTch6CVaeiMn8XK0ByeEtebI5hbbDWprBzr1Y+VMT/Kv5nhe0ARrceYGLKOu2ftynvE9DxS5T7Oym3JFIleKNLCAFnhbh54GBlkRxetWGPB1Q4YhOQ6VEqC1iYgwocbJPYEhL2UGmlieWpDaeM8X3jpIP2Gnhs9/yzumyoJ1ZS0lvLPkd+MZDHhCpdkYfMyqTTOxvEYZjpV6oGAZimXtLilgewSFOXrRwZtTd5RrFCFnY87muQHirhX2QdiCFEXzRd0Xeve72WJNEa+MMCZRfI4Hk8UhACVhWMavSWHdxFduM3sOD6MIMQo2W6RM4uZ6ILzpl2PxRmNoMqVa/q/cKZe8ylhyHAJ2yT9JpF/8rW8H5XCeY3J+HYZm3w+2r/+7nqmoh208bIK2hG0oEYA+VpgmzcNSlauX7Gv/SY72GGVJMO9mEcsZvlpEc8P4UXFbHTdJVk8aLGN6UK0HSSyxxNpuOwsrJLcOw5nODWCo2GbP1WOOUcdM9bMz4IUUMERmZ5W+eELHh1wvVqMudaGMeQY6G1NeSC/FWNTP5UnVXnvrzQK+cOVGR3cF7b7Th8cU4S5jIFSREasAoMcC1pEGBTvI0Ebpv7u6RvJjQCUN7yGcTRFOQzaLa58fgUpLjtaVULgMeNU/JQY1k7W8M2m5/AtAbOQSfvv19kjSWC0pWjNB+dp9RSqMqsy3LnpK5wHQPLjDAdr+Mjtv9J5Utxgwu9FfUyPllcSNPsCaitcRz6Wjzv2yXDx7M7smRV30= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(396003)(136003)(39860400002)(36840700001)(40470700004)(46966006)(70206006)(4326008)(70586007)(8676002)(316002)(41300700001)(82310400005)(44832011)(36860700001)(7636003)(42186006)(336012)(110136005)(356005)(36756003)(47076005)(54906003)(426003)(5660300002)(82740400003)(40480700001)(478600001)(26005)(6266002)(186003)(83380400001)(40460700003)(2906002)(8936002)(107886003)(6666004)(2616005)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 12:07:19.9497 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7402fd42-74e0-4585-15a1-08da55da16d9 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT062.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB8389 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Raviteja Narayanam Xilinx I2C IP has two modes of operation, both of which implement I2C transactions. The only difference from sw perspective is the programming sequence for these modes. Dynamic mode -> Simple to program, less number of steps in sequence. Standard mode -> Gives flexibility, more number of steps in sequence. In dynamic mode, during the i2c-read transactions, if there is a delay(> 200us) between the register writes (address & byte count), read transaction fails. On a system with load, this scenario is occurring frequently. To avoid this, switch to standard mode if there is a read request. Added a quirk to identify the IP version effected by this and follow the standard mode. Signed-off-by: Raviteja Narayanam Signed-off-by: Manikanta Guntupalli --- drivers/i2c/busses/i2c-xiic.c | 87 +++++++++++++++++++++++------------ 1 file changed, 58 insertions(+), 29 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 57ede62de67d..74cd50478694 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -32,6 +32,7 @@ #include =20 #define DRIVER_NAME "xiic-i2c" +#define DYNAMIC_MODE_READ_BROKEN_BIT BIT(0) =20 enum xilinx_i2c_state { STATE_DONE, @@ -63,6 +64,7 @@ enum xiic_endian { * @dynamic: Mode of controller * @prev_msg_tx: Previous message is Tx * @smbus_block_read: Flag to handle block read + * @quirks: To hold platform specific bug info */ struct xiic_i2c { struct device *dev; @@ -82,6 +84,11 @@ struct xiic_i2c { bool dynamic; bool prev_msg_tx; bool smbus_block_read; + u32 quirks; +}; + +struct xiic_version_data { + u32 quirks; }; =20 #define XIIC_MSB_OFFSET 0 @@ -995,7 +1002,8 @@ static void __xiic_start_xfer(struct xiic_i2c *i2c) =20 static int xiic_start_xfer(struct xiic_i2c *i2c, struct i2c_msg *msgs, int= num) { - int ret; + bool broken_read, max_read_len, smbus_blk_read; + int ret, count; =20 mutex_lock(&i2c->lock); =20 @@ -1008,6 +1016,34 @@ static int xiic_start_xfer(struct xiic_i2c *i2c, str= uct i2c_msg *msgs, int num) i2c->nmsgs =3D num; init_completion(&i2c->completion); =20 + /* Decide standard mode or Dynamic mode */ + i2c->dynamic =3D true; + + /* Initialize prev message type */ + i2c->prev_msg_tx =3D false; + + /* + * Scan through nmsgs, use dynamic mode when none of the below three + * conditions occur. We need standard mode even if one condition holds + * true in the entire array of messages in a single transfer. + * If read transaction as dynamic mode is broken for delayed reads + * in xlnx,axi-iic-2.0 / xlnx,xps-iic-2.00.a IP versions. + * If read length is > 255 bytes. + * If smbus_block_read transaction. + */ + for (count =3D 0; count < i2c->nmsgs; count++) { + broken_read =3D (i2c->quirks & DYNAMIC_MODE_READ_BROKEN_BIT) && + (i2c->tx_msg[count].flags & I2C_M_RD); + max_read_len =3D (i2c->tx_msg[count].flags & I2C_M_RD) && + (i2c->tx_msg[count].len > MAX_READ_LENGTH_DYNAMIC); + smbus_blk_read =3D (i2c->tx_msg[count].flags & I2C_M_RECV_LEN); + + if (broken_read || max_read_len || smbus_blk_read) { + i2c->dynamic =3D false; + break; + } + } + ret =3D xiic_reinit(i2c); if (!ret) __xiic_start_xfer(i2c); @@ -1021,7 +1057,7 @@ static int xiic_start_xfer(struct xiic_i2c *i2c, stru= ct i2c_msg *msgs, int num) static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int n= um) { struct xiic_i2c *i2c =3D i2c_get_adapdata(adap); - int err, count; + int err; =20 dev_dbg(adap->dev.parent, "%s entry SR: 0x%x\n", __func__, xiic_getreg8(i2c, XIIC_SR_REG_OFFSET)); @@ -1030,25 +1066,6 @@ static int xiic_xfer(struct i2c_adapter *adap, struc= t i2c_msg *msgs, int num) if (err < 0) return err; =20 - /* Decide standard mode or Dynamic mode */ - i2c->dynamic =3D true; - - /* Initialize prev message type */ - i2c->prev_msg_tx =3D false; - - /* - * Enter standard mode only when read length is > 255 bytes or - * for smbus_block_read transaction - */ - for (count =3D 0; count < i2c->nmsgs; count++) { - if (((i2c->tx_msg[count].flags & I2C_M_RD) && - i2c->tx_msg[count].len > MAX_READ_LENGTH_DYNAMIC) || - (i2c->tx_msg[count].flags & I2C_M_RECV_LEN)) { - i2c->dynamic =3D false; - break; - } - } - err =3D xiic_start_xfer(i2c, msgs, num); if (err < 0) { dev_err(adap->dev.parent, "Error xiic_start_xfer\n"); @@ -1091,10 +1108,23 @@ static const struct i2c_adapter xiic_adapter =3D { .algo =3D &xiic_algorithm, }; =20 +static const struct xiic_version_data xiic_2_00 =3D { + .quirks =3D DYNAMIC_MODE_READ_BROKEN_BIT, +}; + +#if defined(CONFIG_OF) +static const struct of_device_id xiic_of_match[] =3D { + { .compatible =3D "xlnx,xps-iic-2.00.a", .data =3D &xiic_2_00 }, + {}, +}; +MODULE_DEVICE_TABLE(of, xiic_of_match); +#endif + static int xiic_i2c_probe(struct platform_device *pdev) { struct xiic_i2c *i2c; struct xiic_i2c_platform_data *pdata; + const struct of_device_id *match; struct resource *res; int ret, irq; u8 i; @@ -1104,6 +1134,13 @@ static int xiic_i2c_probe(struct platform_device *pd= ev) if (!i2c) return -ENOMEM; =20 + match =3D of_match_node(xiic_of_match, pdev->dev.of_node); + if (match && match->data) { + const struct xiic_version_data *data =3D match->data; + + i2c->quirks =3D data->quirks; + } + res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); i2c->base =3D devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(i2c->base)) @@ -1215,14 +1252,6 @@ static int xiic_i2c_remove(struct platform_device *p= dev) return 0; } =20 -#if defined(CONFIG_OF) -static const struct of_device_id xiic_of_match[] =3D { - { .compatible =3D "xlnx,xps-iic-2.00.a", }, - {}, -}; -MODULE_DEVICE_TABLE(of, xiic_of_match); -#endif - static int __maybe_unused xiic_i2c_runtime_suspend(struct device *dev) { struct xiic_i2c *i2c =3D dev_get_drvdata(dev); --=20 2.25.1 From nobody Sun Apr 19 23:31:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68B7CCCA47F for ; Fri, 24 Jun 2022 12:07:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231869AbiFXMHZ (ORCPT ); Fri, 24 Jun 2022 08:07:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231905AbiFXMHW (ORCPT ); Fri, 24 Jun 2022 08:07:22 -0400 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2084.outbound.protection.outlook.com [40.107.101.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19CFC7FD0B; Fri, 24 Jun 2022 05:07:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FpcoLl1xsf0rlxCHHfPy6pu8z02lKqRMbDacEsGJCYsiBwFumS9327vENWed+XwBBn2syWdP9OlET+ypfjpmS3F1WCBb1m17TM8LtgZbIDKXsOhfBs5LWFuATWRmSpC5XQouSVaGkzKz3D2FweVTuEZgmWp+kndVwcvCkwgsIIddZgEtrXTCRxeDwcbUnxCIIjOu0cUvdTQxTJVn34HPPmTWlVWdexmU1vQszf6oPDQMbT7ZRFv9RCHImogFmS54QlV7ACsPG3Qz3v3NeBrmGXaoBeMwjJ8Nsg87Qnnbgo75K9kREqePNDJcwuAl31hxnvJeBrDEetiDuyY+wInP0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=de9gZ7n9b6NWufyMztspmnWVJ4wgBgwr4L2S6POIpwI=; b=gE3gudo6FupURr73HONFKGtNdB7sNfTTcQ+Qk8MUL+mGbwHhxPBXpfVKafQq3qHPHfCVreXlOosqUqwVaAfrDmgi1OJETb+eTg6GyraY6x8QwWUBdujNh8OD65phh2Q7PIq2VOkswCopmGPat7bUEF/iCKO5jRK5m/ZeI6tqNHdynvL8cN6Lf/mXn802bz6a4bxDq+7l7saiGlqufWaJnAtz6inyfUoABaw8wP1c4g4PqwkH/xWIqG/ybiTTA0qKPRN4byPxafEuGPuAFNKreZwkkEiBWwbgmCW52iQVNPPJt/NWn6XoCZOCSpZ1NxCLFWiTMXq/HGuA7TFWmN0RPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=amd.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=de9gZ7n9b6NWufyMztspmnWVJ4wgBgwr4L2S6POIpwI=; b=rPCWefPnySSYCAtE5wRefDes28Ev8EsjcQA6qvsm3q28k5IMhn0WmRaWM6eQHq5SDu4wAVBc6cTMPpouOTZ+2QOCh91543DN2vS6eE9DpVZLp0cuZ0DwlZhUO3PvbdsHgquEToAU/HKdqrPZ3mZmJIwXjpM6MxVjC6IqMgZ5fX0= Received: from SA0PR13CA0015.namprd13.prod.outlook.com (2603:10b6:806:130::20) by CO6PR02MB8771.namprd02.prod.outlook.com (2603:10b6:303:142::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Fri, 24 Jun 2022 12:07:19 +0000 Received: from SN1NAM02FT0020.eop-nam02.prod.protection.outlook.com (2603:10b6:806:130:cafe::fe) by SA0PR13CA0015.outlook.office365.com (2603:10b6:806:130::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.6 via Frontend Transport; Fri, 24 Jun 2022 12:07:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0020.mail.protection.outlook.com (10.97.5.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:07:19 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 24 Jun 2022 05:07:18 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 24 Jun 2022 05:07:18 -0700 Envelope-to: git@amd.com, michal.simek@amd.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Received: from [172.23.64.2] (port=47737 helo=xhdvnc102.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o4i5m-0005OP-DX; Fri, 24 Jun 2022 05:07:18 -0700 Received: by xhdvnc102.xilinx.com (Postfix, from userid 90444) id 7362210454B; Fri, 24 Jun 2022 17:35:52 +0530 (IST) From: Manikanta Guntupalli To: , , , , , CC: Raviteja Narayanam , Manikanta Guntupalli Subject: [PATCH 08/12] i2c: xiic: Remove interrupt enable/disable in Rx path Date: Fri, 24 Jun 2022 17:35:23 +0530 Message-ID: <1656072327-13628-9-git-send-email-manikanta.guntupalli@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> References: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 16833a2a-5a4a-4290-5dd1-08da55da165c X-MS-TrafficTypeDiagnostic: CO6PR02MB8771:EE_ X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +8EOmDfnKVJRZWfxs0zkgJ6E4rmMqu1Z7FVOUxvl1X2bikd94tluUPYtllbY/Wst8dZhw8+bcATdVI7bkoY4xbOAWExFuWMtme4RkOOaAtdG5AYVEtNq9O/8XF1LeBxChkCjQLvcLzLP/+OP7kFM6y0hrN9vCIi3W+dz45tXmJB5dKBbxoqEa5f83TwOcSPAwVYHoLo72JWX80I7Dsc+un3B2qYVe0QH1efYNrL/3TxhQsy2YCfDvtvnccGKSrKcbcLazjnYeTXAoJbjcEjnjJoM68WJZMoDWeGcmuhlSZbjEeIvatOjPbMwm4J1E3Bx8nEanphle6Zl3nbAQVbQToKrerSRfsMopZNNZnPv/9001sp9F1ayem45dIHVDPC2Z2L0XVCmHFOYIAnnrSC8cCwvrgRV8gQmsfLQ3XMqiBFwFGt5hRzsWW3PpJ1I5e3fWZ/+QB6lR07RM/SQSsgYsmh5sonqjiQLaa1gCMy8aAKoW5HwpfrWVhoi+nc9dsvwEGNn9Z9851bpyH4VfjvWbgaW1Zj8IOZ1Zogo7Ut5l2bR+3CQsDR6GeYe8bXiyOeoXzI68Bpl5JmLt1KOOfoJGH7cvrTWnPpJASXCQRl4SPhfAQ9t9Sf6EN5vm4NJ7llKYKm3U6Q7w8JYwXAum1lg51jy8mDzUU+SI/CU71sdb4yUt6R36Kyrjv69wK1D6PE27NYQLckbQbmOxPYaRwHBvfPgAp09InLmmngXSqAQML456W+Zfgqyi1sJnrfxn89HoTbFjI4LbWG8oSm7d8HUOO42iO9g8QhwdbEVkhzhLJx3WFh4aZSrKpldCPVm3Fg6B5u+ZARSG04kytVBbEvc4u/eCAJa2OJbyjTqrWkXsjM= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(396003)(136003)(346002)(46966006)(40470700004)(36840700001)(70586007)(2906002)(356005)(41300700001)(82310400005)(40460700003)(70206006)(83380400001)(4326008)(6266002)(316002)(42186006)(8676002)(82740400003)(6666004)(7636003)(36756003)(8936002)(36860700001)(40480700001)(54906003)(478600001)(186003)(26005)(426003)(5660300002)(44832011)(110136005)(47076005)(336012)(107886003)(2616005)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 12:07:19.1792 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 16833a2a-5a4a-4290-5dd1-08da55da165c X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0020.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR02MB8771 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Raviteja Narayanam As the 'DYNAMIC_MODE_READ_BROKEN_BIT' quirk is added in the driver, we no longer enter dynamic mode for the effected IP versions. So, remove local_irq_save/local_irq_restore APIs from driver. Signed-off-by: Raviteja Narayanam Signed-off-by: Manikanta Guntupalli --- drivers/i2c/busses/i2c-xiic.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 74cd50478694..720aa671f74b 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -776,7 +776,6 @@ static void xiic_start_recv(struct xiic_i2c *i2c) u16 rx_watermark; u8 cr =3D 0, rfd_set =3D 0; struct i2c_msg *msg =3D i2c->rx_msg =3D i2c->tx_msg; - unsigned long flags; =20 dev_dbg(i2c->adap.dev.parent, "%s entry, ISR: 0x%x, CR: 0x%x\n", __func__, xiic_getreg32(i2c, XIIC_IISR_OFFSET), @@ -808,7 +807,6 @@ static void xiic_start_recv(struct xiic_i2c *i2c) =20 xiic_setreg8(i2c, XIIC_RFD_REG_OFFSET, bytes); =20 - local_irq_save(flags); if (!(msg->flags & I2C_M_NOSTART)) /* write the address */ xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, @@ -822,7 +820,6 @@ static void xiic_start_recv(struct xiic_i2c *i2c) val |=3D msg->len; =20 xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, val); - local_irq_restore(flags); } else { /* * If previous message is Tx, make sure that Tx FIFO is empty --=20 2.25.1 From nobody Sun Apr 19 23:31:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21F1EC43334 for ; Fri, 24 Jun 2022 12:07:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231938AbiFXMHq (ORCPT ); Fri, 24 Jun 2022 08:07:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231912AbiFXMHj (ORCPT ); Fri, 24 Jun 2022 08:07:39 -0400 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2075.outbound.protection.outlook.com [40.107.244.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1F2E7FD35; Fri, 24 Jun 2022 05:07:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nYT6T+g/pToeztR/E5kvwjcTFzX5d0tfqu3985QhhkTss8WaF+/sdm3grG0NUZMb6bQoIoPrKB6QL13ItQtWyxB/DmKjJsNu3n2c4a5/s3N0aODmztRHI4o1E/5PwUa933by3wsv4VzYAXSzU4kvweJnk8DvGPsxdpGa/x+xZsUAFEc5O9VBsvD+UfGUzy4gJ83K4AS7c47P+Qt7vdpebFx9x40zmXkBOasNgX8/KskBxADU15bHc8WkruxRZAGtpMt18k45lPfWzXxJrsbol70dtwCzw9awFW1T8GDzTOu9RhdIRkKO/Z7WvQPNOAMv3EcEPqJIArjyv/k50oCrWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UglXwQ8315VDT7Db2CyxMMeqT8Qbp4ICreWy9dnboEU=; b=ak0qmmp8QkpSgbP5BELPepIYfU9ByFVQ5z1Sc4wA1sX5fpgs6vyKR+T+Q1LE2gYR6mEgnWVcJZuZW7/opqFzPS0b9MKcMno243jF8DItTqNeM28M7J28STWY5S6bmTyqh+z63p4xUD37TDrrdOHqwmTPAVwh+qObr6nMbIIoqKwL9qN5laDiL/Po8Sdp+2sfI5NZ8Cp4l9itfOYPdUFqqgruYPE3hDcHrTqmEbnnw4LxsLlmvBT88G4hkrQIlFFuzBjOc0rrSEUzuaAJhD+pWoX7xyxi4+ME1RsFMNwF+F/7RUHlAK+5XDdobzOKpAyCYmzOrw+KgY2gA7trMcXsgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=amd.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UglXwQ8315VDT7Db2CyxMMeqT8Qbp4ICreWy9dnboEU=; b=ZpYFp5XbXhNbqeM6Lgxr2SCXrRd5SJAjlDpr0nPLYBo4D4Soak5EPLq/bfTCZx4mDNj3aJLBk5VHp+y9RZ4sJ3/eYDTExIBsSHqpPSJ+GBwufSXcFvA7XqQ7RuNkDVanmuq2vSBDfqjwnkZqes5zsAvHf8t2/bW9RHETSIKFOJ4= Received: from SN7PR04CA0116.namprd04.prod.outlook.com (2603:10b6:806:122::31) by SN1PR02MB3758.namprd02.prod.outlook.com (2603:10b6:802:2c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Fri, 24 Jun 2022 12:07:33 +0000 Received: from SN1NAM02FT0039.eop-nam02.prod.protection.outlook.com (2603:10b6:806:122:cafe::c2) by SN7PR04CA0116.outlook.office365.com (2603:10b6:806:122::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16 via Frontend Transport; Fri, 24 Jun 2022 12:07:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0039.mail.protection.outlook.com (10.97.5.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:07:33 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 24 Jun 2022 05:07:31 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 24 Jun 2022 05:07:31 -0700 Envelope-to: git@amd.com, michal.simek@amd.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Received: from [172.23.64.2] (port=47738 helo=xhdvnc102.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o4i5z-0005Oz-Gr; Fri, 24 Jun 2022 05:07:31 -0700 Received: by xhdvnc102.xilinx.com (Postfix, from userid 90444) id 928C010454C; Fri, 24 Jun 2022 17:35:54 +0530 (IST) From: Manikanta Guntupalli To: , , , , , CC: Raviteja Narayanam , Manikanta Guntupalli Subject: [PATCH 09/12] dt-bindings: i2c: xiic: Add 'xlnx,axi-iic-2.1' to compatible Date: Fri, 24 Jun 2022 17:35:24 +0530 Message-ID: <1656072327-13628-10-git-send-email-manikanta.guntupalli@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> References: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f2853b89-ffc6-4e5e-cdc9-08da55da1ebe X-MS-TrafficTypeDiagnostic: SN1PR02MB3758:EE_ X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2NsFFxmG1DK+b9BuMDHuF/YISmiXnAbMuwmrcMAchldpUmSYsOaQtPW2sz7iwIC8q7QLrTcKoBye4TTMgPtU2iNlcpIbbfnm9R1esc18OWG6hnGDNdeMVhJEyfAH/o6P9GATMC826rqUf4WFMyWcGMsVqI7AsMVg/CJO617dgpLnhV1H69JwQ7qDYwVEyz7OrtO4/kmfR9Kiesqa6HG9VsJ6iuJcw+dMbRib2djMLfZP0QUOD4/fL2tOskUAS51u4PXdM4yvYNWQlfUrIKjX943x5i7hj9q/Rlk3Xkk48fKcDU2JIwC3eBxBQJbvzeZTC8Wpnr6YCMOea8SIP67HUuySo9AEOTaWvMBEXkPz+RvGhW3oWlXmRUQr0xcSnnvdL00ap6eOXEbAZpODzd7NqMBylZ80fZqUyfizRqqwDfmXbIdNJHNagJLWG3kslkrxgrKCcMvFJUBIRyvGl9z7rnzIJPQftmwDLzHqddDcqceyea8VD2BlveWMazvUimO/iGmIqBRs5hUVI8u4+u9DEySmvsj3SnxTBhi6r64DXSbA6pZuFWqGnrv5AmvGEihgMuj4V2SmkpeppcKxwcKSod8HEK2uJfERU4BsxSW1cMieibnHq2ynw0SNroYUfuVTMwvEMeysxIBzlkWz24WXuohOCxiYDeixTiYBvqrVTtKJABkieS8fqEq9jYl6vZpt0i2A0IUkqr0o8ybDWMxXkkmImHOap1AH8Q2Q0V9PqVVDIOyp36UQPhDAFPTe+0MlOxvwVi2qY8Ir1BoohaLv5/+eN79qum/Urx4TPV3GaPDJt/1NDzsp9dDjvJml/TPvEvUv4g3Yqq7vW+7mmpLrWOpBCVWTbLgi0WdYapNkUzQ= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(39860400002)(396003)(36840700001)(40470700004)(46966006)(4326008)(478600001)(2906002)(82310400005)(8676002)(70206006)(2616005)(40480700001)(8936002)(36860700001)(70586007)(41300700001)(7636003)(5660300002)(6266002)(82740400003)(26005)(44832011)(54906003)(42186006)(36756003)(83380400001)(426003)(356005)(107886003)(110136005)(6666004)(47076005)(40460700003)(336012)(316002)(186003)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 12:07:33.2461 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f2853b89-ffc6-4e5e-cdc9-08da55da1ebe X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0039.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB3758 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Raviteja Narayanam Xilinx AXI I2C IP is updated with a bug fix for dynamic mode reads. Older IPs are handled with a workaround in which they are using xiic standard mode for all these effected use cases. Added the xilinx I2C new version 'xlnx,axi-iic-2.1' string to compatible. Signed-off-by: Raviteja Narayanam Signed-off-by: Manikanta Guntupalli --- .../devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml= b/Documentation/devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml index 715dcfa5a922..e516c1ed358c 100644 --- a/Documentation/devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml +++ b/Documentation/devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml @@ -14,7 +14,9 @@ allOf: =20 properties: compatible: - const: xlnx,xps-iic-2.00.a + enum: + - xlnx,xps-iic-2.00.a + - xlnx,axi-iic-2.1 =20 reg: maxItems: 1 --=20 2.25.1 From nobody Sun Apr 19 23:31:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 464F6C433EF for ; Fri, 24 Jun 2022 12:07:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231944AbiFXMHz (ORCPT ); Fri, 24 Jun 2022 08:07:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231927AbiFXMHt (ORCPT ); Fri, 24 Jun 2022 08:07:49 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2068.outbound.protection.outlook.com [40.107.237.68]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D7B87FD2B; Fri, 24 Jun 2022 05:07:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eHmnaKOB4MbX2HpUIzDv37R7SI49wpSyTYezfOcCb8JIpzPjFX9qOvHOaCeRNrSMyM6vQCbbzzy3XHMIFZBJMkvS8H6q8H8fJ/iZ0AJbZM4oe1b6r5bSbA3Me6tLUoyQOI0CPEMUqVG6I1oDSl9ZMaVMxTc4TBuDg6vhaqUNNb5DPRh6gMf2pmHms3WNKhL5j9tZO6ynqxDIOa80bsqso0He6Q5QmCgLheMviAHnvCDTXZxWP+eU3HKMbX+Bgt+fuqSaiGm6GOBpQxDPVwwx2Qy7NN9Sxt/JBaPa3vQz2ArdnXCn5otBfPXCP+qPqFi6TpdYJ9w+aiptjqZEmT3qUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZFmVjPRDMbpcURpGuyh3Ti7h8x3zMgfIulT1JWjE1ho=; b=RtivwALVIg4Xq4oI8z0QO/g+uCzUSZenXCffUNGPEKykVItc+YjT3hz3+wnyTspW9ivFw1z95gV5JEv+xS8cqEx1pLA86YBClb830bPhOgo4Pqu0z6Dk4V0mLNh4wseqFykhFClA4XjEKD1L9xRsDn/FeaFjBdeKThyKTx8qgvMNiDPKNhL/KEmGdFJgYAmaS5qNCrpc5qgvIes+e+LFkzA/lMBpdmCvgUXtik3BYdlMa7xWHnPLudIeWTrRY9enEbO6NRsCdcAUCJVnzfevXFAq8yF/UCbufDqRVCd5MOX3zAWbZbtBdwbDwrC5U3r2Kg6yYgf5Jv7EVNpuGPW+jQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=amd.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZFmVjPRDMbpcURpGuyh3Ti7h8x3zMgfIulT1JWjE1ho=; b=XkD/fn4Y5p4ThM2iABj8SY1jayugdPiEmBsYap8bYZABfk8qqyuaVGrO4PhH0yWcQwsmcS9DFIU8zc3QYlPUZZCGkO1HA4seslshATImwDM/SN8vV6pbhhCroEa9K0STZSLQBy+VqaOI0d8e5yr1jeKFH6qtuUqy9ZxLoznIqyQ= Received: from SA0PR11CA0102.namprd11.prod.outlook.com (2603:10b6:806:d1::17) by BL0PR02MB6513.namprd02.prod.outlook.com (2603:10b6:208:1c3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Fri, 24 Jun 2022 12:07:45 +0000 Received: from SN1NAM02FT0051.eop-nam02.prod.protection.outlook.com (2603:10b6:806:d1:cafe::24) by SA0PR11CA0102.outlook.office365.com (2603:10b6:806:d1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:07:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0051.mail.protection.outlook.com (10.97.5.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:07:45 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 24 Jun 2022 05:07:44 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 24 Jun 2022 05:07:44 -0700 Envelope-to: git@amd.com, michal.simek@amd.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Received: from [172.23.64.2] (port=47739 helo=xhdvnc102.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o4i6C-000BZC-Jo; Fri, 24 Jun 2022 05:07:44 -0700 Received: by xhdvnc102.xilinx.com (Postfix, from userid 90444) id 8111B10454D; Fri, 24 Jun 2022 17:35:56 +0530 (IST) From: Manikanta Guntupalli To: , , , , , CC: Raviteja Narayanam , Manikanta Guntupalli Subject: [PATCH 10/12] i2c: xiic: Update compatible with new IP version Date: Fri, 24 Jun 2022 17:35:25 +0530 Message-ID: <1656072327-13628-11-git-send-email-manikanta.guntupalli@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> References: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d24a4ffd-4658-4487-c700-08da55da25f8 X-MS-TrafficTypeDiagnostic: BL0PR02MB6513:EE_ X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EhV7j5QofGerxt9KSR1mA5mUbtenTx99s8/8hEJ2yEhivkzd/qZ4DEHRSup/yIBkd3sONp+r3IzyFYqAGoBQBw9FDLapbE0xBE6GcOU3v4NsrfJ30ogEyvvJUITr0xK17Bi08oobqP1dSyElVZedG036kLZWkw+4YDrVMNurwP4l43f8ws1YSQI0iW/oibWR+qSLD2W3uoAvkOEffAVhxfiiSEexw9n9czxuUvFMV7Ync4rT4xT0uPujOrJb26TiQjGxFiLUIiYMRApcQBnNR4q1JOxUHNHnvWGMMOT7k0jm6o00EiKrjsDPVigC+3PYwi5g66z0qu/z/zewu0oBZWxHzPTViuPKclL7dSyHQb4Z9wx1NgpPgvBpxWb+um2/VRoR/Xq1QRvydhW9dkGxtFVJ7R4x0r9fQkBwlYuiNUsTSKN6rpQAVxB95/CXmQut2BRnYq4YDRXcodet2qoY4fZeq2GBXIH2qTBu2jluE20TLBQaHm+b9qV03lyiOj+M1xLV+AwnXXT1JphlIh7AZ1H2BIDK/7bnZlCH1AvFNtKw7+/PqyUL2Zz4D8UAehLE7z0WVgW0QIzOk32cMWlJ3RmqkZYsqByVwdrV+rqx1qNoxK7lbGN24IboKuR5kubCGw0/ndW1vlzEEkPlSCXXfcIFwvFsGB8BiNx2qeL1elgsRpipQi4VXrCBVB54Wha3po/qHGcU88OCBi8xpwqm8gBJEe87eEahTZusorBeyR5tY3io1Nhsw7nOB3YFtkejDncmQdFPZaLVEybLfqKYWn45pJQ8RS1qv/MahuDW1RMlCjUJb4/U8LRAX+ht+1pyGGMoriaYQaKQheptElTNu/V7JX9YAP9EQh9JFYDZMls= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(136003)(346002)(39860400002)(46966006)(40470700004)(36840700001)(110136005)(26005)(316002)(6266002)(41300700001)(70206006)(82310400005)(6666004)(356005)(7636003)(36756003)(4326008)(36860700001)(70586007)(54906003)(2906002)(8676002)(336012)(5660300002)(47076005)(8936002)(42186006)(107886003)(426003)(40460700003)(2616005)(82740400003)(478600001)(15650500001)(83380400001)(4744005)(40480700001)(186003)(44832011)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 12:07:45.3701 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d24a4ffd-4658-4487-c700-08da55da25f8 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0051.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB6513 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Raviteja Narayanam Xilinx AXI I2C IP is updated with a bug fix for dynamic mode reads. Older IPs are handled with a workaround in which they are using xiic standard mode for all these effected use cases. Added the new IP version to compatible. Signed-off-by: Raviteja Narayanam Signed-off-by: Manikanta Guntupalli --- drivers/i2c/busses/i2c-xiic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 720aa671f74b..f9492c39d3c7 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -1112,6 +1112,7 @@ static const struct xiic_version_data xiic_2_00 =3D { #if defined(CONFIG_OF) static const struct of_device_id xiic_of_match[] =3D { { .compatible =3D "xlnx,xps-iic-2.00.a", .data =3D &xiic_2_00 }, + { .compatible =3D "xlnx,axi-iic-2.1", }, {}, }; MODULE_DEVICE_TABLE(of, xiic_of_match); --=20 2.25.1 From nobody Sun Apr 19 23:31:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36E5FC433EF for ; Fri, 24 Jun 2022 12:08:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232002AbiFXMIJ (ORCPT ); Fri, 24 Jun 2022 08:08:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231968AbiFXMIF (ORCPT ); Fri, 24 Jun 2022 08:08:05 -0400 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CECAD10EB; Fri, 24 Jun 2022 05:08:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SS37MsWcqrivLJ21Wfasdadub3NTszv2PbQwXlumMg8qQaJHr6CSq9BM6kVwy09D5b0Me24GMK2OBsuqwXjtgCdB6mpRv4fCs7qMGe2P6n5BuNuhQ8riLKWD539440O1INp0eFPCPZjQ6leD8iE7vRgZiCqVOc39um5bBHsglxtsjpxrTNeK+xyvEX29s0YACvUWqX83S9i8p4m0KGrnZI3vX3timxP0CBiXCXl5+Cd4bofcouzVPyeS0mBf7rjS9TpIB8nSsh3HH6cSbSahCzUFu92tlWJphrhsAefWoby7hkT6FqzdcZBNCTWvoEEgkz8ey7yttKWWlOjqZgwE0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xD5FK3/R7laeDT8Ts5J63UVmyLmY5cn5Zjuujg0tTLI=; b=bd3qhjvW1RuMf7UmwN6fQqrMmrmTPwzcYGRCQDo3o7xaN68fcGmagh4yQI0jN4C42wZTR09PRJdxJprmAT8pbyNdHE7tz8p7wL0WEsMSL/tm2Mz/Z6OwNiHTpWZXHpGqItOVO+iqHUCO9Rn3synCWocnSWwRMQD8lDCo4mghdXZmZDnLXrmoLkWhkqBipcfgaMddNqskjoiQciFe0Vv/9Wsw21PcedASrom192MKHAzSuGwKqNhdnd4nZ6MKuX9L/PQPeddpFKvw+3Ia5bu5GkptwOqc7e4vPPgZAa/9DewCaLASvvV/+yb6Jddj171PAez74pdOcRY3YTVZlCRYfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=amd.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xD5FK3/R7laeDT8Ts5J63UVmyLmY5cn5Zjuujg0tTLI=; b=hm5PsnsjFFi7IHgOJOU8BmYhSV9RuHW4Sttlk5ZgxkuhxdMLUN4gWZnFynIcV42Mcshgyt4oe9JjDkjMbLEsD9zji0XZYWYbbLNzpFJbR7ICYc6Ws2nMcWCFNPCQOnrZJ1mRpj4WJyuLqTUgP6P4wgPeGfgMccd+KU0qiDyDAKI= Received: from SA0PR11CA0004.namprd11.prod.outlook.com (2603:10b6:806:d3::9) by BY5PR02MB6609.namprd02.prod.outlook.com (2603:10b6:a03:20c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Fri, 24 Jun 2022 12:08:01 +0000 Received: from SN1NAM02FT0030.eop-nam02.prod.protection.outlook.com (2603:10b6:806:d3:cafe::1e) by SA0PR11CA0004.outlook.office365.com (2603:10b6:806:d3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:08:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0030.mail.protection.outlook.com (10.97.5.194) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:08:00 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 24 Jun 2022 05:07:58 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 24 Jun 2022 05:07:58 -0700 Envelope-to: git@amd.com, michal.simek@amd.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Received: from [172.23.64.2] (port=47740 helo=xhdvnc102.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o4i6P-000BZb-Me; Fri, 24 Jun 2022 05:07:58 -0700 Received: by xhdvnc102.xilinx.com (Postfix, from userid 90444) id 646B910454F; Fri, 24 Jun 2022 17:35:58 +0530 (IST) From: Manikanta Guntupalli To: , , , , , CC: Raviteja Narayanam , Manikanta Guntupalli Subject: [PATCH 11/12] i2c: xiic: Add SCL frequency configuration support Date: Fri, 24 Jun 2022 17:35:26 +0530 Message-ID: <1656072327-13628-12-git-send-email-manikanta.guntupalli@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> References: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e7c96803-6ce3-4c27-2abb-08da55da2f1d X-MS-TrafficTypeDiagnostic: BY5PR02MB6609:EE_ X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dDs9kYoP2a7z6YQU5Mzqrjp6QP5x2tBQ8T0Y64garhoOXzSxh0goYE3gE3lmW7Yiy1m+2Jq8XMOdPyi3DAvhSjSBFCtWrL3SQZDQEQmnp/Vk/Ty6UVATSWprpw13diokSriPg45xLaGuT76MvuLMCvCopse7cdB/MuI+K6DPdN0VZ7d6I3TGziCUxNMjXFhoAGyFQdA/8BUsVG0oI3XSHhDEhqJGMocv2uJLakP4EW2dvZXqUTu799SC51sz77nmJp6rOJ6mtYMOhpfxjE5vdGRAnjakQ+mo1LZS9+PBIR0ZHX3zrYXT64JR0vWVTW/bFZmLHaa42z8PTYloyHmTzpojD5u8NtlDs5Wv2omKesEFVj7eyeFof2OouyscLuuGG/0lF2+GSvFa9MEpJ/HUodql/xW0q390z9YNGMA2wpRNuW1kgWW0JLSwMClLnx+Nuz3thkwC4lwPwzJNXKG2HzlVl1kfyXKtbAJWvqs7JG1kc84/SwlKiMQSDIE3NQ45V4gtV0HriSKtgQ1v4qBrfTYoEJ7WS/WDDEf0SXVvDbk8gvlU+Na/vL2mX8OLMRwAPDoHJ1yC8cmW0lmODW7K99IyXCIQgUz2oc0hlMB56m77EiMbiuFfwp2DzCfsTrWT20M2H/DN3UYryZNKwelWUfP/ld69GTO1aX5OqZuqn5XXuPgWHSYCzMyR7Ta2zYeUOgx3FW28jUODRhEQK7I13Im/XFIiX+cWeGpvnuvP8HqUYLph3AwYZ7ppDVPtPQlh9sDQUKTw6sGlciduuessXspz/r4hN/H6lOebWcwFt0KqawRNr+VMUUdFy8Xhp6N9Pe8UAX4GpeL0WpYdleUrVUN5pxtqHeQDkGvNzr+E2mk= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(396003)(136003)(39860400002)(40470700004)(46966006)(36840700001)(83380400001)(426003)(47076005)(110136005)(336012)(40480700001)(8936002)(36860700001)(44832011)(42186006)(2616005)(186003)(26005)(54906003)(4326008)(107886003)(40460700003)(6266002)(478600001)(41300700001)(8676002)(2906002)(40140700001)(6666004)(356005)(82310400005)(70206006)(316002)(36756003)(5660300002)(70586007)(82740400003)(7636003)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 12:08:00.7237 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e7c96803-6ce3-4c27-2abb-08da55da2f1d X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0030.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6609 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Raviteja Narayanam From 'clock-frequency' device tree property, configure I2C SCL frequency by calculating the timing register values according to input clock. After soft reset in reinit function, the timing registers are set to default values (configured in vivado design). So, setting SCL frequency is done inside reinit function after the soft reset. This allows configuration of SCL frequency exclusively through software via device tree property, overriding the vivado design. If the clock-frequency parameter is not specified in DT, driver doesn't configure frequency, making it backward compatible. Signed-off-by: Raviteja Narayanam Signed-off-by: Manikanta Guntupalli --- drivers/i2c/busses/i2c-xiic.c | 149 ++++++++++++++++++++++++++++++++++ 1 file changed, 149 insertions(+) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index f9492c39d3c7..f29acabba5e7 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -65,6 +65,8 @@ enum xiic_endian { * @prev_msg_tx: Previous message is Tx * @smbus_block_read: Flag to handle block read * @quirks: To hold platform specific bug info + * @input_clk: Input clock to I2C controller + * @i2c_clk: I2C SCL frequency */ struct xiic_i2c { struct device *dev; @@ -85,12 +87,30 @@ struct xiic_i2c { bool prev_msg_tx; bool smbus_block_read; u32 quirks; + unsigned long input_clk; + unsigned int i2c_clk; }; =20 struct xiic_version_data { u32 quirks; }; =20 +/** + * struct timing_regs - AXI I2C timing registers that depend on I2C spec + * @tsusta: setup time for a repeated START condition + * @tsusto: setup time for a STOP condition + * @thdsta: hold time for a repeated START condition + * @tsudat: setup time for data + * @tbuf: bus free time between STOP and START + */ +struct timing_regs { + unsigned int tsusta; + unsigned int tsusto; + unsigned int thdsta; + unsigned int tsudat; + unsigned int tbuf; +}; + #define XIIC_MSB_OFFSET 0 #define XIIC_REG_OFFSET (0x100 + XIIC_MSB_OFFSET) =20 @@ -109,6 +129,19 @@ struct xiic_version_data { #define XIIC_RFD_REG_OFFSET (0x20 + XIIC_REG_OFFSET) /* Rx FIFO Depth reg= */ #define XIIC_GPO_REG_OFFSET (0x24 + XIIC_REG_OFFSET) /* Output Register = */ =20 +/* + * Timing register offsets from RegisterBase. These are used only for + * setting i2c clock frequency for the line. + */ +#define XIIC_TSUSTA_REG_OFFSET (0x28 + XIIC_REG_OFFSET) /* TSUSTA Register= */ +#define XIIC_TSUSTO_REG_OFFSET (0x2C + XIIC_REG_OFFSET) /* TSUSTO Register= */ +#define XIIC_THDSTA_REG_OFFSET (0x30 + XIIC_REG_OFFSET) /* THDSTA Register= */ +#define XIIC_TSUDAT_REG_OFFSET (0x34 + XIIC_REG_OFFSET) /* TSUDAT Register= */ +#define XIIC_TBUF_REG_OFFSET (0x38 + XIIC_REG_OFFSET) /* TBUF Register */ +#define XIIC_THIGH_REG_OFFSET (0x3C + XIIC_REG_OFFSET) /* THIGH Register = */ +#define XIIC_TLOW_REG_OFFSET (0x40 + XIIC_REG_OFFSET) /* TLOW Register */ +#define XIIC_THDDAT_REG_OFFSET (0x44 + XIIC_REG_OFFSET) /* THDDAT Register= */ + /* Control Register masks */ #define XIIC_CR_ENABLE_DEVICE_MASK 0x01 /* Device enable =3D 1 = */ #define XIIC_CR_TX_FIFO_RESET_MASK 0x02 /* Transmit FIFO reset=3D1 = */ @@ -190,6 +223,7 @@ struct xiic_version_data { =20 static int xiic_start_xfer(struct xiic_i2c *i2c, struct i2c_msg *msgs, int= num); static void __xiic_start_xfer(struct xiic_i2c *i2c); +static int xiic_setclk(struct xiic_i2c *i2c); =20 /* * For the register read and write functions, a little-endian and big-endi= an @@ -315,6 +349,10 @@ static int xiic_reinit(struct xiic_i2c *i2c) =20 xiic_setreg32(i2c, XIIC_RESETR_OFFSET, XIIC_RESET_MASK); =20 + ret =3D xiic_setclk(i2c); + if (ret) + return ret; + /* Set receive Fifo depth to maximum (zero based). */ xiic_setreg8(i2c, XIIC_RFD_REG_OFFSET, IIC_RX_FIFO_DEPTH - 1); =20 @@ -1118,6 +1156,105 @@ static const struct of_device_id xiic_of_match[] = =3D { MODULE_DEVICE_TABLE(of, xiic_of_match); #endif =20 +enum i2c_scl_freq { + REG_VALUES_100KHZ =3D 0, + REG_VALUES_400KHZ =3D 1, + REG_VALUES_1MHZ =3D 2 +}; + +/* Reg values in ns derived from I2C spec and AXI I2C PG for different fre= quencies */ +static const struct timing_regs timing_reg_values[] =3D { + { 5700, 5000, 4300, 550, 5000 }, /* Reg values for 100KHz */ + { 900, 900, 900, 400, 1600 }, /* Reg values for 400KHz */ + { 380, 380, 380, 170, 620 }, /* Reg values for 1MHz */ +}; + +/** + * xiic_setclk - Sets the configured clock rate + * @i2c: Pointer to the xiic device structure + * + * The timing register values are calculated according to the input clock + * frequency and configured scl frequency. For details, please refer the + * AXI I2C PG and NXP I2C Spec. + * Supported frequencies are 100KHz, 400KHz and 1MHz. + * + * Return: 0 on success (Supported frequency selected or not configurable = in SW) + * -EINVAL on failure (scl frequency not supported or THIGH is 0) + */ +static int xiic_setclk(struct xiic_i2c *i2c) +{ + unsigned int clk_in_mhz; + unsigned int index =3D 0; + u32 reg_val; + + dev_dbg(i2c->adap.dev.parent, + "%s entry, i2c->input_clk: %ld, i2c->i2c_clk: %d\n", + __func__, i2c->input_clk, i2c->i2c_clk); + + /* If not specified in DT, do not configure in SW. Rely only on Vivado de= sign */ + if (!i2c->i2c_clk) + return 0; + + clk_in_mhz =3D DIV_ROUND_UP(i2c->input_clk, 1000000); + + switch (i2c->i2c_clk) { + case I2C_MAX_FAST_MODE_PLUS_FREQ: + index =3D REG_VALUES_1MHZ; + break; + case I2C_MAX_FAST_MODE_FREQ: + index =3D REG_VALUES_400KHZ; + break; + case I2C_MAX_STANDARD_MODE_FREQ: + index =3D REG_VALUES_100KHZ; + break; + default: + dev_warn(i2c->adap.dev.parent, "Unsupported scl frequency\n"); + return -EINVAL; + } + + /* + * Value to be stored in a register is the number of clock cycles required + * for the time duration. So the time is divided by the input clock time + * period to get the number of clock cycles required. Refer Xilinx AXI I2C + * PG document and I2C specification for further details. + */ + + /* THIGH - Depends on SCL clock frequency(i2c_clk) as below */ + reg_val =3D (DIV_ROUND_UP(i2c->input_clk, 2 * i2c->i2c_clk)) - 7; + if (reg_val =3D=3D 0) + return -EINVAL; + + xiic_setreg32(i2c, XIIC_THIGH_REG_OFFSET, reg_val - 1); + + /* TLOW - Value same as THIGH */ + xiic_setreg32(i2c, XIIC_TLOW_REG_OFFSET, reg_val - 1); + + /* TSUSTA */ + reg_val =3D (timing_reg_values[index].tsusta * clk_in_mhz) / 1000; + xiic_setreg32(i2c, XIIC_TSUSTA_REG_OFFSET, reg_val - 1); + + /* TSUSTO */ + reg_val =3D (timing_reg_values[index].tsusto * clk_in_mhz) / 1000; + xiic_setreg32(i2c, XIIC_TSUSTO_REG_OFFSET, reg_val - 1); + + /* THDSTA */ + reg_val =3D (timing_reg_values[index].thdsta * clk_in_mhz) / 1000; + xiic_setreg32(i2c, XIIC_THDSTA_REG_OFFSET, reg_val - 1); + + /* TSUDAT */ + reg_val =3D (timing_reg_values[index].tsudat * clk_in_mhz) / 1000; + xiic_setreg32(i2c, XIIC_TSUDAT_REG_OFFSET, reg_val - 1); + + /* TBUF */ + reg_val =3D (timing_reg_values[index].tbuf * clk_in_mhz) / 1000; + xiic_setreg32(i2c, XIIC_TBUF_REG_OFFSET, reg_val - 1); + + /* THDDAT */ + xiic_setreg32(i2c, XIIC_THDDAT_REG_OFFSET, 1); + + return 0; +} + static int xiic_i2c_probe(struct platform_device *pdev) { struct xiic_i2c *i2c; @@ -1176,6 +1313,15 @@ static int xiic_i2c_probe(struct platform_device *pd= ev) pm_runtime_use_autosuspend(i2c->dev); pm_runtime_set_active(i2c->dev); pm_runtime_enable(i2c->dev); + + /* SCL frequency configuration */ + i2c->input_clk =3D clk_get_rate(i2c->clk); + ret =3D of_property_read_u32(pdev->dev.of_node, "clock-frequency", + &i2c->i2c_clk); + /* If clock-frequency not specified in DT, do not configure in SW */ + if (ret || i2c->i2c_clk > I2C_MAX_FAST_MODE_PLUS_FREQ) + i2c->i2c_clk =3D 0; + ret =3D devm_request_threaded_irq(&pdev->dev, irq, NULL, xiic_process, IRQF_ONESHOT, pdev->name, i2c); @@ -1219,6 +1365,9 @@ static int xiic_i2c_probe(struct platform_device *pde= v) i2c_new_client_device(&i2c->adap, pdata->devices + i); } =20 + dev_dbg(&pdev->dev, "mmio %08lx irq %d scl clock frequency %d\n", + (unsigned long)res->start, irq, i2c->i2c_clk); + return 0; =20 err_clk_dis: --=20 2.25.1 From nobody Sun Apr 19 23:31:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DACBCC43334 for ; Fri, 24 Jun 2022 12:08:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232004AbiFXMI2 (ORCPT ); Fri, 24 Jun 2022 08:08:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232051AbiFXMIW (ORCPT ); Fri, 24 Jun 2022 08:08:22 -0400 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2053.outbound.protection.outlook.com [40.107.244.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8872B80516; Fri, 24 Jun 2022 05:08:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OTl27Kkaq9vbhBnlZJSII4N4JZFsVwsEvLQu5Xt4xzvXS37/zGT43MzjMeckCNYGeMLCt3BpoUA0fIW6al9ifU+/St0a5832kbpD7lJTrDa6FfCfnOrgAjBrJ1ROe25wlCLuqzQ08y5H0gtvFB3EUsYVMzh1BtlqaKWEEGvfb7hiPc38HtNQHAu2a5IzOQ1R96YNKLYwDXFRuQWcYE+9QdbqX+ZMQF+evI53lGaIMeCN9sLTbdN2SmrwHhB2OqGRdJ+4DFkHsTw3LcM8/S+P3bgd8WxGmpgNcj1A4Lqr7QX8zLxqxZLofDIg3EsLFN/f7wKqXLBNfAvbskLl/Awqjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=guHhU86EEcYsTUE1xCOphKC4D0End8nTO+NTJFKyStM=; b=fyoNdEJmsNPTtN7f1FdpzE/PdPMDZfvJSg5eupxg8fs/81B3sBO6pFpcaykaox6eOBipwgsk6OiqMVHCWy5cMdQD322JlNIoVCKqD9EFaxqQd18d2ECFxeQj4w03BIQEQURxbbFBsi2v2j/UlXMYOJ9eTOJYK3W2ogQvjGcJY7gjl0puqgkfy6Y8F3LL+ByjZ7TrT/9yXeXrxCMPe05HgPuMda5KE9Cri5MaFBNssxE7sw7uXEB12PHnReqO998E6SvQTo8gU8+u+3eA0SMsm8DcESxh2Yl+GqWJVU1oYdXd0UKNmCT/v5WZRufa/YbGt3Ff8mWGrRX312fL+KWs4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=amd.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=guHhU86EEcYsTUE1xCOphKC4D0End8nTO+NTJFKyStM=; b=D+CN7I55pfq1SLGT/VW7ylc6AYH319s3V6GkiSZdPU3LiXnqmZWyuogNvDaaU305CSYxMyyHTeXB2aWm607zmSF068i6/8bPUC84mW9a6BLIMPR8ZrBsw7hXBx76v5OWWZHfxClqmOfOPY3NmqSH3mc/2DvkOh2N7VSvf0SfZp8= Received: from BN8PR04CA0055.namprd04.prod.outlook.com (2603:10b6:408:d4::29) by BYAPR02MB5606.namprd02.prod.outlook.com (2603:10b6:a03:9f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Fri, 24 Jun 2022 12:08:13 +0000 Received: from BN1NAM02FT007.eop-nam02.prod.protection.outlook.com (2603:10b6:408:d4:cafe::d4) by BN8PR04CA0055.outlook.office365.com (2603:10b6:408:d4::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.16 via Frontend Transport; Fri, 24 Jun 2022 12:08:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT007.mail.protection.outlook.com (10.13.3.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:08:12 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 24 Jun 2022 05:08:11 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 24 Jun 2022 05:08:11 -0700 Envelope-to: git@amd.com, michal.simek@amd.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Received: from [172.23.64.2] (port=47741 helo=xhdvnc102.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o4i6c-0005Qv-Vx; Fri, 24 Jun 2022 05:08:11 -0700 Received: by xhdvnc102.xilinx.com (Postfix, from userid 90444) id 7B663104546; Fri, 24 Jun 2022 17:35:59 +0530 (IST) From: Manikanta Guntupalli To: , , , , , CC: Srinivas Goud , Manikanta Guntupalli Subject: [PATCH 12/12] i2c: xiic: Correct the BNB interrupt enable sequence Date: Fri, 24 Jun 2022 17:35:27 +0530 Message-ID: <1656072327-13628-13-git-send-email-manikanta.guntupalli@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> References: <1656072327-13628-1-git-send-email-manikanta.guntupalli@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4ee012a8-ee2a-46ee-664f-08da55da365c X-MS-TrafficTypeDiagnostic: BYAPR02MB5606:EE_ X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6aIRN2ykVxqKsqhxI9UA2LKqnupxdfsBzUqdtPk7dDQ799a3GJ9Z+31iCTiQce5j+sM3+j2Z/rKUt0Wz5WQPGLNzrqV/+8NondzNcYMMEZ3rlGe/1IJYoJD55aeSf20Jy38IX7cjb6yVi0OIefcS/+mImYL7zhGEP5HVSAW1PVxxlVF6f1xrI5Eqi+cNe8F4uS38G+K+4HXCojdNwChJ1GcpO7ssL6CnQaJS5o8tTuGhEPuLMEu/qgefDWRSZGGCzgblr+/Fr+WuL7gkR1mb3D6ISLJhtAoL08lccNzmIhagf666RslJlZHIyXS/+GEyJqOGe0NbX2vnJeK8TWE97juGYgdeeHDSu0g65tEKri27MtINEFUSAKkUaTXVbtJ9rpExPivst6+9quJvjqa+zVMh6kv2i5OY2IINCBT3VMGt25VfhfUVckc4+5g/ojt/H3407BTJ/WOp3QE8PXQY/TYN541zkoIkSNQyjH5Eq+2aM7HA3OenF1fjxhUKCTSueaPwQCSoCxXbt6UkIq9mDCGR9VE0gUrukIhQ2Wn3hCA7xcawjn6QBYsaSZWI3e0Kp+ICoNnYy5wYbLr5hpviFXJlP2Ij6mWEx0DzlRkeUyCeQcPiB1aVJmH1Jh39/OBVTkPljrYyuxONyc93pE3ZGyHFEaVV6WezQB3R7UNY5T98bGOc6f5j9K+0tfyiNEpUXtdKhuqzt5zkG951V7KmiAz0xhjfxRCkxJCTDn0mmV2d0xJ1tPEnc509dbdE3JTu/5EYulT2A68WcQ/KSCwmBmsFRPyEOWmyMDZa/wM9aZ/lgaXlrft3plJRGHd3GSNBrXrpHr/2E1Czw3SSfE4D5BOGrgXCu3ABk+6ZyY9SdmY= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(136003)(346002)(396003)(36840700001)(46966006)(40470700004)(478600001)(82740400003)(4326008)(356005)(42186006)(44832011)(83380400001)(70586007)(40460700003)(54906003)(186003)(6266002)(41300700001)(2616005)(336012)(70206006)(110136005)(6666004)(8676002)(316002)(36756003)(107886003)(7636003)(26005)(47076005)(5660300002)(426003)(8936002)(2906002)(82310400005)(36860700001)(40480700001)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 12:08:12.8040 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4ee012a8-ee2a-46ee-664f-08da55da365c X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT007.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5606 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Srinivas Goud With updated AXI IIC IP core(v2.1)there is change in IP behavior in dynamic mode, where controller initiate read transfer on IIC bus only after getting the value for the number of bytes to receive. In the existing xiic_start_recv function Bus Not Busy(BNB) interrupt is enabled just after "slave address + start" write to FIFO and before the "count + stop"write to FIFO. Since IIC controller drives the start address of a transaction on the bus only after it has received the byte count information the above sequence can lead to spurious BNB interrupt in case there is any delay after "slave address + start" write to FIFO. This is fixed by ensuring that BNB interrupt is enabled only after "count + stop" has been written to FIFO. Signed-off-by: Srinivas Goud Signed-off-by: Manikanta Guntupalli --- drivers/i2c/busses/i2c-xiic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index f29acabba5e7..0a34daa9e372 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -851,13 +851,13 @@ static void xiic_start_recv(struct xiic_i2c *i2c) i2c_8bit_addr_from_msg(msg) | XIIC_TX_DYN_START_MASK); =20 - xiic_irq_clr_en(i2c, XIIC_INTR_BNB_MASK); - /* If last message, include dynamic stop bit with length */ val =3D (i2c->nmsgs =3D=3D 1) ? XIIC_TX_DYN_STOP_MASK : 0; val |=3D msg->len; =20 xiic_setreg16(i2c, XIIC_DTR_REG_OFFSET, val); + + xiic_irq_clr_en(i2c, XIIC_INTR_BNB_MASK); } else { /* * If previous message is Tx, make sure that Tx FIFO is empty --=20 2.25.1