From nobody Wed Apr 29 00:33:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31E1DC433EF for ; Thu, 9 Jun 2022 16:51:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344894AbiFIQvJ (ORCPT ); Thu, 9 Jun 2022 12:51:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344675AbiFIQuf (ORCPT ); Thu, 9 Jun 2022 12:50:35 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D6B16C0C6 for ; Thu, 9 Jun 2022 09:50:31 -0700 (PDT) Date: Thu, 09 Jun 2022 16:50:29 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1654793430; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dHielvjeadYHFGOtQOVaGYUxq8bvjP3EnPYD76F6TmU=; b=jI6uonFeKyqsyvgfnLhgVXBrrGtFANnEChLos7FFqAczLtwOHR13TKWO2xVIgQh+ctyU+s NsaMI2sPstwz7oGTZ0smgQsK7S4qYkcZRr8rZIbQXdk1qxl+SO0OfPnY01zQcOp26/EUfZ 5FOag7rdfbGO3opAgwYQNbfE8gS551JMWwqODiBZapALOj+4nG49J90kUPRtl9pmI75V8h ljbzhmjVJT9xMlLlLqhu+A+Qw8NilgoJMrqOhQv4NqBmO5bCVK3PcsE20Zg5XWOMShM4uq bauFMPQBT1q/pBdcgNR0D87uGC90P9BVWzFhFqdbde74F3qnq8awQ0gJrRkUvw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1654793430; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dHielvjeadYHFGOtQOVaGYUxq8bvjP3EnPYD76F6TmU=; b=sGodCvLZ3gr2mBUAXr4VtKNdrBRJ01vpKsCr2br3aWdpbISgea6f603WiOL3XFuSHM61Te q8B0tpk7hYNZJOBw== From: "irqchip-bot for Miaoqian Lin" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-kernel@vger.kernel.org Subject: [irqchip: irq/irqchip-fixes] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init Cc: Miaoqian Lin , Marc Zyngier , tglx@linutronix.de In-Reply-To: <20220601080930.31005-2-linmq006@gmail.com> References: <20220601080930.31005-2-linmq006@gmail.com> MIME-Version: 1.0 Message-ID: <165479342917.4207.8528273657753463802.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the irq/irqchip-fixes branch of i= rqchip: Commit-ID: f4b98e314888cc51486421bcf6d52852452ea48b Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-plat= forms/f4b98e314888cc51486421bcf6d52852452ea48b Author: Miaoqian Lin AuthorDate: Wed, 01 Jun 2022 12:09:25 +04:00 Committer: Marc Zyngier CommitterDate: Thu, 09 Jun 2022 17:36:57 +01:00 irqchip/gic/realview: Fix refcount leak in realview_gic_of_init of_find_matching_node_and_match() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC varia= nts") Signed-off-by: Miaoqian Lin Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20220601080930.31005-2-linmq006@gmail.com --- drivers/irqchip/irq-gic-realview.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-gic-realview.c b/drivers/irqchip/irq-gic-r= ealview.c index b4c1924..38fab02 100644 --- a/drivers/irqchip/irq-gic-realview.c +++ b/drivers/irqchip/irq-gic-realview.c @@ -57,6 +57,7 @@ realview_gic_of_init(struct device_node *node, struct dev= ice_node *parent) =20 /* The PB11MPCore GIC needs to be configured in the syscon */ map =3D syscon_node_to_regmap(np); + of_node_put(np); if (!IS_ERR(map)) { /* new irq mode with no DCC */ regmap_write(map, REALVIEW_SYS_LOCK_OFFSET,