From nobody Tue Apr 28 19:31:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 278A1C433FE for ; Mon, 30 May 2022 08:06:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230098AbiE3IFm (ORCPT ); Mon, 30 May 2022 04:05:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232012AbiE3IFj (ORCPT ); Mon, 30 May 2022 04:05:39 -0400 Received: from mail.meizu.com (edge05.meizu.com [157.122.146.251]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAD2074DFF for ; Mon, 30 May 2022 01:05:36 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail12.meizu.com (172.16.1.108) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 30 May 2022 16:05:36 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Mon, 30 May 2022 16:05:34 +0800 From: Haowen Bai To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman CC: Haowen Bai , , Subject: [PATCH] staging: rtl8712: Fix pointer dereferenced before checking Date: Mon, 30 May 2022 16:05:32 +0800 Message-ID: <1653897933-25931-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The padapter->recvpriv.signal_qual_data is dereferencing before null checking, so move it after checking. Signed-off-by: Haowen Bai --- drivers/staging/rtl8712/rtl8712_recv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl87= 12/rtl8712_recv.c index 7f1fdd058551..8ed94b259dbe 100644 --- a/drivers/staging/rtl8712/rtl8712_recv.c +++ b/drivers/staging/rtl8712/rtl8712_recv.c @@ -863,10 +863,12 @@ static void process_link_qual(struct _adapter *padapt= er, { u32 last_evm =3D 0, tmpVal; struct rx_pkt_attrib *pattrib; - struct smooth_rssi_data *sqd =3D &padapter->recvpriv.signal_qual_data; + struct smooth_rssi_data *sqd; =20 if (!prframe || !padapter) return; + + sqd =3D &padapter->recvpriv.signal_qual_data; pattrib =3D &prframe->u.hdr.attrib; if (pattrib->signal_qual !=3D 0) { /* --=20 2.7.4