From nobody Fri May 8 03:50:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F912C433EF for ; Wed, 11 May 2022 19:48:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347247AbiEKTsC (ORCPT ); Wed, 11 May 2022 15:48:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347219AbiEKTrY (ORCPT ); Wed, 11 May 2022 15:47:24 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFC6A483B7; Wed, 11 May 2022 12:47:15 -0700 (PDT) Date: Wed, 11 May 2022 19:47:13 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1652298434; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9cErrf120Gs7NDjCU8OQgjMjOQVMHCeq5JBSf62u7gk=; b=kLJNOse5QMiSylPpNqFy8ico+grhVqmu+BuJxWVCmKCEIiwAxyGFXkBm03RN1WVaZorSQ8 kLwLKhURhCcTW0Df7fvt+DcSq8OFYaKWm25CN3Iff7xiJZrmz1POdBMw26yEbVUAuyP/QK mFJVVbEKCbWN2mAPxFRWuWUZDqzjggDoOPDSuH+sFWXyU6UceYAc7svLYCo4BHtO6t7HDj nPUtLa/TmOr9S3VDLvZGHrayqbfp8JLZv2fKo6zJTesIDo3ge24nOse711TvsaH3aoa1oQ txLU7U/AA21vAhUu0QuecCZ0PUn/gs5SXq+Dch7A9muzqgkMdNmq5XQzIB1Vlw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1652298434; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9cErrf120Gs7NDjCU8OQgjMjOQVMHCeq5JBSf62u7gk=; b=HbFwf4JWGVR3xddaWay/Hqa2sGSnWASIr3Tele1xo8LiK8hYzXwKdDp5MCDpqIIumzk00F 5uWQ9RGuusEHbwAg== From: "tip-bot2 for Hao Jia" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: sched/core] sched/deadline: Remove superfluous rq clock update in push_dl_task() Cc: Hao Jia , "Peter Zijlstra (Intel)" , Dietmar Eggemann , Daniel Bristot de Oliveira , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20220430085843.62939-3-jiahao.os@bytedance.com> References: <20220430085843.62939-3-jiahao.os@bytedance.com> MIME-Version: 1.0 Message-ID: <165229843321.4207.9114080870680211177.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the sched/core branch of tip: Commit-ID: 734387ec2f9d77b00276042b1fa7c95f48ee879d Gitweb: https://git.kernel.org/tip/734387ec2f9d77b00276042b1fa7c95f4= 8ee879d Author: Hao Jia AuthorDate: Sat, 30 Apr 2022 16:58:43 +08:00 Committer: Peter Zijlstra CommitterDate: Wed, 11 May 2022 16:27:12 +02:00 sched/deadline: Remove superfluous rq clock update in push_dl_task() The change to call update_rq_clock() before activate_task() commit 840d719604b0 ("sched/deadline: Update rq_clock of later_rq when pushing a task") is no longer needed since commit f4904815f97a ("sched/deadline: Fix double accounting of rq/running bw in push & pull") removed the add_running_bw() before the activate_task(). So we remove some comments that are no longer needed and update rq clock in activate_task(). Signed-off-by: Hao Jia Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Dietmar Eggemann Reviewed-by: Daniel Bristot de Oliveira Link: https://lore.kernel.org/r/20220430085843.62939-3-jiahao.os@bytedance.= com --- kernel/sched/deadline.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 0ad2818..936817a 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -2318,13 +2318,7 @@ retry: =20 deactivate_task(rq, next_task, 0); set_task_cpu(next_task, later_rq->cpu); - - /* - * Update the later_rq clock here, because the clock is used - * by the cpufreq_update_util() inside __add_running_bw(). - */ - update_rq_clock(later_rq); - activate_task(later_rq, next_task, ENQUEUE_NOCLOCK); + activate_task(later_rq, next_task, 0); ret =3D 1; =20 resched_curr(later_rq);