From nobody Fri May 8 11:27:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9806AC433EF for ; Wed, 4 May 2022 16:16:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236837AbiEDQTf (ORCPT ); Wed, 4 May 2022 12:19:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353238AbiEDQSu (ORCPT ); Wed, 4 May 2022 12:18:50 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 463A0108 for ; Wed, 4 May 2022 09:15:13 -0700 (PDT) Date: Wed, 04 May 2022 16:15:10 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1651680911; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PejGroVwC4ueRSj8DbrGKAkPmTAcjqv/5OSkbLs1kDo=; b=p/dL/5WEaeh89Ljgwb6Fg7cvVqojH5+szsxHkR/HebSV0zR1GTJO4FCnz0TqdBzznMdv7m BSxho1evxhU9dq/Oe/KRY6rwvwiUE+HXjy0rOZUb9lWM3GOnOmdczvHRBUy/f/+8bKdUmM pBqhjX39Ft89sP+HlZ3TCOmJ68AHh3Ni1vhplbM4IGJqWEwALvnW9nF3pn73H9wSSjsfD5 mMRBCdKV8v6MU/lz48MhSD2xWmooO0BEmdML2XnEWw17lKCFu8bvMvulBtr0f+He7FQ/HP P2emymRoYuDTwlWu6+1nLrBztMU4Bzo0CyJi7LtCJV9cVJAoNUcucJibVi4lEQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1651680911; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PejGroVwC4ueRSj8DbrGKAkPmTAcjqv/5OSkbLs1kDo=; b=rP5pV6qbrz4CAmVsFG4ATWbERYSUif/rs5+kjRAAcwyDWoc2rPi4FgoUYTM6G8FRZvMcFz EfA+GSNqdA7q9ZBA== From: "irqchip-bot for Krzysztof Kozlowski" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-kernel@vger.kernel.org Subject: [irqchip: irq/irqchip-next] irqchip/aspeed-scu-ic: Fix irq_of_parse_and_map() return value Cc: Krzysztof Kozlowski , Marc Zyngier , tglx@linutronix.de In-Reply-To: <20220423094227.33148-2-krzysztof.kozlowski@linaro.org> References: <20220423094227.33148-2-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Message-ID: <165168091077.4207.9608550822373424674.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the irq/irqchip-next branch of ir= qchip: Commit-ID: f03a9670d27d23fe734a456f16e2579b21ec02b4 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-plat= forms/f03a9670d27d23fe734a456f16e2579b21ec02b4 Author: Krzysztof Kozlowski AuthorDate: Sat, 23 Apr 2022 11:42:27 +02:00 Committer: Marc Zyngier CommitterDate: Wed, 04 May 2022 16:37:48 +01:00 irqchip/aspeed-scu-ic: Fix irq_of_parse_and_map() return value The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO. Fixes: 04f605906ff0 ("irqchip: Add Aspeed SCU interrupt controller") Signed-off-by: Krzysztof Kozlowski Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20220423094227.33148-2-krzysztof.kozlowski@= linaro.org --- drivers/irqchip/irq-aspeed-scu-ic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-aspeed-scu-ic.c b/drivers/irqchip/irq-aspe= ed-scu-ic.c index 18b77c3..279e92c 100644 --- a/drivers/irqchip/irq-aspeed-scu-ic.c +++ b/drivers/irqchip/irq-aspeed-scu-ic.c @@ -157,8 +157,8 @@ static int aspeed_scu_ic_of_init_common(struct aspeed_s= cu_ic *scu_ic, } =20 irq =3D irq_of_parse_and_map(node, 0); - if (irq < 0) { - rc =3D irq; + if (!irq) { + rc =3D -EINVAL; goto err; }