From nobody Sun May 10 15:02:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D2FC433F5 for ; Mon, 2 May 2022 07:28:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239466AbiEBHbp (ORCPT ); Mon, 2 May 2022 03:31:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383566AbiEBHbl (ORCPT ); Mon, 2 May 2022 03:31:41 -0400 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2057.outbound.protection.outlook.com [40.107.236.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B56B3A5FA; Mon, 2 May 2022 00:28:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eq67EqpW0Y7cUfDCnpnymyjhXzu8TMguVngMvQQOy2s4wqUYN6ccqHSY6FKLCzGAJMxd+qAhvsX/YSoUOs60bisMyqmiyztUNoeBouR+Bh9OY6IIZrimx4n9LBTJCv0TR20+51GwFzVKV5AefkNxOd79DeH2hxdrsgSYOC2vuy0pvgyQ4mFQfZLd/qbypcPdATQYc4LS2oR/RPg+mRkbRRlIYB3AT+GFTyWu1pV6QhbESdtdENPmVwZk78SRzK/otMPaWRFEh2hwWOMSYbdRQsMaDjw/Ts2++VcA/S/r7MwHXpp48upAVfuVhgO0jrLgBqxvfSs5kLsbLakvvOLxTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HpmbxnG9S3RumvROmQ8xGs+5GmBGFdy0Y77CKX9WBOg=; b=imYjOYl0rTUGQtqnKjTdYZhLcUIi73G2slgFg00TO6WtgnV0zS6jLqS9aw4a+R5G5SlmgngtH6y1/8aTvOyNHw08A3vu+UQDfEo0mZVBxXCoZUAD0PsDFIDOWIVeCY4dE179IwNkFl+2hHc/Gf2tS/xYN48K+Bh7Vnyn/PIiyzU2JdC9P2FZJAXNn0EORSAzNdw/yIEi0QwIVTjc5ywmXK/iz7AwxqrrnhL448n6MPGe5WT6inVVudRMW3YHqxJAoLCSNLKaoPFmy7AQyn3jwURkNxU1vSUhiEvHHtDMFefFDzumaWu1t/RB7MZ6MpcxINHWzsok0o2XiQialUAl5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=davemloft.net smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HpmbxnG9S3RumvROmQ8xGs+5GmBGFdy0Y77CKX9WBOg=; b=nKyL6FZq4fa12IWOHGQslWOP6frsaalTw5bmPCTeMJUrt6XKT004xf+t6ESU1Enduug5RERKN5t+SoPwgIpPLZLaVeEaonQyfojGv51nAwaAldG2tqbe11WdOHmq5WzTTNi0Rg5M5UJ6wD2+dsGPOdjiFbxV20/BMoWLDKYfQPs= Received: from DS7PR03CA0147.namprd03.prod.outlook.com (2603:10b6:5:3b4::32) by DM6PR02MB5033.namprd02.prod.outlook.com (2603:10b6:5:43::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Mon, 2 May 2022 07:28:09 +0000 Received: from DM3NAM02FT035.eop-nam02.prod.protection.outlook.com (2603:10b6:5:3b4:cafe::4f) by DS7PR03CA0147.outlook.office365.com (2603:10b6:5:3b4::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend Transport; Mon, 2 May 2022 07:28:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT035.mail.protection.outlook.com (10.13.4.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5206.12 via Frontend Transport; Mon, 2 May 2022 07:28:08 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Mon, 2 May 2022 00:28:06 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Mon, 2 May 2022 00:28:06 -0700 Envelope-to: git@xilinx.com, davem@davemloft.net, kuba@kernel.org, andrew@lunn.ch, pabeni@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Received: from [172.23.64.6] (port=56284 helo=xhdvnc106.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nlQTW-00010u-Dx; Mon, 02 May 2022 00:28:06 -0700 Received: by xhdvnc106.xilinx.com (Postfix, from userid 13245) id 86F3861099; Mon, 2 May 2022 12:57:52 +0530 (IST) From: Radhey Shyam Pandey To: , , , , CC: , , , Shravya Kumbham , "Radhey Shyam Pandey" Subject: [PATCH net v3 1/2] net: emaclite: Don't advertise 1000BASE-T and do auto negotiation Date: Mon, 2 May 2022 12:57:49 +0530 Message-ID: <1651476470-23904-2-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1651476470-23904-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1651476470-23904-1-git-send-email-radhey.shyam.pandey@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1224cadf-622c-4fba-699b-08da2c0d4e4c X-MS-TrafficTypeDiagnostic: DM6PR02MB5033:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5ADYlX7dUTBlBPaNiycrS48/LV9k2dLmJGfJ3r2Onw8esUVfw4oHgHnoWry2gEmQ1lmw5UXui6jjOWZAvPyNl4Rj1HWAGwwPLATSDjGTVvRG9KUanS00J1NxCxHx0NvAoFXZvsFbCLRQn02CGbA6SmviHp2U36nhFDL9VJwH4PdEw21u2ODk9jJtsLgXriPFuSXHqoMHVmfAyokw6axMmaFt86DSRNpunv/RKbF0r5f9QUlyLeMhWW4Qll0T1kQavctWoks4w9WPCBgUxuQ2YX158vCBFkZWt4KMJzXaYyEYIsj3jmBH7UpgFKcngOIaiPdMYsgcmctNJDGJbWtByXDKBnjS26fZfM4Pha9vaL/F/K8x41z8WeC/hTUrQ9I9K//MP33OJE+PJd1dGCyL+FT9Av8V8M4fIot6mg4aJQ64h+hngAOaa3ahTIkU+N+na0P4YHZYmQXCgzyyvwNLy/dFzKgCXV5ebEOYlrmvO0C8fQgiLgvqFwhSWJ7WZVB75EIxNf9fU1o3ZaMpiofdGsKShYA2PJjGoqrTf0Y3uCjASt7nYTbsDjsZSQnzpFJttCb84pO5xvcnri55fUgtnaoqALrKxlCqn+x5G4FAOUC/92RMyieyKmFPYAtPS6yEEdZpSSdbaeChH9LKAvlTloJLXKPS3qIM9iM8nYGFOxV6veja4ylK1rY9vVcDd1tYveUz+wRSzLaHWUiEB6K4+g== X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(107886003)(356005)(316002)(70586007)(8676002)(4326008)(70206006)(508600001)(42186006)(6666004)(36860700001)(26005)(6266002)(7636003)(186003)(336012)(54906003)(47076005)(110136005)(40460700003)(426003)(8936002)(83380400001)(5660300002)(36756003)(82310400005)(2906002)(2616005)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 07:28:08.5236 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1224cadf-622c-4fba-699b-08da2c0d4e4c X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT035.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB5033 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shravya Kumbham In xemaclite_open() function we are setting the max speed of emaclite to 100Mb using phy_set_max_speed() function so, there is no need to write the advertising registers to stop giga-bit speed and the phy_start() function starts the auto-negotiation so, there is no need to handle it separately using advertising registers. Remove the phy_read and phy_write of advertising registers in xemaclite_open() function. Signed-off-by: Shravya Kumbham Signed-off-by: Radhey Shyam Pandey Reviewed-by: Andrew Lunn --- Changes for v3: - None Changes for v2: - Added Andrew's Reviewed-by tag. --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/et= hernet/xilinx/xilinx_emaclite.c index 57a24f62e353..f7394a5160cf 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -926,8 +926,6 @@ static int xemaclite_open(struct net_device *dev) xemaclite_disable_interrupts(lp); =20 if (lp->phy_node) { - u32 bmcr; - lp->phy_dev =3D of_phy_connect(lp->ndev, lp->phy_node, xemaclite_adjust_link, 0, PHY_INTERFACE_MODE_MII); @@ -938,19 +936,6 @@ static int xemaclite_open(struct net_device *dev) =20 /* EmacLite doesn't support giga-bit speeds */ phy_set_max_speed(lp->phy_dev, SPEED_100); - - /* Don't advertise 1000BASE-T Full/Half duplex speeds */ - phy_write(lp->phy_dev, MII_CTRL1000, 0); - - /* Advertise only 10 and 100mbps full/half duplex speeds */ - phy_write(lp->phy_dev, MII_ADVERTISE, ADVERTISE_ALL | - ADVERTISE_CSMA); - - /* Restart auto negotiation */ - bmcr =3D phy_read(lp->phy_dev, MII_BMCR); - bmcr |=3D (BMCR_ANENABLE | BMCR_ANRESTART); - phy_write(lp->phy_dev, MII_BMCR, bmcr); - phy_start(lp->phy_dev); } =20 --=20 2.7.4 From nobody Sun May 10 15:02:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 222E2C433F5 for ; Mon, 2 May 2022 07:28:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383581AbiEBHcB (ORCPT ); Mon, 2 May 2022 03:32:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383580AbiEBHby (ORCPT ); Mon, 2 May 2022 03:31:54 -0400 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2082.outbound.protection.outlook.com [40.107.220.82]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6D753CA45; Mon, 2 May 2022 00:28:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aEH3BHiHRamMcXTGZaK/A2VulcVZCPEWp91tL4ASP2Ut19DUF0LTLRHHjlod0LR9y3JG9/58WRdbeHnxQfeGRdW5esMRXKmS3WkXlRjBxUVfCnDtOXvLvPIjYYuXcayjIN73tO1whzIO+mDDnifxN5EFVRTZQ/7S9h130gXCjKvhjXpNm0bETb7iJRSIv6ySwFDYALrJaLpvoyHObDci8VvN8fPYmBM14KxPFwdiYaV9n6FKIDIlMCBSyPC52QN1mr9Y2b3vovcm4nQmqSmIjcjyFFZJOeDh0zRFZmHz7Y1EIR1OSfXWlV/4ejDeC05TzOTzZL4UN8K0Df7NaUy+0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OWkA1nlE39S1veXrCKBJ7z0FBNkd79hY7EuKYalnTLI=; b=UQ66157gLy0nBqmZLOLwM7AAaJE0NAX4L0UB/y8dGscUPae9og7fPIpJ3zReiBL57Lk9k+pSQVSPrnwi/Uvio0VMMC13Prfj70jTdlvqxXmlpPeuNBEOIvIvnhSvWHPR/KrbbPNveQHi8X7S/RJMBlH2Tf+q06xlR7dFM8WOAVGE3PNGAZP7G/EhvfnAh6FviKKhBvjA7N5FkalBd6NvV4T6fOLIt0juwRm8lOz9iElCG9YHn0v0xCR+sFilW/XfMSYuZjn4fEL7gmf1FWPth4ZXWTVMkRcSaqLrUuQQxQkyxZBLxT353epYt4ARq/cy5Nqa0MEE8NC/LWKcNa7Yvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=davemloft.net smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OWkA1nlE39S1veXrCKBJ7z0FBNkd79hY7EuKYalnTLI=; b=Rr7dRaSNTAVHwcwhN9n9liZjcbeSb+J+Xesyf4KzQDCPO3tRPtTIVJB6r8/NrPzhon3/OfwNR/dl+y7Mzk8tvSdr5/Bi8GslXhrzy+LSrws5hMwtK7tzmrSrJ9haDEKpl5EVde845mINPTlY9GxdGHLNeZfmelXczgDx7G6o8VE= Received: from DM6PR11CA0060.namprd11.prod.outlook.com (2603:10b6:5:14c::37) by CH2PR02MB6295.namprd02.prod.outlook.com (2603:10b6:610:f::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Mon, 2 May 2022 07:28:21 +0000 Received: from DM3NAM02FT045.eop-nam02.prod.protection.outlook.com (2603:10b6:5:14c:cafe::fb) by DM6PR11CA0060.outlook.office365.com (2603:10b6:5:14c::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend Transport; Mon, 2 May 2022 07:28:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT045.mail.protection.outlook.com (10.13.4.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5206.12 via Frontend Transport; Mon, 2 May 2022 07:28:21 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Mon, 2 May 2022 00:28:19 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Mon, 2 May 2022 00:28:19 -0700 Envelope-to: git@xilinx.com, davem@davemloft.net, kuba@kernel.org, andrew@lunn.ch, pabeni@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Received: from [172.23.64.6] (port=56285 helo=xhdvnc106.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nlQTj-00011c-Gp; Mon, 02 May 2022 00:28:19 -0700 Received: by xhdvnc106.xilinx.com (Postfix, from userid 13245) id 8C6066109B; Mon, 2 May 2022 12:57:52 +0530 (IST) From: Radhey Shyam Pandey To: , , , , CC: , , , Shravya Kumbham , "Radhey Shyam Pandey" Subject: [PATCH net v3 2/2] net: emaclite: Add error handling for of_address_to_resource() Date: Mon, 2 May 2022 12:57:50 +0530 Message-ID: <1651476470-23904-3-git-send-email-radhey.shyam.pandey@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1651476470-23904-1-git-send-email-radhey.shyam.pandey@xilinx.com> References: <1651476470-23904-1-git-send-email-radhey.shyam.pandey@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f733c80-5de5-4735-e52b-08da2c0d55cb X-MS-TrafficTypeDiagnostic: CH2PR02MB6295:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DZguWEAlP+HfFtYcjbNyTx/f+QtJsJVHrEpeSnxVOLe/RwOnauIeM+jHQh+ukYAvKTxUp2JPgB3HfyIxMGueEbwia3oJ5CSP+rVP4KxbIGSIgx9e7WWU5E2QVnIn65cmxQQrWc7lusqcJ23+H8OYI19JeDaiYP4sJJzOaz6lpFupseGPKPBt3FFMDFIlpYzfgJR8JpbszEb3ICkmn6tbdzuRdENzeAvfl00AoIQY2YFXRuriIArLLDKvekkBbSxLMdvep6sCtpTzJpyk3MlR47Qtj5hfjFd8fX5pbrpWIxBZyDzV48ngHa6XlheKbiQ9Rr0kVDkErtEPjQxIfvM16io2MevE8DMNraJb/lPp3rN0YLiduns/JRN2OBrlusWs8hAYOwP5sXya/HaqITnEpF2OiL7HHbMocAfdKGk9iqgUt1gERF8pbhBDC10pH9Vz4ufu3WM65tosJY2hnHOsEpuYekx2nDaYyPp9YJdAHvZIIdY1JIYyDC5zAdClKMNBOrIoDTT7VdGAkPWJJY57N9CXXayzLxq5XZzsHnvaRGkXnvIpRT1pQ+jL1PC9zMQplkH5L3A2LQY8Zr9F3eC1IMo9zBnyOkwYnDAglfGDryElwzjWqu3dianA8iAe1+izeW7wQh0gMjsYsQLGzhHkaPn4f0q4q9BAvMDSIKZybwHJ9yYTQGYRLMoD9777g+mYJln1iLqjkIG/O6V85fNszg== X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(42186006)(82310400005)(54906003)(110136005)(316002)(70586007)(5660300002)(8936002)(70206006)(508600001)(8676002)(4326008)(26005)(83380400001)(36860700001)(40460700003)(36756003)(107886003)(7636003)(2616005)(2906002)(186003)(356005)(6266002)(426003)(47076005)(336012)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 07:28:21.1188 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f733c80-5de5-4735-e52b-08da2c0d55cb X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT045.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6295 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shravya Kumbham check the return value of of_address_to_resource() and also add missing of_node_put() for np and npp nodes. Fixes: e0a3bc65448c ("net: emaclite: Support multiple phys connected to one= MDIO bus") Addresses-Coverity: Event check_return value. Signed-off-by: Shravya Kumbham Signed-off-by: Radhey Shyam Pandey --- Changes for v3: - Fix conflict on net. Changes for v2: - Move ret further down to align with RXT as suggested by Andrew. - Add Fixes tag. --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/et= hernet/xilinx/xilinx_emaclite.c index f7394a5160cf..d770b3ac3f74 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -823,10 +823,10 @@ static int xemaclite_mdio_write(struct mii_bus *bus, = int phy_id, int reg, static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) { struct mii_bus *bus; - int rc; struct resource res; struct device_node *np =3D of_get_parent(lp->phy_node); struct device_node *npp; + int rc, ret; =20 /* Don't register the MDIO bus if the phy_node or its parent node * can't be found. @@ -836,8 +836,14 @@ static int xemaclite_mdio_setup(struct net_local *lp, = struct device *dev) return -ENODEV; } npp =3D of_get_parent(np); - - of_address_to_resource(npp, 0, &res); + ret =3D of_address_to_resource(npp, 0, &res); + of_node_put(npp); + if (ret) { + dev_err(dev, "%s resource error!\n", + dev->of_node->full_name); + of_node_put(np); + return ret; + } if (lp->ndev->mem_start !=3D res.start) { struct phy_device *phydev; phydev =3D of_phy_find_device(lp->phy_node); @@ -846,6 +852,7 @@ static int xemaclite_mdio_setup(struct net_local *lp, s= truct device *dev) "MDIO of the phy is not registered yet\n"); else put_device(&phydev->mdio.dev); + of_node_put(np); return 0; } =20 @@ -858,6 +865,7 @@ static int xemaclite_mdio_setup(struct net_local *lp, s= truct device *dev) bus =3D mdiobus_alloc(); if (!bus) { dev_err(dev, "Failed to allocate mdiobus\n"); + of_node_put(np); return -ENOMEM; } =20 @@ -870,6 +878,7 @@ static int xemaclite_mdio_setup(struct net_local *lp, s= truct device *dev) bus->parent =3D dev; =20 rc =3D of_mdiobus_register(bus, np); + of_node_put(np); if (rc) { dev_err(dev, "Failed to register mdio bus.\n"); goto err_register; --=20 2.7.4