From nobody Sun May 10 23:27:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2E6CC433F5 for ; Thu, 21 Apr 2022 08:22:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1386789AbiDUIZF (ORCPT ); Thu, 21 Apr 2022 04:25:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1386758AbiDUIYx (ORCPT ); Thu, 21 Apr 2022 04:24:53 -0400 Received: from mail.meizu.com (edge05.meizu.com [157.122.146.251]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 822CC2124C for ; Thu, 21 Apr 2022 01:21:28 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail12.meizu.com (172.16.1.108) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 21 Apr 2022 16:21:21 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 21 Apr 2022 16:21:18 +0800 From: Haowen Bai To: CC: , , , , Subject: [PATCH V5] staging: rtl8192e: Fix signedness bug in rtllib_rx_assoc_resp() Date: Thu, 21 Apr 2022 16:21:17 +0800 Message-ID: <1650529277-7893-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <202204211558.TapLZO4j-lkp@intel.com> References: <202204211558.TapLZO4j-lkp@intel.com> MIME-Version: 1.0 X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The rtllib_rx_assoc_resp() function has a signedness bug because it's a declared as a u16 but it return -ENOMEM. When you look at it more closely it returns a mix of error codes including 0xcafe, -ENOMEM, and a->status which is WLAN_STATUS_NOT_SUPPORTED_AUTH_ALG. This is a mess. Clean it up to just return standard kernel error codes. We can print out the a->status before returning a regular error code. The printks in the caller need to be adjusted as well. Signed-off-by: Haowen Bai Reviewed-by: Dan Carpenter --- V1->V2: reduce return random value; print its own error message. V2->V3: change commit message; change s16 -> int. V3->V4:=20 1. change message suggested by Dan Carpenter; 2. hold a->status in auth_parse() and return error code or 0 on success. 3. print le16_to_cpu(errcode) -> int %d. V4->V5: fix compile error. drivers/staging/rtl8192e/rtllib_softmac.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rt= l8192e/rtllib_softmac.c index 82bf05eb1cbf..38ac733c3245 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -1764,7 +1764,7 @@ static void rtllib_softmac_check_all_nets(struct rtll= ib_device *ieee) spin_unlock_irqrestore(&ieee->lock, flags); } =20 -static inline u16 auth_parse(struct net_device *dev, struct sk_buff *skb, +static inline int auth_parse(struct net_device *dev, struct sk_buff *skb, u8 **challenge, int *chlen) { struct rtllib_authentication *a; @@ -1773,7 +1773,7 @@ static inline u16 auth_parse(struct net_device *dev, = struct sk_buff *skb, if (skb->len < (sizeof(struct rtllib_authentication) - sizeof(struct rtllib_info_element))) { netdev_dbg(dev, "invalid len in auth resp: %d\n", skb->len); - return 0xcafe; + return -EINVAL; } *challenge =3D NULL; a =3D (struct rtllib_authentication *) skb->data; @@ -1787,7 +1787,13 @@ static inline u16 auth_parse(struct net_device *dev,= struct sk_buff *skb, return -ENOMEM; } } - return le16_to_cpu(a->status); + + if (a->status) { + netdev_dbg(dev, "auth_parse() failed\n"); + return -EINVAL; + } + + return 0; } =20 static int auth_rq_parse(struct net_device *dev, struct sk_buff *skb, u8 *= dest) @@ -2282,7 +2288,7 @@ rtllib_rx_assoc_resp(struct rtllib_device *ieee, stru= ct sk_buff *skb, =20 static void rtllib_rx_auth_resp(struct rtllib_device *ieee, struct sk_buff= *skb) { - u16 errcode; + int errcode; u8 *challenge; int chlen =3D 0; bool bSupportNmode =3D true, bHalfSupportNmode =3D false; @@ -2292,8 +2298,7 @@ static void rtllib_rx_auth_resp(struct rtllib_device = *ieee, struct sk_buff *skb) if (errcode) { ieee->softmac_stats.rx_auth_rs_err++; netdev_info(ieee->dev, - "Authentication response status code 0x%x", - errcode); + "Authentication response status code %d", errcode); rtllib_associate_abort(ieee); return; } --=20 2.7.4