From nobody Mon May 11 01:32:49 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B072DC433EF for ; Tue, 19 Apr 2022 13:19:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348298AbiDSNVz (ORCPT ); Tue, 19 Apr 2022 09:21:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238617AbiDSNVv (ORCPT ); Tue, 19 Apr 2022 09:21:51 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80391344FC; Tue, 19 Apr 2022 06:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1650374349; x=1681910349; h=from:to:cc:subject:date:message-id:mime-version; bh=FEwok1lzjt/HO93wIkHzSCWrGpT3TbisaBs2ZCCYLc0=; b=x67D8AFHMemndeCBOdJuHzopTptr1WH+fOyvUfBDiIGp946j27+aQ6x5 IPlny3LTJoGREEhCXlz8IsxAeeH3pYeh9TAc1wIC9fs5m1GuZu8r19TaY IaqXitwyP5AZ3Zc92X45pvAk9ZSTXjz82Vsd4vck9Hrrhy5HEfHBmyL1z k=; Received: from ironmsg-lv-alpha.qualcomm.com ([10.47.202.13]) by alexa-out.qualcomm.com with ESMTP; 19 Apr 2022 06:19:08 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg-lv-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 06:19:07 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 19 Apr 2022 06:19:07 -0700 Received: from hu-srivasam-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 19 Apr 2022 06:19:01 -0700 From: Srinivasa Rao Mandadapu To: , , , , , , , , , , , , , , , CC: Srinivasa Rao Mandadapu , "Venkata Prasad Potturu" Subject: [PATCH v2] ASoC: qcom: SC7280: Update machine driver startup, shutdown callbacks Date: Tue, 19 Apr 2022 18:48:49 +0530 Message-ID: <1650374329-7279-1-git-send-email-quic_srivasam@quicinc.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Update machine driver startup, shutdown callback functions to avoid sound card registration failure on other platforms. Without this change, platforms with WCD codec is failing to register sound card. Fixes: c5198db82d4c ("ASoC: qcom: Add driver support for ALC5682I-VS") Signed-off-by: Srinivasa Rao Mandadapu Co-developed-by: Venkata Prasad Potturu Signed-off-by: Venkata Prasad Potturu --- Changes Since V1: -- Update swith case in startup, shutdown callbacks for handling all dai= id's -- Update commit message and add Fixes tag sound/soc/qcom/sc7280.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/sound/soc/qcom/sc7280.c b/sound/soc/qcom/sc7280.c index 4ef4034..834c081 100644 --- a/sound/soc/qcom/sc7280.c +++ b/sound/soc/qcom/sc7280.c @@ -291,13 +291,7 @@ static void sc7280_snd_shutdown(struct snd_pcm_substre= am *substream) SNDRV_PCM_STREAM_PLAYBACK); } break; - case MI2S_SECONDARY: - break; - case LPASS_DP_RX: - break; default: - dev_err(rtd->dev, "%s: invalid dai id 0x%x\n", __func__, - cpu_dai->id); break; } } @@ -312,14 +306,8 @@ static int sc7280_snd_startup(struct snd_pcm_substream= *substream) case MI2S_PRIMARY: ret =3D sc7280_rt5682_init(rtd); break; - case MI2S_SECONDARY: - break; - case LPASS_DP_RX: - break; default: - dev_err(rtd->dev, "%s: invalid dai id 0x%x\n", __func__, - cpu_dai->id); - return -EINVAL; + break; } return ret; } --=20 2.7.4