From nobody Mon May 11 07:06:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7466EC433EF for ; Tue, 12 Apr 2022 01:17:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243245AbiDLBTo (ORCPT ); Mon, 11 Apr 2022 21:19:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349081AbiDLBSk (ORCPT ); Mon, 11 Apr 2022 21:18:40 -0400 Received: from mail.meizu.com (unknown [14.29.68.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1870D10C0; Mon, 11 Apr 2022 18:16:24 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail04.meizu.com (172.16.1.16) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 12 Apr 2022 09:16:22 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Tue, 12 Apr 2022 09:16:22 +0800 From: Haowen Bai To: Vinod Koul CC: Haowen Bai , , Subject: [PATCH V3] dmaengine: pl08x: drop the useless function Date: Tue, 12 Apr 2022 09:16:20 +0800 Message-ID: <1649726180-13133-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-123.meizu.com (172.16.1.123) To IT-EXMB-1-125.meizu.com (172.16.1.125) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Unneeded variable: "retval". Return "NULL" , so we have to make code clear. better way, drop the function. Signed-off-by: Haowen Bai --- V1->V2: drop the useless function. V2->V3: change title drivers/dma/amba-pl08x.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index a24882ba3764..a4a794e62ac2 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba-pl08x.c @@ -1535,14 +1535,6 @@ static void pl08x_free_chan_resources(struct dma_cha= n *chan) vchan_free_chan_resources(to_virt_chan(chan)); } =20 -static struct dma_async_tx_descriptor *pl08x_prep_dma_interrupt( - struct dma_chan *chan, unsigned long flags) -{ - struct dma_async_tx_descriptor *retval =3D NULL; - - return retval; -} - /* * Code accessing dma_async_is_complete() in a tight loop may give problem= s. * If slaves are relying on interrupts to signal completion this function @@ -2760,7 +2752,6 @@ static int pl08x_probe(struct amba_device *adev, cons= t struct amba_id *id) pl08x->memcpy.dev =3D &adev->dev; pl08x->memcpy.device_free_chan_resources =3D pl08x_free_chan_resources; pl08x->memcpy.device_prep_dma_memcpy =3D pl08x_prep_dma_memcpy; - pl08x->memcpy.device_prep_dma_interrupt =3D pl08x_prep_dma_interrupt; pl08x->memcpy.device_tx_status =3D pl08x_dma_tx_status; pl08x->memcpy.device_issue_pending =3D pl08x_issue_pending; pl08x->memcpy.device_config =3D pl08x_config; @@ -2787,8 +2778,6 @@ static int pl08x_probe(struct amba_device *adev, cons= t struct amba_id *id) pl08x->slave.dev =3D &adev->dev; pl08x->slave.device_free_chan_resources =3D pl08x_free_chan_resources; - pl08x->slave.device_prep_dma_interrupt =3D - pl08x_prep_dma_interrupt; pl08x->slave.device_tx_status =3D pl08x_dma_tx_status; pl08x->slave.device_issue_pending =3D pl08x_issue_pending; pl08x->slave.device_prep_slave_sg =3D pl08x_prep_slave_sg; --=20 2.7.4