From nobody Thu May 14 10:37:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C6DCC433EF for ; Mon, 11 Apr 2022 16:10:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348503AbiDKQMV (ORCPT ); Mon, 11 Apr 2022 12:12:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348504AbiDKQK5 (ORCPT ); Mon, 11 Apr 2022 12:10:57 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9436369FD; Mon, 11 Apr 2022 09:08:35 -0700 (PDT) Date: Mon, 11 Apr 2022 16:08:32 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1649693314; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fEumtrNgPRij67RkSd7q5ZbJwNeqqSyIxE9/jivKOtg=; b=a2QAq3kJvaC0ugNY7Bjl5ycWYgdpQ55X3NHTGmVDTBH9ySY5uC1KCP6EE28R2N3+07oOxz MXANzDLEBfWsk3K/UKVAro9IJsGqlZH/FWYppLNFANXHgQD1tZ+YtUd+27grdEhKc3h7uA udpReu0urIYWZVzoRljut6xO/AixCZh8Raybc54uRSm5gniKrvBv1UrEOvPUboQJtAYVgX mSuvRTbS+IIPPYpnUlpyOnAzj33aajxJS2Z5ocJK4Hz1mWild6lBXEdLKO8JWFXBT79GRm msltUje8zD+GoVg8lTgUoa50LBAvq4o7q/UhcQS0I+MRfLwm3kysR+2MDhMiag== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1649693314; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fEumtrNgPRij67RkSd7q5ZbJwNeqqSyIxE9/jivKOtg=; b=FHqAIyofGIoPVgokmmXYKudclcorsQmWyPD69oWZklqSJYzsWkvtpb5U44ovUt9Mlbp/KA 8pXfGViOTX5CS7Cw== From: "tip-bot2 for Yang Yingliang" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/sev] virt: sevguest: Fix return value check in alloc_shared_pages() Cc: Hulk Robot , Yang Yingliang , Borislav Petkov , Brijesh Singh , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20220411111213.1477853-1-yangyingliang@huawei.com> References: <20220411111213.1477853-1-yangyingliang@huawei.com> MIME-Version: 1.0 Message-ID: <164969331258.4207.11880527888370272207.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the x86/sev branch of tip: Commit-ID: e50abbf788c239d529f9ab81e325f8e8f8432c9d Gitweb: https://git.kernel.org/tip/e50abbf788c239d529f9ab81e325f8e8f= 8432c9d Author: Yang Yingliang AuthorDate: Mon, 11 Apr 2022 19:12:13 +08:00 Committer: Borislav Petkov CommitterDate: Mon, 11 Apr 2022 17:58:52 +02:00 virt: sevguest: Fix return value check in alloc_shared_pages() If alloc_pages() fails, it returns a NULL pointer. Replace the wrong IS_ERR() check with the proper NULL pointer check. Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: Borislav Petkov Reviewed-by: Brijesh Singh Link: https://lore.kernel.org/r/20220411111213.1477853-1-yangyingliang@huaw= ei.com --- drivers/virt/coco/sevguest/sevguest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virt/coco/sevguest/sevguest.c b/drivers/virt/coco/sevg= uest/sevguest.c index 15afb6c..aaa6134 100644 --- a/drivers/virt/coco/sevguest/sevguest.c +++ b/drivers/virt/coco/sevguest/sevguest.c @@ -581,7 +581,7 @@ static void *alloc_shared_pages(size_t sz) int ret; =20 page =3D alloc_pages(GFP_KERNEL_ACCOUNT, get_order(sz)); - if (IS_ERR(page)) + if (!page) return NULL; =20 ret =3D set_memory_decrypted((unsigned long)page_address(page), npages);