From nobody Fri Jun 19 19:08:49 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CF15C433EF for ; Wed, 30 Mar 2022 07:13:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243712AbiC3HPC (ORCPT ); Wed, 30 Mar 2022 03:15:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243706AbiC3HO6 (ORCPT ); Wed, 30 Mar 2022 03:14:58 -0400 Received: from mail.meizu.com (edge07.meizu.com [112.91.151.210]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E7F8160FE7; Wed, 30 Mar 2022 00:13:09 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail11.meizu.com (172.16.1.15) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 30 Mar 2022 15:13:08 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Wed, 30 Mar 2022 15:13:07 +0800 From: Haowen Bai To: Daniel Bristot de Oliveira , Steven Rostedt CC: Haowen Bai , , Subject: [PATCH] rtla/osnoise_hist: avoid NULL pointer dereference on out Date: Wed, 30 Mar 2022 15:13:05 +0800 Message-ID: <1648624385-10091-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-124.meizu.com (172.16.1.124) To IT-EXMB-1-125.meizu.com (172.16.1.125) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" record is NULL and go out but dereference record->trace. report by coccicheck: tools/tracing/rtla/src/osnoise_hist.c:870:31-36: ERROR: record is NULL but dereferenced. Signed-off-by: Haowen Bai --- tools/tracing/rtla/src/osnoise_hist.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/tracing/rtla/src/osnoise_hist.c b/tools/tracing/rtla/src= /osnoise_hist.c index b4380d4..b7862b4 100644 --- a/tools/tracing/rtla/src/osnoise_hist.c +++ b/tools/tracing/rtla/src/osnoise_hist.c @@ -819,13 +819,13 @@ int osnoise_hist_main(int argc, char *argv[]) record =3D osnoise_init_trace_tool("osnoise"); if (!record) { err_msg("Failed to enable the trace instance\n"); - goto out_hist; + goto out_top; } =20 if (params->events) { retval =3D trace_events_enable(&record->trace, params->events); if (retval) - goto out_hist; + goto out_top; } =20 trace_instance_start(&record->trace); @@ -845,7 +845,7 @@ int osnoise_hist_main(int argc, char *argv[]) trace); if (retval < 0) { err_msg("Error iterating on events\n"); - goto out_hist; + goto out_top; } =20 if (trace_is_off(&tool->trace, &record->trace)) @@ -865,9 +865,9 @@ int osnoise_hist_main(int argc, char *argv[]) save_trace_to_file(record->trace.inst, params->trace_output); } } - -out_hist: +out_top: trace_events_destroy(&record->trace, params->events); +out_hist: params->events =3D NULL; osnoise_free_histogram(tool->data); out_destroy: --=20 2.7.4