From nobody Fri Jun 19 22:37:43 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDC51C433EF for ; Mon, 28 Mar 2022 01:42:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237326AbiC1Bnl (ORCPT ); Sun, 27 Mar 2022 21:43:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230002AbiC1Bnj (ORCPT ); Sun, 27 Mar 2022 21:43:39 -0400 Received: from mail.meizu.com (edge07.meizu.com [112.91.151.210]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1E284F9E3 for ; Sun, 27 Mar 2022 18:41:58 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail11.meizu.com (172.16.1.15) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 28 Mar 2022 09:41:57 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Mon, 28 Mar 2022 09:41:56 +0800 From: Haowen Bai To: , , , , CC: , , =?UTF-8?q?=E7=99=BD=E6=B5=A9=E6=96=87?= Subject: [PATCH] staging: r8188eu: Directly return instead of using local ret variable Date: Mon, 28 Mar 2022 09:41:55 +0800 Message-ID: <1648431715-21333-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-125.meizu.com (172.16.1.125) To IT-EXMB-1-125.meizu.com (172.16.1.125) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: =E7=99=BD=E6=B5=A9=E6=96=87 fixes coccinelle warning: ./drivers/staging/r8188eu/core/rtw_mlme_ext.c:1518:14-17: Unneeded variable= : "ret". Return "_FAIL" on line 1549 ./drivers/staging/r8188eu/core/rtw_mlme_ext.c:357:5-8: Unneeded variable: "= res". Return "_SUCCESS" on line 380 Signed-off-by: =E7=99=BD=E6=B5=A9=E6=96=87 --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/= r8188eu/core/rtw_mlme_ext.c index 10d5f12..4b7b0ee 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -354,7 +354,6 @@ static u8 init_channel_set(struct adapter *padapter, u8= ChannelPlan, struct rt_c =20 int init_mlme_ext_priv(struct adapter *padapter) { - int res =3D _SUCCESS; struct registry_priv *pregistrypriv =3D &padapter->registrypriv; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; @@ -377,7 +376,7 @@ int init_mlme_ext_priv(struct adapter *padapter) =20 pmlmeext->active_keep_alive_check =3D true; =20 - return res; + return _SUCCESS; } =20 void free_mlme_ext_priv(struct mlme_ext_priv *pmlmeext) @@ -1515,7 +1514,6 @@ unsigned int OnAtim(struct adapter *padapter, struct = recv_frame *precv_frame) =20 unsigned int on_action_spct(struct adapter *padapter, struct recv_frame *p= recv_frame) { - unsigned int ret =3D _FAIL; struct sta_info *psta =3D NULL; struct sta_priv *pstapriv =3D &padapter->stapriv; u8 *pframe =3D precv_frame->rx_data; @@ -1546,7 +1544,7 @@ unsigned int on_action_spct(struct adapter *padapter,= struct recv_frame *precv_f } =20 exit: - return ret; + return _FAIL; } =20 unsigned int OnAction_qos(struct adapter *padapter, struct recv_frame *pre= cv_frame) --=20 2.7.4