From nobody Fri Jun 19 23:46:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F0BC433EF for ; Sat, 26 Mar 2022 03:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231129AbiCZDcP (ORCPT ); Fri, 25 Mar 2022 23:32:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229773AbiCZDcN (ORCPT ); Fri, 25 Mar 2022 23:32:13 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA6F59E9C7 for ; Fri, 25 Mar 2022 20:30:36 -0700 (PDT) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KQPZL62dMzfZPk for ; Sat, 26 Mar 2022 11:28:58 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sat, 26 Mar 2022 11:30:34 +0800 Received: from huawei.com (10.90.53.225) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sat, 26 Mar 2022 11:30:33 +0800 From: fengyubo To: CC: , Subject: [PATCH -next] fatfs: remove redundant judgment Date: Sat, 26 Mar 2022 11:30:18 +0800 Message-ID: <1648265418-76563-1-git-send-email-fengyubo3@huawei.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [10.90.53.225] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Yubo Feng iput() has already judged the incoming parameter, so there is no need to repeat outside. Reported-by: Hulk Robot Signed-off-by: Yubo Feng Acked-by: OGAWA Hirofumi --- fs/fat/inode.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/fat/inode.c b/fs/fat/inode.c index a6f1c6d426d1..da8619148590 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c @@ -1888,10 +1888,8 @@ int fat_fill_super(struct super_block *sb, void *dat= a, int silent, int isvfat, fat_msg(sb, KERN_INFO, "Can't find a valid FAT filesystem"); =20 out_fail: - if (fsinfo_inode) - iput(fsinfo_inode); - if (fat_inode) - iput(fat_inode); + iput(fsinfo_inode); + iput(fat_inode); unload_nls(sbi->nls_io); unload_nls(sbi->nls_disk); fat_reset_iocharset(&sbi->options); --=20 2.17.1