From nobody Sat Jun 20 00:59:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D28CC433F5 for ; Fri, 25 Mar 2022 01:26:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357273AbiCYB2G (ORCPT ); Thu, 24 Mar 2022 21:28:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbiCYB2F (ORCPT ); Thu, 24 Mar 2022 21:28:05 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86E4063B4 for ; Thu, 24 Mar 2022 18:26:32 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id m18so1681218plx.3 for ; Thu, 24 Mar 2022 18:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+SYc0e9g/e2NgojZUkZRw8h8BXGDytMNN9BdB9Ten6k=; b=NjIi4X6s6/CHpJcU1CyCBkQRKN0qkFkGVixQeqmG7EhFyEWBUN27xLTmKwKEJzuvGl fM8LrP+OOHyGj6c/hMm+Bol4ruFuVnzVHA1tl8aqjh6BRoV1iFpv5Oz8R4oPsTqCll31 NIVZWzHJw/mpUkuU1UrDMUjKWG0k46H2SXUX+/waitn7Atz2jo0xyrsTY284zDXMZw3C Y4hzf5ivubQ0t30gvC+hQuEA0gxJjs5k6I0/EMkN8F8orJnBhZ0W3wtUdGWlx8D95Qkl /DOT1DcjP5eztz68VoAHjLrOVW9+VIoeXPjiXKslWvQedwQ0FeeWgsXOI+zvECqAbc2U 1kZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+SYc0e9g/e2NgojZUkZRw8h8BXGDytMNN9BdB9Ten6k=; b=iKoTBKkOqVNuDzw81EIhrINsTdKZsdddt7T+tcgGOB01nF6uscHjWddhGeIYXQUFXM XGlGsP1411RgbLUWfTqmjNg8ozMABghohXU+ZRIVIowcG4rhVDFwDZxFX9uX0oYm+ch1 T49182yHsans3NEH75y2kucRCj9/bUVg0FbUaGAcUNkApOH7FYLRvoH4LAQy9C+RAgFi WhcsHLP7YlVTvWuVHelZCRUShesCamNNuSPLAZZhuJc5asXkDoUCwqVVSRVqlrocIcB+ xtUfAMwgM0eFUTeFuuKb2hGrMUF0n/xd+Df0C4fiawGDqGHxuAv78ITOIRJ7Et87Zjqs o2gA== X-Gm-Message-State: AOAM532CjurF4o92dKeI0NWWrNQ26OMBKLBouPMZodv7OI7tOeexCwfV xSDCoMrNxnK9WCmEhMvXC9Y= X-Google-Smtp-Source: ABdhPJyhXR8P6O2wHa4huE6h/EFstjXQ3srSFIpO/zt19UkXT0kD1guGFuy6yn45l1y8SQNj3+pyrA== X-Received: by 2002:a17:90b:4f8e:b0:1c7:3652:21bc with SMTP id qe14-20020a17090b4f8e00b001c7365221bcmr21835883pjb.38.1648171591987; Thu, 24 Mar 2022 18:26:31 -0700 (PDT) Received: from localhost.localdomain ([2402:7500:56a:d674:140:d261:4ff3:2835]) by smtp.gmail.com with ESMTPSA id oj16-20020a17090b4d9000b001c709bca712sm11729204pjb.29.2022.03.24.18.26.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Mar 2022 18:26:31 -0700 (PDT) From: cy_huang To: broonie@kernel.org Cc: lgirdwood@gmail.com, lucas_tsai@richtek.com, linux-kernel@vger.kernel.org, ChiYuan Huang Subject: [PATCH 1/2] regulator: rt4831: Add bypass mask to fix set_bypass API work Date: Fri, 25 Mar 2022 09:26:16 +0800 Message-Id: <1648171577-9663-2-git-send-email-u0084500@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1648171577-9663-1-git-send-email-u0084500@gmail.com> References: <1648171577-9663-1-git-send-email-u0084500@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: ChiYuan Huang To use set/get_bypass helper function, bypass mask need to be specified. Signed-off-by: ChiYuan Huang --- drivers/regulator/rt4831-regulator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/rt4831-regulator.c b/drivers/regulator/rt483= 1-regulator.c index 676b041..8d24b5f 100644 --- a/drivers/regulator/rt4831-regulator.c +++ b/drivers/regulator/rt4831-regulator.c @@ -106,6 +106,7 @@ static const struct regulator_desc rt4831_regulator_des= cs[] =3D { .vsel_reg =3D RT4831_REG_VLCM, .vsel_mask =3D RT4831_VOLT_MASK, .bypass_reg =3D RT4831_REG_DSVEN, + .bypass_mask =3D RT4831_DSVMODE_MASK, .bypass_val_on =3D DSV_MODE_BYPASS, .bypass_val_off =3D DSV_MODE_NORMAL, .owner =3D THIS_MODULE, --=20 2.7.4 From nobody Sat Jun 20 00:59:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EB6FC433F5 for ; Fri, 25 Mar 2022 01:26:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357280AbiCYB2K (ORCPT ); Thu, 24 Mar 2022 21:28:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357274AbiCYB2I (ORCPT ); Thu, 24 Mar 2022 21:28:08 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 601A125E8C for ; Thu, 24 Mar 2022 18:26:35 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id mj15-20020a17090b368f00b001c637aa358eso11037478pjb.0 for ; Thu, 24 Mar 2022 18:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kGZw8qyWofqQh9TdH3MPUYSBiE8tPJPN6ibqOxgZh3k=; b=NWEbto9YaeDD1I3s6wEJ65UCzv+QNtK9xxA6Uv7U7TVYrQ2gvhnxZVWwRJ1F1LK27q ed3wstCVxtOyzEY/tQq2UP+jvtct6mVoA9fiTSDBXSXrUHZ2EkJ9YXJUfIdljyKRqHuc z8+7/rYRejFNgyRCAjNYuk9YDade/ela0SkA91hkkm9tHPPHNQh4UN/4qCqvNLPz7G66 rFUSPprNZLzyX6LDPDmt07RwIc0qpRz5P+HzibnF9VW4QpduB/2SSPc5L7cnauTL/o91 WAt51ykxTk1iYJMnPRv2ztJMy8D+YV9ZscqlUsiZUOJp9d+QfMPodJHBsMLbU6kXn6zO j0OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kGZw8qyWofqQh9TdH3MPUYSBiE8tPJPN6ibqOxgZh3k=; b=eq2zNHQrStvefYvGFTunq2Wp4XXW/6xQPITknNMfXnVLUoTIiY0E9V6McWc378Rk5I 3v4aobTPNIk8ATV65/6UelwPXHdKRsAnZLUFf/P7+9+8rs13Pioc5WhcVYT77JUkW0zy OVJbE6lIbyXZ/0WIjoya8eRTvQItA2+03mzquPzN5meKm78Vb11RYXpJ+yT1+jwC++GC 7Z+Fy24igLg2M5oMh7LEOJVl7RE7o4VIgMzkzfxG/IcNFEUimPuZSxtYOTsHUwujmWCh iDCwE765MXe0xP2C407zqeVg+BvJc8pWhMBVd3Qbg/JmnvASwZvP51JaCYrZTmbccdSh XOOw== X-Gm-Message-State: AOAM533fe/lk6jtBf2dq6LGKrdAH7nHxBp5fMGYU4uAZUX4ISkQUCYLw 7teTzDAT/ZlCdTnz1ykgoMNXn2isKIM= X-Google-Smtp-Source: ABdhPJzoKMnJ0cn6ry3V9hAQzfkuM2rS327FjALdJuonRTYitc23EGTSmeNm8KvhgLciQK437AGBpA== X-Received: by 2002:a17:902:dac2:b0:154:5d6d:cd02 with SMTP id q2-20020a170902dac200b001545d6dcd02mr8923631plx.123.1648171594820; Thu, 24 Mar 2022 18:26:34 -0700 (PDT) Received: from localhost.localdomain ([2402:7500:56a:d674:140:d261:4ff3:2835]) by smtp.gmail.com with ESMTPSA id oj16-20020a17090b4d9000b001c709bca712sm11729204pjb.29.2022.03.24.18.26.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Mar 2022 18:26:34 -0700 (PDT) From: cy_huang To: broonie@kernel.org Cc: lgirdwood@gmail.com, lucas_tsai@richtek.com, linux-kernel@vger.kernel.org, ChiYuan Huang Subject: [PATCH 2/2] regulator: rt4831: Add active_discharge_on to fix discharge API Date: Fri, 25 Mar 2022 09:26:17 +0800 Message-Id: <1648171577-9663-3-git-send-email-u0084500@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1648171577-9663-1-git-send-email-u0084500@gmail.com> References: <1648171577-9663-1-git-send-email-u0084500@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: ChiYuan Huang To use set_discharge helper function, active_discharge_on need to be added. Signed-off-by: ChiYuan Huang --- drivers/regulator/rt4831-regulator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/rt4831-regulator.c b/drivers/regulator/rt483= 1-regulator.c index 8d24b5f..2016062 100644 --- a/drivers/regulator/rt4831-regulator.c +++ b/drivers/regulator/rt4831-regulator.c @@ -127,6 +127,7 @@ static const struct regulator_desc rt4831_regulator_des= cs[] =3D { .enable_mask =3D RT4831_POSEN_MASK, .active_discharge_reg =3D RT4831_REG_DSVEN, .active_discharge_mask =3D RT4831_POSADEN_MASK, + .active_discharge_on =3D RT4831_POSADEN_MASK, .owner =3D THIS_MODULE, }, { @@ -145,6 +146,7 @@ static const struct regulator_desc rt4831_regulator_des= cs[] =3D { .enable_mask =3D RT4831_NEGEN_MASK, .active_discharge_reg =3D RT4831_REG_DSVEN, .active_discharge_mask =3D RT4831_NEGADEN_MASK, + .active_discharge_on =3D RT4831_NEGADEN_MASK, .owner =3D THIS_MODULE, } }; --=20 2.7.4