From nobody Sat Jun 20 01:53:14 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A31AC433F5 for ; Thu, 24 Mar 2022 09:12:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349112AbiCXJN6 (ORCPT ); Thu, 24 Mar 2022 05:13:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238181AbiCXJN5 (ORCPT ); Thu, 24 Mar 2022 05:13:57 -0400 Received: from m12-11.163.com (m12-11.163.com [220.181.12.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 865E09D0ED for ; Thu, 24 Mar 2022 02:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=Y63xt4boxyExZq6hhV N4HB4jAAAEHQlGefrZDnFYgGg=; b=A9epg5pGbMDc3HSK9XABSIllTpHrUkBJsS FXVkVLZ4uTM2wB+GzQtLn4uVvXdZrSd3Cwnog29OycmaHCY0HWDgKppeD39hlHmX SNGqilINnEfPkkQwb+7jYjfL2Dnv2utnOwVTe51kEOZwzbPUQLVvAcuCiTnY4IkV mMJfpcDEU= Received: from localhost (unknown [159.226.95.33]) by smtp7 (Coremail) with SMTP id C8CowADXcrjqNTxieYAGEA--.7423S2; Thu, 24 Mar 2022 17:12:10 +0800 (CST) From: QintaoShen To: tomba@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, QintaoShen Subject: [PATCH v1] drm: omapdrm: Check for NULL return of kzalloc() Date: Thu, 24 Mar 2022 17:12:07 +0800 Message-Id: <1648113127-8020-1-git-send-email-unSimple1993@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: C8CowADXcrjqNTxieYAGEA--.7423S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Kry3JFy5urWxtw47Zw43KFg_yoW8GFy8pF WDta4jkr18AF42grnrA3WqyFy5Ga13CF1Sgr9ruwna9w4rArW7Xwn8JFy3Arykuws3Ar42 gF4kt3WfGrn8Cr7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0JUO18gUUUUU= X-Originating-IP: [159.226.95.33] X-CM-SenderInfo: 5xqvxz5sohimizt6il2tof0z/xtbCbgrNH2BbCZwkzwAAsz Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" kzalloc() is a memory allocation function which may return NULL. It is better to check the return value of it to catch the error in time. Signed-off-by: QintaoShen --- drivers/gpu/drm/omapdrm/omap_crtc.c | 3 +++ drivers/gpu/drm/omapdrm/omap_irq.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c b/drivers/gpu/drm/omapdrm/= omap_crtc.c index 06a719c..fcd76ea 100644 --- a/drivers/gpu/drm/omapdrm/omap_crtc.c +++ b/drivers/gpu/drm/omapdrm/omap_crtc.c @@ -166,6 +166,9 @@ void omap_crtc_set_enabled(struct drm_crtc *crtc, bool = enable) dispc_mgr_enable(priv->dispc, channel, enable); omap_crtc->enabled =3D enable; =20 + if (!wait) + return ; + ret =3D omap_irq_wait(dev, wait, msecs_to_jiffies(100)); if (ret) { dev_err(dev->dev, "%s: timeout waiting for %s\n", diff --git a/drivers/gpu/drm/omapdrm/omap_irq.c b/drivers/gpu/drm/omapdrm/o= map_irq.c index 4aca14d..a234462 100644 --- a/drivers/gpu/drm/omapdrm/omap_irq.c +++ b/drivers/gpu/drm/omapdrm/omap_irq.c @@ -45,6 +45,9 @@ struct omap_irq_wait * omap_irq_wait_init(struct drm_devi= ce *dev, struct omap_irq_wait *wait =3D kzalloc(sizeof(*wait), GFP_KERNEL); unsigned long flags; =20 + if (!wait) + return NULL; + init_waitqueue_head(&wait->wq); wait->irqmask =3D irqmask; wait->count =3D count; --=20 2.7.4